)]}'
{"lib/puppet/provider/keystone_endpoint/openstack.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2941747f7eeb79695b37a116ed132227bf7b2304","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    id_str \u003d \u0027\u0027"},{"line_number":256,"context_line":"    id_sep \u003d \u0027\u0027"},{"line_number":257,"context_line":"    [:admin, :internal, :public].each do |type|"},{"line_number":258,"context_line":"      id_str +\u003d \"#{id_sep}#{endpoint[type][:id]}\" if endpoint[type]"},{"line_number":259,"context_line":"      id_sep \u003d \u0027,\u0027"},{"line_number":260,"context_line":"    end"},{"line_number":261,"context_line":"    id_str"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a9d85d2_02ac0a34","line":258,"updated":"2016-06-21 11:09:20.000000000","message":"why we need all ids in one line?","commit_id":"6b75c0b1c44b3235b11a22508ac88892ebf4da8e"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"1ce68041e4c03eb3c439e0f8656f884e63678b66","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    id_str \u003d \u0027\u0027"},{"line_number":256,"context_line":"    id_sep \u003d \u0027\u0027"},{"line_number":257,"context_line":"    [:admin, :internal, :public].each do |type|"},{"line_number":258,"context_line":"      id_str +\u003d \"#{id_sep}#{endpoint[type][:id]}\" if endpoint[type]"},{"line_number":259,"context_line":"      id_sep \u003d \u0027,\u0027"},{"line_number":260,"context_line":"    end"},{"line_number":261,"context_line":"    id_str"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a9d85d2_824d9a9b","line":258,"in_reply_to":"5a9d85d2_02ac0a34","updated":"2016-06-21 11:15:12.000000000","message":"It\u0027s how it has been done historically and I don\u0027t feel like refactoring all this part :)","commit_id":"6b75c0b1c44b3235b11a22508ac88892ebf4da8e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2941747f7eeb79695b37a116ed132227bf7b2304","unresolved":false,"context_lines":[{"line_number":279,"context_line":"  def service_id"},{"line_number":280,"context_line":"    # Reset the cache."},{"line_number":281,"context_line":"    self.class.services \u003d nil"},{"line_number":282,"context_line":"    name   \u003d resource[:name]"},{"line_number":283,"context_line":"    type   \u003d resource[:type]"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    services \u003d self.class.services.find_all { |s| s[:name] \u003d\u003d name }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a9d85d2_023b6a39","line":282,"range":{"start_line":282,"start_character":8,"end_line":282,"end_character":10},"updated":"2016-06-21 11:09:20.000000000","message":"nit alignment","commit_id":"6b75c0b1c44b3235b11a22508ac88892ebf4da8e"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"1ce68041e4c03eb3c439e0f8656f884e63678b66","unresolved":false,"context_lines":[{"line_number":279,"context_line":"  def service_id"},{"line_number":280,"context_line":"    # Reset the cache."},{"line_number":281,"context_line":"    self.class.services \u003d nil"},{"line_number":282,"context_line":"    name   \u003d resource[:name]"},{"line_number":283,"context_line":"    type   \u003d resource[:type]"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    services \u003d self.class.services.find_all { |s| s[:name] \u003d\u003d name }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a9d85d2_ad4d2774","line":282,"range":{"start_line":282,"start_character":8,"end_line":282,"end_character":10},"in_reply_to":"5a9d85d2_023b6a39","updated":"2016-06-21 11:15:12.000000000","message":"Done","commit_id":"6b75c0b1c44b3235b11a22508ac88892ebf4da8e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2941747f7eeb79695b37a116ed132227bf7b2304","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    # Reset the cache."},{"line_number":281,"context_line":"    self.class.services \u003d nil"},{"line_number":282,"context_line":"    name   \u003d resource[:name]"},{"line_number":283,"context_line":"    type   \u003d resource[:type]"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    services \u003d self.class.services.find_all { |s| s[:name] \u003d\u003d name }"},{"line_number":286,"context_line":"    service \u003d services.find { |s| s[:type] \u003d\u003d type }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a9d85d2_424572b1","line":283,"updated":"2016-06-21 11:09:20.000000000","message":"same","commit_id":"6b75c0b1c44b3235b11a22508ac88892ebf4da8e"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"1ce68041e4c03eb3c439e0f8656f884e63678b66","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    # Reset the cache."},{"line_number":281,"context_line":"    self.class.services \u003d nil"},{"line_number":282,"context_line":"    name   \u003d resource[:name]"},{"line_number":283,"context_line":"    type   \u003d resource[:type]"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    services \u003d self.class.services.find_all { |s| s[:name] \u003d\u003d name }"},{"line_number":286,"context_line":"    service \u003d services.find { |s| s[:type] \u003d\u003d type }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a9d85d2_2d42d73e","line":283,"in_reply_to":"5a9d85d2_424572b1","updated":"2016-06-21 11:15:12.000000000","message":"Done","commit_id":"6b75c0b1c44b3235b11a22508ac88892ebf4da8e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2941747f7eeb79695b37a116ed132227bf7b2304","unresolved":false,"context_lines":[{"line_number":292,"context_line":"      # Math the service by id."},{"line_number":293,"context_line":"      service_id \u003d service[:id] if service"},{"line_number":294,"context_line":"    end"},{"line_number":295,"context_line":"    if service_id.nil? || service_id.empty?"},{"line_number":296,"context_line":"      title \u003d self.class.transform_name(resource[:region], resource[:name], resource[:type])"},{"line_number":297,"context_line":"      fail(Puppet::Error, \"Cannot find service associated with #{title}\")"},{"line_number":298,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a9d85d2_624fcebd","line":295,"range":{"start_line":295,"start_character":23,"end_line":295,"end_character":25},"updated":"2016-06-21 11:09:20.000000000","message":"afaik, such syntax was deprecated and better to use \u0027or\u0027\n\nbut may be i\u0027m wrong","commit_id":"6b75c0b1c44b3235b11a22508ac88892ebf4da8e"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"1ce68041e4c03eb3c439e0f8656f884e63678b66","unresolved":false,"context_lines":[{"line_number":292,"context_line":"      # Math the service by id."},{"line_number":293,"context_line":"      service_id \u003d service[:id] if service"},{"line_number":294,"context_line":"    end"},{"line_number":295,"context_line":"    if service_id.nil? || service_id.empty?"},{"line_number":296,"context_line":"      title \u003d self.class.transform_name(resource[:region], resource[:name], resource[:type])"},{"line_number":297,"context_line":"      fail(Puppet::Error, \"Cannot find service associated with #{title}\")"},{"line_number":298,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a9d85d2_6d4cdf70","line":295,"range":{"start_line":295,"start_character":23,"end_line":295,"end_character":25},"in_reply_to":"5a9d85d2_624fcebd","updated":"2016-06-21 11:15:12.000000000","message":"That\u0027s the opposite :)\n\nSee https://github.com/bbatsov/ruby-style-guide#no-and-or-or","commit_id":"6b75c0b1c44b3235b11a22508ac88892ebf4da8e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8860a5da97bbc27f6a747fe13213c960563c40d9","unresolved":false,"context_lines":[{"line_number":292,"context_line":"      # Math the service by id."},{"line_number":293,"context_line":"      service_id \u003d service[:id] if service"},{"line_number":294,"context_line":"    end"},{"line_number":295,"context_line":"    if service_id.nil? || service_id.empty?"},{"line_number":296,"context_line":"      title \u003d self.class.transform_name(resource[:region], resource[:name], resource[:type])"},{"line_number":297,"context_line":"      fail(Puppet::Error, \"Cannot find service associated with #{title}\")"},{"line_number":298,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a9d85d2_4de3e333","line":295,"range":{"start_line":295,"start_character":23,"end_line":295,"end_character":25},"in_reply_to":"5a9d85d2_6d4cdf70","updated":"2016-06-21 11:17:30.000000000","message":"Ah, thanks!","commit_id":"6b75c0b1c44b3235b11a22508ac88892ebf4da8e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2941747f7eeb79695b37a116ed132227bf7b2304","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    end"},{"line_number":295,"context_line":"    if service_id.nil? || service_id.empty?"},{"line_number":296,"context_line":"      title \u003d self.class.transform_name(resource[:region], resource[:name], resource[:type])"},{"line_number":297,"context_line":"      fail(Puppet::Error, \"Cannot find service associated with #{title}\")"},{"line_number":298,"context_line":"    end"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    service_id"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a9d85d2_22030644","line":297,"updated":"2016-06-21 11:09:20.000000000","message":"else section or unless check here?","commit_id":"6b75c0b1c44b3235b11a22508ac88892ebf4da8e"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"1ce68041e4c03eb3c439e0f8656f884e63678b66","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    end"},{"line_number":295,"context_line":"    if service_id.nil? || service_id.empty?"},{"line_number":296,"context_line":"      title \u003d self.class.transform_name(resource[:region], resource[:name], resource[:type])"},{"line_number":297,"context_line":"      fail(Puppet::Error, \"Cannot find service associated with #{title}\")"},{"line_number":298,"context_line":"    end"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    service_id"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a9d85d2_ed09ef2d","line":297,"in_reply_to":"5a9d85d2_22030644","updated":"2016-06-21 11:15:12.000000000","message":"The \"else\" part is \"service_id\"","commit_id":"6b75c0b1c44b3235b11a22508ac88892ebf4da8e"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"740e954cdb2c27242884fdf612c43ca369b819af","unresolved":false,"context_lines":[{"line_number":262,"context_line":"  end"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"  def self.get_region(endpoint)"},{"line_number":265,"context_line":"    region \u003d \u0027\u0027"},{"line_number":266,"context_line":"    [:admin, :internal, :public].each do |type|"},{"line_number":267,"context_line":"      if endpoint[type]"},{"line_number":268,"context_line":"        region \u003d endpoint[type][:region]"},{"line_number":269,"context_line":"        break"},{"line_number":270,"context_line":"      end"},{"line_number":271,"context_line":"    end"},{"line_number":272,"context_line":"    region"},{"line_number":273,"context_line":"  end"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"  def self.get_url(endpoint, type, default\u003d\u0027\u0027)"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"3aaa91ec_1e31eeec","line":272,"range":{"start_line":265,"start_character":3,"end_line":272,"end_character":10},"updated":"2016-06-23 09:46:22.000000000","message":"the same?\n\ntype \u003d [:admin, :internal, :public].detect {|t| endpoint.key? t}\ntype ? endpoint[type][:region] : \"\"","commit_id":"10831a4478979ac685a90065d76fffe165eb0f7e"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"14e7fa01e70b33c86be89649fbdc6458264f34f9","unresolved":false,"context_lines":[{"line_number":262,"context_line":"  end"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"  def self.get_region(endpoint)"},{"line_number":265,"context_line":"    region \u003d \u0027\u0027"},{"line_number":266,"context_line":"    [:admin, :internal, :public].each do |type|"},{"line_number":267,"context_line":"      if endpoint[type]"},{"line_number":268,"context_line":"        region \u003d endpoint[type][:region]"},{"line_number":269,"context_line":"        break"},{"line_number":270,"context_line":"      end"},{"line_number":271,"context_line":"    end"},{"line_number":272,"context_line":"    region"},{"line_number":273,"context_line":"  end"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"  def self.get_url(endpoint, type, default\u003d\u0027\u0027)"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"3aaa91ec_63b841c9","line":272,"range":{"start_line":265,"start_character":3,"end_line":272,"end_character":10},"in_reply_to":"3aaa91ec_1e31eeec","updated":"2016-06-23 16:41:31.000000000","message":"Better idiom.  Done.","commit_id":"10831a4478979ac685a90065d76fffe165eb0f7e"}]}