)]}'
{"manifests/federation/openidc.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b1ba4edcff0bb487cb5505551301b473bd69df65","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#  (Required) String value."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*openidc_provider_metadata_url*]"},{"line_number":16,"context_line":"#  The url that points to your OpenID Connect metadata provider"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*openidc_client_id*]"},{"line_number":19,"context_line":"#  The client ID to use when handshaking with your OpenID Connect provider"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3aaa91ec_f19b3364","line":16,"updated":"2016-06-24 09:14:19.000000000","message":"let\u0027s use same doc syntax. Please set (Required) or (Optional) for parameters, where missed.\n\nAnd should be in beginning of doc:\n [*parameter*]\n  (Optional) description.\n  Defaults to \u003cdefault\u003e","commit_id":"ab587fac06ac06967b0bcb6e5ae15b2c91ed1f6e"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"32f1afde827af5f4f4ecc518197fa6d64eb8eefb","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  if !(\u0027openidc\u0027 in $methods ) {"},{"line_number":90,"context_line":"    fail(\u0027Methods should contain openidc as one of the auth methods.\u0027)"},{"line_number":91,"context_line":"  }else{"},{"line_number":92,"context_line":"    if ($module_plugin !\u003d \u0027keystone.auth.plugins.mapped.Mapped\u0027) {"},{"line_number":93,"context_line":"      fail(\u0027The plugin for openidc should be keystone.auth.plugins.mapped.Mapped\u0027)"},{"line_number":94,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1aa78d24_983ed8b6","line":91,"updated":"2016-07-04 09:54:51.000000000","message":"} else {","commit_id":"e224e156b4fefbcaf87db295679db6a34544c2e7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"32f1afde827af5f4f4ecc518197fa6d64eb8eefb","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    fail(\u0027Methods should contain openidc as one of the auth methods.\u0027)"},{"line_number":91,"context_line":"  }else{"},{"line_number":92,"context_line":"    if ($module_plugin !\u003d \u0027keystone.auth.plugins.mapped.Mapped\u0027) {"},{"line_number":93,"context_line":"      fail(\u0027The plugin for openidc should be keystone.auth.plugins.mapped.Mapped\u0027)"},{"line_number":94,"context_line":"    }"},{"line_number":95,"context_line":"  }"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1aa78d24_f876fc3c","line":93,"updated":"2016-07-04 09:54:51.000000000","message":"I\u0027d prefer to see the failure smth like: another plugins are not supported yet.","commit_id":"e224e156b4fefbcaf87db295679db6a34544c2e7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"32f1afde827af5f4f4ecc518197fa6d64eb8eefb","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  validate_bool($admin_port)"},{"line_number":98,"context_line":"  validate_bool($main_port)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"  if( !$admin_port and !$main_port){"},{"line_number":101,"context_line":"    fail(\u0027No VirtualHost port to configure, please choose at least one.\u0027)"},{"line_number":102,"context_line":"  }"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1aa78d24_78b4ccf1","line":100,"updated":"2016-07-04 09:54:51.000000000","message":"if both are true, that\u0027s a mistake too. puppet will fail at 124 line with error: Cannot reassign variable $openidc_redirect_uri","commit_id":"e224e156b4fefbcaf87db295679db6a34544c2e7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"cf2b27ca4f7c546be9cd408e42c2f4daaa8b1d3f","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  })"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  if $admin_port {"},{"line_number":115,"context_line":"    keystone::federation::openidc_httpd_configuration{\u0027admin\u0027:"},{"line_number":116,"context_line":"      port              \u003d\u003e $::keystone::admin_port,"},{"line_number":117,"context_line":"      keystone_endpoint \u003d\u003e $::keystone::admin_endpoint,"},{"line_number":118,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aa78d24_1410c300","line":115,"updated":"2016-07-05 10:20:40.000000000","message":"...configuration { \u0027admin\u0027:","commit_id":"c020b8ae5c511aa6fb3e25ccddeff5c04cd6ad55"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"cf2b27ca4f7c546be9cd408e42c2f4daaa8b1d3f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"  }"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  if $main_port {"},{"line_number":122,"context_line":"    keystone::federation::openidc_httpd_configuration{\u0027main\u0027:"},{"line_number":123,"context_line":"      port              \u003d\u003e $::keystone::public_port,"},{"line_number":124,"context_line":"      keystone_endpoint \u003d\u003e $::keystone::admin_endpoint,"},{"line_number":125,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aa78d24_f4125708","line":122,"updated":"2016-07-05 10:20:40.000000000","message":"same here","commit_id":"c020b8ae5c511aa6fb3e25ccddeff5c04cd6ad55"}],"manifests/federation/openidc_httpd_configuration.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"cf2b27ca4f7c546be9cd408e42c2f4daaa8b1d3f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# [*keystone_endpoint*]"},{"line_number":11,"context_line":"#  The keystone endpoint to use when configuring the OpenIDC redirect back"},{"line_number":12,"context_line":"#  to keystone"},{"line_number":13,"context_line":"#  (Required) (string)."},{"line_number":14,"context_line":"define keystone::federation::openidc_httpd_configuration ("},{"line_number":15,"context_line":"  $port              \u003d undef,"},{"line_number":16,"context_line":"  $keystone_endpoint \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aa78d24_d4d3db36","line":13,"updated":"2016-07-05 10:20:40.000000000","message":"(Required) String value.\n\nAnd please insert empty line with # at the beginning","commit_id":"c020b8ae5c511aa6fb3e25ccddeff5c04cd6ad55"}],"spec/classes/keystone_federation_openidc.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b1ba4edcff0bb487cb5505551301b473bd69df65","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    end"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    it { is_expected.to contain_package(\u0027libapache2-mod-auth-mellon\u0027) }"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  end"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3aaa91ec_b166cb4e","line":141,"updated":"2016-06-24 09:14:19.000000000","message":"please use on_supported_os function instead of having different context.\n\nPlatform based params can be set in case structure, for example.","commit_id":"ab587fac06ac06967b0bcb6e5ae15b2c91ed1f6e"}]}