)]}'
{"manifests/init.pp":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b39fad502bae3aa0e57ff56bb8a7de2c8291decc","unresolved":false,"context_lines":[{"line_number":427,"context_line":"# [*enable_credential_setup*]"},{"line_number":428,"context_line":"#   (Optional) Setup keystone for credentials."},{"line_number":429,"context_line":"#   In a cluster environment where multiple Keystone nodes are running, you might"},{"line_number":430,"context_line":"#   the same keys everywhere; so you\u0027ll have to set credential_keys parameter in"},{"line_number":431,"context_line":"#   order to let Puppet manage Keystone keys in a consistent way, otherwise"},{"line_number":432,"context_line":"#   keystone-manage will generate different set of keys on keystone nodes and the"},{"line_number":433,"context_line":"#   service won\u0027t work."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a89bdaa_15c98426","line":430,"updated":"2016-09-06 22:36:32.000000000","message":"might need* ?","commit_id":"7b8d5b508d5fd23229fd72e8106aa6229e9b7344"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cf7a922f66d7b765fb69818b052f1a786d26f0eb","unresolved":false,"context_lines":[{"line_number":427,"context_line":"# [*enable_credential_setup*]"},{"line_number":428,"context_line":"#   (Optional) Setup keystone for credentials."},{"line_number":429,"context_line":"#   In a cluster environment where multiple Keystone nodes are running, you might"},{"line_number":430,"context_line":"#   the same keys everywhere; so you\u0027ll have to set credential_keys parameter in"},{"line_number":431,"context_line":"#   order to let Puppet manage Keystone keys in a consistent way, otherwise"},{"line_number":432,"context_line":"#   keystone-manage will generate different set of keys on keystone nodes and the"},{"line_number":433,"context_line":"#   service won\u0027t work."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a89bdaa_f85095d6","line":430,"in_reply_to":"9a89bdaa_15c98426","updated":"2016-09-06 22:51:03.000000000","message":"ok I\u0027ll fix in next patchset, thanks","commit_id":"7b8d5b508d5fd23229fd72e8106aa6229e9b7344"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"97690c9c1fdd4c52f1cfbcea5dcbe6b2cc0d13eb","unresolved":false,"context_lines":[{"line_number":449,"context_line":"#     /etc/keystone/credential-keys/1:"},{"line_number":450,"context_line":"#       content: GLlnyygEVJP4-H2OMwClXn3sdSQUZsM5F194139Unv8\u003d"},{"line_number":451,"context_line":"#   Puppet will create a file per key in $credential_key_repository."},{"line_number":452,"context_line":"#   Note: defaults to false so keystone-manage credential_setup will be executed."},{"line_number":453,"context_line":"#   Otherwise Puppet will manage keys with File resource."},{"line_number":454,"context_line":"#   Defaults to false"},{"line_number":455,"context_line":"#"},{"line_number":456,"context_line":"# [*enable_bootstrap*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a89bdaa_23d2d25c","line":453,"range":{"start_line":452,"start_character":0,"end_line":453,"end_character":56},"updated":"2016-09-06 23:20:57.000000000","message":"This should be something like:\n\nNote: enable_credential_setup must be true for these to be managed. \n\nThat way it\u0027s clear that you must also set that parameter for the keys to work","commit_id":"7b8d5b508d5fd23229fd72e8106aa6229e9b7344"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"755f48433c2e6f55d3871d59df5ddb560b43a523","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"  # Credential support"},{"line_number":1097,"context_line":"  if $enable_credential_setup {"},{"line_number":1098,"context_line":"    validate_string($credential_key_repository)"},{"line_number":1099,"context_line":"    ensure_resource(\u0027file\u0027, $credential_key_repository, {"},{"line_number":1100,"context_line":"      ensure    \u003d\u003e \u0027directory\u0027,"},{"line_number":1101,"context_line":"      owner     \u003d\u003e $keystone_user,"},{"line_number":1102,"context_line":"      group     \u003d\u003e $keystone_group,"},{"line_number":1103,"context_line":"      subscribe \u003d\u003e Anchor[\u0027keystone::install::end\u0027],"},{"line_number":1104,"context_line":"    })"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"    if $credential_keys {"},{"line_number":1107,"context_line":"      validate_hash($credential_keys)"},{"line_number":1108,"context_line":"      create_resources(\u0027file\u0027, $credential_keys, {"},{"line_number":1109,"context_line":"          \u0027owner\u0027     \u003d\u003e $keystone_user,"},{"line_number":1110,"context_line":"          \u0027group\u0027     \u003d\u003e $keystone_group,"},{"line_number":1111,"context_line":"          \u0027subscribe\u0027 \u003d\u003e \u0027Anchor[keystone::install::end]\u0027,"},{"line_number":1112,"context_line":"        }"},{"line_number":1113,"context_line":"      )"},{"line_number":1114,"context_line":"    } else {"},{"line_number":1115,"context_line":"      exec { \u0027keystone-manage credential_setup\u0027:"},{"line_number":1116,"context_line":"        command     \u003d\u003e \"keystone-manage credential_setup --keystone-user ${keystone_user} --keystone-group ${keystone_group}\","},{"line_number":1117,"context_line":"        path        \u003d\u003e \u0027/usr/bin\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a89bdaa_d8abd173","line":1114,"range":{"start_line":1099,"start_character":0,"end_line":1114,"end_character":4},"updated":"2016-09-06 22:59:57.000000000","message":"This is starting to seem like we should always ensure the repository directory exists and then the if $credential_keys should be in an elsif to the $enable_credential_setup since they appear to be exclusive.\n\n\nSo...\n\n  validate_string($credential_key_repository)\n  ensure_resource(\u0027file\u0027, $credential_key_repository, {\n    ensure    \u003d\u003e \u0027directory\u0027,\n    owner     \u003d\u003e $keystone_user,\n    group     \u003d\u003e $keystone_group,\n    subscribe \u003d\u003e Anchor[\u0027keystone::install::end\u0027],\n  })\n\n  if $enable_credential_setup and $credential_keys {\n     fail(\u0027You cannot have both\u0027)\n  }\n\n  if $enable_credential_setup {\n    exec { \u0027keystone-manage credential_setup\u0027: ... }\n  } elsif $credential_keys {\n    validate_hash($credential_keys)\n    create_resources(\u0027file\u0027, $credential_keys, {\n      \u0027owner\u0027     \u003d\u003e $keystone_user,\n      \u0027group\u0027     \u003d\u003e $keystone_group,\n      \u0027subscribe\u0027 \u003d\u003e \u0027Anchor[keystone::install::end]\u0027,\n      }\n    )\n  }","commit_id":"7b8d5b508d5fd23229fd72e8106aa6229e9b7344"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"97690c9c1fdd4c52f1cfbcea5dcbe6b2cc0d13eb","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"  # Credential support"},{"line_number":1097,"context_line":"  if $enable_credential_setup {"},{"line_number":1098,"context_line":"    validate_string($credential_key_repository)"},{"line_number":1099,"context_line":"    ensure_resource(\u0027file\u0027, $credential_key_repository, {"},{"line_number":1100,"context_line":"      ensure    \u003d\u003e \u0027directory\u0027,"},{"line_number":1101,"context_line":"      owner     \u003d\u003e $keystone_user,"},{"line_number":1102,"context_line":"      group     \u003d\u003e $keystone_group,"},{"line_number":1103,"context_line":"      subscribe \u003d\u003e Anchor[\u0027keystone::install::end\u0027],"},{"line_number":1104,"context_line":"    })"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"    if $credential_keys {"},{"line_number":1107,"context_line":"      validate_hash($credential_keys)"},{"line_number":1108,"context_line":"      create_resources(\u0027file\u0027, $credential_keys, {"},{"line_number":1109,"context_line":"          \u0027owner\u0027     \u003d\u003e $keystone_user,"},{"line_number":1110,"context_line":"          \u0027group\u0027     \u003d\u003e $keystone_group,"},{"line_number":1111,"context_line":"          \u0027subscribe\u0027 \u003d\u003e \u0027Anchor[keystone::install::end]\u0027,"},{"line_number":1112,"context_line":"        }"},{"line_number":1113,"context_line":"      )"},{"line_number":1114,"context_line":"    } else {"},{"line_number":1115,"context_line":"      exec { \u0027keystone-manage credential_setup\u0027:"},{"line_number":1116,"context_line":"        command     \u003d\u003e \"keystone-manage credential_setup --keystone-user ${keystone_user} --keystone-group ${keystone_group}\","},{"line_number":1117,"context_line":"        path        \u003d\u003e \u0027/usr/bin\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a89bdaa_a3dfc267","line":1114,"range":{"start_line":1099,"start_character":0,"end_line":1114,"end_character":4},"in_reply_to":"9a89bdaa_d8abd173","updated":"2016-09-06 23:20:57.000000000","message":"On second thought, lets just document the fact that $enable_credential_setup will automatically create keys unless $credential_keys are provided.","commit_id":"7b8d5b508d5fd23229fd72e8106aa6229e9b7344"}]}