)]}'
{"manifests/init.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"47edf962898b9410002d9efa1cd0bb9ea8b1bf6a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*admin_token*]"},{"line_number":25,"context_line":"#   Admin token that can be used to authenticate as a keystone"},{"line_number":26,"context_line":"#   admin. Required. Will be deprecated in a future changeset."},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*admin_password*]"},{"line_number":29,"context_line":"#   Keystone password for the admin user. This is not the admin_token."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a89bdaa_aa827cc6","line":26,"updated":"2016-09-09 18:23:04.000000000","message":"so the parameter is required but deprecated?\n\nI would rather set this one to undef by default.","commit_id":"cdd8462ca448415990f4a76935a321d173925a6c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"9b41c7935da978c819960d9d56487498c8804bc3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*admin_token*]"},{"line_number":25,"context_line":"#   Admin token that can be used to authenticate as a keystone"},{"line_number":26,"context_line":"#   admin. Required. Will be deprecated in a future changeset."},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*admin_password*]"},{"line_number":29,"context_line":"#   Keystone password for the admin user. This is not the admin_token."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a89bdaa_7f156699","line":26,"in_reply_to":"9a89bdaa_aa827cc6","updated":"2016-09-12 08:53:29.000000000","message":"+1, still parameter is required by puppet - it always have to be set.","commit_id":"cdd8462ca448415990f4a76935a321d173925a6c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"47edf962898b9410002d9efa1cd0bb9ea8b1bf6a","unresolved":false,"context_lines":[{"line_number":752,"context_line":"  if ($public_endpoint and \u0027v2.0\u0027 in $public_endpoint) {"},{"line_number":753,"context_line":"    warning(\u0027Version string /v2.0/ should not be included in keystone::public_endpoint\u0027)"},{"line_number":754,"context_line":"  }"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"  if $admin_password \u003d\u003d $admin_token {"},{"line_number":757,"context_line":"    warning(\u0027admin_password is required, please set admin_password to a value !\u003d admin_token. admin_token will be removed in a later release\u0027)"},{"line_number":758,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a89bdaa_2ae58ca7","line":755,"updated":"2016-09-09 18:23:04.000000000","message":"I would rather do something like:\n\n if $admin_token {\n   warning(...)\n   $admin_password_real \u003d $admin_token\n } elsif $admin_password {\n   $admin_password_real \u003d $admin_password\n } else {\n   fail(...)\n }","commit_id":"cdd8462ca448415990f4a76935a321d173925a6c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"9b41c7935da978c819960d9d56487498c8804bc3","unresolved":false,"context_lines":[{"line_number":752,"context_line":"  if ($public_endpoint and \u0027v2.0\u0027 in $public_endpoint) {"},{"line_number":753,"context_line":"    warning(\u0027Version string /v2.0/ should not be included in keystone::public_endpoint\u0027)"},{"line_number":754,"context_line":"  }"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"  if $admin_password \u003d\u003d $admin_token {"},{"line_number":757,"context_line":"    warning(\u0027admin_password is required, please set admin_password to a value !\u003d admin_token. admin_token will be removed in a later release\u0027)"},{"line_number":758,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a89bdaa_ff689623","line":755,"in_reply_to":"9a89bdaa_2ae58ca7","updated":"2016-09-12 08:53:29.000000000","message":"or by using pick function.\n\n $admin_password_real \u003d ($admin_token, $admin_password)\n\n+ warning message","commit_id":"cdd8462ca448415990f4a76935a321d173925a6c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"a31b1abfb94052a8281c64b1774a03435297a287","unresolved":false,"context_lines":[{"line_number":1160,"context_line":"    # this requires the database to be up and running and configured"},{"line_number":1161,"context_line":"    # and is only run once, so we don\u0027t need to notify the service"},{"line_number":1162,"context_line":"    exec { \u0027keystone-manage bootstrap\u0027:"},{"line_number":1163,"context_line":"      command     \u003d\u003e \"keystone-manage bootstrap --bootstrap-password ${admin_password_real}\","},{"line_number":1164,"context_line":"      user        \u003d\u003e $keystone_user,"},{"line_number":1165,"context_line":"      path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":1166,"context_line":"      refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a8ec9b2_41ff5434","line":1163,"updated":"2016-09-13 17:45:21.000000000","message":"you\u0027re still using $admin_password_real :)","commit_id":"96ee335c716450f86e57f11a1b9dbfa85902fd5a"}],"manifests/roles/admin.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7b51ac6a19cef6a5ef71948c29ffabaecb3f16a4","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  include ::keystone::deps"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  if $password !\u003d $keystone::admin_password {"},{"line_number":100,"context_line":"    error(\u0027the main class is setting the admin password differently from this class when calling bootstrap. This will lead to the password flip-flopping and cause authentication issues for the admin user. Please ensure that keystone::roles::admin::password and keystone::admin_password are set the same.\u0027)"},{"line_number":101,"context_line":"  }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a8ec9b2_416af41b","line":100,"range":{"start_line":100,"start_character":4,"end_line":100,"end_character":9},"updated":"2016-09-13 17:43:51.000000000","message":"i think better to use fail.\n\nand also can we split this huge line on few lines?","commit_id":"d10395cf9629866c112fed84205cacda0abf5f1c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"28891c08a0d1f0d203e9c2a747d558baac5ddc44","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  include ::keystone::deps"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  if $password !\u003d $keystone::admin_password {"},{"line_number":100,"context_line":"    error(\u0027the main class is setting the admin password differently from this\\"},{"line_number":101,"context_line":"      class when calling bootstrap. This will lead to the password\\"},{"line_number":102,"context_line":"      flip-flopping and cause authentication issues for the admin user.\\"},{"line_number":103,"context_line":"      Please ensure that keystone::roles::admin::password and\\"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a8ec9b2_59d104fb","line":100,"updated":"2016-09-13 21:56:26.000000000","message":"there\u0027s no such thing as error, i think you mean fail :)","commit_id":"d2151058413e10d067a4176e7ea87341b22f5e3b"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"d83d64529de5b208691d716273154d393c5eebbe","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  include ::keystone::deps"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  if $password !\u003d $keystone::admin_password {"},{"line_number":100,"context_line":"    error(\u0027the main class is setting the admin password differently from this\\"},{"line_number":101,"context_line":"      class when calling bootstrap. This will lead to the password\\"},{"line_number":102,"context_line":"      flip-flopping and cause authentication issues for the admin user.\\"},{"line_number":103,"context_line":"      Please ensure that keystone::roles::admin::password and\\"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a8ec9b2_52f8f6e5","line":100,"in_reply_to":"7a8ec9b2_59d104fb","updated":"2016-09-14 01:40:33.000000000","message":"dang it I fixed this twice and missed it in the rebase !thanks!","commit_id":"d2151058413e10d067a4176e7ea87341b22f5e3b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"101019c73fef4902bac6f55acb3968d1a49deb9e","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  include ::keystone::deps"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  if $password !\u003d $keystone::admin_password {"},{"line_number":100,"context_line":"    fail(\u0027the main class is setting the admin password differently from this\\"},{"line_number":101,"context_line":"      class when calling bootstrap. This will lead to the password\\"},{"line_number":102,"context_line":"      flip-flopping and cause authentication issues for the admin user.\\"},{"line_number":103,"context_line":"      Please ensure that keystone::roles::admin::password and\\"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"7a8ec9b2_afada19c","line":100,"updated":"2016-09-16 18:02:34.000000000","message":"looks like tripleo is hitting this since it\u0027s using the token, might want to switch this to a warning rather than a hard fail","commit_id":"81fb6487f5aa54999a2d1d0aaaed7d2015e811a4"}]}