)]}'
{"spec/classes/keystone_messaging_amqp_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ca2879169edc9b63a610e210a2f2facaad723a80","unresolved":false,"context_lines":[{"line_number":3,"context_line":"describe \u0027keystone::messaging::amqp\u0027 do"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  shared_examples_for \u0027keystone messaging amqp\u0027 do"},{"line_number":6,"context_line":"    it \u0027configures amqp messaging default params\u0027 do"},{"line_number":7,"context_line":"      is_expected.to contain_keystone_config(\u0027oslo_messaging_amqp/pre_settled\u0027).with_value([\u0027\u003cSERVICE DEFAULT\u003e\u0027])"},{"line_number":8,"context_line":"      is_expected.to contain_keystone_config(\u0027oslo_messaging_amqp/idle_timeout\u0027).with_value([\u0027\u003cSERVICE DEFAULT\u003e\u0027])"},{"line_number":9,"context_line":"      is_expected.to contain_keystone_config(\u0027oslo_messaging_amqp/ssl_ca_file\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"ba2be162_858cae80","line":6,"updated":"2017-03-02 00:08:27.000000000","message":"Rather than check for the keystone_config, we should just be checking the params get passed to the oslo::messaging::amqp class correctly. The tests for oslo::messaging::amqp should be handling the coverage for these settings to ensure they are getting set as we expect. The problem with checking these like this is that if we change the key in oslo::messaging::amqp we end up breaking all the unit tests for classes that are doing tests like this. We saw this when we removed the rpc_backend for amqp","commit_id":"4da17b6dfcd930d7aae2781b6d804e24d52991ae"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"66e6e1d26cd3fa03d6911d4e892d5228fdfb31f0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"          :amqp_ssl_ca_file      \u003d\u003e \u0027/path/to/ssl/ca/certs\u0027,"},{"line_number":39,"context_line":"          :amqp_ssl_cert_file    \u003d\u003e \u0027/path/to/ssl/cert/file\u0027,"},{"line_number":40,"context_line":"          :amqp_ssl_key_file     \u003d\u003e \u0027/path/to/ssl/keyfile\u0027,"},{"line_number":41,"context_line":"          :amqp_ssl_key_password \u003d\u003e \u0027/path/to/ssl/pw_file\u0027,          "},{"line_number":42,"context_line":"        }"},{"line_number":43,"context_line":"      end"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"ba2be162_2facb133","line":41,"range":{"start_line":41,"start_character":59,"end_line":41,"end_character":69},"updated":"2017-03-02 09:00:39.000000000","message":"empty spaces","commit_id":"4da17b6dfcd930d7aae2781b6d804e24d52991ae"}]}