)]}'
{"manifests/ldap_backend.pp":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"7e9c0a5555d0e526f82ea8f0fc8515d732bd9820","unresolved":false,"context_lines":[{"line_number":375,"context_line":"#"},{"line_number":376,"context_line":"# [*create_domain_entry*]"},{"line_number":377,"context_line":"#   (optional) Creates the domain in keystone via a keystone_domain resource"},{"line_number":378,"context_line":"#   and attempt to refresh the kesytone service."},{"line_number":379,"context_line":"#   Defaults to false."},{"line_number":380,"context_line":"#"},{"line_number":381,"context_line":"# \u003d\u003d\u003d DEPRECATED group/name"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bff0334d_d13880d4","line":378,"range":{"start_line":378,"start_character":8,"end_line":378,"end_character":15},"updated":"2017-04-06 12:13:03.000000000","message":"attemts","commit_id":"c922aace6cd30d18d6a15e25abe591d81b176733"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"abc7112b607f02d1d589ca358c5fd4c29dc7d85a","unresolved":false,"context_lines":[{"line_number":375,"context_line":"#"},{"line_number":376,"context_line":"# [*create_domain_entry*]"},{"line_number":377,"context_line":"#   (optional) Creates the domain in keystone via a keystone_domain resource"},{"line_number":378,"context_line":"#   and attempt to refresh the kesytone service."},{"line_number":379,"context_line":"#   Defaults to false."},{"line_number":380,"context_line":"#"},{"line_number":381,"context_line":"# \u003d\u003d\u003d DEPRECATED group/name"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bff0334d_d1abe0d3","line":378,"range":{"start_line":378,"start_character":8,"end_line":378,"end_character":15},"in_reply_to":"bff0334d_d13880d4","updated":"2017-04-06 12:15:42.000000000","message":"It is attempt: https://www.merriam-webster.com/dictionary/attempt","commit_id":"c922aace6cd30d18d6a15e25abe591d81b176733"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"45735bb767fefd6fd41c2c33af7e7c37a373937b","unresolved":false,"context_lines":[{"line_number":375,"context_line":"#"},{"line_number":376,"context_line":"# [*create_domain_entry*]"},{"line_number":377,"context_line":"#   (optional) Creates the domain in keystone via a keystone_domain resource"},{"line_number":378,"context_line":"#   and attempt to refresh the kesytone service."},{"line_number":379,"context_line":"#   Defaults to false."},{"line_number":380,"context_line":"#"},{"line_number":381,"context_line":"# \u003d\u003d\u003d DEPRECATED group/name"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bff0334d_51d7d04c","line":378,"range":{"start_line":378,"start_character":8,"end_line":378,"end_character":15},"in_reply_to":"bff0334d_d1abe0d3","updated":"2017-04-06 12:16:40.000000000","message":"oh, I see what you mean, it was a plural, not singular. Gotcha","commit_id":"c922aace6cd30d18d6a15e25abe591d81b176733"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"7e9c0a5555d0e526f82ea8f0fc8515d732bd9820","unresolved":false,"context_lines":[{"line_number":595,"context_line":"      enabled \u003d\u003e true,"},{"line_number":596,"context_line":"      tag     \u003d\u003e \u0027domain-specific-ldap\u0027"},{"line_number":597,"context_line":"    }"},{"line_number":598,"context_line":"    Keystone_domain[$domain] ~\u003e Exec\u003c| title \u003d\u003d \u0027restart_keystone\u0027 |\u003e"},{"line_number":599,"context_line":"  }"},{"line_number":600,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bff0334d_71ff7401","line":598,"range":{"start_line":598,"start_character":36,"end_line":598,"end_character":69},"updated":"2017-04-06 12:13:03.000000000","message":"why a collector here? maybe just Exec[\u0027restart_keystone\u0027]","commit_id":"c922aace6cd30d18d6a15e25abe591d81b176733"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"abc7112b607f02d1d589ca358c5fd4c29dc7d85a","unresolved":false,"context_lines":[{"line_number":595,"context_line":"      enabled \u003d\u003e true,"},{"line_number":596,"context_line":"      tag     \u003d\u003e \u0027domain-specific-ldap\u0027"},{"line_number":597,"context_line":"    }"},{"line_number":598,"context_line":"    Keystone_domain[$domain] ~\u003e Exec\u003c| title \u003d\u003d \u0027restart_keystone\u0027 |\u003e"},{"line_number":599,"context_line":"  }"},{"line_number":600,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bff0334d_d194008e","line":598,"range":{"start_line":598,"start_character":36,"end_line":598,"end_character":69},"in_reply_to":"bff0334d_71ff7401","updated":"2017-04-06 12:15:42.000000000","message":"Just in case keystone::init is not ran on the same node. That way it won\u0027t fail. but I could just do Exec[\u0027restart_keystone\u0027], what do you think?","commit_id":"c922aace6cd30d18d6a15e25abe591d81b176733"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0706c4b323b6a1d15577b141dd24051282370112","unresolved":false,"context_lines":[{"line_number":595,"context_line":"      enabled \u003d\u003e true,"},{"line_number":596,"context_line":"      tag     \u003d\u003e \u0027domain-specific-ldap\u0027"},{"line_number":597,"context_line":"    }"},{"line_number":598,"context_line":"    Keystone_domain[$domain] ~\u003e Exec[\u0027restart_keystone\u0027]"},{"line_number":599,"context_line":"  }"},{"line_number":600,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bff0334d_b53841d3","line":598,"updated":"2017-04-06 14:43:18.000000000","message":"do we need to create a simple class that we caninclude with this exec automatically?  I\u0027m not sure i like the requirement of having an operator define the restart exec externally and then assuming it\u0027s in the catalog","commit_id":"8429ae6253d5f1acacc4ade705b2da006df33ef4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"88b3a7b9c6933c0a08dd6c65a516f1051b291edc","unresolved":false,"context_lines":[{"line_number":595,"context_line":"      enabled \u003d\u003e true,"},{"line_number":596,"context_line":"      tag     \u003d\u003e \u0027domain-specific-ldap\u0027"},{"line_number":597,"context_line":"    }"},{"line_number":598,"context_line":"    Keystone_domain[$domain] ~\u003e Exec[\u0027restart_keystone\u0027]"},{"line_number":599,"context_line":"  }"},{"line_number":600,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bff0334d_582ecc43","line":598,"in_reply_to":"bff0334d_5876cca6","updated":"2017-04-06 15:12:46.000000000","message":"Ah i was confused because of the test case that defined it.  That being said it we should note this requirement in the release note so if a user attempts to create_domain_entry and has disabled puppet from managing the service this exec will be missing.","commit_id":"8429ae6253d5f1acacc4ade705b2da006df33ef4"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"7083a77556b20f28f01f88685c0da3257371a76d","unresolved":false,"context_lines":[{"line_number":595,"context_line":"      enabled \u003d\u003e true,"},{"line_number":596,"context_line":"      tag     \u003d\u003e \u0027domain-specific-ldap\u0027"},{"line_number":597,"context_line":"    }"},{"line_number":598,"context_line":"    Keystone_domain[$domain] ~\u003e Exec[\u0027restart_keystone\u0027]"},{"line_number":599,"context_line":"  }"},{"line_number":600,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bff0334d_5876cca6","line":598,"in_reply_to":"bff0334d_b53841d3","updated":"2017-04-06 15:05:29.000000000","message":"It is not an external exec it\u0027s internal https://github.com/openstack/puppet-keystone/blob/master/manifests/init.pp#L1246-L1250","commit_id":"8429ae6253d5f1acacc4ade705b2da006df33ef4"}],"releasenotes/notes/Create-domain-on-ldap_backend-resource-ac3cc85bc101883e.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"88b3a7b9c6933c0a08dd6c65a516f1051b291edc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The flag \u0027create_domain_entry\u0027 was added to the \u0027keystone::ldap_backend\u0027"},{"line_number":4,"context_line":"    resource. It defaults to false. But, if set to true, it will create the"},{"line_number":5,"context_line":"    domain in keystone and will attempt to refresh the keystone server."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bff0334d_d8cf7c7d","line":5,"updated":"2017-04-06 15:12:46.000000000","message":"NOTE: If keystone::enable_service or keystone::enabled are set to false, attempting to set create_domain_entry to true may fail.","commit_id":"8429ae6253d5f1acacc4ade705b2da006df33ef4"}]}