)]}'
{"manifests/cron/token_flush.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6eb6358af84b85626448eb8661fd62f967112e44","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  include ::keystone::deps"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  validate_numeric($maxdelay)"},{"line_number":71,"context_line":"  if $maxdelay \u003d\u003d 0 {"},{"line_number":72,"context_line":"    $sleep \u003d \u0027\u0027"},{"line_number":73,"context_line":"  } else {"},{"line_number":74,"context_line":"    $sleep \u003d \"sleep `expr \\${RANDOM} \\\\% ${maxdelay}`; \""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"df3967d1_9f3ca32f","line":71,"range":{"start_line":70,"start_character":0,"end_line":71,"end_character":21},"updated":"2017-08-04 13:09:34.000000000","message":"An alternative is to just convert it to an integer. \n\nif Integer($maxdelay) \u003d\u003d 0 {\n ...\n}\n\nAlso instead of validate_numeric we can just add the typing to the parameter itself.  I want to say the validate_* functions are all deprecated anyway so actually adding the typing to the parameter is probably what we want to do...","commit_id":"009de94e4fca099e5ae59b2e7c12670c31f3bedc"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"219d9e93e0df0740f327d6ed0ca02aaaead6cb6f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  $monthday    \u003d \u0027*\u0027,"},{"line_number":61,"context_line":"  $month       \u003d \u0027*\u0027,"},{"line_number":62,"context_line":"  $weekday     \u003d \u0027*\u0027,"},{"line_number":63,"context_line":"  Integer $maxdelay    \u003d 0,"},{"line_number":64,"context_line":"  $destination \u003d \u0027/var/log/keystone/keystone-tokenflush.log\u0027,"},{"line_number":65,"context_line":"  $user        \u003d \u0027keystone\u0027,"},{"line_number":66,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"df3967d1_e741d9aa","line":63,"updated":"2017-08-04 19:37:09.000000000","message":"nice! some puppet4 syntax :-)\ncould we please align the \"\u003d\" for a better readability?","commit_id":"785942378b3cad60dbe039a64b3927a93b3c32b1"}]}