)]}'
{"manifests/init.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"60c0d8a91d4a225b6e174e5ebaff98623c711499","unresolved":false,"context_lines":[{"line_number":1109,"context_line":"  }"},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"  case $service_name {"},{"line_number":1112,"context_line":"    $::keystone::params::service_name, \u0027keystone-public-keystone-admin\u0027 : {"},{"line_number":1113,"context_line":"      $service_name_real \u003d $::keystone::params::service_name"},{"line_number":1114,"context_line":"      if $validate_service {"},{"line_number":1115,"context_line":"        if $validate_auth_url {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"df7087c5_485b0bf5","line":1112,"range":{"start_line":1112,"start_character":39,"end_line":1112,"end_character":71},"updated":"2018-03-23 11:12:25.000000000","message":"Do you really need to have a new \"service name\" type? Can\u0027t we instead check operatingsystem fact and operatingsystemmajversion to in service.pp","commit_id":"f971f2154773b83b3d1c47e5c48adaa89eb956b4"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"09f9199df6242dad97328a9483296ed2b46d8784","unresolved":false,"context_lines":[{"line_number":1109,"context_line":"  }"},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"  case $service_name {"},{"line_number":1112,"context_line":"    $::keystone::params::service_name, \u0027keystone-public-keystone-admin\u0027 : {"},{"line_number":1113,"context_line":"      $service_name_real \u003d $::keystone::params::service_name"},{"line_number":1114,"context_line":"      if $validate_service {"},{"line_number":1115,"context_line":"        if $validate_auth_url {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bf659307_a1ac928c","line":1112,"range":{"start_line":1112,"start_character":39,"end_line":1112,"end_character":71},"in_reply_to":"df7087c5_485b0bf5","updated":"2018-03-27 15:50:43.000000000","message":"Actually, I do. Checking for the operating system doesn\u0027t work. First because what I would like to see in this puppet manifest isn\u0027t implemented yet. Second, because it\u0027s possible to run Debian packages on top of Ubuntu (and puppet-openstack handles this possibility elsewhere).","commit_id":"f971f2154773b83b3d1c47e5c48adaa89eb956b4"}],"manifests/service.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"60c0d8a91d4a225b6e174e5ebaff98623c711499","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  include ::keystone::deps"},{"line_number":78,"context_line":"  include ::keystone::params"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  if ($service_name \u003d\u003d \u0027keystone-public-keystone-admin\u0027){"},{"line_number":81,"context_line":"    service { \u0027keystone-public\u0027:"},{"line_number":82,"context_line":"      ensure     \u003d\u003e $ensure,"},{"line_number":83,"context_line":"      name       \u003d\u003e \u0027keystone-public\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"df7087c5_6805afc1","line":80,"range":{"start_line":80,"start_character":2,"end_line":80,"end_character":57},"updated":"2018-03-23 11:12:25.000000000","message":"here, cant we check debian is os and proper os version?","commit_id":"f971f2154773b83b3d1c47e5c48adaa89eb956b4"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"09f9199df6242dad97328a9483296ed2b46d8784","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  include ::keystone::deps"},{"line_number":78,"context_line":"  include ::keystone::params"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  if ($service_name \u003d\u003d \u0027keystone-public-keystone-admin\u0027){"},{"line_number":81,"context_line":"    service { \u0027keystone-public\u0027:"},{"line_number":82,"context_line":"      ensure     \u003d\u003e $ensure,"},{"line_number":83,"context_line":"      name       \u003d\u003e \u0027keystone-public\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bf659307_61a19aa9","line":80,"range":{"start_line":80,"start_character":2,"end_line":80,"end_character":57},"in_reply_to":"df7087c5_6805afc1","updated":"2018-03-27 15:50:43.000000000","message":"No, we can\u0027t, because this doesn\u0027t depend on the OS, but on the way the package is implemented. For example, you could run with the Debian package rebuilt on top of Ubuntu (yes, I did that in the past).","commit_id":"f971f2154773b83b3d1c47e5c48adaa89eb956b4"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"60c0d8a91d4a225b6e174e5ebaff98623c711499","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      tag        \u003d\u003e \u0027keystone-service\u0027,"},{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":"  } else {"},{"line_number":98,"context_line":"    service { \u0027keystone\u0027:"},{"line_number":99,"context_line":"      ensure     \u003d\u003e $ensure,"},{"line_number":100,"context_line":"      name       \u003d\u003e $service_name,"},{"line_number":101,"context_line":"      enable     \u003d\u003e $enable,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"df7087c5_4810eb00","line":98,"range":{"start_line":98,"start_character":4,"end_line":98,"end_character":25},"updated":"2018-03-23 11:12:25.000000000","message":"cant this init/systemd for keystone handle both uwsgi?","commit_id":"f971f2154773b83b3d1c47e5c48adaa89eb956b4"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"09f9199df6242dad97328a9483296ed2b46d8784","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      tag        \u003d\u003e \u0027keystone-service\u0027,"},{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":"  } else {"},{"line_number":98,"context_line":"    service { \u0027keystone\u0027:"},{"line_number":99,"context_line":"      ensure     \u003d\u003e $ensure,"},{"line_number":100,"context_line":"      name       \u003d\u003e $service_name,"},{"line_number":101,"context_line":"      enable     \u003d\u003e $enable,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bf659307_c1998679","line":98,"range":{"start_line":98,"start_character":4,"end_line":98,"end_character":25},"in_reply_to":"df7087c5_4810eb00","updated":"2018-03-27 15:50:43.000000000","message":"Currently, that\u0027s not the way the package works.","commit_id":"f971f2154773b83b3d1c47e5c48adaa89eb956b4"}]}