)]}'
{"manifests/resource/authtoken.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"5287f30e035c750e58003343ffc572ccd2ba5834","unresolved":false,"context_lines":[{"line_number":288,"context_line":"  if !is_service_default($memcached_servers) and !empty($memcached_servers){"},{"line_number":289,"context_line":"    $memcached_servers_real \u003d join(any2array($memcached_servers), \u0027,\u0027)"},{"line_number":290,"context_line":"    if $manage_memcache_package {"},{"line_number":291,"context_line":"      if ($::os_package_type \u003d\u003d \u0027debian\u0027) {"},{"line_number":292,"context_line":"        ensure_packages(\u0027python-memcache\u0027, {"},{"line_number":293,"context_line":"          ensure \u003d\u003e present,"},{"line_number":294,"context_line":"          name   \u003d\u003e $::keystone::params::python_memcache_package_name,"},{"line_number":295,"context_line":"          tag    \u003d\u003e [\u0027openstack\u0027],"},{"line_number":296,"context_line":"        })"},{"line_number":297,"context_line":"      } else {"},{"line_number":298,"context_line":"        ensure_packages(\u0027python3-memcache\u0027, {"},{"line_number":299,"context_line":"          ensure \u003d\u003e present,"},{"line_number":300,"context_line":"          name   \u003d\u003e $::keystone::params::python_memcache_package_name,"},{"line_number":301,"context_line":"          tag    \u003d\u003e [\u0027openstack\u0027],"},{"line_number":302,"context_line":"        })"},{"line_number":303,"context_line":"      }"},{"line_number":304,"context_line":"    }"},{"line_number":305,"context_line":"  } else {"},{"line_number":306,"context_line":"    $memcached_servers_real \u003d $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9f6a8fd7_9d537639","line":303,"range":{"start_line":291,"start_character":5,"end_line":303,"end_character":7},"updated":"2018-04-24 14:02:53.000000000","message":"This part looks suspicious, I know that python_memcache_package_name is properly set but should the resource name python-memcache be python3-memcache if os_package_type \u003d\u003d \u0027debian\u0027, looks to be reversed","commit_id":"1d431ade3f4cd6af4574f9aa59eb6400028647fb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ac794a1616a72e4ecdeaa1ad203a8f270675f5d9","unresolved":false,"context_lines":[{"line_number":288,"context_line":"  if !is_service_default($memcached_servers) and !empty($memcached_servers){"},{"line_number":289,"context_line":"    $memcached_servers_real \u003d join(any2array($memcached_servers), \u0027,\u0027)"},{"line_number":290,"context_line":"    if $manage_memcache_package {"},{"line_number":291,"context_line":"      if ($::os_package_type \u003d\u003d \u0027debian\u0027) {"},{"line_number":292,"context_line":"        ensure_packages(\u0027python-memcache\u0027, {"},{"line_number":293,"context_line":"          ensure \u003d\u003e present,"},{"line_number":294,"context_line":"          name   \u003d\u003e $::keystone::params::python_memcache_package_name,"},{"line_number":295,"context_line":"          tag    \u003d\u003e [\u0027openstack\u0027],"},{"line_number":296,"context_line":"        })"},{"line_number":297,"context_line":"      } else {"},{"line_number":298,"context_line":"        ensure_packages(\u0027python3-memcache\u0027, {"},{"line_number":299,"context_line":"          ensure \u003d\u003e present,"},{"line_number":300,"context_line":"          name   \u003d\u003e $::keystone::params::python_memcache_package_name,"},{"line_number":301,"context_line":"          tag    \u003d\u003e [\u0027openstack\u0027],"},{"line_number":302,"context_line":"        })"},{"line_number":303,"context_line":"      }"},{"line_number":304,"context_line":"    }"},{"line_number":305,"context_line":"  } else {"},{"line_number":306,"context_line":"    $memcached_servers_real \u003d $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9f6a8fd7_677930c6","line":303,"range":{"start_line":291,"start_character":5,"end_line":303,"end_character":7},"in_reply_to":"9f6a8fd7_9d537639","updated":"2018-04-24 15:30:29.000000000","message":"yea it\u0027s backwards","commit_id":"1d431ade3f4cd6af4574f9aa59eb6400028647fb"}],"spec/classes/keystone_client_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6ba3eb318402ffa79aec9df2f10d16bf03561e26","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    @default_facts.merge({ :osfamily \u003d\u003e \u0027Debian\u0027 })"},{"line_number":7,"context_line":"  end"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  describe \"with default parameters\" do"},{"line_number":10,"context_line":"    it { is_expected.to contain_package(\u0027python-keystoneclient\u0027).with("},{"line_number":11,"context_line":"        \u0027ensure\u0027 \u003d\u003e \u0027present\u0027,"},{"line_number":12,"context_line":"        \u0027name\u0027   \u003d\u003e platform_params[:client_package_name],"},{"line_number":13,"context_line":"        \u0027tag\u0027    \u003d\u003e \u0027openstack\u0027"},{"line_number":14,"context_line":"    ) }"},{"line_number":15,"context_line":"    it { is_expected.to contain_package(\u0027python-openstackclient\u0027).with("},{"line_number":16,"context_line":"        \u0027ensure\u0027 \u003d\u003e \u0027present\u0027,"},{"line_number":17,"context_line":"        \u0027name\u0027   \u003d\u003e platform_params[:osclient_package_name],"},{"line_number":18,"context_line":"        \u0027tag\u0027    \u003d\u003e \u0027openstack\u0027,"},{"line_number":19,"context_line":"    ) }"},{"line_number":20,"context_line":"  end"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  describe \"with specified version\" do"},{"line_number":23,"context_line":"    let :params do"},{"line_number":24,"context_line":"      {:ensure \u003d\u003e \u00272013.1\u0027}"},{"line_number":25,"context_line":"    end"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    it { is_expected.to contain_package(\u0027python-keystoneclient\u0027).with("},{"line_number":28,"context_line":"        \u0027ensure\u0027 \u003d\u003e \u00272013.1\u0027,"},{"line_number":29,"context_line":"        \u0027tag\u0027    \u003d\u003e \u0027openstack\u0027"},{"line_number":30,"context_line":"    ) }"},{"line_number":31,"context_line":"  end"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  on_supported_os({"},{"line_number":34,"context_line":"    :supported_os   \u003d\u003e OSDefaults.get_supported_os"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"bf659307_dfb7f6d7","line":31,"range":{"start_line":9,"start_character":0,"end_line":31,"end_character":5},"updated":"2018-04-10 20:47:26.000000000","message":"This is not in a shared_examples block so it doesn\u0027t get the facts from on_support_os. You\u0027ll need to wrap this bit in an shared_example \u0027keystone::client\u0027 block and add it_configures \u0027keystone::client\u0027 or something to that effect","commit_id":"4b1621bfed5a5c5b2f7d8332714700d24fa030b4"}]}