)]}'
{"manifests/federation/mellon.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"6c0b664ceb7d438eae31917a5bb89b58391514d5","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  $template_order     \u003d 331,"},{"line_number":72,"context_line":"  $package_ensure     \u003d present,"},{"line_number":73,"context_line":"  $enable_websso      \u003d false,"},{"line_number":74,"context_line":"  $trusted_dashboards \u003d undef,"},{"line_number":75,"context_line":"  # DEPRECATED"},{"line_number":76,"context_line":"  $module_plugin      \u003d undef,"},{"line_number":77,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_94504e0a","line":74,"range":{"start_line":74,"start_character":3,"end_line":74,"end_character":21},"updated":"2018-12-07 14:20:40.000000000","message":"if is deprecated you should move to the end of #DEPRECATED","commit_id":"82d6c72f75ad1e74ec6ffbe34bbd8c3ca0c0772c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4d2a91a0ccbb4d0c269581868ea4b15e99cd6e3a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  $trusted_dashboards \u003d undef,"},{"line_number":76,"context_line":"  $module_plugin      \u003d undef,"},{"line_number":77,"context_line":") {"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  include ::apache"},{"line_number":80,"context_line":"  include ::keystone::deps"},{"line_number":81,"context_line":"  include ::keystone::params"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"3f79a3b5_387b28f2","line":78,"updated":"2018-12-11 17:19:10.000000000","message":"if $trusted_dashboards {\n  warning(\u0027keystone::federation::mellon::trusted_dashboards is deprecated in Stein and will be removed in future releases\u0027)\n}","commit_id":"22ed73ac25ca6ee22b16a34f7a62c4a279cd4bc5"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"69eb87c952f0388999a7be42d8b03d25f668f9e0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  $trusted_dashboards \u003d undef,"},{"line_number":76,"context_line":"  $module_plugin      \u003d undef,"},{"line_number":77,"context_line":") {"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  include ::apache"},{"line_number":80,"context_line":"  include ::keystone::deps"},{"line_number":81,"context_line":"  include ::keystone::params"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"3f79a3b5_f3539139","line":78,"in_reply_to":"3f79a3b5_387b28f2","updated":"2018-12-11 18:17:39.000000000","message":"Done","commit_id":"22ed73ac25ca6ee22b16a34f7a62c4a279cd4bc5"}],"manifests/federation/openidc.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"09c8d9506db2b48135b3683c4bd9c24e020f50d5","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  if $admin_port and $keystone_admin_url {"},{"line_number":128,"context_line":"    keystone::federation::openidc_httpd_configuration{ \u0027admin\u0027:"},{"line_number":129,"context_line":"      keystone_endpoint \u003d\u003e $::keystone_admin_url,"},{"line_number":130,"context_line":"    }"},{"line_number":131,"context_line":"  }"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5f7c97a3_4622dc53","line":129,"range":{"start_line":129,"start_character":6,"end_line":129,"end_character":49},"updated":"2018-06-13 17:30:28.000000000","message":"I\u0027m kind of worried about that change as it\u0027s not backward compatible for our users already using this class. Since the _url are undef by default, if the users miss this new param their vhost will be broken I think.","commit_id":"8daa163d498f15971a443cb3abab3cd925707739"},{"author":{"_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},"change_message_id":"cd586161cdbb731929301349a4565f5383140c30","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  if $admin_port and $keystone_admin_url {"},{"line_number":128,"context_line":"    keystone::federation::openidc_httpd_configuration{ \u0027admin\u0027:"},{"line_number":129,"context_line":"      keystone_endpoint \u003d\u003e $::keystone_admin_url,"},{"line_number":130,"context_line":"    }"},{"line_number":131,"context_line":"  }"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5f7c97a3_a6d090c9","line":129,"range":{"start_line":129,"start_character":6,"end_line":129,"end_character":49},"in_reply_to":"5f7c97a3_4622dc53","updated":"2018-06-13 17:54:50.000000000","message":"In a tripleo deployment it\u0027s a broken link *right now*.  According to the keystone folks, the module probably shouldn\u0027t be using these values in any case (and because they\u0027re optional, they are in general going to be unset).\n\nBut it\u0027s easy to take the first defined value of either $keystone_X_url or $keystone::X_endpoint, so I\u0027ll submit an update that does that.","commit_id":"8daa163d498f15971a443cb3abab3cd925707739"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"0d0cb79ccbf7b080f4e4c673c27607bf353fb17f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"  }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  keystone_config {"},{"line_number":105,"context_line":"    \u0027openid/remote_id_attribute\u0027: value \u003d\u003e \u0027HTTP_OIDC_ISS\u0027;"},{"line_number":106,"context_line":"  }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  ensure_packages([$::keystone::params::openidc_package_name], {"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"3f79a3b5_843e6786","line":105,"range":{"start_line":105,"start_character":5,"end_line":105,"end_character":11},"updated":"2018-11-30 22:39:30.000000000","message":"This hard codes \u0027openid\u0027 as the auth method name that will need to be put in the list in \u0027auth/methods\u0027 in the configuration.  The previous code in this file that handled the auth methods used to hardcode this as \u0027openidc\u0027.  Now that you pulled the handling of auth methods into the generic keystone::federation class, we are not guaranteed to have the proper method in the list.\n\nI\u0027m OK hard coding it, but we should probably stick with the old name of \u0027openidc\u0027, and we should enforce that it is in the list in auth/methods.","commit_id":"ce1b5302dc6b5dc5d4ad83a67bb5d1618a836995"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"00ba8efdf1f35c94fe28f78a7ddea2e29a61aa54","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# [*methods*]"},{"line_number":6,"context_line":"#  A list of methods used for authentication separated by comma or an array."},{"line_number":7,"context_line":"#  The allowed values are: \u0027external\u0027, \u0027password\u0027, \u0027token\u0027, \u0027oauth1\u0027, \u0027saml2\u0027,"},{"line_number":8,"context_line":"#  and \u0027openidc\u0027"},{"line_number":9,"context_line":"#  (Required) (string or array value)."},{"line_number":10,"context_line":"#  Note: The external value should be dropped to avoid problems."},{"line_number":11,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"3f79a3b5_9c86ad0e","line":8,"updated":"2018-12-03 08:15:57.000000000","message":"Unfortunately there is a mistake in keystone and the valid auth method is \u0027openid\u0027 not \u0027openidc\u0027\n\nhttp://git.openstack.org/cgit/openstack/keystone/tree/setup.cfg?h\u003d14.0.1#n91","commit_id":"e0e12ea919dcc3cdb11026734dfe662318578c38"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"6c0b664ceb7d438eae31917a5bb89b58391514d5","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  $package_ensure              \u003d present,"},{"line_number":91,"context_line":"  $keystone_public_url         \u003d undef,"},{"line_number":92,"context_line":"  $keystone_admin_url          \u003d undef,"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  # DEPRECATED"},{"line_number":95,"context_line":"  $module_plugin               \u003d undef,"},{"line_number":96,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_b46eaac8","line":93,"updated":"2018-12-07 14:20:40.000000000","message":"no need for new line","commit_id":"82d6c72f75ad1e74ec6ffbe34bbd8c3ca0c0772c"}]}