)]}'
{"manifests/db/sync.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"96ac3200ef5b3a771eacecb3b2b72d5585870506","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"# [*keystone_user*]"},{"line_number":14,"context_line":"#   (Optional) Specify the keystone system user to be used with keystone-manage."},{"line_number":15,"context_line":"#   Defaults to $::keystone::params::keystone_user"},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"class keystone::db::sync("},{"line_number":18,"context_line":"  $extra_params  \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3f79a3b5_16cb0a7f","line":15,"range":{"start_line":15,"start_character":37,"end_line":15,"end_character":50},"updated":"2018-12-19 01:10:58.000000000","message":"This comment that was changed in PS11 is wrong.","commit_id":"c89cddd07e5d5117cb3c426df75cc2a64082a860"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"77306ab14cec55f289a5a12d77a84e1514d2a1d8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"class keystone::db::sync("},{"line_number":18,"context_line":"  $extra_params  \u003d undef,"},{"line_number":19,"context_line":"  $keystone_user \u003d $::keystone::params::keystone_user,"},{"line_number":20,"context_line":") inherits keystone::params {"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  include ::keystone::deps"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"dfd5e7cf_b43b989a","side":"PARENT","line":19,"range":{"start_line":19,"start_character":40,"end_line":19,"end_character":53},"updated":"2019-01-07 15:40:54.000000000","message":"This seems unrelated to the port change?","commit_id":"dc71b969a3f0614341c2adf87c4eb0e52ea857af"}],"manifests/federation/openidc.pp":[{"author":{"_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},"change_message_id":"d9b2776fc5bdff884a4ecb14b95489293605bc17","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  include ::keystone::params"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"  # TODO(tobias-urdin): Make keystone_url required when keystone::public_endpoint is removed."},{"line_number":94,"context_line":"  # Dont forget to change the keystone_url_real variable in the templates/openidc.conf.rb file."},{"line_number":95,"context_line":"  $keystone_url_real \u003d pick($keystone_url, $::keystone::public_endpoint)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  if $admin_port or $main_port {"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3f79a3b5_ffb50881","line":94,"updated":"2018-12-18 22:00:26.000000000","message":"I don\u0027t understand this comment.  What needs to be changed in openidc.conf.rb?","commit_id":"c89cddd07e5d5117cb3c426df75cc2a64082a860"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"96ac3200ef5b3a771eacecb3b2b72d5585870506","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  include ::keystone::params"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"  # TODO(tobias-urdin): Make keystone_url required when keystone::public_endpoint is removed."},{"line_number":94,"context_line":"  # Dont forget to change the keystone_url_real variable in the templates/openidc.conf.rb file."},{"line_number":95,"context_line":"  $keystone_url_real \u003d pick($keystone_url, $::keystone::public_endpoint)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  if $admin_port or $main_port {"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3f79a3b5_d6d0322c","line":94,"in_reply_to":"3f79a3b5_ffb50881","updated":"2018-12-19 01:10:58.000000000","message":"When that pick is removed we need to change that variable in the template, see other comment.","commit_id":"c89cddd07e5d5117cb3c426df75cc2a64082a860"}],"manifests/init.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"77306ab14cec55f289a5a12d77a84e1514d2a1d8","unresolved":false,"context_lines":[{"line_number":681,"context_line":"  $policy_driver                        \u003d $::os_service_default,"},{"line_number":682,"context_line":"  $using_domain_config                  \u003d false,"},{"line_number":683,"context_line":"  $domain_config_directory              \u003d \u0027/etc/keystone/domains\u0027,"},{"line_number":684,"context_line":"  $keystone_user                        \u003d $::keystone::params::keystone_user,"},{"line_number":685,"context_line":"  $keystone_group                       \u003d $::keystone::params::keystone_group,"},{"line_number":686,"context_line":"  $manage_policyrcd                     \u003d false,"},{"line_number":687,"context_line":"  $enable_proxy_headers_parsing         \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"dfd5e7cf_f45040d7","side":"PARENT","line":684,"range":{"start_line":684,"start_character":63,"end_line":684,"end_character":76},"updated":"2019-01-07 15:40:54.000000000","message":"Also unrelated to the port change","commit_id":"dc71b969a3f0614341c2adf87c4eb0e52ea857af"}],"manifests/params.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"77306ab14cec55f289a5a12d77a84e1514d2a1d8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  }"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  $client_package_name \u003d \"python${pyvers}-keystoneclient\""},{"line_number":14,"context_line":"  $user                \u003d \u0027keystone\u0027"},{"line_number":15,"context_line":"  $group               \u003d \u0027keystone\u0027"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  case $::osfamily {"},{"line_number":18,"context_line":"    \u0027Debian\u0027: {"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"dfd5e7cf_14738482","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":35},"updated":"2019-01-07 15:40:54.000000000","message":"Let\u0027s do this in another change. Also this might be used external since this is params so maybe we shouldn\u0027t rename this","commit_id":"911c0f07d64c7e6ca852243ca3ec47083a75b5c5"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"cd762173c233189e00bb085e63cc9e7ba17e980b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  $client_package_name \u003d \"python${pyvers}-keystoneclient\""},{"line_number":14,"context_line":"  $keystone_user       \u003d \u0027keystone\u0027"},{"line_number":15,"context_line":"  $keystone_group      \u003d \u0027keystone\u0027"},{"line_number":16,"context_line":"  $group               \u003d \u0027keystone\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  case $::osfamily {"},{"line_number":19,"context_line":"    \u0027Debian\u0027: {"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"dfd5e7cf_b40ab887","line":16,"updated":"2019-01-07 15:56:02.000000000","message":"you left this in","commit_id":"02878c22729f80a64542b9681316dbbeb10adc4a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ee853f585ded7db46f0dc892a9b2e6648787063f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  $client_package_name \u003d \"python${pyvers}-keystoneclient\""},{"line_number":14,"context_line":"  $keystone_user       \u003d \u0027keystone\u0027"},{"line_number":15,"context_line":"  $keystone_group      \u003d \u0027keystone\u0027"},{"line_number":16,"context_line":"  $group               \u003d \u0027keystone\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  case $::osfamily {"},{"line_number":19,"context_line":"    \u0027Debian\u0027: {"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"dfd5e7cf_748770d9","line":16,"in_reply_to":"dfd5e7cf_b40ab887","updated":"2019-01-07 15:59:30.000000000","message":"nm i see it\u0027s still there","commit_id":"02878c22729f80a64542b9681316dbbeb10adc4a"}],"templates/openidc.conf.erb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"96ac3200ef5b3a771eacecb3b2b72d5585870506","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  # The following directives are necessary to support websso from Horizon"},{"line_number":18,"context_line":"  # (Per https://docs.openstack.org/keystone/pike/advanced-topics/federation/websso.html)"},{"line_number":19,"context_line":"  OIDCRedirectURI \"\u003c%\u003d @keystone_url_real-%\u003e/v3/auth/OS-FEDERATION/identity_providers/\u003c%\u003d scope[\u0027keystone::federation::openidc::idp_name\u0027]-%\u003e/protocols/openidc/websso\""},{"line_number":20,"context_line":"  OIDCRedirectURI \"\u003c%\u003d @keystone_url_real-%\u003e/v3/auth/OS-FEDERATION/websso\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  \u003cLocationMatch \"/v3/auth/OS-FEDERATION/websso/openidc\"\u003e"}],"source_content_type":"application/x-erb","patch_set":11,"id":"3f79a3b5_b6db364a","line":19,"range":{"start_line":19,"start_character":24,"end_line":19,"end_character":41},"updated":"2018-12-19 01:10:58.000000000","message":"This...","commit_id":"c89cddd07e5d5117cb3c426df75cc2a64082a860"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"96ac3200ef5b3a771eacecb3b2b72d5585870506","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  # The following directives are necessary to support websso from Horizon"},{"line_number":18,"context_line":"  # (Per https://docs.openstack.org/keystone/pike/advanced-topics/federation/websso.html)"},{"line_number":19,"context_line":"  OIDCRedirectURI \"\u003c%\u003d @keystone_url_real-%\u003e/v3/auth/OS-FEDERATION/identity_providers/\u003c%\u003d scope[\u0027keystone::federation::openidc::idp_name\u0027]-%\u003e/protocols/openidc/websso\""},{"line_number":20,"context_line":"  OIDCRedirectURI \"\u003c%\u003d @keystone_url_real-%\u003e/v3/auth/OS-FEDERATION/websso\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  \u003cLocationMatch \"/v3/auth/OS-FEDERATION/websso/openidc\"\u003e"},{"line_number":23,"context_line":"      AuthType \"openid-connect\""}],"source_content_type":"application/x-erb","patch_set":11,"id":"3f79a3b5_16b46af3","line":20,"range":{"start_line":20,"start_character":24,"end_line":20,"end_character":41},"updated":"2018-12-19 01:10:58.000000000","message":"and this would need to be keystone_url when the pick is removed.","commit_id":"c89cddd07e5d5117cb3c426df75cc2a64082a860"}]}