)]}'
{"id":"openstack%2Fpuppet-keystone~656520","triplet_id":"openstack%2Fpuppet-keystone~master~I0a1b1adec24ba528b623ad0b17e5bba16e0b279a","project":"openstack/puppet-keystone","branch":"master","topic":"bug/1826692","hashtags":[],"change_id":"I0a1b1adec24ba528b623ad0b17e5bba16e0b279a","subject":"Fix database test in keystone class test","status":"MERGED","created":"2019-04-30 14:14:34.000000000","updated":"2019-05-01 16:26:29.000000000","submitted":"2019-05-01 16:26:28.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"656520-1556727989069-21878039","meta_rev_id":"c66ad2e5aafd72f674014d267c0e67d10df0c832","_number":656520,"virtual_id_number":656520,"owner":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2019-05-01 16:26:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2019-05-01 14:44:15.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":1,"date":"2019-05-01 14:44:15.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-01 14:44:15.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-05-01 16:26:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"03bc02b5e3f4c168ff7b4708a21cb5e10ac8a009","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-04-30 14:14:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3a385d95f3839766d0e27a59a3deee3b8686b842","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-04-30 14:15:44.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"616efc7238fd43c553170c6de98bf6e146bf4079","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 16:02:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic http://logs.openstack.org/20/656520/2/check/puppet-openstack-lint-ubuntu-bionic/53ed7d4/ : SUCCESS in 5m 24s\n- puppet-openstack-syntax-4-ubuntu-bionic http://logs.openstack.org/20/656520/2/check/puppet-openstack-syntax-4-ubuntu-bionic/ae7d19f/ : SUCCESS in 5m 13s\n- puppet-openstack-syntax-5-ubuntu-bionic http://logs.openstack.org/20/656520/2/check/puppet-openstack-syntax-5-ubuntu-bionic/8438e78/ : SUCCESS in 5m 14s\n- puppet-openstack-syntax-6-ubuntu-bionic http://logs.openstack.org/20/656520/2/check/puppet-openstack-syntax-6-ubuntu-bionic/1027479/ : SUCCESS in 5m 26s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/20/656520/2/check/puppet-openstack-unit-4.8-centos-7/6d51bfd/ : SUCCESS in 15m 28s\n- puppet-openstack-unit-5.5-centos-7 http://logs.openstack.org/20/656520/2/check/puppet-openstack-unit-5.5-centos-7/13111dc/ : SUCCESS in 19m 21s\n- puppet-openstack-unit-6.0-ubuntu-bionic http://logs.openstack.org/20/656520/2/check/puppet-openstack-unit-6.0-ubuntu-bionic/1a4d5cf/ : SUCCESS in 12m 55s\n- puppet-openstack-unit-latest-ubuntu-bionic http://logs.openstack.org/20/656520/2/check/puppet-openstack-unit-latest-ubuntu-bionic/e1f4f3d/ : FAILURE in 8m 33s (non-voting)\n- puppet-keystone-tripleo-standalone http://logs.openstack.org/20/656520/2/check/puppet-keystone-tripleo-standalone/0b479d5/ : SUCCESS in 1h 40m 09s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"52f84ea3f467a90b02278593e71d758a81e2e86b","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-05-01 14:44:15.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"3f5ce83ea6c94e33a1e5a1115ad0ed036ef0a757","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-01 14:44:27.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"423b14972f5ba9669f12b98057c86baa2f28b38d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-01 16:26:28.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic http://logs.openstack.org/20/656520/2/gate/puppet-openstack-lint-ubuntu-bionic/da107e3/ : SUCCESS in 5m 23s\n- puppet-openstack-syntax-4-ubuntu-bionic http://logs.openstack.org/20/656520/2/gate/puppet-openstack-syntax-4-ubuntu-bionic/d4b87a4/ : SUCCESS in 6m 45s\n- puppet-openstack-syntax-5-ubuntu-bionic http://logs.openstack.org/20/656520/2/gate/puppet-openstack-syntax-5-ubuntu-bionic/6f39e18/ : SUCCESS in 5m 15s\n- puppet-openstack-syntax-6-ubuntu-bionic http://logs.openstack.org/20/656520/2/gate/puppet-openstack-syntax-6-ubuntu-bionic/efb1e45/ : SUCCESS in 6m 53s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/20/656520/2/gate/puppet-openstack-unit-4.8-centos-7/c4701ad/ : SUCCESS in 15m 26s\n- puppet-openstack-unit-5.5-centos-7 http://logs.openstack.org/20/656520/2/gate/puppet-openstack-unit-5.5-centos-7/9957c2b/ : SUCCESS in 15m 08s\n- puppet-openstack-unit-6.0-ubuntu-bionic http://logs.openstack.org/20/656520/2/gate/puppet-openstack-unit-6.0-ubuntu-bionic/b84518d/ : SUCCESS in 11m 25s\n- puppet-keystone-tripleo-standalone http://logs.openstack.org/20/656520/2/gate/puppet-keystone-tripleo-standalone/7efb1ea/ : SUCCESS in 1h 36m 14s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"1e918e937e1be2730f749fa3b04dfe4f100b4089","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-01 16:26:29.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ce7fd5d0a8e9ca4c33c1c4329bc84c2fbd571796","revisions":{"31dca6849ab9164a2b34df6b7069ab5db5aefa28":{"kind":"REWORK","_number":1,"created":"2019-04-30 14:14:34.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/20/656520/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-keystone","ref":"refs/changes/20/656520/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-keystone refs/changes/20/656520/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-keystone refs/changes/20/656520/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-keystone refs/changes/20/656520/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-keystone refs/changes/20/656520/1"}}},"commit":{"parents":[{"commit":"4cdcf63e5b0fd73090e3b5582931f6830027c281","subject":"Remove duplicated owner key in test","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-keystone/commit/4cdcf63e5b0fd73090e3b5582931f6830027c281"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-04-30 14:13:17.000000000","tz":-360},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-04-30 14:13:17.000000000","tz":-360},"subject":"Fix database test in keystone class test","message":"Fix database test in keystone class test\n\nWe were checking for the value of a database setting which is now\nmanaged via puppet-olso in the keystone init class.  We should not be\nchecking the values set by another class in the unit tests. This change\nupdates the unit tests to just make sure we\u0027re including the\nkeystone::db class rather than the values configured by it.\n\nChange-Id: I0a1b1adec24ba528b623ad0b17e5bba16e0b279a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-keystone/commit/31dca6849ab9164a2b34df6b7069ab5db5aefa28"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-keystone/commit/31dca6849ab9164a2b34df6b7069ab5db5aefa28"}]},"branch":"refs/heads/master"},"ce7fd5d0a8e9ca4c33c1c4329bc84c2fbd571796":{"kind":"REWORK","_number":2,"created":"2019-04-30 14:15:44.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/20/656520/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-keystone","ref":"refs/changes/20/656520/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-keystone refs/changes/20/656520/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-keystone refs/changes/20/656520/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-keystone refs/changes/20/656520/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-keystone refs/changes/20/656520/2"}}},"commit":{"parents":[{"commit":"49f89f39bd36c10b89efc13624a8ca9ae7e05999","subject":"Deprecate idle_timeout option","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-keystone/commit/49f89f39bd36c10b89efc13624a8ca9ae7e05999"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-04-30 14:13:17.000000000","tz":-360},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-04-30 14:15:37.000000000","tz":-360},"subject":"Fix database test in keystone class test","message":"Fix database test in keystone class test\n\nWe were checking for the value of a database setting which is now\nmanaged via puppet-olso in the keystone init class.  We should not be\nchecking the values set by another class in the unit tests. This change\nupdates the unit tests to just make sure we\u0027re including the\nkeystone::db class rather than the values configured by it.\n\nChange-Id: I0a1b1adec24ba528b623ad0b17e5bba16e0b279a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-keystone/commit/ce7fd5d0a8e9ca4c33c1c4329bc84c2fbd571796"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-keystone/commit/ce7fd5d0a8e9ca4c33c1c4329bc84c2fbd571796"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}