)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"3fe19277b5fc4a53db7875cc99fc6a5dcc6fee2b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     bc1ff1d7 (Add keystone::bootstrap class)"},{"line_number":2,"context_line":"Author:     Sai Sindhur Malleni \u003csmalleni@redhat.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2020-01-10 14:28:32 -0500"},{"line_number":4,"context_line":"Commit:     Sai Sindhur Malleni \u003csmalleni@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_3ed74425","line":1,"updated":"2020-01-17 12:10:29.000000000","message":"Please follow the best practices for the width of commit message, it\u0027s not really easy to read it.\nIIRC, 76c wide.","commit_id":"2cbd81a729e6faed0e2ae58ef5d5fe6ac262d9b7"}],"manifests/wsgi/apache.pp":[{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"6aea6af8f56a571dc18f82c934847a8b55bb9515","unresolved":false,"context_lines":[{"line_number":139,"context_line":"  $api_port                          \u003d 5000,"},{"line_number":140,"context_line":"  $path                              \u003d \u0027/\u0027,"},{"line_number":141,"context_line":"  $ssl                               \u003d true,"},{"line_number":142,"context_line":"  $workers                           \u003d $::os_workers * 2,"},{"line_number":143,"context_line":"  $ssl_cert                          \u003d undef,"},{"line_number":144,"context_line":"  $ssl_key                           \u003d undef,"},{"line_number":145,"context_line":"  $ssl_chain                         \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa7e38b_2e192bd1","line":142,"range":{"start_line":142,"start_character":53,"end_line":142,"end_character":54},"updated":"2020-01-21 13:08:40.000000000","message":"What we really want here is 1 WSGI process per CPU, with a min cap of 2 and max cap of 12 to prevent problems on systems with large numbers of CPUs.  We used \"os_workers\" to satisfy this before, which is defined as:\n\n    [ [ (processors.to_i / 2), 2 ].max, 12 ].min\n\nThis worked since we had both \"keystone_main\" and \"keystone_admin\", which both configure their own WSGI processes.\n\nUnfortunately, there is not an equivalent of what we want in openstacklib as seen in https://github.com/openstack/puppet-openstacklib/blob/master/lib/facter/os_workers.rb\n\nThe proposal of using multiplication in this patch has the potential of resulting in 24 keystone processes on systems with 24 or more CPUs.  This exceeds our desired max cap, though the previous split of \"keystone_main\" and \"keystone_admin\" had the same issue from what I can see.\n\nI think what we really want is this:\n\n    [ [ processors.to_i, 2 ].max, 12 ].min","commit_id":"2cbd81a729e6faed0e2ae58ef5d5fe6ac262d9b7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"9f356cf0e43bf5d6d4e4b252c39171dee5533fc6","unresolved":false,"context_lines":[{"line_number":139,"context_line":"  $api_port                          \u003d 5000,"},{"line_number":140,"context_line":"  $path                              \u003d \u0027/\u0027,"},{"line_number":141,"context_line":"  $ssl                               \u003d true,"},{"line_number":142,"context_line":"  $workers                           \u003d $::os_workers * 2,"},{"line_number":143,"context_line":"  $ssl_cert                          \u003d undef,"},{"line_number":144,"context_line":"  $ssl_key                           \u003d undef,"},{"line_number":145,"context_line":"  $ssl_chain                         \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa7e38b_2e260bce","line":142,"range":{"start_line":142,"start_character":53,"end_line":142,"end_character":54},"in_reply_to":"3fa7e38b_2e192bd1","updated":"2020-01-21 13:24:03.000000000","message":"We have to keep in mind that, before, we had 2 wsgi processes with, each, 2 workers. Meaning 4 workers, taking keystone workload.\nNow, with your proposal, we\u0027d have to manage the same workload with only 2 workers - this isn\u0027t good, and this led to the current patch.\n\nTaking your formula, we can set \"min\" to 4 instead of 2, and max to 24 in order to keep the same capability as before (2 processes, 12 workers each, and so on).\n\nMaybe we should, instead of putting \"$::os_workers*2\", be more explicit and define there the intended value. Not really sure what\u0027s the best.\n\nIn any cases, we can\u0027t expect to keep the same workload and reduce the workers :).","commit_id":"2cbd81a729e6faed0e2ae58ef5d5fe6ac262d9b7"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"5136131594bceca34855d4b4b93b1903f38ad9b5","unresolved":false,"context_lines":[{"line_number":139,"context_line":"  $api_port                          \u003d 5000,"},{"line_number":140,"context_line":"  $path                              \u003d \u0027/\u0027,"},{"line_number":141,"context_line":"  $ssl                               \u003d true,"},{"line_number":142,"context_line":"  $workers                           \u003d $::os_workers * 2,"},{"line_number":143,"context_line":"  $ssl_cert                          \u003d undef,"},{"line_number":144,"context_line":"  $ssl_key                           \u003d undef,"},{"line_number":145,"context_line":"  $ssl_chain                         \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa7e38b_3b140842","line":142,"range":{"start_line":142,"start_character":53,"end_line":142,"end_character":54},"in_reply_to":"3fa7e38b_2e260bce","updated":"2020-01-21 14:32:00.000000000","message":"You are correct about the previous behavior, though I recall that the intent when changes were made in this area was to use a max cap of 8 for keystone (which was later increased to 12 I believe).  We wanted to avoid too many workers, as it could result in issues such as overwhelming connections to a database when it is shared by other services.\n\nThe safe approach right now would be to mimic the previous behavior.  I do think being more explicit here (and adding a comment) would be better than just using \"$::os_workers * 2\", as it will make our intent clear.","commit_id":"2cbd81a729e6faed0e2ae58ef5d5fe6ac262d9b7"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"8d1d19de4f2333ea5c76d063bef0f234e60d6bf6","unresolved":false,"context_lines":[{"line_number":146,"context_line":"  # both serving keystone requests (2 workers each, resulting in 4 workers"},{"line_number":147,"context_line":"  # total). Now that all requests are served by a single application, we ensure"},{"line_number":148,"context_line":"  # the minimum is no less than 4 workers."},{"line_number":149,"context_line":"  $workers                           \u003d [ [ processors.to_i, 4 ].max, 24 ].min"},{"line_number":150,"context_line":"  $ssl_cert                          \u003d undef,"},{"line_number":151,"context_line":"  $ssl_key                           \u003d undef,"},{"line_number":152,"context_line":"  $ssl_chain                         \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3fa7e38b_95dda76f","line":149,"range":{"start_line":149,"start_character":74,"end_line":149,"end_character":77},"updated":"2020-01-23 09:12:19.000000000","message":"You\u0027re missing a \u0027,\u0027 here, which is breaking the CI job.","commit_id":"8b6de1b6f424f30ce44e7808be013d7d318df3eb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5200a226e58bc2c84fe0416a6e5bdcf2866cfb14","unresolved":false,"context_lines":[{"line_number":146,"context_line":"  # both serving keystone requests (2 workers each, resulting in 4 workers"},{"line_number":147,"context_line":"  # total). Now that all requests are served by a single application, we ensure"},{"line_number":148,"context_line":"  # the minimum is no less than 4 workers."},{"line_number":149,"context_line":"  $workers                           \u003d [ [ processors.to_i, 4 ].max, 24 ].min"},{"line_number":150,"context_line":"  $ssl_cert                          \u003d undef,"},{"line_number":151,"context_line":"  $ssl_key                           \u003d undef,"},{"line_number":152,"context_line":"  $ssl_chain                         \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3fa7e38b_09652249","line":149,"range":{"start_line":149,"start_character":74,"end_line":149,"end_character":77},"in_reply_to":"3fa7e38b_95dda76f","updated":"2020-01-23 14:30:22.000000000","message":"Nice catch, done.","commit_id":"8b6de1b6f424f30ce44e7808be013d7d318df3eb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"186eaffcad4902b77a4adb78cb3edff4fa649aea","unresolved":false,"context_lines":[{"line_number":146,"context_line":"  # both serving keystone requests (2 workers each, resulting in 4 workers"},{"line_number":147,"context_line":"  # total). Now that all requests are served by a single application, we ensure"},{"line_number":148,"context_line":"  # the minimum is no less than 4 workers."},{"line_number":149,"context_line":"  $workers                           \u003d [ [ processors.to_i, 4 ].max, 24 ].min,"},{"line_number":150,"context_line":"  $ssl_cert                          \u003d undef,"},{"line_number":151,"context_line":"  $ssl_key                           \u003d undef,"},{"line_number":152,"context_line":"  $ssl_chain                         \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3fa7e38b_4d6563e1","line":149,"updated":"2020-01-23 16:06:45.000000000","message":"actually min(max($::os_workers, 4), 24)","commit_id":"f8047aa133df80a8da84af4a3567b1c2373f1fa8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0fe359d509688fded4b20a5513a70aef75912cfe","unresolved":false,"context_lines":[{"line_number":146,"context_line":"  # both serving keystone requests (2 workers each, resulting in 4 workers"},{"line_number":147,"context_line":"  # total). Now that all requests are served by a single application, we ensure"},{"line_number":148,"context_line":"  # the minimum is no less than 4 workers."},{"line_number":149,"context_line":"  $workers                           \u003d [ [ processors.to_i, 4 ].max, 24 ].min,"},{"line_number":150,"context_line":"  $ssl_cert                          \u003d undef,"},{"line_number":151,"context_line":"  $ssl_key                           \u003d undef,"},{"line_number":152,"context_line":"  $ssl_chain                         \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3fa7e38b_8d4efb6a","line":149,"updated":"2020-01-23 16:05:04.000000000","message":"this value is not correct puppet dsl. This is the code if it was in ruby (like in the fact code) but is not correct for .pp files.  min($::os_workers, 4) is likely what you\u0027d want.","commit_id":"f8047aa133df80a8da84af4a3567b1c2373f1fa8"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1d62793f9229ac1c09fb1472a805932e284b2cbc","unresolved":false,"context_lines":[{"line_number":146,"context_line":"  # both serving keystone requests (2 workers each, resulting in 4 workers"},{"line_number":147,"context_line":"  # total). Now that all requests are served by a single application, we ensure"},{"line_number":148,"context_line":"  # the minimum is no less than 4 workers."},{"line_number":149,"context_line":"  $workers                           \u003d [ [ processors.to_i, 4 ].max, 24 ].min,"},{"line_number":150,"context_line":"  $ssl_cert                          \u003d undef,"},{"line_number":151,"context_line":"  $ssl_key                           \u003d undef,"},{"line_number":152,"context_line":"  $ssl_chain                         \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3fa7e38b_ae3e31e0","line":149,"in_reply_to":"3fa7e38b_4d6563e1","updated":"2020-01-27 13:41:22.000000000","message":"Thanks for the tip, Alex. New patch set on the way.","commit_id":"f8047aa133df80a8da84af4a3567b1c2373f1fa8"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fadd79fc397f7bc1b7045af5409638bd8c3dd9da","unresolved":false,"context_lines":[{"line_number":146,"context_line":"  # both serving keystone requests (2 workers each, resulting in 4 workers"},{"line_number":147,"context_line":"  # total). Now that all requests are served by a single application, we ensure"},{"line_number":148,"context_line":"  # the minimum is no less than 4 workers."},{"line_number":149,"context_line":"  $workers                           \u003d [ [ processors.to_i, 4 ].max, 24 ].min,"},{"line_number":150,"context_line":"  $ssl_cert                          \u003d undef,"},{"line_number":151,"context_line":"  $ssl_key                           \u003d undef,"},{"line_number":152,"context_line":"  $ssl_chain                         \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3fa7e38b_ae339111","line":149,"in_reply_to":"3fa7e38b_ae3e31e0","updated":"2020-01-27 13:42:10.000000000","message":"Disregard, I noticed you uploaded on already. Thanks!","commit_id":"f8047aa133df80a8da84af4a3567b1c2373f1fa8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"36b54e46d0ccc52b75b1c9ce9a1dc8c4eba927f4","unresolved":false,"context_lines":[{"line_number":141,"context_line":"  $api_port                          \u003d 5000,"},{"line_number":142,"context_line":"  $path                              \u003d \u0027/\u0027,"},{"line_number":143,"context_line":"  $ssl                               \u003d true,"},{"line_number":144,"context_line":"  # We chose 4 as the absolute minimum to support comparable throughput when"},{"line_number":145,"context_line":"  # keystone was deployed with keystone-main and keystone-admin applications"},{"line_number":146,"context_line":"  # both serving keystone requests (2 workers each, resulting in 4 workers"},{"line_number":147,"context_line":"  # total). Now that all requests are served by a single application, we ensure"},{"line_number":148,"context_line":"  # the minimum is no less than 4 workers."},{"line_number":149,"context_line":"  $workers                           \u003d min(max($facts[\u0027processors\u0027][\u0027count\u0027], 4), 24),"},{"line_number":150,"context_line":"  $ssl_cert                          \u003d undef,"},{"line_number":151,"context_line":"  $ssl_key                           \u003d undef,"},{"line_number":152,"context_line":"  $ssl_chain                         \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3fa7e38b_ceba54b9","line":149,"range":{"start_line":144,"start_character":0,"end_line":149,"end_character":86},"updated":"2020-01-30 13:29:55.000000000","message":"I\u0027m afraid that I\u0027m too late to raise this, but I\u0027d prefer to see this implementation in openstacklib instead of puppet-keystone.\n\nWe already have the one for heat engine[1], so it makes more sense to me to have all worker calculators in one place.\n\n[1] https://github.com/openstack/puppet-openstacklib/blob/master/lib/facter/os_workers.rb#L52-L63","commit_id":"84c03934b22c739dff4a66b026421efc47538995"}],"spec/classes/keystone_db_postgresql_spec.rb":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"3fe19277b5fc4a53db7875cc99fc6a5dcc6fee2b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    context \"on #{os}\" do"},{"line_number":31,"context_line":"      let (:facts) do"},{"line_number":32,"context_line":"        facts.merge(OSDefaults.get_facts({"},{"line_number":33,"context_line":"          :os_workers     \u003d\u003e 16,"},{"line_number":34,"context_line":"          :concat_basedir \u003d\u003e \u0027/var/lib/puppet/concat\u0027"},{"line_number":35,"context_line":"        }))"},{"line_number":36,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3fa7e38b_7eb61cff","line":33,"updated":"2020-01-17 12:10:29.000000000","message":"hm, are you sure this is to be updated?","commit_id":"2cbd81a729e6faed0e2ae58ef5d5fe6ac262d9b7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f167f0cf5f89b26cd7df7c6c708082b8be435f96","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    context \"on #{os}\" do"},{"line_number":31,"context_line":"      let (:facts) do"},{"line_number":32,"context_line":"        facts.merge(OSDefaults.get_facts({"},{"line_number":33,"context_line":"          :os_workers     \u003d\u003e 16,"},{"line_number":34,"context_line":"          :concat_basedir \u003d\u003e \u0027/var/lib/puppet/concat\u0027"},{"line_number":35,"context_line":"        }))"},{"line_number":36,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3fa7e38b_09630943","line":33,"in_reply_to":"3fa7e38b_4edb4779","updated":"2020-01-21 14:25:57.000000000","message":"Done","commit_id":"2cbd81a729e6faed0e2ae58ef5d5fe6ac262d9b7"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"6aea6af8f56a571dc18f82c934847a8b55bb9515","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    context \"on #{os}\" do"},{"line_number":31,"context_line":"      let (:facts) do"},{"line_number":32,"context_line":"        facts.merge(OSDefaults.get_facts({"},{"line_number":33,"context_line":"          :os_workers     \u003d\u003e 16,"},{"line_number":34,"context_line":"          :concat_basedir \u003d\u003e \u0027/var/lib/puppet/concat\u0027"},{"line_number":35,"context_line":"        }))"},{"line_number":36,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3fa7e38b_4edb4779","line":33,"in_reply_to":"3fa7e38b_7eb61cff","updated":"2020-01-21 13:08:40.000000000","message":"I agree that this probably shouldn\u0027t be updated, as it doesn\u0027t pertain to the WSGI configuration used for the keystone processes.  IIUC, this will be used for configuring postgres, which is not related to the problem described in the commit message.","commit_id":"2cbd81a729e6faed0e2ae58ef5d5fe6ac262d9b7"}],"spec/classes/keystone_wsgi_apache_spec.rb":[{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"6aea6af8f56a571dc18f82c934847a8b55bb9515","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        :bind_host                   \u003d\u003e nil,"},{"line_number":23,"context_line":"        :bind_port                   \u003d\u003e 5000,"},{"line_number":24,"context_line":"        :group                       \u003d\u003e \u0027keystone\u0027,"},{"line_number":25,"context_line":"        :workers                     \u003d\u003e facts[:os_workers] * 2,"},{"line_number":26,"context_line":"        :threads                     \u003d\u003e 1,"},{"line_number":27,"context_line":"        :user                        \u003d\u003e \u0027keystone\u0027,"},{"line_number":28,"context_line":"        :priority                    \u003d\u003e \u002710\u0027,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3fa7e38b_ee26b322","line":25,"range":{"start_line":25,"start_character":58,"end_line":25,"end_character":59},"updated":"2020-01-21 13:08:40.000000000","message":"I think this also should be the equivalent of the following as mentioned in my other comment:\n\n    [ [ processors.to_i, 2 ].max, 12 ].min","commit_id":"2cbd81a729e6faed0e2ae58ef5d5fe6ac262d9b7"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"5136131594bceca34855d4b4b93b1903f38ad9b5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        :bind_host                   \u003d\u003e nil,"},{"line_number":23,"context_line":"        :bind_port                   \u003d\u003e 5000,"},{"line_number":24,"context_line":"        :group                       \u003d\u003e \u0027keystone\u0027,"},{"line_number":25,"context_line":"        :workers                     \u003d\u003e facts[:os_workers] * 2,"},{"line_number":26,"context_line":"        :threads                     \u003d\u003e 1,"},{"line_number":27,"context_line":"        :user                        \u003d\u003e \u0027keystone\u0027,"},{"line_number":28,"context_line":"        :priority                    \u003d\u003e \u002710\u0027,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3fa7e38b_bb9c78be","line":25,"range":{"start_line":25,"start_character":58,"end_line":25,"end_character":59},"in_reply_to":"3fa7e38b_4e2347bc","updated":"2020-01-21 14:32:00.000000000","message":"ack","commit_id":"2cbd81a729e6faed0e2ae58ef5d5fe6ac262d9b7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8720e1bb0698f857184a6a4de9794b36cb395e2d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        :bind_host                   \u003d\u003e nil,"},{"line_number":23,"context_line":"        :bind_port                   \u003d\u003e 5000,"},{"line_number":24,"context_line":"        :group                       \u003d\u003e \u0027keystone\u0027,"},{"line_number":25,"context_line":"        :workers                     \u003d\u003e facts[:os_workers] * 2,"},{"line_number":26,"context_line":"        :threads                     \u003d\u003e 1,"},{"line_number":27,"context_line":"        :user                        \u003d\u003e \u0027keystone\u0027,"},{"line_number":28,"context_line":"        :priority                    \u003d\u003e \u002710\u0027,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3fa7e38b_5b3d4427","line":25,"range":{"start_line":25,"start_character":58,"end_line":25,"end_character":59},"in_reply_to":"3fa7e38b_bb9c78be","updated":"2020-01-21 14:54:37.000000000","message":"Done","commit_id":"2cbd81a729e6faed0e2ae58ef5d5fe6ac262d9b7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"9f356cf0e43bf5d6d4e4b252c39171dee5533fc6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        :bind_host                   \u003d\u003e nil,"},{"line_number":23,"context_line":"        :bind_port                   \u003d\u003e 5000,"},{"line_number":24,"context_line":"        :group                       \u003d\u003e \u0027keystone\u0027,"},{"line_number":25,"context_line":"        :workers                     \u003d\u003e facts[:os_workers] * 2,"},{"line_number":26,"context_line":"        :threads                     \u003d\u003e 1,"},{"line_number":27,"context_line":"        :user                        \u003d\u003e \u0027keystone\u0027,"},{"line_number":28,"context_line":"        :priority                    \u003d\u003e \u002710\u0027,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3fa7e38b_4e2347bc","line":25,"range":{"start_line":25,"start_character":58,"end_line":25,"end_character":59},"in_reply_to":"3fa7e38b_ee26b322","updated":"2020-01-21 13:24:03.000000000","message":"same remark here - min\u003d4, max\u003d24 should be fine in order to keep the same total amount of available workers.","commit_id":"2cbd81a729e6faed0e2ae58ef5d5fe6ac262d9b7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"3fe19277b5fc4a53db7875cc99fc6a5dcc6fee2b","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    context \"on #{os}\" do"},{"line_number":194,"context_line":"      let (:facts) do"},{"line_number":195,"context_line":"        facts.merge!(OSDefaults.get_facts({"},{"line_number":196,"context_line":"          :os_workers     \u003d\u003e 16,"},{"line_number":197,"context_line":"          :concat_basedir \u003d\u003e \u0027/var/lib/puppet/concat\u0027,"},{"line_number":198,"context_line":"          :fqdn           \u003d\u003e \u0027some.host.tld\u0027,"},{"line_number":199,"context_line":"        }))"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3fa7e38b_5eb3200a","line":196,"updated":"2020-01-17 12:10:29.000000000","message":"ditto - you\u0027re editing the fact afaik, not some expected \"workers\" value... ?","commit_id":"2cbd81a729e6faed0e2ae58ef5d5fe6ac262d9b7"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"6aea6af8f56a571dc18f82c934847a8b55bb9515","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    context \"on #{os}\" do"},{"line_number":194,"context_line":"      let (:facts) do"},{"line_number":195,"context_line":"        facts.merge!(OSDefaults.get_facts({"},{"line_number":196,"context_line":"          :os_workers     \u003d\u003e 16,"},{"line_number":197,"context_line":"          :concat_basedir \u003d\u003e \u0027/var/lib/puppet/concat\u0027,"},{"line_number":198,"context_line":"          :fqdn           \u003d\u003e \u0027some.host.tld\u0027,"},{"line_number":199,"context_line":"        }))"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3fa7e38b_aec3db8b","line":196,"in_reply_to":"3fa7e38b_5eb3200a","updated":"2020-01-21 13:08:40.000000000","message":"Yes, I believe you are correct.  This shouldn\u0027t be changed.","commit_id":"2cbd81a729e6faed0e2ae58ef5d5fe6ac262d9b7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f167f0cf5f89b26cd7df7c6c708082b8be435f96","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    context \"on #{os}\" do"},{"line_number":194,"context_line":"      let (:facts) do"},{"line_number":195,"context_line":"        facts.merge!(OSDefaults.get_facts({"},{"line_number":196,"context_line":"          :os_workers     \u003d\u003e 16,"},{"line_number":197,"context_line":"          :concat_basedir \u003d\u003e \u0027/var/lib/puppet/concat\u0027,"},{"line_number":198,"context_line":"          :fqdn           \u003d\u003e \u0027some.host.tld\u0027,"},{"line_number":199,"context_line":"        }))"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3fa7e38b_c958918a","line":196,"in_reply_to":"3fa7e38b_aec3db8b","updated":"2020-01-21 14:25:57.000000000","message":"Done","commit_id":"2cbd81a729e6faed0e2ae58ef5d5fe6ac262d9b7"}]}