)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8932d7f32841ebff8e543b67f241f922be7169c7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecate unused parameters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone deprecated writable LDAP support for projects and roles in"},{"line_number":10,"context_line":"Kilo [0] and removed it in Mitaka."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We can simplify the puppet definitions by staging these options for"},{"line_number":13,"context_line":"removal like we did with writeable user and group support:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_6e68701c","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":34},"updated":"2020-03-20 13:04:42.000000000","message":"Can you also update this ?","commit_id":"f65fea484c7449285c968a704abd35a798497503"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"25f5f0ae14d64615f4e3a8822f1a9bf14a60f9df","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecate unused parameters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone deprecated writable LDAP support for projects and roles in"},{"line_number":10,"context_line":"Kilo [0] and removed it in Mitaka."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We can simplify the puppet definitions by staging these options for"},{"line_number":13,"context_line":"removal like we did with writeable user and group support:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_716931f7","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":34},"in_reply_to":"1fa4df85_6e68701c","updated":"2020-03-20 17:10:45.000000000","message":"Done","commit_id":"f65fea484c7449285c968a704abd35a798497503"}],"manifests/ldap_backend.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"404f6d4d7aaa743fb5dd64625ad2d30e6aae5527","unresolved":false,"context_lines":[{"line_number":158,"context_line":"#   List of attributes stripped off the project on update. (list value)"},{"line_number":159,"context_line":"#   Defaults to \u0027undef\u0027"},{"line_number":160,"context_line":"#"},{"line_number":161,"context_line":"# [*project_allow_create*]"},{"line_number":162,"context_line":"#   Allow project creation in LDAP backend. (boolean value)"},{"line_number":163,"context_line":"#   Defaults to \u0027undef\u0027"},{"line_number":164,"context_line":"#"},{"line_number":165,"context_line":"# [*project_allow_update*]"},{"line_number":166,"context_line":"#   Allow project update in LDAP backend. (boolean value)"},{"line_number":167,"context_line":"#   Defaults to \u0027undef\u0027"},{"line_number":168,"context_line":"#"},{"line_number":169,"context_line":"# [*project_allow_delete*]"},{"line_number":170,"context_line":"#   Allow project deletion in LDAP backend. (boolean value)"},{"line_number":171,"context_line":"#   Defaults to \u0027undef\u0027"},{"line_number":172,"context_line":"#"},{"line_number":173,"context_line":"# [*project_enabled_emulation*]"},{"line_number":174,"context_line":"#   If true, Keystone uses an alternative method to determine if"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1fa4df85_e7149aa2","side":"PARENT","line":171,"range":{"start_line":161,"start_character":0,"end_line":171,"end_character":23},"updated":"2020-03-19 13:16:59.000000000","message":"The all parameters which are related to projects and role assignments were already removed [1]\n\n[1] https://github.com/openstack/keystone/commit/e6efbe62b8b7f226aab22e01edecee0e60745897\n\nSo I think it\u0027d make more sense to remove all parameters related to projects and role assignments than deprecating only allow_* parameters.","commit_id":"1081ac51db7f560e5856809480fb98c215747476"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9d37da6a7ef4d3d3d76fd74de604f2b3658845b4","unresolved":false,"context_lines":[{"line_number":158,"context_line":"#   List of attributes stripped off the project on update. (list value)"},{"line_number":159,"context_line":"#   Defaults to \u0027undef\u0027"},{"line_number":160,"context_line":"#"},{"line_number":161,"context_line":"# [*project_allow_create*]"},{"line_number":162,"context_line":"#   Allow project creation in LDAP backend. (boolean value)"},{"line_number":163,"context_line":"#   Defaults to \u0027undef\u0027"},{"line_number":164,"context_line":"#"},{"line_number":165,"context_line":"# [*project_allow_update*]"},{"line_number":166,"context_line":"#   Allow project update in LDAP backend. (boolean value)"},{"line_number":167,"context_line":"#   Defaults to \u0027undef\u0027"},{"line_number":168,"context_line":"#"},{"line_number":169,"context_line":"# [*project_allow_delete*]"},{"line_number":170,"context_line":"#   Allow project deletion in LDAP backend. (boolean value)"},{"line_number":171,"context_line":"#   Defaults to \u0027undef\u0027"},{"line_number":172,"context_line":"#"},{"line_number":173,"context_line":"# [*project_enabled_emulation*]"},{"line_number":174,"context_line":"#   If true, Keystone uses an alternative method to determine if"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1fa4df85_226aa080","side":"PARENT","line":171,"range":{"start_line":161,"start_character":0,"end_line":171,"end_character":23},"in_reply_to":"1fa4df85_e7149aa2","updated":"2020-03-19 13:37:20.000000000","message":"I agree. Keystone doesn\u0027t use these anymore. It also doesn\u0027t use any of the options for users and groups.\n\nInitially, I removed the user and group options and Alex suggested we deprecate them first [0]. I\u0027m following the same advice here for consistency, but it also logs a message to users so they can clean up their configuration files.\n\n\n[0] https://review.opendev.org/#/c/695079/","commit_id":"1081ac51db7f560e5856809480fb98c215747476"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"404f6d4d7aaa743fb5dd64625ad2d30e6aae5527","unresolved":false,"context_lines":[{"line_number":216,"context_line":"#   List of attributes stripped off the role on update. (list value)"},{"line_number":217,"context_line":"#   Defaults to \u0027undef\u0027"},{"line_number":218,"context_line":"#"},{"line_number":219,"context_line":"# [*role_allow_create*]"},{"line_number":220,"context_line":"#   Allow role creation in LDAP backend. (boolean value)"},{"line_number":221,"context_line":"#   Defaults to \u0027undef\u0027"},{"line_number":222,"context_line":"#"},{"line_number":223,"context_line":"# [*role_allow_update*]"},{"line_number":224,"context_line":"#   Allow role update in LDAP backend. (boolean value)"},{"line_number":225,"context_line":"#   Defaults to \u0027undef\u0027"},{"line_number":226,"context_line":"#"},{"line_number":227,"context_line":"# [*role_allow_delete*]"},{"line_number":228,"context_line":"#   Allow role deletion in LDAP backend. (boolean value)"},{"line_number":229,"context_line":"#   Defaults to \u0027undef\u0027"},{"line_number":230,"context_line":"#"},{"line_number":231,"context_line":"# [*role_additional_attribute_mapping*]"},{"line_number":232,"context_line":"#   Additional attribute mappings for roles. Attribute mapping"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1fa4df85_87c9265a","side":"PARENT","line":229,"range":{"start_line":219,"start_character":0,"end_line":229,"end_character":23},"updated":"2020-03-19 13:16:59.000000000","message":"These parameters were removed as a part of removal of role management in ldap[1]\n\n[1] https://github.com/openstack/keystone/commit/d78fcc361e006c97163bee2d3fe04eb5aa2880e2","commit_id":"1081ac51db7f560e5856809480fb98c215747476"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9d37da6a7ef4d3d3d76fd74de604f2b3658845b4","unresolved":false,"context_lines":[{"line_number":216,"context_line":"#   List of attributes stripped off the role on update. (list value)"},{"line_number":217,"context_line":"#   Defaults to \u0027undef\u0027"},{"line_number":218,"context_line":"#"},{"line_number":219,"context_line":"# [*role_allow_create*]"},{"line_number":220,"context_line":"#   Allow role creation in LDAP backend. (boolean value)"},{"line_number":221,"context_line":"#   Defaults to \u0027undef\u0027"},{"line_number":222,"context_line":"#"},{"line_number":223,"context_line":"# [*role_allow_update*]"},{"line_number":224,"context_line":"#   Allow role update in LDAP backend. (boolean value)"},{"line_number":225,"context_line":"#   Defaults to \u0027undef\u0027"},{"line_number":226,"context_line":"#"},{"line_number":227,"context_line":"# [*role_allow_delete*]"},{"line_number":228,"context_line":"#   Allow role deletion in LDAP backend. (boolean value)"},{"line_number":229,"context_line":"#   Defaults to \u0027undef\u0027"},{"line_number":230,"context_line":"#"},{"line_number":231,"context_line":"# [*role_additional_attribute_mapping*]"},{"line_number":232,"context_line":"#   Additional attribute mappings for roles. Attribute mapping"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1fa4df85_e20568c3","side":"PARENT","line":229,"range":{"start_line":219,"start_character":0,"end_line":229,"end_character":23},"in_reply_to":"1fa4df85_87c9265a","updated":"2020-03-19 13:37:20.000000000","message":"Same comment as above.","commit_id":"1081ac51db7f560e5856809480fb98c215747476"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8932d7f32841ebff8e543b67f241f922be7169c7","unresolved":false,"context_lines":[{"line_number":448,"context_line":"  $manage_packages                      \u003d true,"},{"line_number":449,"context_line":"  $create_domain_entry                  \u003d false,"},{"line_number":450,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":451,"context_line":"  $assignment_driver                    \u003d undef,"},{"line_number":452,"context_line":"  $credential_driver                    \u003d undef,"},{"line_number":453,"context_line":"  $identity_driver                      \u003d \u0027ldap\u0027,"},{"line_number":454,"context_line":"  $project_allow_create                 \u003d undef,"},{"line_number":455,"context_line":"  $project_allow_update                 \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1fa4df85_0e43fc6d","line":452,"range":{"start_line":451,"start_character":0,"end_line":452,"end_character":48},"updated":"2020-03-20 13:04:42.000000000","message":"so these parameters will be deprecated because keystone provides only sql driver.","commit_id":"f65fea484c7449285c968a704abd35a798497503"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"25f5f0ae14d64615f4e3a8822f1a9bf14a60f9df","unresolved":false,"context_lines":[{"line_number":448,"context_line":"  $manage_packages                      \u003d true,"},{"line_number":449,"context_line":"  $create_domain_entry                  \u003d false,"},{"line_number":450,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":451,"context_line":"  $assignment_driver                    \u003d undef,"},{"line_number":452,"context_line":"  $credential_driver                    \u003d undef,"},{"line_number":453,"context_line":"  $identity_driver                      \u003d \u0027ldap\u0027,"},{"line_number":454,"context_line":"  $project_allow_create                 \u003d undef,"},{"line_number":455,"context_line":"  $project_allow_update                 \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1fa4df85_d177c5d3","line":452,"range":{"start_line":451,"start_character":0,"end_line":452,"end_character":48},"in_reply_to":"1fa4df85_0e43fc6d","updated":"2020-03-20 17:10:45.000000000","message":"Yep, exactly.","commit_id":"f65fea484c7449285c968a704abd35a798497503"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8932d7f32841ebff8e543b67f241f922be7169c7","unresolved":false,"context_lines":[{"line_number":450,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":451,"context_line":"  $assignment_driver                    \u003d undef,"},{"line_number":452,"context_line":"  $credential_driver                    \u003d undef,"},{"line_number":453,"context_line":"  $identity_driver                      \u003d \u0027ldap\u0027,"},{"line_number":454,"context_line":"  $project_allow_create                 \u003d undef,"},{"line_number":455,"context_line":"  $project_allow_update                 \u003d undef,"},{"line_number":456,"context_line":"  $project_allow_delete                 \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1fa4df85_ee5d4047","line":453,"range":{"start_line":453,"start_character":2,"end_line":453,"end_character":49},"updated":"2020-03-20 13:04:42.000000000","message":"I would agree to deprecated this because we don\u0027t expect users to use other drivers with using ldap backend.\n\nHowever we still need to set that value itself in keystone_domain_config, don\u0027t we ?","commit_id":"f65fea484c7449285c968a704abd35a798497503"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"25f5f0ae14d64615f4e3a8822f1a9bf14a60f9df","unresolved":false,"context_lines":[{"line_number":450,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":451,"context_line":"  $assignment_driver                    \u003d undef,"},{"line_number":452,"context_line":"  $credential_driver                    \u003d undef,"},{"line_number":453,"context_line":"  $identity_driver                      \u003d \u0027ldap\u0027,"},{"line_number":454,"context_line":"  $project_allow_create                 \u003d undef,"},{"line_number":455,"context_line":"  $project_allow_update                 \u003d undef,"},{"line_number":456,"context_line":"  $project_allow_delete                 \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"df33271e_ea737b4c","line":453,"range":{"start_line":453,"start_character":2,"end_line":453,"end_character":49},"in_reply_to":"1fa4df85_ee5d4047","updated":"2020-03-20 17:10:45.000000000","message":"Oh - yes, you\u0027re right. I had to double-check the keystone code. This shouldn\u0027t be deprecated or removed.\n\nWe\u0027re safe to remove the assignment and credential drivers since they don\u0027t support anything upstream except SQL.\n\nNice catch!","commit_id":"f65fea484c7449285c968a704abd35a798497503"}]}