)]}'
{"manifests/federation/openidc.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9de7239dd46c498898a3444d57564d8e498f18c1","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    }"},{"line_number":164,"context_line":"  }"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"  if $memcached_servers {"},{"line_number":167,"context_line":"    $memcached_servers_real \u003d join(any2array($memcached_servers), \u0027 \u0027)"},{"line_number":168,"context_line":"  }"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"  # Note: if puppet-apache modify these values, this needs to be updated"},{"line_number":171,"context_line":"  if $template_order \u003c\u003d 330 or $template_order \u003e\u003d 999 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f681702_c3c13583","line":168,"range":{"start_line":166,"start_character":0,"end_line":168,"end_character":3},"updated":"2020-10-18 12:56:21.000000000","message":"IMO it\u0027s better to \"undef\" as a mark to unset parameters, to be consistent with the other parameters.\n\nHow about making the following changes ?\n\n1) Here set \"$memcached_servers_real \u003d undef\" explicitly in else statement\n\n2) In the template file, set OIDCMemCacheServers when $memcached_servers_real IS NOT nil.\n\n[1] https://github.com/openstack/puppet-keystone/blob/97c2a39d59c56b9393001214939313405df4c5ce/templates/openidc.conf.erb#L25","commit_id":"89e490b3664f333020dbb76ba1776159aba2e6a0"}]}