)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"12f8061c72f84280d61496b86714c8cabc1e5359","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Thomas Goirand \u003czigo@debian.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-31 11:53:53 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"configure policy_dirs by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, puppet-openstack calls oslo::policy without an argument for"},{"line_number":10,"context_line":"policy_dirs, leading to that directive being removed from the config"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bb85e53c_dded6272","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":32},"updated":"2021-03-31 10:12:36.000000000","message":"Please update the title and below description according to the change in patch.","commit_id":"10f51536cc08980cc3bf172bec3b8aa41a745613"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"487b1c7f9eeadff899a66481c924d2c8a507cc89","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Thomas Goirand \u003czigo@debian.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-31 11:53:53 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"configure policy_dirs by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, puppet-openstack calls oslo::policy without an argument for"},{"line_number":10,"context_line":"policy_dirs, leading to that directive being removed from the config"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"a0d09fe8_80a2fcd9","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":32},"in_reply_to":"bb85e53c_dded6272","updated":"2021-03-31 10:37:10.000000000","message":"Done","commit_id":"10f51536cc08980cc3bf172bec3b8aa41a745613"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"12f8061c72f84280d61496b86714c8cabc1e5359","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"configure policy_dirs by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, puppet-openstack calls oslo::policy without an argument for"},{"line_number":10,"context_line":"policy_dirs, leading to that directive being removed from the config"},{"line_number":11,"context_line":"file. This patch makes it possible to override the current default,"},{"line_number":12,"context_line":"which is important in Debian where all services have been migrated to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"f2eef7c8_f01db0d4","line":9,"updated":"2021-03-31 10:12:36.000000000","message":"As I mentioned in irc, this is not expected behavior and /etc/\u003cservice\u003e/policy.d should be loaded by default when policy_dir is not set.","commit_id":"10f51536cc08980cc3bf172bec3b8aa41a745613"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"487b1c7f9eeadff899a66481c924d2c8a507cc89","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"configure policy_dirs by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, puppet-openstack calls oslo::policy without an argument for"},{"line_number":10,"context_line":"policy_dirs, leading to that directive being removed from the config"},{"line_number":11,"context_line":"file. This patch makes it possible to override the current default,"},{"line_number":12,"context_line":"which is important in Debian where all services have been migrated to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"500b2e98_277f9d49","line":9,"in_reply_to":"f2eef7c8_f01db0d4","updated":"2021-03-31 10:37:10.000000000","message":"Done","commit_id":"10f51536cc08980cc3bf172bec3b8aa41a745613"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5c87aae5f3cc62ca63bce03cfc5da200a4f5aaed","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This patch makes it possible to override the current service default,"},{"line_number":10,"context_line":"which is /etc/\u003cservice\u003e/policy.d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"I intend to commit the same kind of patch in each module, with only"},{"line_number":13,"context_line":"the default path for policy_dirs as difference."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ifdf0f0808789fc82a8f53307c3c7e7676cbdc4b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"732d1c8b_9f8bb1cd","line":12,"range":{"start_line":12,"start_character":58,"end_line":12,"end_character":1},"updated":"2021-03-31 13:25:33.000000000","message":"This should be updated","commit_id":"cd591b97202036128db83904169dc1968ad7bbb3"}],"manifests/policy.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ff9b981d2bc820447ff6092d729ad760faaa06e1","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  $enforce_new_defaults \u003d $::os_service_default,"},{"line_number":42,"context_line":"  $policies             \u003d {},"},{"line_number":43,"context_line":"  $policy_path          \u003d \u0027/etc/keystone/policy.yaml\u0027,"},{"line_number":44,"context_line":"  $policy_dirs          \u003d \u0027/etc/keystone/policy.d\u0027,"},{"line_number":45,"context_line":") {"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  include keystone::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5f540a93_2684ba9f","line":44,"range":{"start_line":44,"start_character":27,"end_line":44,"end_character":49},"updated":"2021-03-26 02:36:05.000000000","message":"I agree to expose this parameter but I still have some doubt about hard-coding the default, especially because the requirement is very specific to Debian.\n\nGenerally speaking this should be dealt by Debian package itself. For example in RDO we have *-dist.conf to adjust some parameters to distro specific configuration and you\u0027d need similar thing to ensure your package work.\n\nNote that for policy path we need the default value so that openstacklib::policy::base can pick up the location of the policy file.","commit_id":"724f2980b3b9c06cb2ab09088dfbd1db662ec376"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"edb912e5d7692d3f1c6b1e6cb3370de76968cd22","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  $enforce_new_defaults \u003d $::os_service_default,"},{"line_number":42,"context_line":"  $policies             \u003d {},"},{"line_number":43,"context_line":"  $policy_path          \u003d \u0027/etc/keystone/policy.yaml\u0027,"},{"line_number":44,"context_line":"  $policy_dirs          \u003d \u0027/etc/keystone/policy.d\u0027,"},{"line_number":45,"context_line":") {"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  include keystone::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"cbad3d39_51e12fb4","line":44,"range":{"start_line":44,"start_character":27,"end_line":44,"end_character":49},"in_reply_to":"5f540a93_2684ba9f","updated":"2021-03-31 09:36:56.000000000","message":"I\u0027ve set the default folder name in params.pp. Hopefully, that\u0027s what you\u0027re suggesting.","commit_id":"724f2980b3b9c06cb2ab09088dfbd1db662ec376"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"12f8061c72f84280d61496b86714c8cabc1e5359","unresolved":true,"context_lines":[{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*policy_dirs*]"},{"line_number":36,"context_line":"#   (Optional) Path to the keystone policy folder"},{"line_number":37,"context_line":"#   Defaults to /etc/keystone/policy.d"},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"class keystone::policy ("},{"line_number":40,"context_line":"  $enforce_scope        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1490bcca_a14be0c5","line":37,"range":{"start_line":37,"start_character":16,"end_line":37,"end_character":38},"updated":"2021-03-31 10:12:36.000000000","message":"Please update this.","commit_id":"10f51536cc08980cc3bf172bec3b8aa41a745613"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"487b1c7f9eeadff899a66481c924d2c8a507cc89","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*policy_dirs*]"},{"line_number":36,"context_line":"#   (Optional) Path to the keystone policy folder"},{"line_number":37,"context_line":"#   Defaults to /etc/keystone/policy.d"},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"class keystone::policy ("},{"line_number":40,"context_line":"  $enforce_scope        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1ee62416_b39e041e","line":37,"range":{"start_line":37,"start_character":16,"end_line":37,"end_character":38},"in_reply_to":"1490bcca_a14be0c5","updated":"2021-03-31 10:37:10.000000000","message":"Done","commit_id":"10f51536cc08980cc3bf172bec3b8aa41a745613"}],"releasenotes/notes/policy-dirs-3cc292a2be2bd104.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"12f8061c72f84280d61496b86714c8cabc1e5359","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Thereis now a new policy_dirs directive in the ::keystone::policy class,"},{"line_number":5,"context_line":"    so one can set a custom path."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ecaefb38_c3f15bc5","line":4,"range":{"start_line":4,"start_character":51,"end_line":4,"end_character":53},"updated":"2021-03-31 10:12:36.000000000","message":"Would be better to remove the heading :: from class name","commit_id":"10f51536cc08980cc3bf172bec3b8aa41a745613"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"12f8061c72f84280d61496b86714c8cabc1e5359","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Thereis now a new policy_dirs directive in the ::keystone::policy class,"},{"line_number":5,"context_line":"    so one can set a custom path."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"33c2c971_b6c51422","line":4,"updated":"2021-03-31 10:12:36.000000000","message":"missing space between There and is.","commit_id":"10f51536cc08980cc3bf172bec3b8aa41a745613"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"12f8061c72f84280d61496b86714c8cabc1e5359","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Thereis now a new policy_dirs directive in the ::keystone::policy class,"},{"line_number":5,"context_line":"    so one can set a custom path."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fe914126_15ccda85","line":4,"range":{"start_line":4,"start_character":34,"end_line":4,"end_character":43},"updated":"2021-03-31 10:12:36.000000000","message":"parameter ?","commit_id":"10f51536cc08980cc3bf172bec3b8aa41a745613"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"487b1c7f9eeadff899a66481c924d2c8a507cc89","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Thereis now a new policy_dirs directive in the ::keystone::policy class,"},{"line_number":5,"context_line":"    so one can set a custom path."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"99ee8558_7b431629","line":4,"in_reply_to":"33c2c971_b6c51422","updated":"2021-03-31 10:37:10.000000000","message":"Done","commit_id":"10f51536cc08980cc3bf172bec3b8aa41a745613"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"487b1c7f9eeadff899a66481c924d2c8a507cc89","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Thereis now a new policy_dirs directive in the ::keystone::policy class,"},{"line_number":5,"context_line":"    so one can set a custom path."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"19a9f416_16543b19","line":4,"range":{"start_line":4,"start_character":51,"end_line":4,"end_character":53},"in_reply_to":"ecaefb38_c3f15bc5","updated":"2021-03-31 10:37:10.000000000","message":"Done","commit_id":"10f51536cc08980cc3bf172bec3b8aa41a745613"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"487b1c7f9eeadff899a66481c924d2c8a507cc89","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Thereis now a new policy_dirs directive in the ::keystone::policy class,"},{"line_number":5,"context_line":"    so one can set a custom path."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"28d35bb9_27590111","line":4,"range":{"start_line":4,"start_character":34,"end_line":4,"end_character":43},"in_reply_to":"fe914126_15ccda85","updated":"2021-03-31 10:37:10.000000000","message":"Done","commit_id":"10f51536cc08980cc3bf172bec3b8aa41a745613"}]}