)]}'
{"manifests/federation/openidc.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ca3f41c10dd762e9b4e4d33b4edcba089d227a68","unresolved":true,"context_lines":[{"line_number":147,"context_line":"  $openidc_introspection_endpoint \u003d undef,"},{"line_number":148,"context_line":"  $openidc_verify_jwks_uri        \u003d undef,"},{"line_number":149,"context_line":"  $openidc_verify_method          \u003d \u0027introspection\u0027,"},{"line_number":150,"context_line":"  $openidc_pass_userinfo_as       \u003d \u0027claims\u0027,"},{"line_number":151,"context_line":"  $openidc_pass_claim_as          \u003d \u0027both\u0027,"},{"line_number":152,"context_line":"  $memcached_servers              \u003d undef,"},{"line_number":153,"context_line":"  $redis_server                   \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"18abaf7e_7764c16b","line":150,"range":{"start_line":150,"start_character":37,"end_line":150,"end_character":43},"updated":"2021-08-09 04:41:59.000000000","message":"If the configuration can be valid without these options, I\u0027d prefer using undef as their default value.","commit_id":"aca992c281cf08a2309190be38c56f1f4bc9c24d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1e83d86a94aa29223e85f0dc24da48f1de99ef6b","unresolved":true,"context_lines":[{"line_number":147,"context_line":"  $openidc_introspection_endpoint \u003d undef,"},{"line_number":148,"context_line":"  $openidc_verify_jwks_uri        \u003d undef,"},{"line_number":149,"context_line":"  $openidc_verify_method          \u003d \u0027introspection\u0027,"},{"line_number":150,"context_line":"  $openidc_pass_userinfo_as       \u003d undef,"},{"line_number":151,"context_line":"  $openidc_pass_claim_as          \u003d undef,"},{"line_number":152,"context_line":"  $memcached_servers              \u003d undef,"},{"line_number":153,"context_line":"  $redis_server                   \u003d undef,"},{"line_number":154,"context_line":"  $redis_password                 \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"cb97fd67_d466aa5b","line":151,"range":{"start_line":150,"start_character":0,"end_line":151,"end_character":42},"updated":"2021-08-09 08:11:31.000000000","message":"We can enforce validation if the parameter is not set to undef.","commit_id":"9fc16af7b2bc152f972239273b8efcc0b8d18db2"}],"releasenotes/notes/add-oidc-params-0bddcca8d49ccfdb.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1e83d86a94aa29223e85f0dc24da48f1de99ef6b","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adding the following configurable items for OpenID:"},{"line_number":5,"context_line":"    OIDCPassUserInfoAs: Defaults to \u0027claims\u0027"},{"line_number":6,"context_line":"    (::keystone::federation::openidc::openidc_pass_userinfo_as)"},{"line_number":7,"context_line":"    OIDCPassClaimsAs: Defaults to \u0027both\u0027"},{"line_number":8,"context_line":"    (::keystone::federation::openidc::openidc_pass_claim_as)"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a29f8947_ed8dc33d","line":8,"range":{"start_line":5,"start_character":4,"end_line":8,"end_character":60},"updated":"2021-08-09 08:11:31.000000000","message":"These should be updated.","commit_id":"9fc16af7b2bc152f972239273b8efcc0b8d18db2"}],"spec/classes/keystone_federation_openidc_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ca3f41c10dd762e9b4e4d33b4edcba089d227a68","unresolved":true,"context_lines":[{"line_number":171,"context_line":"        })"},{"line_number":172,"context_line":"      end"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    context \u0027with openidc_pass_userinfo_as attribute\u0027 do"},{"line_number":175,"context_line":"      before do"},{"line_number":176,"context_line":"        params.merge!({"},{"line_number":177,"context_line":"          :openidc_pass_userinfo_as \u003d\u003e \u0027claims\u0027,"},{"line_number":178,"context_line":"        })"},{"line_number":179,"context_line":"      end"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    context \u0027with openidc_pass_claim_as attribute\u0027 do"},{"line_number":182,"context_line":"     before do"},{"line_number":183,"context_line":"       params.merge!({"},{"line_number":184,"context_line":"         :openidc_pass_claim_as \u003d\u003e \u0027both\u0027,"},{"line_number":185,"context_line":"       })"},{"line_number":186,"context_line":"      end"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"      it \u0027should contain OIDC claim delimiter\u0027 do"},{"line_number":189,"context_line":"        content \u003d get_param(\u0027concat::fragment\u0027, \u0027configure_openidc_keystone\u0027, \u0027content\u0027)"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"4f359382_1d90a8d3","line":186,"range":{"start_line":174,"start_character":0,"end_line":186,"end_character":9},"updated":"2021-08-09 04:41:59.000000000","message":"It seems these test cases are incomplete.","commit_id":"aca992c281cf08a2309190be38c56f1f4bc9c24d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1e83d86a94aa29223e85f0dc24da48f1de99ef6b","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        params.merge!({"},{"line_number":177,"context_line":"          :openidc_pass_userinfo_as \u003d\u003e \u0027claims\u0027,"},{"line_number":178,"context_line":"        })"},{"line_number":179,"context_line":"      end"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    context \u0027with openidc_pass_claim_as attribute\u0027 do"},{"line_number":182,"context_line":"     before do"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"7a24f7c3_38726ef0","line":179,"updated":"2021-08-09 08:11:31.000000000","message":"This test case is incomplete because;\n\n- closing \"end\" which corresponds to context is missing\n\n- There is no test case defined.","commit_id":"9fc16af7b2bc152f972239273b8efcc0b8d18db2"}],"templates/openidc.conf.erb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d423922333c215b34b32239a2a644a591d3da7ca","unresolved":true,"context_lines":[{"line_number":34,"context_line":"\u003c%- if scope[\u0027::keystone::federation::openidc::openidc_claim_delimiter\u0027] !\u003d nil -%\u003e"},{"line_number":35,"context_line":"  OIDCClaimDelimiter \"\u003c%\u003d scope[\u0027::keystone::federation::openidc::openidc_claim_delimiter\u0027] %\u003e\""},{"line_number":36,"context_line":"\u003c%- end -%\u003e"},{"line_number":37,"context_line":"\u003c%- if scope[\u0027::keystone::federation::openidc::openidc_pass_userinfo_as\u0027] !\u003d nil -%\u003e"},{"line_number":38,"context_line":"  OIDCPassUserInfoAs \"\u003c%\u003d scope[\u0027::keystone::federation::openidc::openidc_pass_userinfo_as\u0027] %\u003e\""},{"line_number":39,"context_line":"\u003c%- end -%\u003e"},{"line_number":40,"context_line":"\u003c%- if scope[\u0027::keystone::federation::openidc::openidc_pass_claim_as\u0027] !\u003d nil -%\u003e"}],"source_content_type":"application/x-erb","patch_set":4,"id":"88e260fe_968fbef4","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":84},"updated":"2021-08-09 04:43:58.000000000","message":"so this implementation expect these parameters can be set to \"undef\" while current definition in the keystone::federation::openidc class enforces the parameters get atcual values.","commit_id":"aca992c281cf08a2309190be38c56f1f4bc9c24d"}]}