)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"299fb32e08bd90e526f4b4237c37449f14e31772","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OIDC: Add support for setting OIDCResponseMode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Default response modes fragment or query are using URL encoding which limits"},{"line_number":10,"context_line":"maximum token size. Response mode form_post does not have limits for token size."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change allows to define response mode."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a52cbe5a_8cf3f7d7","line":9,"range":{"start_line":9,"start_character":72,"end_line":9,"end_character":76},"updated":"2021-11-02 05:05:58.000000000","message":"We generally recommend wrapping lines at 72 characters.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"11bc18d65a0b7f0f8a293d7cca8205b7dc3cdcc4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8c0c1b09b2499d09c8073842a0b180702b1f1c36","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OIDC: Add support for setting OIDCResponseMode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Default response modes fragment or query are using URL encoding which limits"},{"line_number":10,"context_line":"maximum token size. Response mode form_post does not have limits for token size."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change allows to define response mode."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fb14c0d6_4e085258","line":9,"range":{"start_line":9,"start_character":72,"end_line":9,"end_character":76},"in_reply_to":"a52cbe5a_8cf3f7d7","updated":"2021-11-02 05:06:32.000000000","message":"Done","commit_id":"11bc18d65a0b7f0f8a293d7cca8205b7dc3cdcc4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"baf6918336a99d60d45976abc5a4180fd3c2ac6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e095d8ad_5d3a06a5","updated":"2021-10-31 11:57:02.000000000","message":"recheck\n\nThe logic change looks good. Do you mind adding a unit test case to verify the new parameter ?\nYou can follow how we test other parameters like openidc_claim_delimiter .\n https://github.com/openstack/puppet-keystone/blob/master/spec/classes/keystone_federation_openidc_spec.rb#L167-L178","commit_id":"0da32a070932d13d3c4d686c97111a42111d20f6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cacfd8b9a2442918785ef1ee829fe5284c4bd749","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"94d7300c_534bc201","updated":"2021-11-02 05:01:48.000000000","message":"Also, good to have a release note to explain the new parameter.","commit_id":"11bc18d65a0b7f0f8a293d7cca8205b7dc3cdcc4"},{"author":{"_account_id":34200,"name":"Oskari Lemmelä","email":"oskari@lemmela.net","username":"olemmela"},"change_message_id":"08b6274fd1fcaf026a13140ec2d718d01345e227","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"07387a78_2464fabd","updated":"2021-11-01 18:36:14.000000000","message":"Thanks for the review. I added test for openidc_response_mode in second patchset.","commit_id":"11bc18d65a0b7f0f8a293d7cca8205b7dc3cdcc4"},{"author":{"_account_id":34200,"name":"Oskari Lemmelä","email":"oskari@lemmela.net","username":"olemmela"},"change_message_id":"82bfb5c5d1699de1228f970ceb6edfef26b9252e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cef3af05_8b239737","updated":"2021-11-02 04:52:42.000000000","message":"recheck","commit_id":"11bc18d65a0b7f0f8a293d7cca8205b7dc3cdcc4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8c0c1b09b2499d09c8073842a0b180702b1f1c36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d0ab67dc_83498f47","in_reply_to":"94d7300c_534bc201","updated":"2021-11-02 05:06:32.000000000","message":"Done","commit_id":"11bc18d65a0b7f0f8a293d7cca8205b7dc3cdcc4"}],"spec/classes/keystone_federation_openidc_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"edf80b3e174baecf4ed79ee3d3ca2483447c881c","unresolved":true,"context_lines":[{"line_number":211,"context_line":"      end"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"      it \u0027should contain OIDC response mode\u0027 do"},{"line_number":214,"context_line":"        content \u003d get_param(\u0027concat::fragment\u0027, \u0027openidc_response_mode\u0027, \u0027content\u0027)"},{"line_number":215,"context_line":"        expect(content).to match(\u0027OIDCResponseMode \"form_post\"\u0027)"},{"line_number":216,"context_line":"      end"},{"line_number":217,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"45e641cf_670b844f","line":214,"range":{"start_line":214,"start_character":49,"end_line":214,"end_character":70},"updated":"2021-11-02 05:00:51.000000000","message":"this should be configure_openidc_keystone","commit_id":"11bc18d65a0b7f0f8a293d7cca8205b7dc3cdcc4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8c0c1b09b2499d09c8073842a0b180702b1f1c36","unresolved":false,"context_lines":[{"line_number":211,"context_line":"      end"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"      it \u0027should contain OIDC response mode\u0027 do"},{"line_number":214,"context_line":"        content \u003d get_param(\u0027concat::fragment\u0027, \u0027openidc_response_mode\u0027, \u0027content\u0027)"},{"line_number":215,"context_line":"        expect(content).to match(\u0027OIDCResponseMode \"form_post\"\u0027)"},{"line_number":216,"context_line":"      end"},{"line_number":217,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"08a07d0a_66ce6d98","line":214,"range":{"start_line":214,"start_character":49,"end_line":214,"end_character":70},"in_reply_to":"45e641cf_670b844f","updated":"2021-11-02 05:06:32.000000000","message":"Done","commit_id":"11bc18d65a0b7f0f8a293d7cca8205b7dc3cdcc4"}]}