)]}'
{"manifests/init.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e9ce8b47206dbb7311cf0a74bce943259241cc82","unresolved":false,"context_lines":[{"line_number":811,"context_line":"  # restart_keystone exec is doing 4/, it restart Keystone if we have a new default domain setted"},{"line_number":812,"context_line":"  # and if we manage the service to be enabled."},{"line_number":813,"context_line":"  if $manage_service and $enabled {"},{"line_number":814,"context_line":"    $restart_command \u003d $::service_provider ? {"},{"line_number":815,"context_line":"      \u0027systemd\u0027 \u003d\u003e \"systemctl restart ${service_name_real}\","},{"line_number":816,"context_line":"      default   \u003d\u003e \"service ${service_name_real} restart\","},{"line_number":817,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fd06bb89_6ea94cff","line":814,"updated":"2022-01-12 15:40:31.000000000","message":"can we update this to $facts[\u0027service_provider\u0027] ?","commit_id":"1976b54ae8f9a0f7da921b5b00b02a728f740db2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b1ca0cd77cbb07703bfa4dc74bd267c9ca9ef094","unresolved":false,"context_lines":[{"line_number":811,"context_line":"  # restart_keystone exec is doing 4/, it restart Keystone if we have a new default domain setted"},{"line_number":812,"context_line":"  # and if we manage the service to be enabled."},{"line_number":813,"context_line":"  if $manage_service and $enabled {"},{"line_number":814,"context_line":"    $restart_command \u003d $::service_provider ? {"},{"line_number":815,"context_line":"      \u0027systemd\u0027 \u003d\u003e \"systemctl restart ${service_name_real}\","},{"line_number":816,"context_line":"      default   \u003d\u003e \"service ${service_name_real} restart\","},{"line_number":817,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3dc6e48f_002c9fae","line":814,"in_reply_to":"a587ee04_3c1fb556","updated":"2022-01-12 16:14:06.000000000","message":"I understand that point and I agree. I\u0027ll have a look when I have time. I was also thinking of replacing old facts like osfamily by new ones but switching to $facts would help this plan as well because it allows us to find the value coming from facts easily.","commit_id":"1976b54ae8f9a0f7da921b5b00b02a728f740db2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1c0ff7a42a78355e14ed61ae8f19a971687f8ab5","unresolved":false,"context_lines":[{"line_number":811,"context_line":"  # restart_keystone exec is doing 4/, it restart Keystone if we have a new default domain setted"},{"line_number":812,"context_line":"  # and if we manage the service to be enabled."},{"line_number":813,"context_line":"  if $manage_service and $enabled {"},{"line_number":814,"context_line":"    $restart_command \u003d $::service_provider ? {"},{"line_number":815,"context_line":"      \u0027systemd\u0027 \u003d\u003e \"systemctl restart ${service_name_real}\","},{"line_number":816,"context_line":"      default   \u003d\u003e \"service ${service_name_real} restart\","},{"line_number":817,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"a587ee04_3c1fb556","line":814,"in_reply_to":"ce732b6c_918a1678","updated":"2022-01-12 16:08:21.000000000","message":"Well it\u0027s the same var, I just mean we should probably get away from the global var usage for facts and switch to $facts[...].  It\u0027s something we should have done years ago but never bothered to update all the things","commit_id":"1976b54ae8f9a0f7da921b5b00b02a728f740db2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ae4d8e88a532ed16aa79047542084e533766f66b","unresolved":false,"context_lines":[{"line_number":811,"context_line":"  # restart_keystone exec is doing 4/, it restart Keystone if we have a new default domain setted"},{"line_number":812,"context_line":"  # and if we manage the service to be enabled."},{"line_number":813,"context_line":"  if $manage_service and $enabled {"},{"line_number":814,"context_line":"    $restart_command \u003d $::service_provider ? {"},{"line_number":815,"context_line":"      \u0027systemd\u0027 \u003d\u003e \"systemctl restart ${service_name_real}\","},{"line_number":816,"context_line":"      default   \u003d\u003e \"service ${service_name_real} restart\","},{"line_number":817,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ce732b6c_918a1678","line":814,"in_reply_to":"fd06bb89_6ea94cff","updated":"2022-01-12 16:01:33.000000000","message":"Because I noticed checking the service_provider fact is just redundant, I removed the logic to check the fact and just replaced the hard-coded command.","commit_id":"1976b54ae8f9a0f7da921b5b00b02a728f740db2"}]}