)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7ebb8ddcbf81d7e9e99ddfa50cc560748888b4ec","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Trivial fix"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change fixes parameter value typo as well as typo in"},{"line_number":10,"context_line":"os_service_default."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I1c45f1fcb8663383b09014aa5095c9b0e99fb231"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d231be87_cfb9ef49","line":9,"updated":"2022-06-16 08:56:41.000000000","message":"we are not modifying the actual value and would be better to state this affects only parameter descriptions.","commit_id":"dd2db4a00633c4b0ad94046df70716860a10f0b2"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"f28d636dab2b901fd3b98eb298d0b1c726425ec9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Trivial fix"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change fixes parameter value typo as well as typo in"},{"line_number":10,"context_line":"os_service_default."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I1c45f1fcb8663383b09014aa5095c9b0e99fb231"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"09c9a222_23360cf5","line":9,"in_reply_to":"d231be87_cfb9ef49","updated":"2022-06-16 13:23:34.000000000","message":"Thanks for updating patch.","commit_id":"dd2db4a00633c4b0ad94046df70716860a10f0b2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6e27d86a1237e0bffd226c28ffbe87ded2bbd819","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajesh Tailor \u003cratailor@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-16 17:04:49 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix a few typos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change fixes a few typos in parameter descriptions."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"74599f81_d058db4b","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":9},"updated":"2022-06-16 13:17:50.000000000","message":"maybe it\u0027s no longer \u0027a few\u0027 ? :-)","commit_id":"2982730ac4c7bd42e4e283d07251b6abda9ed957"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6e1db41122dd08f5b6fa0362f4a2e2ee1eb45d67","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajesh Tailor \u003cratailor@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-16 17:04:49 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix a few typos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change fixes a few typos in parameter descriptions."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"59f4ea33_f6afb8d2","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":9},"in_reply_to":"74599f81_d058db4b","updated":"2022-06-16 13:30:29.000000000","message":"Done","commit_id":"2982730ac4c7bd42e4e283d07251b6abda9ed957"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1d57d7f14e88a051893beec1c7fb7152b0caf045","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7d59c83f_21f0e455","updated":"2022-06-15 11:46:02.000000000","message":"Also, we have a typo in logging.pp (0ptional , not Optional) which you fixed in puppet-nova.\n\nDo you care to cover that ?\n\nIt might be overkilling to fix that single typo in every modules but now as are fixing another typo, fixing that at the same time would make sense.","commit_id":"07d17b66641657b8a90bf976dcb574527c162857"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"1b28df5f8c2f51088ec31e3b45314a6952ab0efc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8c81d086_b3a4e737","updated":"2022-06-16 07:32:24.000000000","message":"Thanks for mentioning this.","commit_id":"07d17b66641657b8a90bf976dcb574527c162857"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"1b28df5f8c2f51088ec31e3b45314a6952ab0efc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7b6cfbdf_a0df2cd2","in_reply_to":"7d59c83f_21f0e455","updated":"2022-06-16 07:32:24.000000000","message":"Done","commit_id":"07d17b66641657b8a90bf976dcb574527c162857"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"3bb70f7a0ef54049dbd5082d6be6574ab89ef01e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4b24c0a5_dd90bb0f","updated":"2022-06-16 11:06:37.000000000","message":"recheck","commit_id":"2c798c5870aa688bb46903d8cc578dabfa86a86d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8f6170119ca0c15962dd4c77e72a9fa7778bc9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"21df20df_a4c30080","updated":"2022-06-16 13:18:42.000000000","message":"Note to self: We are likely to have the same issue with common implementation (eg logging, healthcheck, cache, ...) in the other modules.","commit_id":"2982730ac4c7bd42e4e283d07251b6abda9ed957"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"f28d636dab2b901fd3b98eb298d0b1c726425ec9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ad03a30f_49d32800","in_reply_to":"21df20df_a4c30080","updated":"2022-06-16 13:23:34.000000000","message":"If you don\u0027t mind, I could submit patches for those ?","commit_id":"2982730ac4c7bd42e4e283d07251b6abda9ed957"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6e1db41122dd08f5b6fa0362f4a2e2ee1eb45d67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"446d73a7_7d9779d7","in_reply_to":"ad03a30f_49d32800","updated":"2022-06-16 13:30:29.000000000","message":"That\u0027s nice !","commit_id":"2982730ac4c7bd42e4e283d07251b6abda9ed957"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"1b82ef760241b4e250c4bbf32f21cf78e35dfa3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"853a48fe_b42e13d2","updated":"2022-06-17 04:07:49.000000000","message":"recheck","commit_id":"c6a3840a8e24cedd5d1116ce6081e7e76886cfcb"}],"spec/classes/keystone_init_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5676991846f59430a93e9263c0f6cce5a0ce6398","unresolved":true,"context_lines":[{"line_number":629,"context_line":"            :service_name       \u003d\u003e \u0027keystone\u0027,"},{"line_number":630,"context_line":"            :httpd_service_name \u003d\u003e \u0027apache2\u0027 }"},{"line_number":631,"context_line":"        when \u0027RedHat\u0027"},{"line_number":632,"context_line":"          { :package_name       \u003d\u003e \u0027openstack-keystone\u0027,"},{"line_number":633,"context_line":"            :service_name       \u003d\u003e \u0027openstack-keystone\u0027,"},{"line_number":634,"context_line":"            :httpd_service_name \u003d\u003e \u0027httpd\u0027 }"},{"line_number":635,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"6f91aff7_b3934ac8","line":632,"range":{"start_line":632,"start_character":36,"end_line":632,"end_character":54},"updated":"2022-06-15 11:43:19.000000000","message":"This is a good catch, but is quite strange because this should cause test failure.\n\nI noticed this is not used by actual assertion and submitted a fix for that.\n https://review.opendev.org/c/openstack/puppet-keystone/+/845925\n\nI\u0027d make it separate so that we can backport that to stable branches. Do you care to update this change to exclude this ?","commit_id":"07d17b66641657b8a90bf976dcb574527c162857"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1699f649ea609012282384f70edc4250c583459e","unresolved":false,"context_lines":[{"line_number":629,"context_line":"            :service_name       \u003d\u003e \u0027keystone\u0027,"},{"line_number":630,"context_line":"            :httpd_service_name \u003d\u003e \u0027apache2\u0027 }"},{"line_number":631,"context_line":"        when \u0027RedHat\u0027"},{"line_number":632,"context_line":"          { :package_name       \u003d\u003e \u0027openstack-keystone\u0027,"},{"line_number":633,"context_line":"            :service_name       \u003d\u003e \u0027openstack-keystone\u0027,"},{"line_number":634,"context_line":"            :httpd_service_name \u003d\u003e \u0027httpd\u0027 }"},{"line_number":635,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"0a6362ee_193068f6","line":632,"range":{"start_line":632,"start_character":36,"end_line":632,"end_character":54},"in_reply_to":"6f91aff7_b3934ac8","updated":"2022-06-16 08:54:56.000000000","message":"Done","commit_id":"07d17b66641657b8a90bf976dcb574527c162857"}]}