)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e40d410304a944de242bb65a156fc1ae9b97d0c3","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix access to configs hash symbol in get_auth_endpoint"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The hash returned by the request method of Puppet::Provider::Openstack uses"},{"line_number":10,"context_line":"symbols instead of strings as keys, see [1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This prepends the missing \u0027:\u0027 in front of the \u0027auth.auth_url\u0027 key to make it a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7d537f60_1f088ea0","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":75},"updated":"2023-03-10 15:18:42.000000000","message":"please wrap each line at 72 characters.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages\n```\nSubsequent lines should be wrapped at 72 characters.\n```","commit_id":"8db3aba45bec4de8850c1a79c22fc704bde9ac20"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"69062e579ee3a8d914732f11a48dc5af22a7ea4c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix access to configs hash symbol in get_auth_endpoint"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The hash returned by the request method of Puppet::Provider::Openstack uses"},{"line_number":10,"context_line":"symbols instead of strings as keys, see [1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This prepends the missing \u0027:\u0027 in front of the \u0027auth.auth_url\u0027 key to make it a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2c55569c_89bec4a4","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":75},"in_reply_to":"2dcb5588_b04b94e2","updated":"2023-03-10 19:02:10.000000000","message":"Done","commit_id":"8db3aba45bec4de8850c1a79c22fc704bde9ac20"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0cfd54118c64c5611fedb7c6f93a1aabebe71d67","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix access to configs hash symbol in get_auth_endpoint"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The hash returned by the request method of Puppet::Provider::Openstack uses"},{"line_number":10,"context_line":"symbols instead of strings as keys, see [1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This prepends the missing \u0027:\u0027 in front of the \u0027auth.auth_url\u0027 key to make it a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2dcb5588_b04b94e2","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":75},"in_reply_to":"7d537f60_1f088ea0","updated":"2023-03-10 15:19:40.000000000","message":"note that you don\u0027t have to wrap URL because that likely break the link.","commit_id":"8db3aba45bec4de8850c1a79c22fc704bde9ac20"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e40d410304a944de242bb65a156fc1ae9b97d0c3","unresolved":true,"context_lines":[{"line_number":14,"context_line":"empty."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://opendev.org/openstack/puppet-openstacklib/src/commit/a1dfd6861f9593f005e72acaef7262e618d2cf6c/lib/puppet/provider/openstack.rb#L123"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I97546a1030559d1f91030a668106e220ce7a7650"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a8a83727_e95c7007","line":17,"updated":"2023-03-10 15:18:42.000000000","message":"do you mind reporting a bug ? The bug affects older branches so we better have it for tracking purpose.","commit_id":"8db3aba45bec4de8850c1a79c22fc704bde9ac20"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"69062e579ee3a8d914732f11a48dc5af22a7ea4c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"empty."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://opendev.org/openstack/puppet-openstacklib/src/commit/a1dfd6861f9593f005e72acaef7262e618d2cf6c/lib/puppet/provider/openstack.rb#L123"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I97546a1030559d1f91030a668106e220ce7a7650"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b3bc5def_efffa81c","line":17,"in_reply_to":"a8a83727_e95c7007","updated":"2023-03-10 19:02:10.000000000","message":"Done","commit_id":"8db3aba45bec4de8850c1a79c22fc704bde9ac20"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"4c86f4cc5617f5ea7ebb6ced3f19d5c41b1dcf33","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0c57f82e_047361bb","updated":"2023-03-10 14:57:20.000000000","message":"I just ran into this wondering why puppet-keystone was constantly changing passwords.\nThis was simply due to the fact the authentication (let alone fetching a token) will always fail with no auth_url set ;-)\n\n\nJust as another observation ... unfortunately the \"password needs changing\" check via Puppet::Error::OpenstackUnauthorizedError can not distinguish between a general configuration error of the openstack client\u0027s auth (missing variable), or a wrong password in this case. \nThis is simply due to https://opendev.org/openstack/puppet-openstacklib/src/commit/a1dfd6861f9593f005e72acaef7262e618d2cf6c/lib/puppet/provider/openstack.rb#L129 making all cases look equal.\n\nThis lack of a clear error message made hunting the ever changing password issue a little more work.","commit_id":"8db3aba45bec4de8850c1a79c22fc704bde9ac20"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e40d410304a944de242bb65a156fc1ae9b97d0c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a09e9f4f_0aa18b9e","updated":"2023-03-10 15:18:42.000000000","message":"Thanks for proposing the fix ! We are still waiting for CI but let me leave a few early comments. The logic change looks correct to me.","commit_id":"8db3aba45bec4de8850c1a79c22fc704bde9ac20"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"69062e579ee3a8d914732f11a48dc5af22a7ea4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a5b384e7_7c014dda","updated":"2023-03-10 19:02:10.000000000","message":"New patchset (hopefully) fixing commit message line wrapping and \nmentioning the bug I opened at https://bugs.launchpad.net/puppet-keystone/+bug/2010894","commit_id":"5a6378c6dfc053f2e65867ae9b27537b4bc558a5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"81d011f77a64fcbf61624cd009cad4a3c45a9b8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7772e7e8_fa833c5a","updated":"2023-03-11 03:12:33.000000000","message":"Thank you !","commit_id":"5a6378c6dfc053f2e65867ae9b27537b4bc558a5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f3f0cd3dc82644c4b10e49c26b8f754ac4014544","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"90a9d504_b9823ed9","updated":"2023-03-12 10:56:58.000000000","message":"recheck tempest","commit_id":"5a6378c6dfc053f2e65867ae9b27537b4bc558a5"}]}