)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"425c6f4555a2e4fcfebc43b27a01ec821cada7cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3f68a483_01c7951f","updated":"2024-06-24 13:31:53.000000000","message":"Added a missing release note and missing unit test coverage. I also adjusted the parameter name to make the naming consistent with the existing parameters.\n\nPlease lmk if you have any concerns about these changes.","commit_id":"68e091978887937a46bf9dd389e4b9d85079ac59"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"b69ab275eed77434cc2568e9ca9d03c46805b237","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e2308a89_65143be0","in_reply_to":"3f68a483_01c7951f","updated":"2024-06-24 14:04:00.000000000","message":"Thank you, forgot about the RN","commit_id":"68e091978887937a46bf9dd389e4b9d85079ac59"}],"manifests/federation/openidc.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"425c6f4555a2e4fcfebc43b27a01ec821cada7cc","unresolved":false,"context_lines":[{"line_number":101,"context_line":"#  \"both\": claims/tokens are passed as both headers as well as environment variables (default)"},{"line_number":102,"context_line":"#  Defaults to undef"},{"line_number":103,"context_line":"#"},{"line_number":104,"context_line":"# [*openidc_custom_redirecturi*]"},{"line_number":105,"context_line":"# (Optional) An arbitrary URI for OIDCRedirectURI. Defaults to undef, in this"},{"line_number":106,"context_line":"# case the URI is generated from keystone_url and idp_name."},{"line_number":107,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"74b89da5_ae6c9a84","line":104,"range":{"start_line":104,"start_character":4,"end_line":104,"end_character":30},"updated":"2024-06-24 13:31:53.000000000","message":"I\u0027d suggest openidc_redirect_uri to use the consistent parameter name format.","commit_id":"bce95f90ecd54c6a5de1a2a0d9c8f938b127dd94"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6c746304045967689369015379b28d40286e80f5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"#  \"both\": claims/tokens are passed as both headers as well as environment variables (default)"},{"line_number":102,"context_line":"#  Defaults to undef"},{"line_number":103,"context_line":"#"},{"line_number":104,"context_line":"# [*openidc_custom_redirecturi*]"},{"line_number":105,"context_line":"# (Optional) An arbitrary URI for OIDCRedirectURI. Defaults to undef, in this"},{"line_number":106,"context_line":"# case the URI is generated from keystone_url and idp_name."},{"line_number":107,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"73940f14_df6c39a0","line":104,"range":{"start_line":104,"start_character":4,"end_line":104,"end_character":30},"in_reply_to":"141c846c_e623c4f2","updated":"2024-06-25 02:12:44.000000000","message":"Let\u0027s leave the validation for now. I\u0027ll push a follow-up if I come up with a good method.","commit_id":"bce95f90ecd54c6a5de1a2a0d9c8f938b127dd94"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"b69ab275eed77434cc2568e9ca9d03c46805b237","unresolved":false,"context_lines":[{"line_number":101,"context_line":"#  \"both\": claims/tokens are passed as both headers as well as environment variables (default)"},{"line_number":102,"context_line":"#  Defaults to undef"},{"line_number":103,"context_line":"#"},{"line_number":104,"context_line":"# [*openidc_custom_redirecturi*]"},{"line_number":105,"context_line":"# (Optional) An arbitrary URI for OIDCRedirectURI. Defaults to undef, in this"},{"line_number":106,"context_line":"# case the URI is generated from keystone_url and idp_name."},{"line_number":107,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"141c846c_e623c4f2","line":104,"range":{"start_line":104,"start_character":4,"end_line":104,"end_character":30},"in_reply_to":"74b89da5_ae6c9a84","updated":"2024-06-24 14:04:00.000000000","message":"For me it\u0027s ok, is it possible to validate it like in https://review.opendev.org/c/openstack/puppet-keystone/+/911043 ?","commit_id":"bce95f90ecd54c6a5de1a2a0d9c8f938b127dd94"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"a49b291a1fb1e109fc35759dd59dfe71c080061c","unresolved":true,"context_lines":[{"line_number":172,"context_line":"  $openidc_verify_method          \u003d \u0027introspection\u0027,"},{"line_number":173,"context_line":"  $openidc_pass_userinfo_as       \u003d undef,"},{"line_number":174,"context_line":"  $openidc_pass_claim_as          \u003d undef,"},{"line_number":175,"context_line":"  $openidc_custom_redirecturi     \u003d undef,"},{"line_number":176,"context_line":"  $memcached_servers              \u003d undef,"},{"line_number":177,"context_line":"  $redis_server                   \u003d undef,"},{"line_number":178,"context_line":"  $redis_password                 \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"2d6337ce_d8f30543","line":175,"updated":"2024-06-19 14:37:35.000000000","message":"Currently there is no inputvalidation, Stdlib::HTTPUrl has been suggested but might not be the ideal solution as this should not contain http://","commit_id":"bce95f90ecd54c6a5de1a2a0d9c8f938b127dd94"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"4a82a1250ecff981efc482f9a82af6f8269d6b67","unresolved":true,"context_lines":[{"line_number":172,"context_line":"  $openidc_verify_method          \u003d \u0027introspection\u0027,"},{"line_number":173,"context_line":"  $openidc_pass_userinfo_as       \u003d undef,"},{"line_number":174,"context_line":"  $openidc_pass_claim_as          \u003d undef,"},{"line_number":175,"context_line":"  $openidc_custom_redirecturi     \u003d undef,"},{"line_number":176,"context_line":"  $memcached_servers              \u003d undef,"},{"line_number":177,"context_line":"  $redis_server                   \u003d undef,"},{"line_number":178,"context_line":"  $redis_password                 \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9b2210b1_62e03a64","line":175,"in_reply_to":"2d6337ce_d8f30543","updated":"2024-06-24 12:40:29.000000000","message":"EDIT: it should containt HTTP(S), my bad","commit_id":"bce95f90ecd54c6a5de1a2a0d9c8f938b127dd94"}]}