)]}'
{"manifests/federation/openidc.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ea2ca984130372db3d7f467da97b72a486431ae","unresolved":true,"context_lines":[{"line_number":106,"context_line":"#  case the URI is generated from keystone_url and idp_name."},{"line_number":107,"context_line":"#"},{"line_number":108,"context_line":"# [*locations*]"},{"line_number":109,"context_line":"# (Optional) Array of hashes of additional Apache \u003cLocation\u003e directives with"},{"line_number":110,"context_line":"# mod_auth_openidc configuration. Accepted parameters are url, authtype, "},{"line_number":111,"context_line":"# oidcdiscoverurl (optional), requireoidc, loglevel (optional)"},{"line_number":112,"context_line":"# Example:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"b650ad04_8c1cd0c2","line":109,"updated":"2024-07-03 06:22:13.000000000","message":"please add one more space to align the parameter descrpitons.","commit_id":"50398f815d83486c41d585a602b39e9026c17f39"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4a518eb77f9649770be34d7be3e1a54684afc1ae","unresolved":false,"context_lines":[{"line_number":106,"context_line":"#  case the URI is generated from keystone_url and idp_name."},{"line_number":107,"context_line":"#"},{"line_number":108,"context_line":"# [*locations*]"},{"line_number":109,"context_line":"# (Optional) Array of hashes of additional Apache \u003cLocation\u003e directives with"},{"line_number":110,"context_line":"# mod_auth_openidc configuration. Accepted parameters are url, authtype, "},{"line_number":111,"context_line":"# oidcdiscoverurl (optional), requireoidc, loglevel (optional)"},{"line_number":112,"context_line":"# Example:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"d490b707_ed1fbd18","line":109,"in_reply_to":"a14405a5_e394fc8a","updated":"2024-07-17 11:54:23.000000000","message":"Done","commit_id":"50398f815d83486c41d585a602b39e9026c17f39"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"ee34cc37e8965f011ec056466603c570d6c29ef7","unresolved":true,"context_lines":[{"line_number":106,"context_line":"#  case the URI is generated from keystone_url and idp_name."},{"line_number":107,"context_line":"#"},{"line_number":108,"context_line":"# [*locations*]"},{"line_number":109,"context_line":"# (Optional) Array of hashes of additional Apache \u003cLocation\u003e directives with"},{"line_number":110,"context_line":"# mod_auth_openidc configuration. Accepted parameters are url, authtype, "},{"line_number":111,"context_line":"# oidcdiscoverurl (optional), requireoidc, loglevel (optional)"},{"line_number":112,"context_line":"# Example:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"a14405a5_e394fc8a","line":109,"in_reply_to":"b650ad04_8c1cd0c2","updated":"2024-07-04 10:22:20.000000000","message":"I\u0027m sorry I didn\u0027t understand - what/where should be aligned?","commit_id":"50398f815d83486c41d585a602b39e9026c17f39"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3968d572ba14047aacc3e17c76e3454a50574c6e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"#"},{"line_number":108,"context_line":"# [*locations*]"},{"line_number":109,"context_line":"# (Optional) Array of hashes of additional Apache \u003cLocation\u003e directives with"},{"line_number":110,"context_line":"# mod_auth_openidc configuration. Accepted parameters are url, authtype, "},{"line_number":111,"context_line":"# oidcdiscoverurl (optional), requireoidc, loglevel (optional)"},{"line_number":112,"context_line":"# Example:"},{"line_number":113,"context_line":"# locations \u003d\u003e [{"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"eb46a239_2e4330b0","line":110,"updated":"2024-07-02 15:13:13.000000000","message":"nit: trailing space","commit_id":"50398f815d83486c41d585a602b39e9026c17f39"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ea2ca984130372db3d7f467da97b72a486431ae","unresolved":true,"context_lines":[{"line_number":186,"context_line":"  $openidc_pass_userinfo_as       \u003d undef,"},{"line_number":187,"context_line":"  $openidc_pass_claim_as          \u003d undef,"},{"line_number":188,"context_line":"  $openidc_redirect_uri           \u003d undef,"},{"line_number":189,"context_line":"  Optional[Array[Hash]] $locations \u003d undef,"},{"line_number":190,"context_line":"  $memcached_servers              \u003d undef,"},{"line_number":191,"context_line":"  $redis_server                   \u003d undef,"},{"line_number":192,"context_line":"  $redis_password                 \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"4fb5603f_855827c8","line":189,"range":{"start_line":189,"start_character":25,"end_line":189,"end_character":35},"updated":"2024-07-03 06:22:13.000000000","message":"Because this does not override the default locations but additional ones, I\u0027d suggest \"additional_locations\"","commit_id":"50398f815d83486c41d585a602b39e9026c17f39"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"ee34cc37e8965f011ec056466603c570d6c29ef7","unresolved":false,"context_lines":[{"line_number":186,"context_line":"  $openidc_pass_userinfo_as       \u003d undef,"},{"line_number":187,"context_line":"  $openidc_pass_claim_as          \u003d undef,"},{"line_number":188,"context_line":"  $openidc_redirect_uri           \u003d undef,"},{"line_number":189,"context_line":"  Optional[Array[Hash]] $locations \u003d undef,"},{"line_number":190,"context_line":"  $memcached_servers              \u003d undef,"},{"line_number":191,"context_line":"  $redis_server                   \u003d undef,"},{"line_number":192,"context_line":"  $redis_password                 \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ad76d88d_23653cb0","line":189,"range":{"start_line":189,"start_character":25,"end_line":189,"end_character":35},"in_reply_to":"4fb5603f_855827c8","updated":"2024-07-04 10:22:20.000000000","message":"Done in patch set 3","commit_id":"50398f815d83486c41d585a602b39e9026c17f39"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0807956c331aad797bf92156ccbcb7632a8619ce","unresolved":true,"context_lines":[{"line_number":176,"context_line":"  $openidc_client_secret,"},{"line_number":177,"context_line":"  Optional[Stdlib::HTTPUrl] $openidc_provider_metadata_url \u003d undef,"},{"line_number":178,"context_line":"  Optional[Stdlib::Unixpath] $openidc_metadata_dir         \u003d undef,"},{"line_number":179,"context_line":"  $openidc_crypto_passphrase      \u003d \u0027openstack\u0027,"},{"line_number":180,"context_line":"  $openidc_response_type          \u003d \u0027id_token\u0027,"},{"line_number":181,"context_line":"  $openidc_response_mode          \u003d undef,"},{"line_number":182,"context_line":"  $openidc_cache_type             \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7a304db0_9325b6ec","line":179,"range":{"start_line":179,"start_character":34,"end_line":179,"end_character":35},"updated":"2024-07-11 14:28:29.000000000","message":"Can we avoid removing these spaces to reduce lines being updated ?","commit_id":"935d507867b436e8354e29e1692dfbb9ed38e590"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"b0e89278d8791737de9de1474742643b74169e2d","unresolved":false,"context_lines":[{"line_number":176,"context_line":"  $openidc_client_secret,"},{"line_number":177,"context_line":"  Optional[Stdlib::HTTPUrl] $openidc_provider_metadata_url \u003d undef,"},{"line_number":178,"context_line":"  Optional[Stdlib::Unixpath] $openidc_metadata_dir         \u003d undef,"},{"line_number":179,"context_line":"  $openidc_crypto_passphrase      \u003d \u0027openstack\u0027,"},{"line_number":180,"context_line":"  $openidc_response_type          \u003d \u0027id_token\u0027,"},{"line_number":181,"context_line":"  $openidc_response_mode          \u003d undef,"},{"line_number":182,"context_line":"  $openidc_cache_type             \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9d6098ae_4ec55403","line":179,"range":{"start_line":179,"start_character":34,"end_line":179,"end_character":35},"in_reply_to":"7a304db0_9325b6ec","updated":"2024-07-17 08:30:56.000000000","message":"Done in patch set 6","commit_id":"935d507867b436e8354e29e1692dfbb9ed38e590"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0807956c331aad797bf92156ccbcb7632a8619ce","unresolved":true,"context_lines":[{"line_number":202,"context_line":"  $redis_timeout                  \u003d undef,"},{"line_number":203,"context_line":"  $remote_id_attribute            \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":204,"context_line":"  $template_order                 \u003d 331,"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":") {"},{"line_number":207,"context_line":"  include apache"},{"line_number":208,"context_line":"  include apache::mod::auth_openidc"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"697cf68e_62b8bea6","line":205,"updated":"2024-07-11 14:28:29.000000000","message":"please remove this empty line.","commit_id":"935d507867b436e8354e29e1692dfbb9ed38e590"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"b0e89278d8791737de9de1474742643b74169e2d","unresolved":false,"context_lines":[{"line_number":202,"context_line":"  $redis_timeout                  \u003d undef,"},{"line_number":203,"context_line":"  $remote_id_attribute            \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":204,"context_line":"  $template_order                 \u003d 331,"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":") {"},{"line_number":207,"context_line":"  include apache"},{"line_number":208,"context_line":"  include apache::mod::auth_openidc"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"eb04206f_5e11bc1d","line":205,"in_reply_to":"697cf68e_62b8bea6","updated":"2024-07-17 08:30:56.000000000","message":"Done in patch set 6","commit_id":"935d507867b436e8354e29e1692dfbb9ed38e590"}],"templates/openidc.conf.erb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ea2ca984130372db3d7f467da97b72a486431ae","unresolved":true,"context_lines":[{"line_number":94,"context_line":"  \u003c/Location\u003e"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"\u003c% if @locations %\u003e"},{"line_number":97,"context_line":"  # Additional Location directives from keystone::federation::openidc:locations"},{"line_number":98,"context_line":"\u003c% @locations.each do |loc| %\u003e"},{"line_number":99,"context_line":"  \u003cLocation \"\u003c%\u003d loc[\u0027url\u0027] %\u003e\"\u003e"},{"line_number":100,"context_line":"    AuthType \"\u003c%\u003d loc[\u0027authtype\u0027] %\u003e\""}],"source_content_type":"application/x-erb","patch_set":2,"id":"cc5c32d7_72ca55bf","line":97,"updated":"2024-07-03 06:22:13.000000000","message":"missing one more :","commit_id":"50398f815d83486c41d585a602b39e9026c17f39"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"ee34cc37e8965f011ec056466603c570d6c29ef7","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  \u003c/Location\u003e"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"\u003c% if @locations %\u003e"},{"line_number":97,"context_line":"  # Additional Location directives from keystone::federation::openidc:locations"},{"line_number":98,"context_line":"\u003c% @locations.each do |loc| %\u003e"},{"line_number":99,"context_line":"  \u003cLocation \"\u003c%\u003d loc[\u0027url\u0027] %\u003e\"\u003e"},{"line_number":100,"context_line":"    AuthType \"\u003c%\u003d loc[\u0027authtype\u0027] %\u003e\""}],"source_content_type":"application/x-erb","patch_set":2,"id":"e02dad5f_04ce8d14","line":97,"in_reply_to":"cc5c32d7_72ca55bf","updated":"2024-07-04 10:22:20.000000000","message":"Done in patch set 3","commit_id":"50398f815d83486c41d585a602b39e9026c17f39"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ea2ca984130372db3d7f467da97b72a486431ae","unresolved":true,"context_lines":[{"line_number":98,"context_line":"\u003c% @locations.each do |loc| %\u003e"},{"line_number":99,"context_line":"  \u003cLocation \"\u003c%\u003d loc[\u0027url\u0027] %\u003e\"\u003e"},{"line_number":100,"context_line":"    AuthType \"\u003c%\u003d loc[\u0027authtype\u0027] %\u003e\""},{"line_number":101,"context_line":"    \u003c% if loc[\u0027oidcdiscoverurl\u0027] %\u003eOIDCDiscoverURL \u003c%\u003d loc[\u0027oidcdiscoverurl\u0027] %\u003e\u003c% end %\u003e"},{"line_number":102,"context_line":"    Require \u003c%\u003d loc[\u0027requireoidc\u0027] %\u003e"},{"line_number":103,"context_line":"    \u003c% if loc[\u0027loglevel\u0027] %\u003eLogLevel \u003c%\u003d loc[\u0027loglevel\u0027] %\u003e\u003c% end %\u003e"},{"line_number":104,"context_line":"  \u003c/Location\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"af41b90c_56e1564e","line":101,"range":{"start_line":101,"start_character":4,"end_line":101,"end_character":89},"updated":"2024-07-03 06:22:13.000000000","message":"This may result in additional spaces here in case oidcdiscoverurl is not set.","commit_id":"50398f815d83486c41d585a602b39e9026c17f39"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4a518eb77f9649770be34d7be3e1a54684afc1ae","unresolved":false,"context_lines":[{"line_number":98,"context_line":"\u003c% @locations.each do |loc| %\u003e"},{"line_number":99,"context_line":"  \u003cLocation \"\u003c%\u003d loc[\u0027url\u0027] %\u003e\"\u003e"},{"line_number":100,"context_line":"    AuthType \"\u003c%\u003d loc[\u0027authtype\u0027] %\u003e\""},{"line_number":101,"context_line":"    \u003c% if loc[\u0027oidcdiscoverurl\u0027] %\u003eOIDCDiscoverURL \u003c%\u003d loc[\u0027oidcdiscoverurl\u0027] %\u003e\u003c% end %\u003e"},{"line_number":102,"context_line":"    Require \u003c%\u003d loc[\u0027requireoidc\u0027] %\u003e"},{"line_number":103,"context_line":"    \u003c% if loc[\u0027loglevel\u0027] %\u003eLogLevel \u003c%\u003d loc[\u0027loglevel\u0027] %\u003e\u003c% end %\u003e"},{"line_number":104,"context_line":"  \u003c/Location\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"98f031a8_ddfbd495","line":101,"range":{"start_line":101,"start_character":4,"end_line":101,"end_character":89},"in_reply_to":"a293f653_dc013e17","updated":"2024-07-17 11:54:23.000000000","message":"Done","commit_id":"50398f815d83486c41d585a602b39e9026c17f39"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"ee34cc37e8965f011ec056466603c570d6c29ef7","unresolved":true,"context_lines":[{"line_number":98,"context_line":"\u003c% @locations.each do |loc| %\u003e"},{"line_number":99,"context_line":"  \u003cLocation \"\u003c%\u003d loc[\u0027url\u0027] %\u003e\"\u003e"},{"line_number":100,"context_line":"    AuthType \"\u003c%\u003d loc[\u0027authtype\u0027] %\u003e\""},{"line_number":101,"context_line":"    \u003c% if loc[\u0027oidcdiscoverurl\u0027] %\u003eOIDCDiscoverURL \u003c%\u003d loc[\u0027oidcdiscoverurl\u0027] %\u003e\u003c% end %\u003e"},{"line_number":102,"context_line":"    Require \u003c%\u003d loc[\u0027requireoidc\u0027] %\u003e"},{"line_number":103,"context_line":"    \u003c% if loc[\u0027loglevel\u0027] %\u003eLogLevel \u003c%\u003d loc[\u0027loglevel\u0027] %\u003e\u003c% end %\u003e"},{"line_number":104,"context_line":"  \u003c/Location\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"a293f653_dc013e17","line":101,"range":{"start_line":101,"start_character":4,"end_line":101,"end_character":89},"in_reply_to":"af41b90c_56e1564e","updated":"2024-07-04 10:22:20.000000000","message":"It prints an empty line, what is the proper way to avoid this?","commit_id":"50398f815d83486c41d585a602b39e9026c17f39"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ea2ca984130372db3d7f467da97b72a486431ae","unresolved":true,"context_lines":[{"line_number":100,"context_line":"    AuthType \"\u003c%\u003d loc[\u0027authtype\u0027] %\u003e\""},{"line_number":101,"context_line":"    \u003c% if loc[\u0027oidcdiscoverurl\u0027] %\u003eOIDCDiscoverURL \u003c%\u003d loc[\u0027oidcdiscoverurl\u0027] %\u003e\u003c% end %\u003e"},{"line_number":102,"context_line":"    Require \u003c%\u003d loc[\u0027requireoidc\u0027] %\u003e"},{"line_number":103,"context_line":"    \u003c% if loc[\u0027loglevel\u0027] %\u003eLogLevel \u003c%\u003d loc[\u0027loglevel\u0027] %\u003e\u003c% end %\u003e"},{"line_number":104,"context_line":"  \u003c/Location\u003e"},{"line_number":105,"context_line":"\u003c% end %\u003e"},{"line_number":106,"context_line":"\u003c% end %\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"58c50691_d475ca56","line":103,"updated":"2024-07-03 06:22:13.000000000","message":"ditto","commit_id":"50398f815d83486c41d585a602b39e9026c17f39"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4a518eb77f9649770be34d7be3e1a54684afc1ae","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    AuthType \"\u003c%\u003d loc[\u0027authtype\u0027] %\u003e\""},{"line_number":101,"context_line":"    \u003c% if loc[\u0027oidcdiscoverurl\u0027] %\u003eOIDCDiscoverURL \u003c%\u003d loc[\u0027oidcdiscoverurl\u0027] %\u003e\u003c% end %\u003e"},{"line_number":102,"context_line":"    Require \u003c%\u003d loc[\u0027requireoidc\u0027] %\u003e"},{"line_number":103,"context_line":"    \u003c% if loc[\u0027loglevel\u0027] %\u003eLogLevel \u003c%\u003d loc[\u0027loglevel\u0027] %\u003e\u003c% end %\u003e"},{"line_number":104,"context_line":"  \u003c/Location\u003e"},{"line_number":105,"context_line":"\u003c% end %\u003e"},{"line_number":106,"context_line":"\u003c% end %\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"e4730062_0af24ea5","line":103,"in_reply_to":"58c50691_d475ca56","updated":"2024-07-17 11:54:23.000000000","message":"Done","commit_id":"50398f815d83486c41d585a602b39e9026c17f39"}]}