)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3384a3bd92613d305ff21696398c9cbd730fe5c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"11b20801_c552e2d6","updated":"2025-02-19 14:22:02.000000000","message":"Adjusted the pattern to reject empty strings/arrays.","commit_id":"5e6b933e63582fdcf900858afec35fda6713c2e7"}],"manifests/federation/openidc.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"19374238eeb122bd65dfe4b07acf295427b54481","unresolved":true,"context_lines":[{"line_number":182,"context_line":"  Optional[Stdlib::Unixpath] $openidc_metadata_dir         \u003d undef,"},{"line_number":183,"context_line":"  $openidc_crypto_passphrase                               \u003d \u0027openstack\u0027,"},{"line_number":184,"context_line":"  $openidc_response_type                                   \u003d \u0027id_token\u0027,"},{"line_number":185,"context_line":"  String $openidc_scope                                    \u003d \u0027openid email profile\u0027,"},{"line_number":186,"context_line":"  $openidc_response_mode                                   \u003d undef,"},{"line_number":187,"context_line":"  $openidc_cache_type                                      \u003d undef,"},{"line_number":188,"context_line":"  $openidc_cache_shm_max                                   \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"2984f02a_23e5453c","line":185,"range":{"start_line":185,"start_character":10,"end_line":185,"end_character":23},"updated":"2025-02-18 09:24:17.000000000","message":"Maybe we can also accept an array like `Variant[String[1], Array[String[1], 1]]` (or `Variant[String, Array[String]] for simplicity`) and then concat the items with \u0027 \u0027 ?","commit_id":"f8210a7431b7169e6dbd6ec690423a6ed6c009ea"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"9ab9d237063c2c60e78732bf08203f9cf9b3e8f5","unresolved":true,"context_lines":[{"line_number":182,"context_line":"  Optional[Stdlib::Unixpath] $openidc_metadata_dir         \u003d undef,"},{"line_number":183,"context_line":"  $openidc_crypto_passphrase                               \u003d \u0027openstack\u0027,"},{"line_number":184,"context_line":"  $openidc_response_type                                   \u003d \u0027id_token\u0027,"},{"line_number":185,"context_line":"  String $openidc_scope                                    \u003d \u0027openid email profile\u0027,"},{"line_number":186,"context_line":"  $openidc_response_mode                                   \u003d undef,"},{"line_number":187,"context_line":"  $openidc_cache_type                                      \u003d undef,"},{"line_number":188,"context_line":"  $openidc_cache_shm_max                                   \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"299ff5a2_3d61bcf1","line":185,"range":{"start_line":185,"start_character":10,"end_line":185,"end_character":23},"in_reply_to":"2984f02a_23e5453c","updated":"2025-02-18 10:02:55.000000000","message":"Done, could you check concat syntax?","commit_id":"f8210a7431b7169e6dbd6ec690423a6ed6c009ea"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"54a9e55d77bdda5f62ea96aae2eba0fe4f12f673","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  Optional[Stdlib::Unixpath] $openidc_metadata_dir         \u003d undef,"},{"line_number":183,"context_line":"  $openidc_crypto_passphrase                               \u003d \u0027openstack\u0027,"},{"line_number":184,"context_line":"  $openidc_response_type                                   \u003d \u0027id_token\u0027,"},{"line_number":185,"context_line":"  String $openidc_scope                                    \u003d \u0027openid email profile\u0027,"},{"line_number":186,"context_line":"  $openidc_response_mode                                   \u003d undef,"},{"line_number":187,"context_line":"  $openidc_cache_type                                      \u003d undef,"},{"line_number":188,"context_line":"  $openidc_cache_shm_max                                   \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"49cf76ef_55d65382","line":185,"range":{"start_line":185,"start_character":10,"end_line":185,"end_character":23},"in_reply_to":"299ff5a2_3d61bcf1","updated":"2025-02-19 11:15:59.000000000","message":"Done","commit_id":"f8210a7431b7169e6dbd6ec690423a6ed6c009ea"}],"spec/classes/keystone_federation_openidc_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2885bfb812aa8aaa81a66edc5ebf9ef33b7aa146","unresolved":true,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    it { is_expected.to contain_class(\u0027apache::mod::auth_openidc\u0027) }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    context \u0027with only required parameters\u0027 do"},{"line_number":76,"context_line":"      it \u0027should have basic params for openidc in Keystone configuration\u0027 do"},{"line_number":77,"context_line":"        is_expected.to contain_keystone_config(\u0027auth/methods\u0027).with_value(\u0027password, token, openid\u0027)"},{"line_number":78,"context_line":"        is_expected.to contain_keystone_config(\u0027openid/remote_id_attribute\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"20b21483_6b30463d","line":75,"range":{"start_line":75,"start_character":13,"end_line":75,"end_character":42},"updated":"2025-02-18 10:08:24.000000000","message":"Can you add an assertion to make sure that OIDCScope is configured with the default values ?","commit_id":"92cad1195414054071dcde0747984eb7b9805937"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"124e3aed57053c878b7bb04e1ee59dc9ca3b92fa","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    it { is_expected.to contain_class(\u0027apache::mod::auth_openidc\u0027) }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    context \u0027with only required parameters\u0027 do"},{"line_number":76,"context_line":"      it \u0027should have basic params for openidc in Keystone configuration\u0027 do"},{"line_number":77,"context_line":"        is_expected.to contain_keystone_config(\u0027auth/methods\u0027).with_value(\u0027password, token, openid\u0027)"},{"line_number":78,"context_line":"        is_expected.to contain_keystone_config(\u0027openid/remote_id_attribute\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"20a5be69_960847cb","line":75,"range":{"start_line":75,"start_character":13,"end_line":75,"end_character":42},"in_reply_to":"1cc0438d_782dfe37","updated":"2025-02-18 13:57:52.000000000","message":"Done","commit_id":"92cad1195414054071dcde0747984eb7b9805937"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"3069860795d86b91dc20873226d627f9613091db","unresolved":true,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    it { is_expected.to contain_class(\u0027apache::mod::auth_openidc\u0027) }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    context \u0027with only required parameters\u0027 do"},{"line_number":76,"context_line":"      it \u0027should have basic params for openidc in Keystone configuration\u0027 do"},{"line_number":77,"context_line":"        is_expected.to contain_keystone_config(\u0027auth/methods\u0027).with_value(\u0027password, token, openid\u0027)"},{"line_number":78,"context_line":"        is_expected.to contain_keystone_config(\u0027openid/remote_id_attribute\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1cc0438d_782dfe37","line":75,"range":{"start_line":75,"start_character":13,"end_line":75,"end_character":42},"in_reply_to":"20b21483_6b30463d","updated":"2025-02-18 10:21:32.000000000","message":"Yes, sure","commit_id":"92cad1195414054071dcde0747984eb7b9805937"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"124e3aed57053c878b7bb04e1ee59dc9ca3b92fa","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        is_expected.to contain_keystone_config(\u0027auth/methods\u0027).with_value(\u0027password, token, openid\u0027)"},{"line_number":78,"context_line":"        is_expected.to contain_keystone_config(\u0027openid/remote_id_attribute\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":79,"context_line":"        content \u003d get_param(\u0027concat::fragment\u0027, \u0027keystone_wsgi-configure_openidc_keystone\u0027, \u0027content\u0027)"},{"line_number":80,"context_line":"        expect(content).to match(\u0027OIDCScope \"openid email profile\"\u0027)"},{"line_number":81,"context_line":"      end"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"      it { is_expected.to contain_apache__vhost__fragment(\u0027configure_openidc_keystone\u0027).with({"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"e056ef4b_f1d017a6","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":68},"updated":"2025-02-18 13:57:52.000000000","message":"You can add this to the block of L91-96 instead.","commit_id":"b10b36c484740dfb350b33844fab8ae1708c54ea"}],"templates/openidc.conf.erb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2885bfb812aa8aaa81a66edc5ebf9ef33b7aa146","unresolved":true,"context_lines":[{"line_number":1,"context_line":"  OIDCClaimPrefix \"OIDC-\""},{"line_number":2,"context_line":"  OIDCResponseType \"\u003c%\u003d scope[\u0027keystone::federation::openidc::openidc_response_type\u0027]-%\u003e\""},{"line_number":3,"context_line":"  OIDCScope \"\u003c%\u003d scope[\u0027keystone::federation::openidc::openidc_scope\u0027].join(\u0027, \u0027)-%\u003e\""},{"line_number":4,"context_line":"\u003c%- if scope[\u0027::keystone::federation::openidc::openidc_provider_metadata_url\u0027] !\u003d nil -%\u003e"},{"line_number":5,"context_line":"  OIDCProviderMetadataURL \"\u003c%\u003d scope[\u0027keystone::federation::openidc::openidc_provider_metadata_url\u0027]-%\u003e\""},{"line_number":6,"context_line":"\u003c%- end -%\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"1d36368b_80dfd2ce","line":3,"range":{"start_line":3,"start_character":77,"end_line":3,"end_character":78},"updated":"2025-02-18 10:08:24.000000000","message":"You don\u0027t need \u0027,\u0027 here, right ?\n\nAlso you have to convert a bare string to an array for join. I wonder if we can drop support for a bare string value if it just adds complexity without any benefit (though I know I proposed it).","commit_id":"92cad1195414054071dcde0747984eb7b9805937"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"3069860795d86b91dc20873226d627f9613091db","unresolved":true,"context_lines":[{"line_number":1,"context_line":"  OIDCClaimPrefix \"OIDC-\""},{"line_number":2,"context_line":"  OIDCResponseType \"\u003c%\u003d scope[\u0027keystone::federation::openidc::openidc_response_type\u0027]-%\u003e\""},{"line_number":3,"context_line":"  OIDCScope \"\u003c%\u003d scope[\u0027keystone::federation::openidc::openidc_scope\u0027].join(\u0027, \u0027)-%\u003e\""},{"line_number":4,"context_line":"\u003c%- if scope[\u0027::keystone::federation::openidc::openidc_provider_metadata_url\u0027] !\u003d nil -%\u003e"},{"line_number":5,"context_line":"  OIDCProviderMetadataURL \"\u003c%\u003d scope[\u0027keystone::federation::openidc::openidc_provider_metadata_url\u0027]-%\u003e\""},{"line_number":6,"context_line":"\u003c%- end -%\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"c7022842_d1daa71d","line":3,"range":{"start_line":3,"start_character":77,"end_line":3,"end_character":78},"in_reply_to":"1d36368b_80dfd2ce","updated":"2025-02-18 10:21:32.000000000","message":"My bad, yes, scopes are not divided by commas, only enclosed in double quotes. As it\u0027s a new parameter and there is no backwards compatibility required, maybe we can just keep it to an array of strings?","commit_id":"92cad1195414054071dcde0747984eb7b9805937"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"124e3aed57053c878b7bb04e1ee59dc9ca3b92fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"  OIDCClaimPrefix \"OIDC-\""},{"line_number":2,"context_line":"  OIDCResponseType \"\u003c%\u003d scope[\u0027keystone::federation::openidc::openidc_response_type\u0027]-%\u003e\""},{"line_number":3,"context_line":"  OIDCScope \"\u003c%\u003d scope[\u0027keystone::federation::openidc::openidc_scope\u0027].join(\u0027, \u0027)-%\u003e\""},{"line_number":4,"context_line":"\u003c%- if scope[\u0027::keystone::federation::openidc::openidc_provider_metadata_url\u0027] !\u003d nil -%\u003e"},{"line_number":5,"context_line":"  OIDCProviderMetadataURL \"\u003c%\u003d scope[\u0027keystone::federation::openidc::openidc_provider_metadata_url\u0027]-%\u003e\""},{"line_number":6,"context_line":"\u003c%- end -%\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"5b362683_483b48e2","line":3,"range":{"start_line":3,"start_character":77,"end_line":3,"end_character":78},"in_reply_to":"c7022842_d1daa71d","updated":"2025-02-18 13:57:52.000000000","message":"Yeah. Let\u0027s make it simple now.","commit_id":"92cad1195414054071dcde0747984eb7b9805937"}]}