)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"84fa9a41caec4ebd2c9c4d617264b70c44c3c748","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1add702a_b20ff59a","updated":"2025-06-13 05:09:23.000000000","message":"Hi Tobias, please let me know your thoughts on this. There is also a corresponding one in puppet-glance (and will be others once we firm this up).\n\nThe tests are not complete yet, will be good to discuss how you\u0027d like to refactor them, since user / pass are not mandatory if using app creds.","commit_id":"65469d68c8a54392230db0cb513e67d1f9716710"}],"manifests/resource/authtoken.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"535c6b67c342a9dc6fead265a39104f38d9be5ff","unresolved":true,"context_lines":[{"line_number":47,"context_line":"# [*password*]"},{"line_number":48,"context_line":"#   (Required) Password to create for the service user"},{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"# [*application_credential_id*]"},{"line_number":51,"context_line":"#   (Optional) Application credential ID"},{"line_number":52,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027]"},{"line_number":53,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"46c0f13f_fb3837d1","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":29},"updated":"2025-06-16 14:34:24.000000000","message":"Can we use name instead of ID ? Name is predictable but ID is not. Using name would allow us to provide full deployment feature, if we could add a resource type for app credential.","commit_id":"65469d68c8a54392230db0cb513e67d1f9716710"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1e387aacfd90284e55df1883c0979f861fe7aef4","unresolved":false,"context_lines":[{"line_number":237,"context_line":"#"},{"line_number":238,"context_line":"define keystone::resource::authtoken("},{"line_number":239,"context_line":"  $username,"},{"line_number":240,"context_line":"  $password,"},{"line_number":241,"context_line":"  $auth_url,"},{"line_number":242,"context_line":"  $application_credential_id       \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":243,"context_line":"  $application_credential_secret   \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9bdb6a9f_20ae5a23","line":240,"updated":"2025-06-13 15:41:21.000000000","message":"There\u0027s a similar change in another repo where we\u0027re making this not required though it\u0027s missing the check for password or application creds. We should align on a standard way for handle this","commit_id":"65469d68c8a54392230db0cb513e67d1f9716710"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"535c6b67c342a9dc6fead265a39104f38d9be5ff","unresolved":true,"context_lines":[{"line_number":237,"context_line":"#"},{"line_number":238,"context_line":"define keystone::resource::authtoken("},{"line_number":239,"context_line":"  $username,"},{"line_number":240,"context_line":"  $password,"},{"line_number":241,"context_line":"  $auth_url,"},{"line_number":242,"context_line":"  $application_credential_id       \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":243,"context_line":"  $application_credential_secret   \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"53ebf6eb_975c0727","line":240,"in_reply_to":"21eafe8f_8bec8517","updated":"2025-06-16 14:34:24.000000000","message":"+1 to implement the common check within this defined resource type, and let the actual puppet classes to just pass down the parameters.\nWe probably have to make password and application_credential options default to undef, and check if these options are undef to determine whether the parameters are set.","commit_id":"65469d68c8a54392230db0cb513e67d1f9716710"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"7e74f83b68aa79186948ede0af0ef8741f211f95","unresolved":false,"context_lines":[{"line_number":237,"context_line":"#"},{"line_number":238,"context_line":"define keystone::resource::authtoken("},{"line_number":239,"context_line":"  $username,"},{"line_number":240,"context_line":"  $password,"},{"line_number":241,"context_line":"  $auth_url,"},{"line_number":242,"context_line":"  $application_credential_id       \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":243,"context_line":"  $application_credential_secret   \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"21eafe8f_8bec8517","line":240,"in_reply_to":"9bdb6a9f_20ae5a23","updated":"2025-06-14 01:27:50.000000000","message":"are you referring to this corresponding change in puppet-glance? Iaf774e87e6adfec7e75bbfc6a74527f35d808fd0\n\nI feel it\u0027s ultimately puppet-keystone responsibility to check either user/pass or app cred is provided, since it configures `[keystone_authtoken]`; the puppet classes don\u0027t need to know.\n\nWill be good to confirm if this is the way forward. We held off writing more code to handle that until we can have a chat about it, as a bunch of tests will need to be refactored.","commit_id":"65469d68c8a54392230db0cb513e67d1f9716710"}],"spec/defines/keystone_resource_authtoken_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"535c6b67c342a9dc6fead265a39104f38d9be5ff","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  end"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  shared_examples \u0027shared examples\u0027 do"},{"line_number":14,"context_line":"    context \u0027with only required parameters\u0027 do"},{"line_number":15,"context_line":"      it \u0027configures keystone authtoken\u0027 do"},{"line_number":16,"context_line":"        is_expected.to contain_keystone_config(\u0027keystone_authtoken/username\u0027).with_value(\u0027keystone\u0027)"},{"line_number":17,"context_line":"        is_expected.to contain_keystone_config(\u0027keystone_authtoken/password\u0027).with_value(\u0027secret\u0027).with_secret(true)"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fbdb804b_737de18f","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":46},"updated":"2025-06-16 14:34:24.000000000","message":"Please also add test cases to ensure the default values are set.","commit_id":"65469d68c8a54392230db0cb513e67d1f9716710"}]}