)]}'
{"manifests/api.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"656b1822894bda47f2d21ef0cf316cb5efc59ca5","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  $ssl_cert_file                  \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $ssl_key_file                   \u003d $::os_service_default,"},{"line_number":85,"context_line":"  $workers                        \u003d $::os_workers,"},{"line_number":86,"context_line":"  $enable_proxy_headers_parsing   \u003d $::os_service_default,"},{"line_number":87,"context_line":") inherits magnum::params {"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  include magnum::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f560f44_30e3c7a6","line":86,"range":{"start_line":86,"start_character":32,"end_line":86,"end_character":34},"updated":"2020-09-03 03:52:06.000000000","message":"(nit) you can reduce 2 spaces.","commit_id":"6a867571fabc54c8bf03a5569dc80945e6a17541"}],"releasenotes/notes/add_enable_proxy_headers_parsing-294bbf9c4d73a49c.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6ca22d97355e66411d19a478f4373d5eb525ff82","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add configure option enable_proxy_headers_parsing in [oslo_middleware]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_be5de116","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":17},"updated":"2020-09-03 10:47:15.000000000","message":"\"Add configure\" sounds a bit odd to me.\n\nHow about the following description ?\n\nAdd support to configure the enable_proxy_headers_parsing parameter in the oslo_middlware section.\n\nor \n\nAdd support to configure the ``oslo_middlewae/enable_proxy_headers_parsing` parameter.","commit_id":"f4348cb05040f33e224eb736cedf9d9f36d5adc5"}],"spec/classes/magnum_api_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"656b1822894bda47f2d21ef0cf316cb5efc59ca5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      is_expected.to contain_magnum_config(\u0027api/ssl_cert_file\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":59,"context_line":"      is_expected.to contain_magnum_config(\u0027api/ssl_key_file\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":60,"context_line":"      is_expected.to contain_magnum_config(\u0027api/workers\u0027).with_value(facts[:os_workers])"},{"line_number":61,"context_line":"    end"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    context \u0027when overriding parameters\u0027 do"},{"line_number":64,"context_line":"      before :each do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f560f44_f0014f3b","line":61,"updated":"2020-09-03 03:52:06.000000000","message":"Please add a test case to check the default value.","commit_id":"6a867571fabc54c8bf03a5569dc80945e6a17541"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"656b1822894bda47f2d21ef0cf316cb5efc59ca5","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        }"},{"line_number":100,"context_line":"      end"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"      it { is_expected.to contain_magnum_config(\u0027oslo_middleware/enable_proxy_headers_parsing\u0027).with_value(\u0027true\u0027) }"},{"line_number":103,"context_line":"    end"},{"line_number":104,"context_line":"  end"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f560f44_b0e8777c","line":102,"range":{"start_line":102,"start_character":26,"end_line":102,"end_character":96},"updated":"2020-09-03 03:52:06.000000000","message":"It\u0027s better to check that oslo::db is loaded with proper values, instead of checking actual config parameters.\n\nSee\n https://review.opendev.org/#/c/749288/3","commit_id":"6a867571fabc54c8bf03a5569dc80945e6a17541"}]}