)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"99afb0811b4d97928a4d4f9518869ba96460c35f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"12b20053_3a9db964","updated":"2022-09-15 08:04:30.000000000","message":"Could add a release note for this, does this replace any x509 configs that can be set somewhere else that needs to be deprecated or is this all brand new?","commit_id":"ead63faba326cda99ff08d87b6902f92117d0d7f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ed3f647b290c88dade2d74c35c3f65f90f4b6915","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e403f1a0_5af9b404","updated":"2022-09-15 08:33:31.000000000","message":"I agree we better have a release note. It seems any x509 parameters are not supported by this module now so we don\u0027t need any deprecation.\n\nAlso, please consider addressing a few minor format I pointed by inline comments","commit_id":"ead63faba326cda99ff08d87b6902f92117d0d7f"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"831334e80530b899f4d3a9451c949ee99a77f6e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ebcd66ff_8b646546","in_reply_to":"12b20053_3a9db964","updated":"2022-09-15 11:54:32.000000000","message":"Added reno, please feel free to update if it is not up to standard\n\nThis should be brand new, nothing in this module sets [x509] section AFAICT. Not sure how you would want to handle cases where users might define it somewhere else already.","commit_id":"ead63faba326cda99ff08d87b6902f92117d0d7f"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"831334e80530b899f4d3a9451c949ee99a77f6e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"750e3d10_9de7b641","updated":"2022-09-15 11:54:32.000000000","message":"updated, thanks for the reviews!","commit_id":"7c36439ae0ef8d244ad643be55e162f8219ac41f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b2cb6051f2eae49ba5c1b5d88da3157bcc3b6fb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4f7889a0_52ee4f71","updated":"2022-09-16 01:47:36.000000000","message":"Thanks !","commit_id":"4f55ae389def5bd71a54284a3dd3b7717f949710"}],"manifests/x509.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"94109c788769aa64792bca599921a574ece59db0","unresolved":true,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Manages the magnum x509 config"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters:"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*allow_ca*]"},{"line_number":8,"context_line":"#   (optional) Certificate can get the CA flag in x509 extensions."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"13d34b50_ec773ab6","line":5,"range":{"start_line":5,"start_character":6,"end_line":5,"end_character":16},"updated":"2022-09-15 08:35:21.000000000","message":"Also, do you mind adding support for allowed_extensions and allowed_key_usage ? I can add these later but it\u0027d be more simple if we can implement all options by a single change.","commit_id":"ead63faba326cda99ff08d87b6902f92117d0d7f"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"831334e80530b899f4d3a9451c949ee99a77f6e6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Manages the magnum x509 config"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters:"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*allow_ca*]"},{"line_number":8,"context_line":"#   (optional) Certificate can get the CA flag in x509 extensions."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"66c0dc52_a637ddf8","line":5,"range":{"start_line":5,"start_character":6,"end_line":5,"end_character":16},"in_reply_to":"13d34b50_ec773ab6","updated":"2022-09-15 11:54:32.000000000","message":"Done","commit_id":"ead63faba326cda99ff08d87b6902f92117d0d7f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ed3f647b290c88dade2d74c35c3f65f90f4b6915","unresolved":true,"context_lines":[{"line_number":15,"context_line":"# [*rsa_key_size*]"},{"line_number":16,"context_line":"#   (optional) Size of generated private key."},{"line_number":17,"context_line":"#   Defaults to $::os_service_default"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class magnum::x509 ("},{"line_number":21,"context_line":"  $allow_ca         \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ca5c54c4_2c3f9194","line":18,"updated":"2022-09-15 08:33:31.000000000","message":"Please add #","commit_id":"ead63faba326cda99ff08d87b6902f92117d0d7f"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"831334e80530b899f4d3a9451c949ee99a77f6e6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# [*rsa_key_size*]"},{"line_number":16,"context_line":"#   (optional) Size of generated private key."},{"line_number":17,"context_line":"#   Defaults to $::os_service_default"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class magnum::x509 ("},{"line_number":21,"context_line":"  $allow_ca         \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bbcc2548_62eb81f5","line":18,"in_reply_to":"ca5c54c4_2c3f9194","updated":"2022-09-15 11:54:32.000000000","message":"Done","commit_id":"ead63faba326cda99ff08d87b6902f92117d0d7f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ed3f647b290c88dade2d74c35c3f65f90f4b6915","unresolved":true,"context_lines":[{"line_number":16,"context_line":"#   (optional) Size of generated private key."},{"line_number":17,"context_line":"#   Defaults to $::os_service_default"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class magnum::x509 ("},{"line_number":21,"context_line":"  $allow_ca         \u003d $::os_service_default,"},{"line_number":22,"context_line":"  $term_of_validity \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"01cf9b5d_4367174e","line":19,"updated":"2022-09-15 08:33:31.000000000","message":"remove one blank line","commit_id":"ead63faba326cda99ff08d87b6902f92117d0d7f"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"831334e80530b899f4d3a9451c949ee99a77f6e6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#   (optional) Size of generated private key."},{"line_number":17,"context_line":"#   Defaults to $::os_service_default"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class magnum::x509 ("},{"line_number":21,"context_line":"  $allow_ca         \u003d $::os_service_default,"},{"line_number":22,"context_line":"  $term_of_validity \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"0f3fa53d_56f8d312","line":19,"in_reply_to":"01cf9b5d_4367174e","updated":"2022-09-15 11:54:32.000000000","message":"Done","commit_id":"ead63faba326cda99ff08d87b6902f92117d0d7f"}]}