)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"d219b1e9b2499e400d09acbff26bd34b0c6511f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2fadad6f_f9094838","updated":"2024-08-12 14:17:19.000000000","message":"recheck","commit_id":"ea51b0453052024f5072301a66991a752025d024"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"085bb88eccce328fa90b505c37c98f0f5f76de7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9f9dd173_ade5d954","updated":"2024-08-12 15:13:53.000000000","message":"recheck","commit_id":"e1a5d2d73c8ad553169a1f64abba102386abba6f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ff5163f9b61d5cea66c19c56f2bdff68cfe4b53b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1f5e31b2_3ef9eb7b","updated":"2024-08-30 16:09:30.000000000","message":"IIUC the capi_helm driver is not part of the magnum repo. Is that correct ? I wonder if we have any packages available (RDO package or Ubuntu package) to install that additional driver, because current our puppet modules support only package installation.\n\nIf there are no packages available and there is no plan to add ones, we probably should add warning to tell that the driver should be installed additionally by users.","commit_id":"c232951ecb65c0e5d447fded5cca183d0136e783"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"fa3eeea1ae61586e7da9ed39c988c6029805c25b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d37ee64f_65112428","updated":"2024-08-12 16:49:28.000000000","message":"recheck","commit_id":"c232951ecb65c0e5d447fded5cca183d0136e783"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"e1e48d15e4ee8accd45e897ee4c9559a03a349a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"037fea68_f62359c8","in_reply_to":"1f5e31b2_3ef9eb7b","updated":"2024-08-30 16:42:13.000000000","message":"You\u0027re right, there are not yet any packages available (the driver is very new). As far as I know there is work underway for RDO packages.\nI will add a warning.","commit_id":"c232951ecb65c0e5d447fded5cca183d0136e783"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"e1e48d15e4ee8accd45e897ee4c9559a03a349a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2d7dab73_07505e57","updated":"2024-08-30 16:42:13.000000000","message":"Thanks, should all be resolved","commit_id":"797738c1dc89bc8d56a00ded321d26a1c9936491"}],"manifests/capi_helm.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ff5163f9b61d5cea66c19c56f2bdff68cfe4b53b","unresolved":true,"context_lines":[{"line_number":98,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027]"},{"line_number":99,"context_line":"#"},{"line_number":100,"context_line":"class magnum::capi_helm ("},{"line_number":101,"context_line":"  Variant[Stdlib::Absolutepath, Openstacklib::ServiceDefault] $kubeconfig_file     \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":102,"context_line":"  Optional[Hash] $kubeconfig                                                       \u003d undef,"},{"line_number":103,"context_line":"  String[1] $kubeconfig_owner                                                      \u003d \u0027magnum\u0027,"},{"line_number":104,"context_line":"  String[1] $kubeconfig_group                                                      \u003d \u0027magnum\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"49cba58a_e32dd591","line":101,"range":{"start_line":101,"start_character":85,"end_line":101,"end_character":113},"updated":"2024-08-30 16:09:30.000000000","message":"I\u0027d suggest using undef as the default. so that we can use `Optional[Stdlib::Absolutepath]`","commit_id":"c232951ecb65c0e5d447fded5cca183d0136e783"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"e1e48d15e4ee8accd45e897ee4c9559a03a349a3","unresolved":false,"context_lines":[{"line_number":98,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027]"},{"line_number":99,"context_line":"#"},{"line_number":100,"context_line":"class magnum::capi_helm ("},{"line_number":101,"context_line":"  Variant[Stdlib::Absolutepath, Openstacklib::ServiceDefault] $kubeconfig_file     \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":102,"context_line":"  Optional[Hash] $kubeconfig                                                       \u003d undef,"},{"line_number":103,"context_line":"  String[1] $kubeconfig_owner                                                      \u003d \u0027magnum\u0027,"},{"line_number":104,"context_line":"  String[1] $kubeconfig_group                                                      \u003d \u0027magnum\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1ac63878_51fc5848","line":101,"range":{"start_line":101,"start_character":85,"end_line":101,"end_character":113},"in_reply_to":"49cba58a_e32dd591","updated":"2024-08-30 16:42:13.000000000","message":"Done","commit_id":"c232951ecb65c0e5d447fded5cca183d0136e783"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ff5163f9b61d5cea66c19c56f2bdff68cfe4b53b","unresolved":true,"context_lines":[{"line_number":140,"context_line":"  }"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  if $kubeconfig_file !\u003d $facts[\u0027os_service_default\u0027] and $kubeconfig {"},{"line_number":143,"context_line":"    file{ $kubeconfig_file:"},{"line_number":144,"context_line":"      owner   \u003d\u003e $kubeconfig_owner,"},{"line_number":145,"context_line":"      group   \u003d\u003e $kubeconfig_group,"},{"line_number":146,"context_line":"      mode    \u003d\u003e $kubeconfig_mode,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"d2377e8a_ecda580e","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":8},"updated":"2024-08-30 16:09:30.000000000","message":"Please add orders so that this file is created between ``magnum::config::begin`` anchor and ``magnum::config::end`` anchor","commit_id":"c232951ecb65c0e5d447fded5cca183d0136e783"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"e1e48d15e4ee8accd45e897ee4c9559a03a349a3","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  }"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  if $kubeconfig_file !\u003d $facts[\u0027os_service_default\u0027] and $kubeconfig {"},{"line_number":143,"context_line":"    file{ $kubeconfig_file:"},{"line_number":144,"context_line":"      owner   \u003d\u003e $kubeconfig_owner,"},{"line_number":145,"context_line":"      group   \u003d\u003e $kubeconfig_group,"},{"line_number":146,"context_line":"      mode    \u003d\u003e $kubeconfig_mode,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"6f2d1816_461994af","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":8},"in_reply_to":"d2377e8a_ecda580e","updated":"2024-08-30 16:42:13.000000000","message":"right, thanks","commit_id":"c232951ecb65c0e5d447fded5cca183d0136e783"}]}