)]}'
{"manifests/network/nova_network.pp":[{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"09412de475ad213f1db17a8deb6e34224de82ba6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d defnie: manila::network::nova_network"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Setup and configure Nova Networking communication"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9aa53dc9_48b405d0","line":1,"updated":"2015-04-08 17:01:53.000000000","message":"*define","commit_id":"a7959747f94cc16e2e3cda655f90bae94ffab5c4"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"431ca9804d146faf51fc0919aa9fdd77ec9fd47e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"define manila::network::nova_network ("},{"line_number":17,"context_line":"  $share_backend_name                \u003d $name,"},{"line_number":18,"context_line":"  $nova_single_network_plugin_net_id \u003d undef,"},{"line_number":19,"context_line":") {"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aaa499b_b62fc7a0","line":17,"updated":"2015-04-12 23:01:23.000000000","message":"A parameter isn\u0027t required if it has a default value.","commit_id":"b321e185de9d219c78f7b003f5860e0b3c01f4ce"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"431ca9804d146faf51fc0919aa9fdd77ec9fd47e","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"define manila::network::nova_network ("},{"line_number":17,"context_line":"  $share_backend_name                \u003d $name,"},{"line_number":18,"context_line":"  $nova_single_network_plugin_net_id \u003d undef,"},{"line_number":19,"context_line":") {"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  $nova_net_plugin_name \u003d \u0027manila.network.nova_network_plugin.NovaNetworkPlugin\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aaa499b_962ccbac","line":18,"updated":"2015-04-12 23:01:23.000000000","message":"This should be unset instead of set to undef.","commit_id":"b321e185de9d219c78f7b003f5860e0b3c01f4ce"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"679b04cb75f8024bd746d381e3a878dea0524ec7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  $nova_single_network_plugin_net_id,"},{"line_number":14,"context_line":") {"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  $nova_net_plugin_name \u003d \u0027manila.network.nova_network_plugin.NovaNetworkPlugin\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  manila_config {"},{"line_number":19,"context_line":"    \"${name}/network_api_class\":                 value \u003d\u003e $nova_net_plugin_name;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aaa499b_c19b87c8","line":16,"updated":"2015-04-13 21:30:40.000000000","message":"There are two python classes that support Nova networking in Manila. You refer here to one - NovaNetworkPlugin and point to configuration option from another one. So, here is mistake.","commit_id":"9f57e702e38d107e55d332bec591d0b0f2b33285"},{"author":{"_account_id":13084,"name":"Ryan Hefner","email":"rhefner1@gmail.com","username":"rhefner"},"change_message_id":"694147af9b13b80e40fc9c4886a2bf815f46a246","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  $nova_single_network_plugin_net_id,"},{"line_number":14,"context_line":") {"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  $nova_net_plugin_name \u003d \u0027manila.network.nova_network_plugin.NovaNetworkPlugin\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  manila_config {"},{"line_number":19,"context_line":"    \"${name}/network_api_class\":                 value \u003d\u003e $nova_net_plugin_name;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aaa499b_81357f47","line":16,"in_reply_to":"7aaa499b_a1099b97","updated":"2015-04-13 21:44:18.000000000","message":"Got it. Thanks!","commit_id":"9f57e702e38d107e55d332bec591d0b0f2b33285"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"66d6e0fb20944a42307fd966cea2a4396ca1deab","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  $nova_single_network_plugin_net_id,"},{"line_number":14,"context_line":") {"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  $nova_net_plugin_name \u003d \u0027manila.network.nova_network_plugin.NovaNetworkPlugin\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  manila_config {"},{"line_number":19,"context_line":"    \"${name}/network_api_class\":                 value \u003d\u003e $nova_net_plugin_name;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aaa499b_a1099b97","line":16,"in_reply_to":"7aaa499b_a194fb36","updated":"2015-04-13 21:42:58.000000000","message":"\"NovaNetworkPlugin\" does not use configuration and uses values provided with \"share-network\" object in Manila. So, it can use any amount of networks compared to one that does use config option and uses only one network.","commit_id":"9f57e702e38d107e55d332bec591d0b0f2b33285"},{"author":{"_account_id":13084,"name":"Ryan Hefner","email":"rhefner1@gmail.com","username":"rhefner"},"change_message_id":"73c131899630ac08449d4eab6e7656d8ad198b03","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  $nova_single_network_plugin_net_id,"},{"line_number":14,"context_line":") {"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  $nova_net_plugin_name \u003d \u0027manila.network.nova_network_plugin.NovaNetworkPlugin\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  manila_config {"},{"line_number":19,"context_line":"    \"${name}/network_api_class\":                 value \u003d\u003e $nova_net_plugin_name;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aaa499b_a194fb36","line":16,"in_reply_to":"7aaa499b_c19b87c8","updated":"2015-04-13 21:36:46.000000000","message":"Looks like `NovaSingleNetworkPlugin` is the one that I\u0027m looking for.  What purpose does `NovaNetworkPlugin` have? Given your other comment, I\u0027m assuming that it doesn\u0027t have any config options associated with it?","commit_id":"9f57e702e38d107e55d332bec591d0b0f2b33285"}],"spec/defines/manila_network_nova_network_spec.rb":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"679b04cb75f8024bd746d381e3a878dea0524ec7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    it \u0027configures nova network plugin\u0027 do"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"      is_expected.to contain_manila_config(\"novanet/network_api_class\").with_value("},{"line_number":16,"context_line":"        \u0027manila.network.nova_network_plugin.NovaNetworkPlugin\u0027)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"      params.each_pair do |config,value|"},{"line_number":19,"context_line":"        is_expected.to contain_manila_config(\"novanet/#{config}\").with_value( value )"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7aaa499b_8158dffb","line":16,"updated":"2015-04-13 21:30:40.000000000","message":"This class does not use config options.","commit_id":"9f57e702e38d107e55d332bec591d0b0f2b33285"}]}