)]}'
{"manifests/backend/generic.pp":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"ca2334f1b0496405c92609373cfa97db0e0d7ce1","unresolved":false,"context_lines":[{"line_number":54,"context_line":"#"},{"line_number":55,"context_line":"define manila::backend::generic ("},{"line_number":56,"context_line":"  $share_backend_name               \u003d $name,"},{"line_number":57,"context_line":"  $driver_handles_share_servers     \u003d true,"},{"line_number":58,"context_line":"  $smb_template_config_path         \u003d \u0027$state_path/smb.conf\u0027,"},{"line_number":59,"context_line":"  $volume_name_template             \u003d \u0027manila-share-%s\u0027,"},{"line_number":60,"context_line":"  $volume_snapshot_name_template    \u003d \u0027manila-snapshot-%s\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9aa53dc9_a7f04568","line":57,"updated":"2015-04-09 10:15:01.000000000","message":"Should be set to nothing if this parameter is really required as documented above!","commit_id":"f0e11b1df39dcf441264c3cc2ebb3eec3bffa500"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ca916c73b0b7a95492a63bfb9d8f784293be9e68","unresolved":false,"context_lines":[{"line_number":54,"context_line":"#"},{"line_number":55,"context_line":"define manila::backend::generic ("},{"line_number":56,"context_line":"  $share_backend_name               \u003d $name,"},{"line_number":57,"context_line":"  $driver_handles_share_servers     \u003d undef,"},{"line_number":58,"context_line":"  $smb_template_config_path         \u003d \u0027$state_path/smb.conf\u0027,"},{"line_number":59,"context_line":"  $volume_name_template             \u003d \u0027manila-share-%s\u0027,"},{"line_number":60,"context_line":"  $volume_snapshot_name_template    \u003d \u0027manila-snapshot-%s\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aaa499b_56652343","line":57,"updated":"2015-04-12 22:22:04.000000000","message":"If this is a required value, it should come before all the other parameters and not be set to any default value, even undef. https://docs.puppetlabs.com/guides/style_guide.html#display-order-of-parameters","commit_id":"8d1e5766a422cd1b0b8fb6d40b5c8ac9326f190b"}],"manifests/backend/netapp.pp":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"ca2334f1b0496405c92609373cfa97db0e0d7ce1","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  $driver_handles_share_servers          \u003d undef,"},{"line_number":102,"context_line":"  $netapp_transport_type                 \u003d \u0027http\u0027,"},{"line_number":103,"context_line":"  $netapp_login                          \u003d undef,"},{"line_number":104,"context_line":"  $netapp_password                       \u003d undef,"},{"line_number":105,"context_line":"  $netapp_server_hostname                \u003d undef,"},{"line_number":106,"context_line":"  $netapp_storage_family                 \u003d \u0027ontap_cluster\u0027,"},{"line_number":107,"context_line":"  $netapp_server_port                    \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9aa53dc9_67e6bdb1","line":104,"updated":"2015-04-09 10:15:01.000000000","message":"Should be set to false here! and I would use validate_string($netapp_password) to check if the user has set a password!","commit_id":"f0e11b1df39dcf441264c3cc2ebb3eec3bffa500"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"ca2334f1b0496405c92609373cfa97db0e0d7ce1","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  $netapp_port_name_search_pattern       \u003d \u0027(.*)\u0027,"},{"line_number":116,"context_line":"  $netapp_trace_flags                    \u003d undef,"},{"line_number":117,"context_line":") {"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"  $netapp_share_driver \u003d \u0027manila.share.drivers.netapp.common.NetAppDriver\u0027"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  manila_config {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9aa53dc9_47ebb978","line":118,"updated":"2015-04-09 10:15:01.000000000","message":"add validate_string($netapp_password) here!\nLike this, it should fail with a Puppet::ParseError if it\u0027s other than a string!","commit_id":"f0e11b1df39dcf441264c3cc2ebb3eec3bffa500"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ca916c73b0b7a95492a63bfb9d8f784293be9e68","unresolved":false,"context_lines":[{"line_number":88,"context_line":"# \u003d\u003d\u003d Examples"},{"line_number":89,"context_line":"#"},{"line_number":90,"context_line":"#  manila::backend::netapp { \u0027myBackend\u0027:"},{"line_number":91,"context_line":"#    driver_handles_share_servers \u003d\u003e true,"},{"line_number":92,"context_line":"#    netapp_login           \u003d\u003e \u0027clusterAdmin\u0027,"},{"line_number":93,"context_line":"#    netapp_password        \u003d\u003e \u0027password\u0027,"},{"line_number":94,"context_line":"#    netapp_server_hostname \u003d\u003e \u0027netapp.mycorp.com\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aaa499b_76c7ff12","line":91,"updated":"2015-04-12 22:22:04.000000000","message":"Please make the arrows aligned.","commit_id":"8d1e5766a422cd1b0b8fb6d40b5c8ac9326f190b"}],"manifests/init.pp":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"ca2334f1b0496405c92609373cfa97db0e0d7ce1","unresolved":false,"context_lines":[{"line_number":155,"context_line":"#   running commands as root"},{"line_number":156,"context_line":"#"},{"line_number":157,"context_line":"# [*lock_path*]"},{"line_number":158,"context_line":"#   (optional) Location to store Manila locks"},{"line_number":159,"context_line":"#"},{"line_number":160,"context_line":"class manila ("},{"line_number":161,"context_line":"  $sql_connection              \u003d \u0027sqlite:////var/lib/manila/manila.sqlite\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9aa53dc9_87f54158","line":158,"updated":"2015-04-09 10:15:01.000000000","message":"Should add \u0027Defaults to /tmp/manila/manila_locks\u0027 here!","commit_id":"f0e11b1df39dcf441264c3cc2ebb3eec3bffa500"}],"manifests/share/generic.pp":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"ca2334f1b0496405c92609373cfa97db0e0d7ce1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class manila::share::generic ("},{"line_number":55,"context_line":"  $driver_handles_share_servers     \u003d true,"},{"line_number":56,"context_line":"  $smb_template_config_path         \u003d \u0027$state_path/smb.conf\u0027,"},{"line_number":57,"context_line":"  $volume_name_template             \u003d \u0027manila-share-%s\u0027,"},{"line_number":58,"context_line":"  $volume_snapshot_name_template    \u003d \u0027manila-snapshot-%s\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9aa53dc9_e7e3eda2","line":55,"updated":"2015-04-09 10:15:01.000000000","message":"This param should be set to nothing if it\u0027s really a required parameter","commit_id":"f0e11b1df39dcf441264c3cc2ebb3eec3bffa500"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ca916c73b0b7a95492a63bfb9d8f784293be9e68","unresolved":false,"context_lines":[{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class manila::share::generic ("},{"line_number":55,"context_line":"  $driver_handles_share_servers     \u003d undef,"},{"line_number":56,"context_line":"  $smb_template_config_path         \u003d \u0027$state_path/smb.conf\u0027,"},{"line_number":57,"context_line":"  $volume_name_template             \u003d \u0027manila-share-%s\u0027,"},{"line_number":58,"context_line":"  $volume_snapshot_name_template    \u003d \u0027manila-snapshot-%s\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aaa499b_f6db0fec","line":55,"updated":"2015-04-12 22:22:04.000000000","message":"Please leave this value unset instead of setting it to undef, since it\u0027s a required parameter https://docs.puppetlabs.com/guides/style_guide.html#display-order-of-parameters","commit_id":"8d1e5766a422cd1b0b8fb6d40b5c8ac9326f190b"}],"manifests/share/netapp.pp":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"ca2334f1b0496405c92609373cfa97db0e0d7ce1","unresolved":false,"context_lines":[{"line_number":28,"context_line":"# [*netapp_storage_family*]"},{"line_number":29,"context_line":"#   (required) The storage family type used on the storage system; valid"},{"line_number":30,"context_line":"#   values are ontap_cluster for clustered Data ONTAP."},{"line_number":31,"context_line":"#   Defaults to ontap_cluster"},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*netapp_server_port*]"},{"line_number":34,"context_line":"#   (optional) The TCP port to use for communication with the storage system"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9aa53dc9_c7e0e998","line":31,"updated":"2015-04-09 10:15:01.000000000","message":"This one should be Optional as you set a default value!","commit_id":"f0e11b1df39dcf441264c3cc2ebb3eec3bffa500"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ca916c73b0b7a95492a63bfb9d8f784293be9e68","unresolved":false,"context_lines":[{"line_number":81,"context_line":"#"},{"line_number":82,"context_line":"# \u003d\u003d\u003d Examples"},{"line_number":83,"context_line":"#  class { \u0027manila::share::netapp\u0027:"},{"line_number":84,"context_line":"#    driver_handles_share_servers \u003d\u003e true,"},{"line_number":85,"context_line":"#    netapp_login           \u003d\u003e \u0027clusterAdmin\u0027,"},{"line_number":86,"context_line":"#    netapp_password        \u003d\u003e \u0027password\u0027,"},{"line_number":87,"context_line":"#    netapp_server_hostname \u003d\u003e \u0027netapp.mycorp.com\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aaa499b_d6d813f2","line":84,"updated":"2015-04-12 22:22:04.000000000","message":"Arrow alignment","commit_id":"8d1e5766a422cd1b0b8fb6d40b5c8ac9326f190b"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ca916c73b0b7a95492a63bfb9d8f784293be9e68","unresolved":false,"context_lines":[{"line_number":90,"context_line":"#  }"},{"line_number":91,"context_line":"#"},{"line_number":92,"context_line":"class manila::share::netapp ("},{"line_number":93,"context_line":"    $driver_handles_share_servers          \u003d undef,"},{"line_number":94,"context_line":"    $netapp_transport_type                 \u003d \u0027http\u0027,"},{"line_number":95,"context_line":"    $netapp_login                          \u003d undef,"},{"line_number":96,"context_line":"    $netapp_password                       \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aaa499b_b6e587a9","line":93,"updated":"2015-04-12 22:22:04.000000000","message":"Should be unset since it\u0027s required","commit_id":"8d1e5766a422cd1b0b8fb6d40b5c8ac9326f190b"}]}