)]}'
{"manifests/db/sync.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"dbac5a822554bda32470e3f9462bb26cea50e44f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  Exec[\u0027manila-manage db_sync\u0027] ~\u003e Service\u003c| tag \u003d\u003d \u0027manila-service\u0027 |\u003e"},{"line_number":7,"context_line":"  Package\u003c| tag \u003d\u003d \u0027manila-package\u0027 |\u003e ~\u003e Exec[\u0027manila-manage db_sync\u0027]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  Manila_config\u003c||\u003e ~\u003e Exec[\u0027manila-manage db_sync\u0027]"},{"line_number":10,"context_line":"  Manila_config\u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e ~\u003e Exec[\u0027manila-manage db_sync\u0027]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  exec { \u0027manila-manage db_sync\u0027:"},{"line_number":13,"context_line":"    command     \u003d\u003e $::manila::params::db_sync_command,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_7958aa56","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":84},"updated":"2016-07-21 10:50:49.000000000","message":"i guess we can remove one line\n\nManila_config\u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e is included in Manila_config\u003c||\u003e","commit_id":"17fe11006df10878ef392b7375110fdc15a4aa14"},{"author":{"_account_id":22742,"name":"Simon Fowler","email":"simon.fowler@anu.edu.au","username":"sjjfowler"},"change_message_id":"ba90a8b91a35d2fc3bbbb2d12837ca80429f7d92","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  Exec[\u0027manila-manage db_sync\u0027] ~\u003e Service\u003c| tag \u003d\u003d \u0027manila-service\u0027 |\u003e"},{"line_number":7,"context_line":"  Package\u003c| tag \u003d\u003d \u0027manila-package\u0027 |\u003e ~\u003e Exec[\u0027manila-manage db_sync\u0027]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  Manila_config\u003c||\u003e ~\u003e Exec[\u0027manila-manage db_sync\u0027]"},{"line_number":10,"context_line":"  Manila_config\u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e ~\u003e Exec[\u0027manila-manage db_sync\u0027]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  exec { \u0027manila-manage db_sync\u0027:"},{"line_number":13,"context_line":"    command     \u003d\u003e $::manila::params::db_sync_command,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_b4a4e9b9","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":84},"in_reply_to":"dada55a8_7958aa56","updated":"2016-07-21 10:57:37.000000000","message":"I figured it wasn\u0027t really necessary, but this was the constriction used in puppet-cinder.","commit_id":"17fe11006df10878ef392b7375110fdc15a4aa14"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2ce0a40a6d5aa6c182bd749eea371153a4fcff20","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  Exec[\u0027manila-manage db_sync\u0027] ~\u003e Service\u003c| tag \u003d\u003d \u0027manila-service\u0027 |\u003e"},{"line_number":7,"context_line":"  Package\u003c| tag \u003d\u003d \u0027manila-package\u0027 |\u003e ~\u003e Exec[\u0027manila-manage db_sync\u0027]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  Manila_config\u003c||\u003e ~\u003e Exec[\u0027manila-manage db_sync\u0027]"},{"line_number":10,"context_line":"  Manila_config\u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e ~\u003e Exec[\u0027manila-manage db_sync\u0027]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  exec { \u0027manila-manage db_sync\u0027:"},{"line_number":13,"context_line":"    command     \u003d\u003e $::manila::params::db_sync_command,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_92af347c","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":84},"in_reply_to":"dada55a8_b4a4e9b9","updated":"2016-07-21 11:49:59.000000000","message":"Well, after looking on other components, mostly all of them have\n\n  \u003cproject\u003e_config\u003c||\u003e -\u003e Exec[\u0027dbsync\u0027]\n  \u003cproject\u003e_config\u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e ~\u003e Exec[\u0027dbsync\u0027]\n\nSo, just -\u003e not ~\u003e.\n\nBut my point was actually in removing Manila_config\u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e ~\u003e Exec[\u0027manila-manage db_sync\u0027] because Manila_config\u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e is in Manila_config\u003c||\u003e.\n\nAs side question, do we need to re-dbsync if some other parameters (not database/connection) changed?","commit_id":"17fe11006df10878ef392b7375110fdc15a4aa14"}]}