)]}'
{"manifests/backend/hitachi_hnas.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b377a84524304ae17a3f531b0d6db6717d608982","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#   managing share servers. This must be set to false if the driver is to"},{"line_number":11,"context_line":"#   operate without managing share servers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# [*package_ensure*]"},{"line_number":14,"context_line":"#   (optional) Ensure state for package. Defaults to \u0027present\u0027."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# \u003d\u003d\u003d Examples"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a629dbe_ec57d357","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":18},"updated":"2016-11-10 09:47:43.000000000","message":"no such class parameter below","commit_id":"34363d05f89c52f69ed8ea2045201361ec429f37"},{"author":{"_account_id":14963,"name":"Denis Cavalcante","username":"dencaval","inactive":true},"change_message_id":"3340885daeaba840d8ac1c91c76fa552194d0e98","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#   managing share servers. This must be set to false if the driver is to"},{"line_number":11,"context_line":"#   operate without managing share servers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# [*package_ensure*]"},{"line_number":14,"context_line":"#   (optional) Ensure state for package. Defaults to \u0027present\u0027."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# \u003d\u003d\u003d Examples"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a77a97e_5b4b6959","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":18},"in_reply_to":"9a629dbe_ec57d357","updated":"2016-11-22 16:27:08.000000000","message":"Done","commit_id":"34363d05f89c52f69ed8ea2045201361ec429f37"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b377a84524304ae17a3f531b0d6db6717d608982","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  $hds_hnas_ip,"},{"line_number":32,"context_line":"  $hds_hnas_evs_id,"},{"line_number":33,"context_line":"  $hds_hnas_evs_ip,"},{"line_number":34,"context_line":"  $hds_hnas_file_system_name,"},{"line_number":35,"context_line":"  $driver_handles_share_servers \u003d false,"},{"line_number":36,"context_line":"  $share_backend_name           \u003d $name,"},{"line_number":37,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a629dbe_8c72d70f","line":34,"updated":"2016-11-10 09:47:43.000000000","message":"each class parameter should be described in docs section.","commit_id":"34363d05f89c52f69ed8ea2045201361ec429f37"},{"author":{"_account_id":14963,"name":"Denis Cavalcante","username":"dencaval","inactive":true},"change_message_id":"3340885daeaba840d8ac1c91c76fa552194d0e98","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  $hds_hnas_ip,"},{"line_number":32,"context_line":"  $hds_hnas_evs_id,"},{"line_number":33,"context_line":"  $hds_hnas_evs_ip,"},{"line_number":34,"context_line":"  $hds_hnas_file_system_name,"},{"line_number":35,"context_line":"  $driver_handles_share_servers \u003d false,"},{"line_number":36,"context_line":"  $share_backend_name           \u003d $name,"},{"line_number":37,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a77a97e_3baa2dd3","line":34,"in_reply_to":"9a629dbe_8c72d70f","updated":"2016-11-22 16:27:08.000000000","message":"I\u0027ll fix it. thanks for the review.","commit_id":"34363d05f89c52f69ed8ea2045201361ec429f37"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d08aada9c813e912cf0d75ad1a939e210f6c8b1f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  $hitachi_hnas_file_system_name,"},{"line_number":59,"context_line":"  $driver_handles_share_servers \u003d false,"},{"line_number":60,"context_line":"  $share_backend_name           \u003d $name,"},{"line_number":61,"context_line":"  $package_ensure                        \u003d \u0027present\u0027,"},{"line_number":62,"context_line":") {"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  include ::manila::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3a71b18c_dead20ea","line":61,"updated":"2016-12-06 17:38:31.000000000","message":"nit: can you remove the extra space here and line up the \u003d","commit_id":"88e8ed970819064e0e76485a7b2d0d9a3ddbd34d"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"cb13548dde79f215fbef9de1a3af410868281ff3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  $hitachi_hnas_file_system_name,"},{"line_number":59,"context_line":"  $driver_handles_share_servers \u003d false,"},{"line_number":60,"context_line":"  $share_backend_name           \u003d $name,"},{"line_number":61,"context_line":"  $package_ensure                        \u003d \u0027present\u0027,"},{"line_number":62,"context_line":") {"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  include ::manila::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba5201f7_8646174d","line":61,"in_reply_to":"3a71b18c_dead20ea","updated":"2017-01-05 16:03:33.000000000","message":"Done","commit_id":"88e8ed970819064e0e76485a7b2d0d9a3ddbd34d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e426cf2e5465517207ffe4bf9c3ddd57076dece0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    \"${share_backend_name}/hitachi_hnas_file_system_name\":    value \u003d\u003e $hitachi_hnas_file_system_name;"},{"line_number":79,"context_line":"  }"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  package { \u0027nfs-utils\u0027:"},{"line_number":82,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":83,"context_line":"    tag    \u003d\u003e \u0027manila-support-package\u0027,"},{"line_number":84,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba5201f7_f59e2e62","line":81,"updated":"2017-01-09 22:34:09.000000000","message":"So this can\u0027t be defined like this here in this resource because you can have many declarations of it.  Technically if you were going to put it in anything it should go in the class, but I would also recommend using ensure_resource(\u0027package\u0027, \u0027nfs-utils\u0027, { ... }) to prevent duplicated resource definitions as I think it\u0027s included in a few other spots.  Additionally unless you really think you need to specify something other than ensure \u003d\u003e present, I wouldn\u0027t add that in unless required.","commit_id":"8d6c60c706bd40322c7bef7e8a0d3491b2dbcdb7"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"a25f3bb06a1f23577a9401d0fc5a8bf43bb4a973","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    \"${share_backend_name}/hitachi_hnas_file_system_name\":    value \u003d\u003e $hitachi_hnas_file_system_name;"},{"line_number":79,"context_line":"  }"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  package { \u0027nfs-utils\u0027:"},{"line_number":82,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":83,"context_line":"    tag    \u003d\u003e \u0027manila-support-package\u0027,"},{"line_number":84,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba5201f7_6b46c522","line":81,"in_reply_to":"ba5201f7_859f5fb3","updated":"2017-01-10 12:54:55.000000000","message":"Done","commit_id":"8d6c60c706bd40322c7bef7e8a0d3491b2dbcdb7"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6fcfd68427d125d12ef697c66ad51862f7968996","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    \"${share_backend_name}/hitachi_hnas_file_system_name\":    value \u003d\u003e $hitachi_hnas_file_system_name;"},{"line_number":79,"context_line":"  }"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  package { \u0027nfs-utils\u0027:"},{"line_number":82,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":83,"context_line":"    tag    \u003d\u003e \u0027manila-support-package\u0027,"},{"line_number":84,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba5201f7_859f5fb3","line":81,"in_reply_to":"ba5201f7_f59e2e62","updated":"2017-01-10 10:11:10.000000000","message":"+1 for ensure_resource usage.","commit_id":"8d6c60c706bd40322c7bef7e8a0d3491b2dbcdb7"}],"manifests/share/hitachi_hnas.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e426cf2e5465517207ffe4bf9c3ddd57076dece0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    hitachi_hnas_evs_id           \u003d\u003e $hitachi_hnas_evs_id,"},{"line_number":65,"context_line":"    hitachi_hnas_evs_ip           \u003d\u003e $hitachi_hnas_evs_ip,"},{"line_number":66,"context_line":"    hitachi_hnas_file_system_name \u003d\u003e $hitachi_hnas_file_system_name,"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba5201f7_159c9268","line":67,"updated":"2017-01-09 22:34:09.000000000","message":"If you want to manage nfs-utils, i\u0027d put it in here.","commit_id":"8d6c60c706bd40322c7bef7e8a0d3491b2dbcdb7"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6fcfd68427d125d12ef697c66ad51862f7968996","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    hitachi_hnas_evs_id           \u003d\u003e $hitachi_hnas_evs_id,"},{"line_number":65,"context_line":"    hitachi_hnas_evs_ip           \u003d\u003e $hitachi_hnas_evs_ip,"},{"line_number":66,"context_line":"    hitachi_hnas_file_system_name \u003d\u003e $hitachi_hnas_file_system_name,"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba5201f7_c5e16700","line":67,"in_reply_to":"ba5201f7_159c9268","updated":"2017-01-10 10:11:10.000000000","message":"Well, i disagree with putting package here. Because \u0027share\u0027 are classes like some common template - with some hardcoded section. Real resource management is under backend (like it done in cinder too), so i\u0027d like to leave nfs-utils under backend class.","commit_id":"8d6c60c706bd40322c7bef7e8a0d3491b2dbcdb7"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"a25f3bb06a1f23577a9401d0fc5a8bf43bb4a973","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    hitachi_hnas_evs_id           \u003d\u003e $hitachi_hnas_evs_id,"},{"line_number":65,"context_line":"    hitachi_hnas_evs_ip           \u003d\u003e $hitachi_hnas_evs_ip,"},{"line_number":66,"context_line":"    hitachi_hnas_file_system_name \u003d\u003e $hitachi_hnas_file_system_name,"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba5201f7_4b4bc12b","line":67,"in_reply_to":"ba5201f7_c5e16700","updated":"2017-01-10 12:54:55.000000000","message":"I agree with Denis.","commit_id":"8d6c60c706bd40322c7bef7e8a0d3491b2dbcdb7"}],"spec/classes/manila_share_hitachi_hnas_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d08aada9c813e912cf0d75ad1a939e210f6c8b1f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    end"},{"line_number":29,"context_line":"  end"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  context \u0027with provided parameters\u0027 do"},{"line_number":32,"context_line":"    it_configures \u0027hitachi hnas share driver\u0027"},{"line_number":33,"context_line":"  end"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3a71b18c_1eb4f832","line":31,"updated":"2016-12-06 17:38:31.000000000","message":"Should wrap this in an on_supported_os block to properly test multiple OS\u0027s","commit_id":"88e8ed970819064e0e76485a7b2d0d9a3ddbd34d"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"cb13548dde79f215fbef9de1a3af410868281ff3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    end"},{"line_number":29,"context_line":"  end"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  context \u0027with provided parameters\u0027 do"},{"line_number":32,"context_line":"    it_configures \u0027hitachi hnas share driver\u0027"},{"line_number":33,"context_line":"  end"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ba5201f7_8650d7d5","line":31,"in_reply_to":"3a71b18c_1eb4f832","updated":"2017-01-05 16:03:33.000000000","message":"I prefer to leave it as is, after check all related files is easy to see that this is the default way to do it.\n\n[1] https://github.com/openstack/puppet-manila/blob/master/spec/classes/manila_share_netapp_spec.rb#L51","commit_id":"88e8ed970819064e0e76485a7b2d0d9a3ddbd34d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7ad7a6a1b0427a80776348573d47e953a10512ca","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    end"},{"line_number":29,"context_line":"  end"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  context \u0027with provided parameters\u0027 do"},{"line_number":32,"context_line":"    it_configures \u0027hitachi hnas share driver\u0027"},{"line_number":33,"context_line":"  end"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"ba5201f7_d731a75b","line":33,"range":{"start_line":31,"start_character":0,"end_line":33,"end_character":5},"updated":"2017-01-05 17:07:18.000000000","message":"Going back to the previous patch set, this needs to be changed to an on_supported_os block. We are using rspec-puppet-facts for all new tests. if this was an existing update I would not -1 this. As this is new code and we are working towards moving all tests over to rspec-puppet-facts this should be an on_support_os block.  Sorry if I made it seem optional but as we are trying not to include additional tech debt around this, I want to see this switched. \n\nhttps://github.com/openstack/puppet-nova/blob/master/spec/classes/nova_compute_spec.rb#L270-L290","commit_id":"95bee8a4b772e34ae23fb5206fbc7375ead94a84"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c3630b72855495f421a534375c6b498441d1c73c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    end"},{"line_number":29,"context_line":"  end"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  context \u0027with provided parameters\u0027 do"},{"line_number":32,"context_line":"    it_configures \u0027hitachi hnas share driver\u0027"},{"line_number":33,"context_line":"  end"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"ba5201f7_6832dcf3","line":33,"range":{"start_line":31,"start_character":0,"end_line":33,"end_character":5},"in_reply_to":"ba5201f7_d731a75b","updated":"2017-01-05 17:56:47.000000000","message":"Ok, i\u0027ll do.","commit_id":"95bee8a4b772e34ae23fb5206fbc7375ead94a84"}],"spec/defines/manila_backend_hitachi_hnas_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d08aada9c813e912cf0d75ad1a939e210f6c8b1f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  end"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  shared_examples_for \u0027hitachi hnas share driver\u0027 do"},{"line_number":20,"context_line":"    it \u0027configures hitachi nas share driver\u0027 do"},{"line_number":21,"context_line":"      is_expected.to contain_manila_config(\"myhitachinas/share_driver\").with_value("},{"line_number":22,"context_line":"        \u0027manila.share.drivers.hitachi.hds_hnas.HDSHNASDriver\u0027)"},{"line_number":23,"context_line":"      params.each_pair do |config,value|"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3a71b18c_feb81c2c","line":20,"updated":"2016-12-06 17:38:31.000000000","message":"Should wrap these in a context and move the other context blocks in the shared examples so you can use on_support_os to test.  You can see https://review.openstack.org/#/q/topic:rspec-puppet-facts for examples on this","commit_id":"88e8ed970819064e0e76485a7b2d0d9a3ddbd34d"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"cb13548dde79f215fbef9de1a3af410868281ff3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  end"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  shared_examples_for \u0027hitachi hnas share driver\u0027 do"},{"line_number":20,"context_line":"    it \u0027configures hitachi nas share driver\u0027 do"},{"line_number":21,"context_line":"      is_expected.to contain_manila_config(\"myhitachinas/share_driver\").with_value("},{"line_number":22,"context_line":"        \u0027manila.share.drivers.hitachi.hds_hnas.HDSHNASDriver\u0027)"},{"line_number":23,"context_line":"      params.each_pair do |config,value|"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ba5201f7_26748b66","line":20,"in_reply_to":"3a71b18c_feb81c2c","updated":"2017-01-05 16:03:33.000000000","message":"ditto.","commit_id":"88e8ed970819064e0e76485a7b2d0d9a3ddbd34d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7ad7a6a1b0427a80776348573d47e953a10512ca","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    it { is_expected.to raise_error(Puppet::Error, /true is not a string.  It looks to be a TrueClass/) }"},{"line_number":45,"context_line":"  end"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"ba5201f7_97447fb7","line":46,"updated":"2017-01-05 17:07:18.000000000","message":"same this needs on_support_os method of testing.","commit_id":"95bee8a4b772e34ae23fb5206fbc7375ead94a84"}]}