)]}'
{"manifests/api.pp":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"63793bd8c337eea696a4512473d243d1e5dad80e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  $os_region_name               \u003d undef,"},{"line_number":68,"context_line":"  $package_ensure               \u003d \u0027present\u0027,"},{"line_number":69,"context_line":"  $bind_host                    \u003d \u00270.0.0.0\u0027,"},{"line_number":70,"context_line":"  $default_share_type           \u003d undef,"},{"line_number":71,"context_line":"  $enabled                      \u003d true,"},{"line_number":72,"context_line":"  $sync_db                      \u003d true,"},{"line_number":73,"context_line":"  $manage_service               \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba5201f7_5ff87bc3","line":70,"range":{"start_line":70,"start_character":34,"end_line":70,"end_character":39},"updated":"2017-01-05 13:06:56.000000000","message":"Just checking whether this should be \u0027default\u0027.  We want the deployment\u0027s manila.conf to include \u0027default_share_type\u003ddefault\u0027 even though at this stage the share type called \u0027default\u0027 has not been created via a \u0027manila type-create ...\u0027 command.","commit_id":"933d5129ad8d141cd94cec4ac5d8872e68afb83d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"50fcea1a5417f810bfe0c860b67929def5380ce9","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  $os_region_name               \u003d undef,"},{"line_number":68,"context_line":"  $package_ensure               \u003d \u0027present\u0027,"},{"line_number":69,"context_line":"  $bind_host                    \u003d \u00270.0.0.0\u0027,"},{"line_number":70,"context_line":"  $default_share_type           \u003d undef,"},{"line_number":71,"context_line":"  $enabled                      \u003d true,"},{"line_number":72,"context_line":"  $sync_db                      \u003d true,"},{"line_number":73,"context_line":"  $manage_service               \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba5201f7_085dd078","line":70,"updated":"2017-01-05 18:14:23.000000000","message":"This should be $::os_service_default","commit_id":"933d5129ad8d141cd94cec4ac5d8872e68afb83d"},{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"62ec47b6bbf862b24be75bbc2e43a97b34b1e64e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  $os_region_name               \u003d undef,"},{"line_number":68,"context_line":"  $package_ensure               \u003d \u0027present\u0027,"},{"line_number":69,"context_line":"  $bind_host                    \u003d \u00270.0.0.0\u0027,"},{"line_number":70,"context_line":"  $default_share_type           \u003d undef,"},{"line_number":71,"context_line":"  $enabled                      \u003d true,"},{"line_number":72,"context_line":"  $sync_db                      \u003d true,"},{"line_number":73,"context_line":"  $manage_service               \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba5201f7_ecfc0bba","line":70,"in_reply_to":"ba5201f7_085dd078","updated":"2017-01-06 08:20:50.000000000","message":"Done","commit_id":"933d5129ad8d141cd94cec4ac5d8872e68afb83d"},{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"e704206df6df2511f5f458f0891822c2dc128051","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  $os_region_name               \u003d undef,"},{"line_number":68,"context_line":"  $package_ensure               \u003d \u0027present\u0027,"},{"line_number":69,"context_line":"  $bind_host                    \u003d \u00270.0.0.0\u0027,"},{"line_number":70,"context_line":"  $default_share_type           \u003d undef,"},{"line_number":71,"context_line":"  $enabled                      \u003d true,"},{"line_number":72,"context_line":"  $sync_db                      \u003d true,"},{"line_number":73,"context_line":"  $manage_service               \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba5201f7_dfcd4b32","line":70,"range":{"start_line":70,"start_character":34,"end_line":70,"end_character":39},"in_reply_to":"ba5201f7_5ff87bc3","updated":"2017-01-05 13:18:21.000000000","message":"Well, I lean towards setting this \u0027default\u0027 option on higher level (see related patch https://review.openstack.org/#/c/416960/1) rather than on this \"lowest\" level. IMO it\u0027s cleaner to default to service defaults on this level. Though I\u0027m fine to set it here if it will be general preference (though then why not set it directly in the project config default opts?).","commit_id":"933d5129ad8d141cd94cec4ac5d8872e68afb83d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"50fcea1a5417f810bfe0c860b67929def5380ce9","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    }"},{"line_number":138,"context_line":"  }"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  if $default_share_type {"},{"line_number":141,"context_line":"    manila_config {"},{"line_number":142,"context_line":"      \u0027DEFAULT/default_share_type\u0027: value \u003d\u003e $default_share_type;"},{"line_number":143,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba5201f7_2856145c","line":140,"updated":"2017-01-05 18:14:23.000000000","message":"You don\u0027t need this if clause if the default is $::os_service_default.  This is how we traditionally handle these types of settings because $::os_service_default will have the effect of having the configuration item removed from the config file. The problem with these types of if clauses is that in this setup, if someone sets it to \u0027default\u0027 and then in a subseqent run it is undef, then the value is not properly cleared from the configuration file.","commit_id":"933d5129ad8d141cd94cec4ac5d8872e68afb83d"},{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"62ec47b6bbf862b24be75bbc2e43a97b34b1e64e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    }"},{"line_number":138,"context_line":"  }"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  if $default_share_type {"},{"line_number":141,"context_line":"    manila_config {"},{"line_number":142,"context_line":"      \u0027DEFAULT/default_share_type\u0027: value \u003d\u003e $default_share_type;"},{"line_number":143,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba5201f7_4cfef7ae","line":140,"in_reply_to":"ba5201f7_2856145c","updated":"2017-01-06 08:20:50.000000000","message":"Done","commit_id":"933d5129ad8d141cd94cec4ac5d8872e68afb83d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d0f8234db613813f4add4bf323ba695d8e51d88b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# [*default_share_type*]"},{"line_number":26,"context_line":"#   (optional) Name of default share type which is used if user doesn\u0027t"},{"line_number":27,"context_line":"#   set a share type explicitly when creating a share."},{"line_number":28,"context_line":"#   Defaults to undef."},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*enabled*]"},{"line_number":31,"context_line":"#   (optional) The state of the service"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba5201f7_2d02830a","line":28,"updated":"2017-01-06 15:17:07.000000000","message":"default is not undef","commit_id":"a562c952b6f8ad2af93da4cb8758920169e8c793"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d0f8234db613813f4add4bf323ba695d8e51d88b","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"  manila_config {"},{"line_number":126,"context_line":"    \u0027DEFAULT/osapi_share_listen\u0027:      value \u003d\u003e $bind_host;"},{"line_number":127,"context_line":"    \u0027DEFAULT/enabled_share_protocols\u0027: value \u003d\u003e $enabled_share_protocols;"},{"line_number":128,"context_line":"  }"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"  oslo::middleware { \u0027manila_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba5201f7_4d05070f","line":127,"updated":"2017-01-06 15:17:07.000000000","message":"add it here, so we save lines.","commit_id":"a562c952b6f8ad2af93da4cb8758920169e8c793"}]}