)]}'
{"manifests/backend/cephfs.pp":[{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"d2b4248b1fd8d4a7b4636f50aaf286b6d8477a28","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# [*share_backend_name*]"},{"line_number":12,"context_line":"#  (optional) Name of the backend in manila.conf that"},{"line_number":13,"context_line":"#  these settings will reside in"},{"line_number":14,"context_line":"#  Defaults to: cephfs"},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# [*cephfs_conf_path*]"},{"line_number":17,"context_line":"#   (optional) Path to cephfs config."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1f485f77_81ff0833","line":14,"range":{"start_line":14,"start_character":16,"end_line":14,"end_character":22},"updated":"2017-11-15 00:48:47.000000000","message":"maybe \u0027$name\u0027 is better :)","commit_id":"ddf7773a732227002a33cb38f05a0d7a9f1d0a52"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"fd34b41074f03e340b60e29d380ccdce5b57a337","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# [*share_backend_name*]"},{"line_number":12,"context_line":"#  (optional) Name of the backend in manila.conf that"},{"line_number":13,"context_line":"#  these settings will reside in"},{"line_number":14,"context_line":"#  Defaults to: cephfs"},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# [*cephfs_conf_path*]"},{"line_number":17,"context_line":"#   (optional) Path to cephfs config."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1f485f77_ba0fa335","line":14,"range":{"start_line":14,"start_character":16,"end_line":14,"end_character":22},"in_reply_to":"1f485f77_0d07c284","updated":"2017-11-16 04:20:08.000000000","message":"The class title is not CephFS as this is a Puppet defined resource, this means it is *NOT* defined as such:\n\nclass { \"::manila::backend::cephfs\": ... }\n\nHowever, it is defined as the following:\n\nmanila::backend::cephfs { \u0027foo\u0027:\n  driver_handles_share_servers \u003d\u003e false,\n  ...\n}\n\nThis makes $share_backend_name set to $name which is \u0027foo\u0027 in this case and not CephFS, therefore, the review by zhongshengping is correct and what Arne mentioned would be correct if this was a class, but it\u0027s a defined resource. :)","commit_id":"ddf7773a732227002a33cb38f05a0d7a9f1d0a52"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"3022f84aed4cf7a92033d0fe324ef3013ef98fac","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# [*share_backend_name*]"},{"line_number":12,"context_line":"#  (optional) Name of the backend in manila.conf that"},{"line_number":13,"context_line":"#  these settings will reside in"},{"line_number":14,"context_line":"#  Defaults to: cephfs"},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# [*cephfs_conf_path*]"},{"line_number":17,"context_line":"#   (optional) Path to cephfs config."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1f485f77_0d07c284","line":14,"range":{"start_line":14,"start_character":16,"end_line":14,"end_character":22},"in_reply_to":"1f485f77_81ff0833","updated":"2017-11-15 08:13:57.000000000","message":"As the class title is \u0027cephfs\u0027, the current line is correct and avoids an indirection. However, your suggestion may be better in the sense that when this class is copied ever again, this line can stay unchanged this time ;-)\n\nFrom what I see, no other driver has this line, I find it useful though.\n\nI have no strong opinion ... Jan or Tom maybe?","commit_id":"ddf7773a732227002a33cb38f05a0d7a9f1d0a52"}]}
