)]}'
{"manifests/compute/nova.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0a99c23b76afbdf1bafd91137a0428ac09f5c288","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#   (optional) Same as nova_catalog_info, but for admin endpoint."},{"line_number":15,"context_line":"#   Defaults to \u0027compute:nova:adminURL\u0027"},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# [*nova_ca_certificates_file*]"},{"line_number":18,"context_line":"#   (optional) Location of ca certificates file to use for nova client"},{"line_number":19,"context_line":"#   requests."},{"line_number":20,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_7e68cc20","side":"PARENT","line":17,"updated":"2018-11-09 13:27:49.000000000","message":"You can\u0027t just remove/rename parameters. If that\u0027s truly your intention then they\u0027ll need to go through a deprecation period where the parameters are accepted as valid inputs, with a deprecation warning message.","commit_id":"8784790e7128bebc6a8593d2dd9a686a29a990b5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0a99c23b76afbdf1bafd91137a0428ac09f5c288","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"## [*api_microversion*]"},{"line_number":8,"context_line":"# Version of Nova API to be used. (string value)"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*ca_certificates_file*]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_5e3b9034","line":7,"updated":"2018-11-09 13:27:49.000000000","message":"General comments:\n\n- The order of the parameters described in this comment header should match the order in the class declaration (and api_microversion is the last parameter, not the first).\n- Default values should always be listed (see \"Defaults to\" lines)\n- Unless there is a specific reason to default something to undef, the typical default is $::os_service_default.","commit_id":"5da852b21052d05ad3475bc001c56cc3d6186d52"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0a99c23b76afbdf1bafd91137a0428ac09f5c288","unresolved":false,"context_lines":[{"line_number":134,"context_line":"  $password                     \u003d undef,"},{"line_number":135,"context_line":"  $nova_catalog_info         \u003d \u0027compute:nova:publicURL\u0027,"},{"line_number":136,"context_line":"  $nova_catalog_admin_info   \u003d \u0027compute:nova:adminURL\u0027,"},{"line_number":137,"context_line":"  $api_microversion                \u003d \u00272.10\u0027,"},{"line_number":138,"context_line":") {"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  include ::manila::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_bec8a41f","line":137,"updated":"2018-11-09 13:27:49.000000000","message":"This seems unrelated to the updating the auth parameters, and doesn\u0027t seem to be used in the manila_config.","commit_id":"5da852b21052d05ad3475bc001c56cc3d6186d52"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f28fb859e4319ef9adb8d83b4d95c7c4c65a41da","unresolved":false,"context_lines":[{"line_number":134,"context_line":"  $password                     \u003d undef,"},{"line_number":135,"context_line":"  $nova_catalog_info         \u003d \u0027compute:nova:publicURL\u0027,"},{"line_number":136,"context_line":"  $nova_catalog_admin_info   \u003d \u0027compute:nova:adminURL\u0027,"},{"line_number":137,"context_line":"  $api_microversion                \u003d \u00272.10\u0027,"},{"line_number":138,"context_line":") {"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  include ::manila::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_99e13bd1","line":137,"in_reply_to":"3f79a3b5_b647647a","updated":"2018-11-09 20:18:15.000000000","message":"Oh wait, misunderstood your comment. Yes, it has to be added below if needed; I think someone using nova opts will want to override api_microversion, I am unsure if it has to be treated as an \"authentication\" parameter.","commit_id":"5da852b21052d05ad3475bc001c56cc3d6186d52"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee73819f7ec0ddaf7df9ec1030f4760c877e7cf7","unresolved":false,"context_lines":[{"line_number":134,"context_line":"  $password                     \u003d undef,"},{"line_number":135,"context_line":"  $nova_catalog_info         \u003d \u0027compute:nova:publicURL\u0027,"},{"line_number":136,"context_line":"  $nova_catalog_admin_info   \u003d \u0027compute:nova:adminURL\u0027,"},{"line_number":137,"context_line":"  $api_microversion                \u003d \u00272.10\u0027,"},{"line_number":138,"context_line":") {"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  include ::manila::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_b647647a","line":137,"in_reply_to":"3f79a3b5_bec8a41f","updated":"2018-11-09 19:37:13.000000000","message":"It\u0027s used and the default in manila is 2.10, which can be  $::os_service_default \n\nhttps://github.com/openstack/manila/blob/7969d94/manila/compute/nova.py#L37","commit_id":"5da852b21052d05ad3475bc001c56cc3d6186d52"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08bc0dadc2360958f88c1fde48d2498a07f4bbb0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*api_insecure*]"},{"line_number":8,"context_line":"#   Allow to perform insecure SSL requests to nova. (boolean value)"},{"line_number":9,"context_line":"#   Defaults to false"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*insecure*]"},{"line_number":12,"context_line":"#   Verify HTTPS connections. (boolean value)"},{"line_number":13,"context_line":"#   Defaults to false"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*endpoint_type*]"},{"line_number":16,"context_line":"#   Endpoint type to be used with nova client calls. (string value)"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f79a3b5_e25713cc","line":13,"range":{"start_line":7,"start_character":0,"end_line":13,"end_character":21},"updated":"2018-11-15 01:31:03.000000000","message":"These really ought to be one opt \n\n \n\n\"insecure\" here is a keystoneauth1 option - we\u0027re not using keystoneauth1 directly when communicating with nova, we use novaclient - while keystoneauth1 will allow you to override \"insecure\", it is inconsequential because the value of \"api_insecure\" above will override it.\n\n \n\nI will propose a change to manila to deprecate \"api_insecure\" in favor or \"insecure\"\nWith or without that change, this change should only one opt.","commit_id":"78ed45489270ddce2473907e6a91e3cccdcc5758"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08bc0dadc2360958f88c1fde48d2498a07f4bbb0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*endpoint_type*]"},{"line_number":16,"context_line":"#   Endpoint type to be used with nova client calls. (string value)"},{"line_number":17,"context_line":"#   Defaults to \u0027publicURL\u0027"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*auth_strategy*]"},{"line_number":20,"context_line":"#   The strategy to use for auth. Supports noauth, keystone, and"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f79a3b5_a21fdb09","line":17,"range":{"start_line":17,"start_character":16,"end_line":17,"end_character":27},"updated":"2018-11-15 01:31:03.000000000","message":"$::os_service_default","commit_id":"78ed45489270ddce2473907e6a91e3cccdcc5758"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08bc0dadc2360958f88c1fde48d2498a07f4bbb0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#   Endpoint type to be used with nova client calls. (string value)"},{"line_number":17,"context_line":"#   Defaults to \u0027publicURL\u0027"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*auth_strategy*]"},{"line_number":20,"context_line":"#   The strategy to use for auth. Supports noauth, keystone, and"},{"line_number":21,"context_line":"#   deprecated. (string value)"},{"line_number":22,"context_line":"#   Defaults to \u0027keystone\u0027"},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*auth_url*]"},{"line_number":25,"context_line":"#   (optional) Authentication URL (string value)"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f79a3b5_9f6798ed","line":22,"range":{"start_line":19,"start_character":0,"end_line":22,"end_character":26},"updated":"2018-11-15 01:31:03.000000000","message":"this is not a valid option for this section","commit_id":"78ed45489270ddce2473907e6a91e3cccdcc5758"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08bc0dadc2360958f88c1fde48d2498a07f4bbb0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"# [*auth_type*]"},{"line_number":29,"context_line":"#   (optional) Authentication type to load (string value)"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*ca_certificates_file*]"},{"line_number":32,"context_line":"#   (optional) Location of CA certificates file to use for nova client requests."},{"line_number":33,"context_line":"#   (string value)"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*cafile*]"},{"line_number":36,"context_line":"#   (optional) PEM encoded Certificate Authority to use when verifying HTTPs"},{"line_number":37,"context_line":"#   connections. (string value)"},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"# [*certfile*]"},{"line_number":40,"context_line":"#   (optional) PEM encoded client certificate cert file (string value)"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f79a3b5_82197f8c","line":37,"range":{"start_line":31,"start_character":0,"end_line":37,"end_character":31},"updated":"2018-11-15 01:31:03.000000000","message":"Same concern as with \"insecure\" and \"api_insecure\"\n\n \n\n\"ca_certificates_file\" is overriding the keystone session opt \"cafile\" - puppet-manila should only allow configuring one of them, preferably cafile, so that I can go deprecate nova/ca_certificates_file in manila","commit_id":"78ed45489270ddce2473907e6a91e3cccdcc5758"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08bc0dadc2360958f88c1fde48d2498a07f4bbb0","unresolved":false,"context_lines":[{"line_number":102,"context_line":"# [*password*]"},{"line_number":103,"context_line":"#   (optional) User\u0027s password (string value)"},{"line_number":104,"context_line":"#"},{"line_number":105,"context_line":"# [*nova_catalog_info*]"},{"line_number":106,"context_line":"#   (optional) Info to match when looking for nova in the service"},{"line_number":107,"context_line":"#   catalog. Format is : separated values of the form:"},{"line_number":108,"context_line":"#   \u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpoint_type\u003e"},{"line_number":109,"context_line":"#   Defaults to \u0027compute:nova:publicURL\u0027"},{"line_number":110,"context_line":"#"},{"line_number":111,"context_line":"# [*nova_catalog_admin_info*]"},{"line_number":112,"context_line":"#   (optional) Same as nova_catalog_info, but for admin endpoint."},{"line_number":113,"context_line":"#   Defaults to \u0027compute:nova:adminURL\u0027"},{"line_number":114,"context_line":"#"},{"line_number":115,"context_line":"#"},{"line_number":116,"context_line":"class manila::compute::nova ("}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f79a3b5_bf95b433","line":113,"range":{"start_line":105,"start_character":0,"end_line":113,"end_character":39},"updated":"2018-11-15 01:31:03.000000000","message":"These are no longer used by manila. Now a good time to deprecate them here I guess.","commit_id":"78ed45489270ddce2473907e6a91e3cccdcc5758"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08bc0dadc2360958f88c1fde48d2498a07f4bbb0","unresolved":false,"context_lines":[{"line_number":114,"context_line":"#"},{"line_number":115,"context_line":"#"},{"line_number":116,"context_line":"class manila::compute::nova ("},{"line_number":117,"context_line":"  $api_insecure                 \u003d false,"},{"line_number":118,"context_line":"  $insecure                     \u003d false,"},{"line_number":119,"context_line":"  $endpoint_type                \u003d \u0027publicURL\u0027,"},{"line_number":120,"context_line":"  $auth_strategy                \u003d \u0027keystone\u0027,"},{"line_number":121,"context_line":"  $auth_url                     \u003d \u0027http://localhost:5000/\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f79a3b5_1ff5c852","line":118,"range":{"start_line":117,"start_character":0,"end_line":118,"end_character":40},"updated":"2018-11-15 01:31:03.000000000","message":"See concern above.","commit_id":"78ed45489270ddce2473907e6a91e3cccdcc5758"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08bc0dadc2360958f88c1fde48d2498a07f4bbb0","unresolved":false,"context_lines":[{"line_number":116,"context_line":"class manila::compute::nova ("},{"line_number":117,"context_line":"  $api_insecure                 \u003d false,"},{"line_number":118,"context_line":"  $insecure                     \u003d false,"},{"line_number":119,"context_line":"  $endpoint_type                \u003d \u0027publicURL\u0027,"},{"line_number":120,"context_line":"  $auth_strategy                \u003d \u0027keystone\u0027,"},{"line_number":121,"context_line":"  $auth_url                     \u003d \u0027http://localhost:5000/\u0027,"},{"line_number":122,"context_line":"  $auth_type                    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f79a3b5_9f05586b","line":119,"range":{"start_line":119,"start_character":35,"end_line":119,"end_character":44},"updated":"2018-11-15 01:31:03.000000000","message":"$::os_service_default","commit_id":"78ed45489270ddce2473907e6a91e3cccdcc5758"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08bc0dadc2360958f88c1fde48d2498a07f4bbb0","unresolved":false,"context_lines":[{"line_number":117,"context_line":"  $api_insecure                 \u003d false,"},{"line_number":118,"context_line":"  $insecure                     \u003d false,"},{"line_number":119,"context_line":"  $endpoint_type                \u003d \u0027publicURL\u0027,"},{"line_number":120,"context_line":"  $auth_strategy                \u003d \u0027keystone\u0027,"},{"line_number":121,"context_line":"  $auth_url                     \u003d \u0027http://localhost:5000/\u0027,"},{"line_number":122,"context_line":"  $auth_type                    \u003d $::os_service_default,"},{"line_number":123,"context_line":"  $ca_certificates_file         \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f79a3b5_3f1684a3","line":120,"range":{"start_line":120,"start_character":0,"end_line":120,"end_character":45},"updated":"2018-11-15 01:31:03.000000000","message":"Remove, not used in this group","commit_id":"78ed45489270ddce2473907e6a91e3cccdcc5758"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08bc0dadc2360958f88c1fde48d2498a07f4bbb0","unresolved":false,"context_lines":[{"line_number":141,"context_line":"  $user_id                      \u003d $::os_service_default,"},{"line_number":142,"context_line":"  $username                     \u003d \u0027nova\u0027,"},{"line_number":143,"context_line":"  $password                     \u003d $::os_service_default,"},{"line_number":144,"context_line":"  $nova_catalog_info            \u003d \u0027compute:nova:publicURL\u0027,"},{"line_number":145,"context_line":"  $nova_catalog_admin_info      \u003d \u0027compute:nova:adminURL\u0027,"},{"line_number":146,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":147,"context_line":"  $nova_ca_certificates_file    \u003d undef,"},{"line_number":148,"context_line":"  $nova_api_insecure            \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f79a3b5_bf7ff4dc","line":145,"range":{"start_line":144,"start_character":0,"end_line":145,"end_character":58},"updated":"2018-11-15 01:31:03.000000000","message":"See comment above, these can be deprecated as well.","commit_id":"78ed45489270ddce2473907e6a91e3cccdcc5758"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"3575d8f0ca58673ff84f0b916a8f3c5a7009707f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"  $insecure_real \u003d pick($insecure, $nova_api_insecure)"},{"line_number":150,"context_line":"  $cafile_real \u003d pick($cafile, $nova_ca_certificates_file)"},{"line_number":151,"context_line":"  $username_real \u003d pick($username, $nova_admin_username)"},{"line_number":152,"context_line":"  $password_real \u003d pick($password, $nova_admin_password)"},{"line_number":153,"context_line":"  $project_name_real \u003d pick($project_name, $nova_admin_tenant_name)"},{"line_number":154,"context_line":"  $auth_url_real \u003d pick($auth_url, $nova_admin_auth_url)"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"3f79a3b5_c2532508","line":152,"updated":"2018-12-11 15:21:25.000000000","message":"This is failing, for some reason both $password and $nova_admin_password have values and the pick doesn\u0027t work","commit_id":"1cabd2d61faf4daacc6fe7e5122fadb4d4635847"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2f1d4d90fe461a9e17e042392c2bf8c26f508fd0","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    warning(\u0027The nova_admin_auth_url parameter is deprecated, use auth_url instead.\u0027)"},{"line_number":161,"context_line":"  }"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"  $insecure_real \u003d pick($nova_api_insecure, $insecure)"},{"line_number":164,"context_line":"  $cafile_real \u003d pick($nova_ca_certificates_file, $cafile)"},{"line_number":165,"context_line":"  $username_real \u003d pick($nova_admin_username, $username)"},{"line_number":166,"context_line":"  $password_real \u003d pick_default($nova_admin_password, $password)"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"3f79a3b5_be2d59fc","line":163,"updated":"2018-12-18 16:56:59.000000000","message":"these are awesome but we probably want the arguments the other way around so that for example $insecure preveals when given?","commit_id":"47c933b9492feafc82135a22229962af0c7f342e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0d8dbc9747ea42904088f402613f80d834d99c7d","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    warning(\u0027The nova_admin_auth_url parameter is deprecated, use auth_url instead.\u0027)"},{"line_number":161,"context_line":"  }"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"  $insecure_real \u003d pick($nova_api_insecure, $insecure)"},{"line_number":164,"context_line":"  $cafile_real \u003d pick($nova_ca_certificates_file, $cafile)"},{"line_number":165,"context_line":"  $username_real \u003d pick($nova_admin_username, $username)"},{"line_number":166,"context_line":"  $password_real \u003d pick_default($nova_admin_password, $password)"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"3f79a3b5_b9aa5369","line":163,"in_reply_to":"3f79a3b5_be2d59fc","updated":"2018-12-18 17:27:38.000000000","message":"But won\u0027t $insecure always appear to have been given, even when it\u0027s $::os_service_default?","commit_id":"47c933b9492feafc82135a22229962af0c7f342e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#   (optional) Authentication URL"},{"line_number":13,"context_line":"#   Defaults to $::os_service_default"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*token_auth_url*]"},{"line_number":16,"context_line":"#   (Optional) The authentication URL for the nova"},{"line_number":17,"context_line":"#   connection when using the current users token."},{"line_number":18,"context_line":"#   Defaults to $::os_service_default"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# [*auth_type*]"},{"line_number":21,"context_line":"#   (optional) Authentication type to load"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_1d30f3e9","line":18,"range":{"start_line":15,"start_character":0,"end_line":18,"end_character":37},"updated":"2018-12-19 23:44:01.000000000","message":"This is not a valid option for manila\u0027s [nova] config group. This is only a cinder thing. \n\n \n\nDo you mean to introduce a new \"auth_type\" config to the nova section? See [1] for options necessary, I think you can replace this with \"token\" which will work if auth_type is set to \"token\" or \"admin_token\".\n\n[1] https://docs.openstack.org/keystoneauth/latest/plugin-options.html#available-plugins","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#   (optional) Authentication URL"},{"line_number":13,"context_line":"#   Defaults to $::os_service_default"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*token_auth_url*]"},{"line_number":16,"context_line":"#   (Optional) The authentication URL for the nova"},{"line_number":17,"context_line":"#   connection when using the current users token."},{"line_number":18,"context_line":"#   Defaults to $::os_service_default"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# [*auth_type*]"},{"line_number":21,"context_line":"#   (optional) Authentication type to load"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_504ddb35","line":18,"range":{"start_line":15,"start_character":0,"end_line":18,"end_character":37},"in_reply_to":"3f79a3b5_1d30f3e9","updated":"2018-12-20 20:49:14.000000000","message":"Seems that auth_type is deprecated too and that the correct way to do this is to specify nova/auth_plugin, I\u0027ll investigate that.","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9b9ad0af198ab6f5477d4a94fd0780260eacc061","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#   (optional) Authentication URL"},{"line_number":13,"context_line":"#   Defaults to $::os_service_default"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*token_auth_url*]"},{"line_number":16,"context_line":"#   (Optional) The authentication URL for the nova"},{"line_number":17,"context_line":"#   connection when using the current users token."},{"line_number":18,"context_line":"#   Defaults to $::os_service_default"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# [*auth_type*]"},{"line_number":21,"context_line":"#   (optional) Authentication type to load"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_4663e5e0","line":18,"range":{"start_line":15,"start_character":0,"end_line":18,"end_character":37},"in_reply_to":"3f79a3b5_504ddb35","updated":"2018-12-20 21:51:06.000000000","message":"Ah, thanks for looking at this deeply and pointing me to [1]. However, that\u0027s a bug in manila\u0027s config file generation, and the keystone auth plugin parameter is now auth_type (auth_plugin was its deprecated name) [2]\n\n[1] https://docs.openstack.org/manila/rocky/configuration/shared-file-systems/samples/manila.conf.html\n[2] https://github.com/openstack/keystoneauth/blob/6538141/keystoneauth1/loading/conf.py#L16","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":59,"context_line":"#   Defaults to \u0027nova\u0027"},{"line_number":60,"context_line":"#"},{"line_number":61,"context_line":"# [*password*]"},{"line_number":62,"context_line":"#   (optional) User\u0027s password"},{"line_number":63,"context_line":"#   Defaults to undef"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# \u003d\u003d\u003d DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_bd421f93","line":62,"range":{"start_line":62,"start_character":15,"end_line":62,"end_character":30},"updated":"2018-12-19 23:44:01.000000000","message":"Please add: Only required if auth_type has been set to \"password\"","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":59,"context_line":"#   Defaults to \u0027nova\u0027"},{"line_number":60,"context_line":"#"},{"line_number":61,"context_line":"# [*password*]"},{"line_number":62,"context_line":"#   (optional) User\u0027s password"},{"line_number":63,"context_line":"#   Defaults to undef"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# \u003d\u003d\u003d DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_30685f87","line":62,"range":{"start_line":62,"start_character":15,"end_line":62,"end_character":30},"in_reply_to":"3f79a3b5_bd421f93","updated":"2018-12-20 20:49:14.000000000","message":"Done","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":61,"context_line":"# [*password*]"},{"line_number":62,"context_line":"#   (optional) User\u0027s password"},{"line_number":63,"context_line":"#   Defaults to undef"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# \u003d\u003d\u003d DEPRECATED PARAMETERS"},{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"# [*nova_catalog_info*]"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_0f019a5b","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":1},"updated":"2018-12-19 23:44:01.000000000","message":"Since the removal of catalog_info, we use two more options to work with the Keystone Service catalog to determine the right service endpoint to hit. See [1]\n\n\nSo please add:\n\n# [*region_name*]\n#   (optional) Name of nova region to use. Useful if keystone manages more than\n#   one region.\n#   Defaults to $::os_service_default\n#\n# [*endpoint_type*]\n#   (optional) The type of nova endpoint to use when looking up in\n#   the keystone catalog.\n#   Defaults to $::os_service_default\n\n \n\n[1] https://review.openstack.org/#/c/386627/","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":61,"context_line":"# [*password*]"},{"line_number":62,"context_line":"#   (optional) User\u0027s password"},{"line_number":63,"context_line":"#   Defaults to undef"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# \u003d\u003d\u003d DEPRECATED PARAMETERS"},{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"# [*nova_catalog_info*]"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_f03f4707","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":1},"in_reply_to":"3f79a3b5_0f019a5b","updated":"2018-12-20 20:49:14.000000000","message":"Good catch, will add those","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":85,"context_line":"#"},{"line_number":86,"context_line":"# [*nova_admin_username*]"},{"line_number":87,"context_line":"#   (optional) Nova admin username"},{"line_number":88,"context_line":"#   Defaults to undef"},{"line_number":89,"context_line":"#"},{"line_number":90,"context_line":"# [*nova_admin_password*]"},{"line_number":91,"context_line":"#   (optional) Nova admin password"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_fdc6576a","line":88,"range":{"start_line":88,"start_character":16,"end_line":88,"end_character":21},"updated":"2018-12-19 23:44:01.000000000","message":"nit: still \u0027nova\u0027","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9b9ad0af198ab6f5477d4a94fd0780260eacc061","unresolved":false,"context_lines":[{"line_number":85,"context_line":"#"},{"line_number":86,"context_line":"# [*nova_admin_username*]"},{"line_number":87,"context_line":"#   (optional) Nova admin username"},{"line_number":88,"context_line":"#   Defaults to undef"},{"line_number":89,"context_line":"#"},{"line_number":90,"context_line":"# [*nova_admin_password*]"},{"line_number":91,"context_line":"#   (optional) Nova admin password"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_4698c5c8","line":88,"range":{"start_line":88,"start_character":16,"end_line":88,"end_character":21},"in_reply_to":"3f79a3b5_89659b1d","updated":"2018-12-20 21:51:06.000000000","message":"Sure, yes","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":85,"context_line":"#"},{"line_number":86,"context_line":"# [*nova_admin_username*]"},{"line_number":87,"context_line":"#   (optional) Nova admin username"},{"line_number":88,"context_line":"#   Defaults to undef"},{"line_number":89,"context_line":"#"},{"line_number":90,"context_line":"# [*nova_admin_password*]"},{"line_number":91,"context_line":"#   (optional) Nova admin password"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_89659b1d","line":88,"range":{"start_line":88,"start_character":16,"end_line":88,"end_character":21},"in_reply_to":"3f79a3b5_fdc6576a","updated":"2018-12-20 20:49:14.000000000","message":"We are setting all deprecated params to undef so they don\u0027t have precedence over new params.","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":103,"context_line":"class manila::compute::nova ("},{"line_number":104,"context_line":"  $insecure                     \u003d $::os_service_default,"},{"line_number":105,"context_line":"  $auth_url                     \u003d $::os_service_default,"},{"line_number":106,"context_line":"  $token_auth_url               \u003d $::os_service_default,"},{"line_number":107,"context_line":"  $auth_type                    \u003d $::os_service_default,"},{"line_number":108,"context_line":"  $cafile                       \u003d $::os_service_default,"},{"line_number":109,"context_line":"  $certfile                     \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_bd569ff9","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":56},"updated":"2018-12-19 23:44:01.000000000","message":"remove","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9b9ad0af198ab6f5477d4a94fd0780260eacc061","unresolved":false,"context_lines":[{"line_number":103,"context_line":"class manila::compute::nova ("},{"line_number":104,"context_line":"  $insecure                     \u003d $::os_service_default,"},{"line_number":105,"context_line":"  $auth_url                     \u003d $::os_service_default,"},{"line_number":106,"context_line":"  $token_auth_url               \u003d $::os_service_default,"},{"line_number":107,"context_line":"  $auth_type                    \u003d $::os_service_default,"},{"line_number":108,"context_line":"  $cafile                       \u003d $::os_service_default,"},{"line_number":109,"context_line":"  $certfile                     \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_669dc1b7","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":56},"in_reply_to":"3f79a3b5_296ec7fe","updated":"2018-12-20 21:51:06.000000000","message":"and replace with \"token\" :)","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":103,"context_line":"class manila::compute::nova ("},{"line_number":104,"context_line":"  $insecure                     \u003d $::os_service_default,"},{"line_number":105,"context_line":"  $auth_url                     \u003d $::os_service_default,"},{"line_number":106,"context_line":"  $token_auth_url               \u003d $::os_service_default,"},{"line_number":107,"context_line":"  $auth_type                    \u003d $::os_service_default,"},{"line_number":108,"context_line":"  $cafile                       \u003d $::os_service_default,"},{"line_number":109,"context_line":"  $certfile                     \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_296ec7fe","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":56},"in_reply_to":"3f79a3b5_bd569ff9","updated":"2018-12-20 20:49:14.000000000","message":"Done","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  include ::manila::deps"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  if $nova_catalog_info {"},{"line_number":132,"context_line":"    warning(\u0027The nova_catalog_info parameter is deprecated, has no effect and will be removed in the future release.\u0027)"},{"line_number":133,"context_line":"  }"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"  if $nova_catalog_admin_info {"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_dd0b5bc5","line":132,"range":{"start_line":132,"start_character":97,"end_line":132,"end_character":100},"updated":"2018-12-19 23:44:01.000000000","message":"a","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  include ::manila::deps"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  if $nova_catalog_info {"},{"line_number":132,"context_line":"    warning(\u0027The nova_catalog_info parameter is deprecated, has no effect and will be removed in the future release.\u0027)"},{"line_number":133,"context_line":"  }"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"  if $nova_catalog_admin_info {"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_c948738a","line":132,"range":{"start_line":132,"start_character":97,"end_line":132,"end_character":100},"in_reply_to":"3f79a3b5_dd0b5bc5","updated":"2018-12-20 20:49:14.000000000","message":"Done","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  }"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"  if $nova_catalog_admin_info {"},{"line_number":136,"context_line":"    warning(\u0027The nova_catalog_admin_info parameter is deprecated, has no effect and will be removed in the future release.\u0027)"},{"line_number":137,"context_line":"  }"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  if $nova_api_insecure {"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_7dca477b","line":136,"range":{"start_line":136,"start_character":103,"end_line":136,"end_character":106},"updated":"2018-12-19 23:44:01.000000000","message":"a","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  }"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"  if $nova_catalog_admin_info {"},{"line_number":136,"context_line":"    warning(\u0027The nova_catalog_admin_info parameter is deprecated, has no effect and will be removed in the future release.\u0027)"},{"line_number":137,"context_line":"  }"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  if $nova_api_insecure {"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_69391ff8","line":136,"range":{"start_line":136,"start_character":103,"end_line":136,"end_character":106},"in_reply_to":"3f79a3b5_7dca477b","updated":"2018-12-20 20:49:14.000000000","message":"Done","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":141,"context_line":"  }"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  if $nova_ca_certificates_file {"},{"line_number":144,"context_line":"    warning(\u0027The nova_ca_certificates_file is deprecated, use cafile instead.\u0027)"},{"line_number":145,"context_line":"  }"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"  if $nova_admin_username {"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_bd0e9fd6","line":144,"range":{"start_line":144,"start_character":42,"end_line":144,"end_character":43},"updated":"2018-12-19 23:44:01.000000000","message":"parameter","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":141,"context_line":"  }"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  if $nova_ca_certificates_file {"},{"line_number":144,"context_line":"    warning(\u0027The nova_ca_certificates_file is deprecated, use cafile instead.\u0027)"},{"line_number":145,"context_line":"  }"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"  if $nova_admin_username {"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_893efbdf","line":144,"range":{"start_line":144,"start_character":42,"end_line":144,"end_character":43},"in_reply_to":"3f79a3b5_bd0e9fd6","updated":"2018-12-20 20:49:14.000000000","message":"Done","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"  manila_config {"},{"line_number":171,"context_line":"    \u0027nova/insecure\u0027:                     value \u003d\u003e $insecure_real;"},{"line_number":172,"context_line":"    \u0027nova/token_auth_url\u0027:               value \u003d\u003e $token_auth_url;"},{"line_number":173,"context_line":"    \u0027nova/auth_type\u0027:                    value \u003d\u003e $auth_type;"},{"line_number":174,"context_line":"    \u0027nova/cafile\u0027:                       value \u003d\u003e $cafile_real;"},{"line_number":175,"context_line":"    \u0027nova/certfile\u0027:                     value \u003d\u003e $certfile;"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_9dd96328","line":172,"range":{"start_line":172,"start_character":0,"end_line":172,"end_character":66},"updated":"2018-12-19 23:44:01.000000000","message":"not supported by manila, see suggestion regarding \"token\" above","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"  manila_config {"},{"line_number":171,"context_line":"    \u0027nova/insecure\u0027:                     value \u003d\u003e $insecure_real;"},{"line_number":172,"context_line":"    \u0027nova/token_auth_url\u0027:               value \u003d\u003e $token_auth_url;"},{"line_number":173,"context_line":"    \u0027nova/auth_type\u0027:                    value \u003d\u003e $auth_type;"},{"line_number":174,"context_line":"    \u0027nova/cafile\u0027:                       value \u003d\u003e $cafile_real;"},{"line_number":175,"context_line":"    \u0027nova/certfile\u0027:                     value \u003d\u003e $certfile;"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_10d203d1","line":172,"range":{"start_line":172,"start_character":0,"end_line":172,"end_character":66},"in_reply_to":"3f79a3b5_9dd96328","updated":"2018-12-20 20:49:14.000000000","message":"Ditto","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"  if $auth_type \u003d\u003d \u0027password\u0027 {"},{"line_number":182,"context_line":"    manila_config {"},{"line_number":183,"context_line":"      \u0027nova/auth_url\u0027:                     value \u003d\u003e $auth_url_real;"},{"line_number":184,"context_line":"      \u0027nova/username\u0027:                     value \u003d\u003e $username_real;"},{"line_number":185,"context_line":"      \u0027nova/user_domain_name\u0027:             value \u003d\u003e $user_domain_name;"},{"line_number":186,"context_line":"      \u0027nova/password\u0027:                     value \u003d\u003e $password_real, secret \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_3dddafd9","line":183,"range":{"start_line":183,"start_character":0,"end_line":183,"end_character":67},"updated":"2018-12-19 23:44:01.000000000","message":"this is a generic opt, regardless of the auth_type","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"  if $auth_type \u003d\u003d \u0027password\u0027 {"},{"line_number":182,"context_line":"    manila_config {"},{"line_number":183,"context_line":"      \u0027nova/auth_url\u0027:                     value \u003d\u003e $auth_url_real;"},{"line_number":184,"context_line":"      \u0027nova/username\u0027:                     value \u003d\u003e $username_real;"},{"line_number":185,"context_line":"      \u0027nova/user_domain_name\u0027:             value \u003d\u003e $user_domain_name;"},{"line_number":186,"context_line":"      \u0027nova/password\u0027:                     value \u003d\u003e $password_real, secret \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_d0f00b64","line":183,"range":{"start_line":183,"start_character":0,"end_line":183,"end_character":67},"in_reply_to":"3f79a3b5_3dddafd9","updated":"2018-12-20 20:49:14.000000000","message":"True that, moving it out of this if clause","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"17c8933efa8ce239160bc35d750c8b151de12938","unresolved":false,"context_lines":[{"line_number":90,"context_line":"#"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"class manila::compute::nova ("},{"line_number":93,"context_line":"  $insecure                     \u003d $::os_service_default,"},{"line_number":94,"context_line":"  $auth_url                     \u003d $::os_service_default,"},{"line_number":95,"context_line":"  $auth_type                    \u003d $::os_service_default,"},{"line_number":96,"context_line":"  $cafile                       \u003d $::os_service_default,"},{"line_number":97,"context_line":"  $user_domain_name             \u003d \u0027Default\u0027,"},{"line_number":98,"context_line":"  $project_domain_name          \u003d \u0027Default\u0027,"},{"line_number":99,"context_line":"  $project_name                 \u003d \u0027service\u0027,"},{"line_number":100,"context_line":"  $region_name                  \u003d $::os_service_default,"},{"line_number":101,"context_line":"  $endpoint_type                \u003d $::os_service_default,"},{"line_number":102,"context_line":"  $username                     \u003d \u0027nova\u0027,"},{"line_number":103,"context_line":"  $password                     \u003d undef,"},{"line_number":104,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":105,"context_line":"  $nova_catalog_info            \u003d undef,"},{"line_number":106,"context_line":"  $nova_catalog_admin_info      \u003d undef,"},{"line_number":107,"context_line":"  $nova_api_insecure            \u003d undef,"},{"line_number":108,"context_line":"  $nova_ca_certificates_file    \u003d undef,"},{"line_number":109,"context_line":"  $nova_admin_username          \u003d undef,"},{"line_number":110,"context_line":"  $nova_admin_password          \u003d undef,"},{"line_number":111,"context_line":"  $nova_admin_tenant_name       \u003d undef,"},{"line_number":112,"context_line":"  $nova_admin_auth_url          \u003d undef,"},{"line_number":113,"context_line":") {"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  include ::manila::deps"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"1f769fc5_4ff06768","line":112,"range":{"start_line":93,"start_character":0,"end_line":112,"end_character":40},"updated":"2018-12-30 01:07:40.000000000","message":"spacing is not aligned properly","commit_id":"ca40edad141d9154603f061e0fb0a08f3abfab53"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"17c8933efa8ce239160bc35d750c8b151de12938","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    \u0027nova/auth_type\u0027:                    value \u003d\u003e $auth_type;"},{"line_number":160,"context_line":"    \u0027nova/cafile\u0027:                       value \u003d\u003e $cafile_real;"},{"line_number":161,"context_line":"    \u0027nova/region_name\u0027:                  value \u003d\u003e $region_name;"},{"line_number":162,"context_line":"    \u0027nova/endpoint_type\u0027:                value \u003d\u003e $endpoint_type;"},{"line_number":163,"context_line":"    }"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"  if $auth_type \u003d\u003d \u0027password\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"1f769fc5_6ff52357","line":162,"range":{"start_line":162,"start_character":26,"end_line":162,"end_character":41},"updated":"2018-12-30 01:07:40.000000000","message":"spacing on these lines","commit_id":"ca40edad141d9154603f061e0fb0a08f3abfab53"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"17c8933efa8ce239160bc35d750c8b151de12938","unresolved":false,"context_lines":[{"line_number":168,"context_line":"      \u0027nova/user_domain_name\u0027:             value \u003d\u003e $user_domain_name;"},{"line_number":169,"context_line":"      \u0027nova/password\u0027:                     value \u003d\u003e $password_real, secret \u003d\u003e true;"},{"line_number":170,"context_line":"      \u0027nova/project_name\u0027:                 value \u003d\u003e $project_name_real;"},{"line_number":171,"context_line":"      \u0027nova/project_domain_name\u0027:          value \u003d\u003e $project_domain_name;"},{"line_number":172,"context_line":"    }"},{"line_number":173,"context_line":"  }"},{"line_number":174,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"1f769fc5_0fea6f74","line":171,"range":{"start_line":171,"start_character":34,"end_line":171,"end_character":43},"updated":"2018-12-30 01:07:40.000000000","message":"spacing on these lines","commit_id":"ca40edad141d9154603f061e0fb0a08f3abfab53"}],"manifests/network/neutron.pp":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08bc0dadc2360958f88c1fde48d2498a07f4bbb0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: manila::network::neutron"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Setup and configure Nova communication"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f79a3b5_c210d75b","line":3,"range":{"start_line":3,"start_character":22,"end_line":3,"end_character":26},"updated":"2018-11-15 01:31:03.000000000","message":"This is Neutron","commit_id":"78ed45489270ddce2473907e6a91e3cccdcc5758"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08bc0dadc2360958f88c1fde48d2498a07f4bbb0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*api_insecure*]"},{"line_number":8,"context_line":"#   Allow to perform insecure SSL requests to neutron. (boolean value)"},{"line_number":9,"context_line":"#   Defaults to false"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*insecure*]"},{"line_number":12,"context_line":"#   Verify HTTPS connections. (boolean value)"},{"line_number":13,"context_line":"#   Defaults to false"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*endpoint_type*]"},{"line_number":16,"context_line":"#   Endpoint type to be used with neutron client calls. (string value)"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f79a3b5_8202df0c","line":13,"range":{"start_line":7,"start_character":0,"end_line":13,"end_character":21},"updated":"2018-11-15 01:31:03.000000000","message":"same concern as nova","commit_id":"78ed45489270ddce2473907e6a91e3cccdcc5758"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08bc0dadc2360958f88c1fde48d2498a07f4bbb0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*endpoint_type*]"},{"line_number":16,"context_line":"#   Endpoint type to be used with neutron client calls. (string value)"},{"line_number":17,"context_line":"#   Defaults to \u0027publicURL\u0027"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*auth_strategy*]"},{"line_number":20,"context_line":"#   The strategy to use for auth. Supports noauth, keystone, and"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f79a3b5_55331ff9","line":17,"range":{"start_line":17,"start_character":17,"end_line":17,"end_character":26},"updated":"2018-11-15 01:31:03.000000000","message":"$::os_service_default","commit_id":"78ed45489270ddce2473907e6a91e3cccdcc5758"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08bc0dadc2360958f88c1fde48d2498a07f4bbb0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"# [*auth_type*]"},{"line_number":29,"context_line":"#   (optional) Authentication type to load (string value)"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*ca_certificates_file*]"},{"line_number":32,"context_line":"#   (optional) Location of CA certificates file to use for neutron client requests."},{"line_number":33,"context_line":"#   (string value)"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*cafile*]"},{"line_number":36,"context_line":"#   (optional) PEM encoded Certificate Authority to use when verifying HTTPs"},{"line_number":37,"context_line":"#   connections. (string value)"},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"# [*certfile*]"},{"line_number":40,"context_line":"#   (optional) PEM encoded client certificate cert file (string value)"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f79a3b5_3511c351","line":37,"range":{"start_line":31,"start_character":0,"end_line":37,"end_character":31},"updated":"2018-11-15 01:31:03.000000000","message":"same concern as nova","commit_id":"78ed45489270ddce2473907e6a91e3cccdcc5758"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08bc0dadc2360958f88c1fde48d2498a07f4bbb0","unresolved":false,"context_lines":[{"line_number":113,"context_line":"  $url_timeout                  \u003d 30,"},{"line_number":114,"context_line":"  $api_insecure                 \u003d false,"},{"line_number":115,"context_line":"  $insecure                     \u003d false,"},{"line_number":116,"context_line":"  $endpoint_type                \u003d \u0027publicURL\u0027,"},{"line_number":117,"context_line":"  $auth_strategy                \u003d \u0027keystone\u0027,"},{"line_number":118,"context_line":"  $auth_url                     \u003d \u0027http://localhost:5000/\u0027,"},{"line_number":119,"context_line":"  $auth_type                    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f79a3b5_b51e335c","line":116,"range":{"start_line":116,"start_character":34,"end_line":116,"end_character":45},"updated":"2018-11-15 01:31:03.000000000","message":"$::os_service_default","commit_id":"78ed45489270ddce2473907e6a91e3cccdcc5758"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08bc0dadc2360958f88c1fde48d2498a07f4bbb0","unresolved":false,"context_lines":[{"line_number":189,"context_line":"  } else {"},{"line_number":190,"context_line":"   $password_real \u003d $password"},{"line_number":191,"context_line":"  }"},{"line_number":192,"context_line":" "},{"line_number":193,"context_line":"  $neutron_plugin_name \u003d \u0027manila.network.neutron.neutron_network_plugin.NeutronNetworkPlugin\u0027"},{"line_number":194,"context_line":"  manila_config {"},{"line_number":195,"context_line":"    \u0027neutron/url\u0027:                          value \u003d\u003e $url;"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f79a3b5_75309beb","line":192,"range":{"start_line":192,"start_character":0,"end_line":192,"end_character":1},"updated":"2018-11-15 01:31:03.000000000","message":"remove space","commit_id":"78ed45489270ddce2473907e6a91e3cccdcc5758"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6ca8598e7cd3d84ecf6c862fd1a30e6e6b533471","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    warning(\u0027The neutron_admin_tenant_name parameter is deprecated, use project_name instead.\u0027)"},{"line_number":159,"context_line":"  }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  if $neutron_admin_region_name {"},{"line_number":162,"context_line":"    warning(\u0027The neutron_admin_region_name parameter is deprecated, use region_name instead.\u0027)"},{"line_number":163,"context_line":"  }"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":22,"id":"3f79a3b5_994f57c0","line":161,"updated":"2018-12-18 17:37:10.000000000","message":"Looks like this should be $neutron_region_name","commit_id":"47c933b9492feafc82135a22229962af0c7f342e"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2f1d4d90fe461a9e17e042392c2bf8c26f508fd0","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    warning(\u0027The neutron_admin_password parameter is deprecated, use password instead.\u0027)"},{"line_number":171,"context_line":"  }"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"  $insecure_real \u003d pick($neutron_api_insecure, $insecure)"},{"line_number":174,"context_line":"  $auth_url_real \u003d pick($neutron_admin_auth_url, $auth_url)"},{"line_number":175,"context_line":"  $cafile_real \u003d pick($neutron_ca_certificates_file, $cafile)"},{"line_number":176,"context_line":"  $project_name_real \u003d pick($neutron_admin_tenant_name, $project_name)"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"3f79a3b5_5efbe547","line":173,"updated":"2018-12-18 16:56:59.000000000","message":"like nova.pp","commit_id":"47c933b9492feafc82135a22229962af0c7f342e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6ca8598e7cd3d84ecf6c862fd1a30e6e6b533471","unresolved":false,"context_lines":[{"line_number":174,"context_line":"  $auth_url_real \u003d pick($neutron_admin_auth_url, $auth_url)"},{"line_number":175,"context_line":"  $cafile_real \u003d pick($neutron_ca_certificates_file, $cafile)"},{"line_number":176,"context_line":"  $project_name_real \u003d pick($neutron_admin_tenant_name, $project_name)"},{"line_number":177,"context_line":"  $region_name_real \u003d pick($neutron_admin_region_name, $region_name)"},{"line_number":178,"context_line":"  $username_real \u003d pick($neutron_admin_username, $username)"},{"line_number":179,"context_line":"  $password_real \u003d pick_default($neutron_admin_password, $password)"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":22,"id":"3f79a3b5_b9549356","line":177,"updated":"2018-12-18 17:37:10.000000000","message":"ditto here","commit_id":"47c933b9492feafc82135a22229962af0c7f342e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#   (optional) Authentication URL"},{"line_number":13,"context_line":"#   Defaults to $::os_service_default"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*token_auth_url*]"},{"line_number":16,"context_line":"#   (optional) The authentication URL for the neutron"},{"line_number":17,"context_line":"#   connection when using the current users token."},{"line_number":18,"context_line":"#   Defaults to $::os_service_default"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# [*auth_type*]"},{"line_number":21,"context_line":"#   (optional) Authentication type to load"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_7d8c87dd","line":18,"range":{"start_line":15,"start_character":0,"end_line":18,"end_character":37},"updated":"2018-12-19 23:44:01.000000000","message":"this is a cinder thing and won\u0027t work with manila - I think you should introduce \"token\" as an option and remove this.","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#   (optional) Authentication URL"},{"line_number":13,"context_line":"#   Defaults to $::os_service_default"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*token_auth_url*]"},{"line_number":16,"context_line":"#   (optional) The authentication URL for the neutron"},{"line_number":17,"context_line":"#   connection when using the current users token."},{"line_number":18,"context_line":"#   Defaults to $::os_service_default"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# [*auth_type*]"},{"line_number":21,"context_line":"#   (optional) Authentication type to load"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_5092bbfb","line":18,"range":{"start_line":15,"start_character":0,"end_line":18,"end_character":37},"in_reply_to":"3f79a3b5_7d8c87dd","updated":"2018-12-20 20:49:14.000000000","message":"Ditto nova","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":69,"context_line":"# [*network_plugin_ipv6_enabled*]"},{"line_number":70,"context_line":"#   (optional) whether to support IPv6 network resource"},{"line_number":71,"context_line":"#   Defaults to $::os_service_default"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# \u003d\u003d\u003d DEPRECATED PARAMETERS"},{"line_number":74,"context_line":"#"},{"line_number":75,"context_line":"# [*neutron_api_insecure*]"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_ef1bfec8","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":1},"updated":"2018-12-19 23:44:01.000000000","message":"Since the removal of catalog_info, we use one more option to work with the Keystone Service catalog to determine the right service endpoint to hit. See [1]\n\n\nSo please add:\n\n \n\n# [*endpoint_type*]\n#   (optional) The type of neutron endpoint to use when looking up in\n#   the keystone catalog.\n#   Defaults to $::os_service_default\n\n \n\n\n[1] https://review.openstack.org/#/c/386627/","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":69,"context_line":"# [*network_plugin_ipv6_enabled*]"},{"line_number":70,"context_line":"#   (optional) whether to support IPv6 network resource"},{"line_number":71,"context_line":"#   Defaults to $::os_service_default"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# \u003d\u003d\u003d DEPRECATED PARAMETERS"},{"line_number":74,"context_line":"#"},{"line_number":75,"context_line":"# [*neutron_api_insecure*]"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_1080c39c","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":1},"in_reply_to":"3f79a3b5_ef1bfec8","updated":"2018-12-20 20:49:14.000000000","message":"Done","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":91,"context_line":"#"},{"line_number":92,"context_line":"# [*neutron_admin_username*]"},{"line_number":93,"context_line":"#   (optional) username for connecting to neutron in admin context"},{"line_number":94,"context_line":"#   Defaults to undef"},{"line_number":95,"context_line":"#"},{"line_number":96,"context_line":"# [*neutron_admin_password*]"},{"line_number":97,"context_line":"#   (optional) password for connecting to neutron in admin context"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_fd7f37ba","line":94,"range":{"start_line":94,"start_character":16,"end_line":94,"end_character":21},"updated":"2018-12-19 23:44:01.000000000","message":"nit: still defaults to \"neutron\"","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9b9ad0af198ab6f5477d4a94fd0780260eacc061","unresolved":false,"context_lines":[{"line_number":91,"context_line":"#"},{"line_number":92,"context_line":"# [*neutron_admin_username*]"},{"line_number":93,"context_line":"#   (optional) username for connecting to neutron in admin context"},{"line_number":94,"context_line":"#   Defaults to undef"},{"line_number":95,"context_line":"#"},{"line_number":96,"context_line":"# [*neutron_admin_password*]"},{"line_number":97,"context_line":"#   (optional) password for connecting to neutron in admin context"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_26a349ff","line":94,"range":{"start_line":94,"start_character":16,"end_line":94,"end_character":21},"in_reply_to":"3f79a3b5_fd7f37ba","updated":"2018-12-20 21:51:06.000000000","message":"ignore :)","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":118,"context_line":"class manila::network::neutron ("},{"line_number":119,"context_line":"  $insecure                     \u003d $::os_service_default,"},{"line_number":120,"context_line":"  $auth_url                     \u003d $::os_service_default,"},{"line_number":121,"context_line":"  $token_auth_url               \u003d $::os_service_default,"},{"line_number":122,"context_line":"  $auth_type                    \u003d $::os_service_default,"},{"line_number":123,"context_line":"  $cafile                       \u003d $::os_service_default,"},{"line_number":124,"context_line":"  $certfile                     \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_bd853fae","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":56},"updated":"2018-12-19 23:44:01.000000000","message":"replace with \"token\"","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":118,"context_line":"class manila::network::neutron ("},{"line_number":119,"context_line":"  $insecure                     \u003d $::os_service_default,"},{"line_number":120,"context_line":"  $auth_url                     \u003d $::os_service_default,"},{"line_number":121,"context_line":"  $token_auth_url               \u003d $::os_service_default,"},{"line_number":122,"context_line":"  $auth_type                    \u003d $::os_service_default,"},{"line_number":123,"context_line":"  $cafile                       \u003d $::os_service_default,"},{"line_number":124,"context_line":"  $certfile                     \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_f082e7a2","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":56},"in_reply_to":"3f79a3b5_bd853fae","updated":"2018-12-20 20:49:14.000000000","message":"Ditto nova","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":132,"context_line":"  $password                     \u003d undef,"},{"line_number":133,"context_line":"  $network_plugin_ipv4_enabled  \u003d $::os_service_default,"},{"line_number":134,"context_line":"  $network_plugin_ipv6_enabled  \u003d $::os_service_default,"},{"line_number":135,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":136,"context_line":"  $neutron_api_insecure            \u003d undef,"},{"line_number":137,"context_line":"  $neutron_ca_certificates_file    \u003d undef,"},{"line_number":138,"context_line":"  $neutron_admin_username          \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_5d650b1a","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":25},"updated":"2018-12-19 23:44:01.000000000","message":"You\u0027re missing some old opts supported by this module:\n\n1) neutron_url\n2) neutron_url_timeout ---\u003e replaced by \"timeout\"\n3) neutron_auth_strategy\n\n \n\n(1) and (3) will no longer have any effect, but the deprecation warning is probably warranted if someone\u0027s specifying these so they can clean up their scripts.","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":132,"context_line":"  $password                     \u003d undef,"},{"line_number":133,"context_line":"  $network_plugin_ipv4_enabled  \u003d $::os_service_default,"},{"line_number":134,"context_line":"  $network_plugin_ipv6_enabled  \u003d $::os_service_default,"},{"line_number":135,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":136,"context_line":"  $neutron_api_insecure            \u003d undef,"},{"line_number":137,"context_line":"  $neutron_ca_certificates_file    \u003d undef,"},{"line_number":138,"context_line":"  $neutron_admin_username          \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_50ab9b1f","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":25},"in_reply_to":"3f79a3b5_5d650b1a","updated":"2018-12-20 20:49:14.000000000","message":"Good catch, will add these","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":143,"context_line":") {"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  if $neutron_api_insecure {"},{"line_number":146,"context_line":"    warning(\u0027The neutron_api_insecure parameter is deprecated, use api_insecure instead.\u0027)"},{"line_number":147,"context_line":"  }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  if $neutron_admin_auth_url {"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_9dbac36d","line":146,"range":{"start_line":146,"start_character":67,"end_line":146,"end_character":79},"updated":"2018-12-19 23:44:01.000000000","message":"insecure","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":143,"context_line":") {"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  if $neutron_api_insecure {"},{"line_number":146,"context_line":"    warning(\u0027The neutron_api_insecure parameter is deprecated, use api_insecure instead.\u0027)"},{"line_number":147,"context_line":"  }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  if $neutron_admin_auth_url {"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_10a9a324","line":146,"range":{"start_line":146,"start_character":67,"end_line":146,"end_character":79},"in_reply_to":"3f79a3b5_9dbac36d","updated":"2018-12-20 20:49:14.000000000","message":"Done","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":151,"context_line":"  }"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"  if $neutron_ca_certificates_file {"},{"line_number":154,"context_line":"    warning(\u0027The neutron_ca_certificates_file is deprecated, use insecure instead.\u0027)"},{"line_number":155,"context_line":"  }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  if $neutron_admin_tenant_name {"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_fda89722","line":154,"range":{"start_line":154,"start_character":65,"end_line":154,"end_character":73},"updated":"2018-12-19 23:44:01.000000000","message":"ca_file","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":151,"context_line":"  }"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"  if $neutron_ca_certificates_file {"},{"line_number":154,"context_line":"    warning(\u0027The neutron_ca_certificates_file is deprecated, use insecure instead.\u0027)"},{"line_number":155,"context_line":"  }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  if $neutron_admin_tenant_name {"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_f09bc706","line":154,"range":{"start_line":154,"start_character":65,"end_line":154,"end_character":73},"in_reply_to":"3f79a3b5_fda89722","updated":"2018-12-20 20:49:14.000000000","message":"Done","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":183,"context_line":"  manila_config {"},{"line_number":184,"context_line":"    \u0027DEFAULT/network_api_class\u0027:            value \u003d\u003e $neutron_plugin_name;"},{"line_number":185,"context_line":"    \u0027neutron/insecure\u0027:                     value \u003d\u003e $insecure_real;"},{"line_number":186,"context_line":"    \u0027neutron/token_auth_url\u0027:               value \u003d\u003e $token_auth_url;"},{"line_number":187,"context_line":"    \u0027neutron/auth_type\u0027:                    value \u003d\u003e $auth_type;"},{"line_number":188,"context_line":"    \u0027neutron/cafile\u0027:                       value \u003d\u003e $cafile_real;"},{"line_number":189,"context_line":"    \u0027neutron/certfile\u0027:                     value \u003d\u003e $certfile;"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_afed0688","line":186,"range":{"start_line":186,"start_character":0,"end_line":186,"end_character":69},"updated":"2018-12-19 23:44:01.000000000","message":"remove/replace with neutron/token","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":183,"context_line":"  manila_config {"},{"line_number":184,"context_line":"    \u0027DEFAULT/network_api_class\u0027:            value \u003d\u003e $neutron_plugin_name;"},{"line_number":185,"context_line":"    \u0027neutron/insecure\u0027:                     value \u003d\u003e $insecure_real;"},{"line_number":186,"context_line":"    \u0027neutron/token_auth_url\u0027:               value \u003d\u003e $token_auth_url;"},{"line_number":187,"context_line":"    \u0027neutron/auth_type\u0027:                    value \u003d\u003e $auth_type;"},{"line_number":188,"context_line":"    \u0027neutron/cafile\u0027:                       value \u003d\u003e $cafile_real;"},{"line_number":189,"context_line":"    \u0027neutron/certfile\u0027:                     value \u003d\u003e $certfile;"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_905a935a","line":186,"range":{"start_line":186,"start_character":0,"end_line":186,"end_character":69},"in_reply_to":"3f79a3b5_afed0688","updated":"2018-12-20 20:49:14.000000000","message":"Ditto nova","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    \u0027neutron/keyfile\u0027:                      value \u003d\u003e $keyfile;"},{"line_number":191,"context_line":"    \u0027neutron/region_name\u0027:                  value \u003d\u003e $region_name_real;"},{"line_number":192,"context_line":"    \u0027neutron/timeout\u0027:                      value \u003d\u003e $timeout;"},{"line_number":193,"context_line":"    \u0027neutron/network_plugin_ipv4_enabled\u0027:  value \u003d\u003e $network_plugin_ipv4_enabled;"},{"line_number":194,"context_line":"    \u0027neutron/network_plugin_ipv6_enabled\u0027:  value \u003d\u003e $network_plugin_ipv6_enabled;"},{"line_number":195,"context_line":"    }"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"  if $auth_type \u003d\u003d \u0027password\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_6fc36e06","line":194,"range":{"start_line":193,"start_character":0,"end_line":194,"end_character":82},"updated":"2018-12-19 23:44:01.000000000","message":"These options should be left in the DEFAULT section\n\n \n\nThey really belong in a custom-named section, but we need to do some more work to enable custom network groups with puppet-manila","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    \u0027neutron/keyfile\u0027:                      value \u003d\u003e $keyfile;"},{"line_number":191,"context_line":"    \u0027neutron/region_name\u0027:                  value \u003d\u003e $region_name_real;"},{"line_number":192,"context_line":"    \u0027neutron/timeout\u0027:                      value \u003d\u003e $timeout;"},{"line_number":193,"context_line":"    \u0027neutron/network_plugin_ipv4_enabled\u0027:  value \u003d\u003e $network_plugin_ipv4_enabled;"},{"line_number":194,"context_line":"    \u0027neutron/network_plugin_ipv6_enabled\u0027:  value \u003d\u003e $network_plugin_ipv6_enabled;"},{"line_number":195,"context_line":"    }"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"  if $auth_type \u003d\u003d \u0027password\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_703ed7e2","line":194,"range":{"start_line":193,"start_character":0,"end_line":194,"end_character":82},"in_reply_to":"3f79a3b5_6fc36e06","updated":"2018-12-20 20:49:14.000000000","message":"All right, will correct the prefix to DEFAULT","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4229f69a0993e7f639c15d7b51549aaf72ff2e38","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"  if $auth_type \u003d\u003d \u0027password\u0027 {"},{"line_number":198,"context_line":"    manila_config {"},{"line_number":199,"context_line":"      \u0027neutron/auth_url\u0027:                     value \u003d\u003e $auth_url_real;"},{"line_number":200,"context_line":"      \u0027neutron/username\u0027:                     value \u003d\u003e $username_real;"},{"line_number":201,"context_line":"      \u0027neutron/user_domain_name\u0027:             value \u003d\u003e $user_domain_name;"},{"line_number":202,"context_line":"      \u0027neutron/password\u0027:                     value \u003d\u003e $password_real, secret \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_8ff04a63","line":199,"range":{"start_line":199,"start_character":0,"end_line":199,"end_character":70},"updated":"2018-12-19 23:44:01.000000000","message":"This option is generic, doesn\u0027t really depend on the auth_type","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36498986fa787abc4105b5b15f8f03be3f0b5613","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"  if $auth_type \u003d\u003d \u0027password\u0027 {"},{"line_number":198,"context_line":"    manila_config {"},{"line_number":199,"context_line":"      \u0027neutron/auth_url\u0027:                     value \u003d\u003e $auth_url_real;"},{"line_number":200,"context_line":"      \u0027neutron/username\u0027:                     value \u003d\u003e $username_real;"},{"line_number":201,"context_line":"      \u0027neutron/user_domain_name\u0027:             value \u003d\u003e $user_domain_name;"},{"line_number":202,"context_line":"      \u0027neutron/password\u0027:                     value \u003d\u003e $password_real, secret \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"3f79a3b5_d04c8b99","line":199,"range":{"start_line":199,"start_character":0,"end_line":199,"end_character":70},"in_reply_to":"3f79a3b5_8ff04a63","updated":"2018-12-20 20:49:14.000000000","message":"True that, moving it out from the if clause","commit_id":"6cbbde74161d4d5abe7f5011b761b43b64d03a32"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"17c8933efa8ce239160bc35d750c8b151de12938","unresolved":false,"context_lines":[{"line_number":106,"context_line":"#   neutron in admin context."},{"line_number":107,"context_line":"#   Defaults to undef"},{"line_number":108,"context_line":"#"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class manila::network::neutron ("},{"line_number":111,"context_line":"  $insecure                     \u003d $::os_service_default,"},{"line_number":112,"context_line":"  $auth_url                     \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"1f769fc5_8ffd1f3c","line":109,"updated":"2018-12-30 01:07:40.000000000","message":"remove this empty line","commit_id":"ca40edad141d9154603f061e0fb0a08f3abfab53"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"17c8933efa8ce239160bc35d750c8b151de12938","unresolved":false,"context_lines":[{"line_number":108,"context_line":"#"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class manila::network::neutron ("},{"line_number":111,"context_line":"  $insecure                     \u003d $::os_service_default,"},{"line_number":112,"context_line":"  $auth_url                     \u003d $::os_service_default,"},{"line_number":113,"context_line":"  $auth_type                    \u003d $::os_service_default,"},{"line_number":114,"context_line":"  $cafile                       \u003d $::os_service_default,"},{"line_number":115,"context_line":"  $user_domain_name             \u003d \u0027Default\u0027,"},{"line_number":116,"context_line":"  $project_domain_name          \u003d \u0027Default\u0027,"},{"line_number":117,"context_line":"  $project_name                 \u003d \u0027service\u0027,"},{"line_number":118,"context_line":"  $region_name                  \u003d $::os_service_default,"},{"line_number":119,"context_line":"  $timeout                      \u003d $::os_service_default,"},{"line_number":120,"context_line":"  $endpoint_type                \u003d $::os_service_default,"},{"line_number":121,"context_line":"  $username                     \u003d \u0027neutron\u0027,"},{"line_number":122,"context_line":"  $password                     \u003d undef,"},{"line_number":123,"context_line":"  $network_plugin_ipv4_enabled  \u003d $::os_service_default,"},{"line_number":124,"context_line":"  $network_plugin_ipv6_enabled  \u003d $::os_service_default,"},{"line_number":125,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":126,"context_line":"  $neutron_api_insecure            \u003d undef,"},{"line_number":127,"context_line":"  $neutron_ca_certificates_file    \u003d undef,"},{"line_number":128,"context_line":"  $neutron_url                     \u003d undef,"},{"line_number":129,"context_line":"  $neutron_url_timeout             \u003d undef,"},{"line_number":130,"context_line":"  $neutron_admin_username          \u003d undef,"},{"line_number":131,"context_line":"  $neutron_admin_password          \u003d undef,"},{"line_number":132,"context_line":"  $neutron_admin_tenant_name       \u003d undef,"},{"line_number":133,"context_line":"  $neutron_region_name             \u003d undef,"},{"line_number":134,"context_line":"  $neutron_admin_auth_url          \u003d undef,"},{"line_number":135,"context_line":"  $neutron_auth_strategy           \u003d undef,"},{"line_number":136,"context_line":") {"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  if $neutron_api_insecure {"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"1f769fc5_2fef2b85","line":135,"range":{"start_line":111,"start_character":0,"end_line":135,"end_character":43},"updated":"2018-12-30 01:07:40.000000000","message":"spacing wrong on these lines","commit_id":"ca40edad141d9154603f061e0fb0a08f3abfab53"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"17c8933efa8ce239160bc35d750c8b151de12938","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    \u0027neutron/cafile\u0027:                       value \u003d\u003e $cafile_real;"},{"line_number":195,"context_line":"    \u0027neutron/region_name\u0027:                  value \u003d\u003e $region_name_real;"},{"line_number":196,"context_line":"    \u0027neutron/timeout\u0027:                      value \u003d\u003e $timeout_real;"},{"line_number":197,"context_line":"    \u0027neutron/endpoint_type\u0027:                value \u003d\u003e $endpoint_type;"},{"line_number":198,"context_line":"    \u0027DEFAULT/network_plugin_ipv4_enabled\u0027:  value \u003d\u003e $network_plugin_ipv4_enabled;"},{"line_number":199,"context_line":"    \u0027DEFAULT/network_plugin_ipv6_enabled\u0027:  value \u003d\u003e $network_plugin_ipv6_enabled;"},{"line_number":200,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"1f769fc5_cf031742","line":197,"range":{"start_line":197,"start_character":29,"end_line":197,"end_character":44},"updated":"2018-12-30 01:07:40.000000000","message":"spacing on these lines","commit_id":"ca40edad141d9154603f061e0fb0a08f3abfab53"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"17c8933efa8ce239160bc35d750c8b151de12938","unresolved":false,"context_lines":[{"line_number":205,"context_line":"      \u0027neutron/user_domain_name\u0027:             value \u003d\u003e $user_domain_name;"},{"line_number":206,"context_line":"      \u0027neutron/password\u0027:                     value \u003d\u003e $password_real, secret \u003d\u003e true;"},{"line_number":207,"context_line":"      \u0027neutron/project_name\u0027:                 value \u003d\u003e $project_name_real;"},{"line_number":208,"context_line":"      \u0027neutron/project_domain_name\u0027:          value \u003d\u003e $project_domain_name;"},{"line_number":209,"context_line":"    }"},{"line_number":210,"context_line":"  }"},{"line_number":211,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"1f769fc5_ef005337","line":208,"range":{"start_line":208,"start_character":37,"end_line":208,"end_character":46},"updated":"2018-12-30 01:07:40.000000000","message":"spacing on these lines","commit_id":"ca40edad141d9154603f061e0fb0a08f3abfab53"}],"spec/classes/manila_compute_nova_spec.rb":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"3575d8f0ca58673ff84f0b916a8f3c5a7009707f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"          :cafile         \u003d\u003e \u0027/etc/ssl/certs/ca.crt\u0027,"},{"line_number":34,"context_line":"          :certfile       \u003d\u003e \u0027/etc/ssl/certs/cert.crt\u0027,"},{"line_number":35,"context_line":"          :keyfile        \u003d\u003e \u0027/etc/ssl/private/key.key\u0027,"},{"line_number":36,"context_line":"          :region_name    \u003d\u003e \u0027RegionOne\u0027,"},{"line_number":37,"context_line":"          :timeout        \u003d\u003e 30,"},{"line_number":38,"context_line":"          :username       \u003d\u003e \u0027novav1\u0027,"},{"line_number":39,"context_line":"          :password       \u003d\u003e \u0027123123\u0027,"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"3f79a3b5_8249ad65","line":36,"updated":"2018-12-11 15:21:25.000000000","message":"This should have the same value as in L54. Should be nova or RegionOne?","commit_id":"1cabd2d61faf4daacc6fe7e5122fadb4d4635847"}],"spec/classes/manila_network_neutron_spec.rb":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"3575d8f0ca58673ff84f0b916a8f3c5a7009707f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      :project_domain_name      \u003d\u003e \u0027Default\u0027,"},{"line_number":10,"context_line":"      :project_name             \u003d\u003e \u0027service\u0027,"},{"line_number":11,"context_line":"      :region_name              \u003d\u003e \u0027nova\u0027,"},{"line_number":12,"context_line":"      :cafile                   \u003d\u003e \u0027/etc/neutron/ca-certificates\u0027,"},{"line_number":13,"context_line":"      :certfile                 \u003d\u003e \u0027/etc/neutron/ca-certificates\u0027,"},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"3f79a3b5_e23981cf","line":12,"updated":"2018-12-11 15:21:25.000000000","message":"Not sure if this is the proper value","commit_id":"1cabd2d61faf4daacc6fe7e5122fadb4d4635847"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"3575d8f0ca58673ff84f0b916a8f3c5a7009707f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        \u0027manila.network.neutron.neutron_network_plugin.NeutronNetworkPlugin\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"      params_hash.each_pair do |config,value|"},{"line_number":46,"context_line":"        is_expected.to contain_manila_config(\"neutron/#{config}\").with_value( value )"},{"line_number":47,"context_line":"      end"},{"line_number":48,"context_line":"    end"},{"line_number":49,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"3f79a3b5_82720dae","line":46,"updated":"2018-12-11 15:21:25.000000000","message":"This is failing, for some reason we are expecting DEFAULT/insecure, not neutron/insecure","commit_id":"1cabd2d61faf4daacc6fe7e5122fadb4d4635847"}]}
