)]}'
{"manifests/backend/dellemc_unity.pp":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"897bcf6b25fbc1b7f13d87c02de50f5702cdd2dc","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  validate_string($emc_nas_password)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  $unity_share_driver \u003d \u0027manila.share.drivers.dell_emc.driver.EMCShareDriver\u0027"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  manila_config {"},{"line_number":102,"context_line":"    \"${share_backend_name}/share_driver\":                 value \u003d\u003e $unity_share_driver;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9fdfeff1_3305b446","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":77},"updated":"2019-02-15 17:24:51.000000000","message":"do we want to do that for deprecated driver?","commit_id":"7f030125b12257a235197267d8408789fae165f8"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"d33873ba0d3b8175a241062cb399406937176776","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  validate_string($emc_nas_password)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  $unity_share_driver \u003d \u0027manila.share.drivers.dell_emc.driver.EMCShareDriver\u0027"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  manila_config {"},{"line_number":102,"context_line":"    \"${share_backend_name}/share_driver\":                 value \u003d\u003e $unity_share_driver;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9fdfeff1_e7676624","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":77},"in_reply_to":"9fdfeff1_3305b446","updated":"2019-02-15 20:26:16.000000000","message":"This driver is not deprecated. Only the old url is depreated. Don\u0027t understand","commit_id":"7f030125b12257a235197267d8408789fae165f8"}],"spec/defines/manila_backend_dellemc_isilon_spec.rb":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"897bcf6b25fbc1b7f13d87c02de50f5702cdd2dc","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      end"},{"line_number":36,"context_line":"    end"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    it \u0027marks emc_nas_password as secret\u0027 do"},{"line_number":39,"context_line":"      is_expected.to contain_manila_config(\"dellemc_isilon/emc_nas_password\").with_secret( true )"},{"line_number":40,"context_line":"    end"},{"line_number":41,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9fdfeff1_b39684ef","line":38,"range":{"start_line":38,"start_character":1,"end_line":38,"end_character":44},"updated":"2019-02-15 17:24:51.000000000","message":"shouldn\u0027t we change all instances of emc to dell emc?","commit_id":"7f030125b12257a235197267d8408789fae165f8"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"d33873ba0d3b8175a241062cb399406937176776","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      end"},{"line_number":36,"context_line":"    end"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    it \u0027marks emc_nas_password as secret\u0027 do"},{"line_number":39,"context_line":"      is_expected.to contain_manila_config(\"dellemc_isilon/emc_nas_password\").with_secret( true )"},{"line_number":40,"context_line":"    end"},{"line_number":41,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9fdfeff1_2779eec3","line":38,"range":{"start_line":38,"start_character":1,"end_line":38,"end_character":44},"in_reply_to":"9fdfeff1_b39684ef","updated":"2019-02-15 20:26:16.000000000","message":"Those changes should start from the manila project. It will have to be a another PR","commit_id":"7f030125b12257a235197267d8408789fae165f8"}],"spec/defines/manila_backend_dellemc_unity_spec.rb":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"897bcf6b25fbc1b7f13d87c02de50f5702cdd2dc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      end"},{"line_number":45,"context_line":"    end"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    it \u0027marks emc_nas_password as secret\u0027 do"},{"line_number":48,"context_line":"      is_expected.to contain_manila_config(\"dellemc_unity/emc_nas_password\").with_secret( true )"},{"line_number":49,"context_line":"    end"},{"line_number":50,"context_line":"  end"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9fdfeff1_338a94be","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":75},"updated":"2019-02-15 17:24:51.000000000","message":"ditto","commit_id":"7f030125b12257a235197267d8408789fae165f8"}],"spec/defines/manila_backend_dellemc_vnx_spec.rb":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"897bcf6b25fbc1b7f13d87c02de50f5702cdd2dc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      end"},{"line_number":45,"context_line":"    end"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    it \u0027marks emc_nas_password as secret\u0027 do"},{"line_number":48,"context_line":"      is_expected.to contain_manila_config(\"dellemc_vnx/emc_nas_password\").with_secret( true )"},{"line_number":49,"context_line":"    end"},{"line_number":50,"context_line":"  end"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9fdfeff1_f38f2cca","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":94},"updated":"2019-02-15 17:24:51.000000000","message":"ditto","commit_id":"7f030125b12257a235197267d8408789fae165f8"}]}
