)]}'
{"manifests/image/glance.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b994f8e9f0e6ba6eda6a836438248ba11accf5db","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   (optional) User\u0027s password"},{"line_number":63,"context_line":"#   Only required if auth_type has been set to \"password\""},{"line_number":64,"context_line":"#   Defaults to undef"},{"line_number":65,"context_line":"class manila::image::glance ("},{"line_number":66,"context_line":"  $api_microversion            \u003d $::os_service_default,"},{"line_number":67,"context_line":"  $insecure                    \u003d $::os_service_default,"},{"line_number":68,"context_line":"  $auth_url                    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f560f44_cf12f362","line":65,"updated":"2020-08-12 14:15:21.000000000","message":"(nit) Add one blank comment line above.","commit_id":"d4a87af89880f36b55131897ef513a18a0c531f2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2966df307d5bc67aebc173b50052f600d6f5adf6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   (optional) User\u0027s password"},{"line_number":63,"context_line":"#   Only required if auth_type has been set to \"password\""},{"line_number":64,"context_line":"#   Defaults to undef"},{"line_number":65,"context_line":"class manila::image::glance ("},{"line_number":66,"context_line":"  $api_microversion            \u003d $::os_service_default,"},{"line_number":67,"context_line":"  $insecure                    \u003d $::os_service_default,"},{"line_number":68,"context_line":"  $auth_url                    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f560f44_b52c80ac","line":65,"in_reply_to":"9f560f44_cf12f362","updated":"2020-08-25 00:55:15.000000000","message":"Done","commit_id":"d4a87af89880f36b55131897ef513a18a0c531f2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b994f8e9f0e6ba6eda6a836438248ba11accf5db","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  include manila::deps"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  manila_config {"},{"line_number":85,"context_line":"    \u0027glance/api_microversion\u0027:    value \u003d\u003e $api_microversion;"},{"line_number":86,"context_line":"    \u0027glance/insecure\u0027:            value \u003d\u003e $insecure;"},{"line_number":87,"context_line":"    \u0027glance/auth_url\u0027:            value \u003d\u003e $auth_url;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f560f44_d220d89e","line":84,"updated":"2020-08-12 14:15:21.000000000","message":"Does it make sense to implement the same logic based on auth_type as we have in nova/neutron configuration ?\n\nhttps://github.com/openstack/puppet-manila/blob/master/manifests/compute/nova.pp","commit_id":"d4a87af89880f36b55131897ef513a18a0c531f2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2966df307d5bc67aebc173b50052f600d6f5adf6","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  include manila::deps"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  manila_config {"},{"line_number":85,"context_line":"    \u0027glance/api_microversion\u0027:    value \u003d\u003e $api_microversion;"},{"line_number":86,"context_line":"    \u0027glance/insecure\u0027:            value \u003d\u003e $insecure;"},{"line_number":87,"context_line":"    \u0027glance/auth_url\u0027:            value \u003d\u003e $auth_url;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f560f44_1823e1a8","line":84,"in_reply_to":"9f560f44_18181d1c","updated":"2020-08-25 00:55:15.000000000","message":"Thanks for the fixes in https://review.opendev.org/747525/\n\nWe should be good now!","commit_id":"d4a87af89880f36b55131897ef513a18a0c531f2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cb1124dd42c31f870ff5b1ca4da84a7389efdbcf","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  include manila::deps"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  manila_config {"},{"line_number":85,"context_line":"    \u0027glance/api_microversion\u0027:    value \u003d\u003e $api_microversion;"},{"line_number":86,"context_line":"    \u0027glance/insecure\u0027:            value \u003d\u003e $insecure;"},{"line_number":87,"context_line":"    \u0027glance/auth_url\u0027:            value \u003d\u003e $auth_url;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f560f44_18181d1c","line":84,"in_reply_to":"9f560f44_2350e8d4","updated":"2020-08-22 12:02:04.000000000","message":"Indeed.\nI notice that existing logic has some problem because these parameters like username are used in other \"auth_type\"s like v3password.\n\nI think it\u0027s ok to keep the current implemnetation here. I found some other modules which have this problem and fix them all.\n# I guess this comes from the implementation of cinder::nova but I\u0027m not sure.","commit_id":"d4a87af89880f36b55131897ef513a18a0c531f2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d8bbe173703702230a51d601a3ca5a45c4472e84","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  include manila::deps"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  manila_config {"},{"line_number":85,"context_line":"    \u0027glance/api_microversion\u0027:    value \u003d\u003e $api_microversion;"},{"line_number":86,"context_line":"    \u0027glance/insecure\u0027:            value \u003d\u003e $insecure;"},{"line_number":87,"context_line":"    \u0027glance/auth_url\u0027:            value \u003d\u003e $auth_url;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f560f44_2350e8d4","line":84,"in_reply_to":"9f560f44_d220d89e","updated":"2020-08-21 23:22:42.000000000","message":"I didn\u0027t understand that logic, although I reviewed the patch that added it, perhaps Victoria Martinez can help clarify, \n\nI mean, regardless of whether the \"auth_type\" is password or not, we\u0027d still need username, project_name and project_domain_name\n\nWhen auth_type isn\u0027t password, we\u0027d assume for production clouds, two other kinds of auth:\n\n- noauth, i.e., service is operating without keystone, and these values are not used\n- token, which I\u0027ve not added an option for - will do\n\n\nI can fix the other manifests in a separate patch to not have this condition, what do you think?","commit_id":"d4a87af89880f36b55131897ef513a18a0c531f2"}],"spec/classes/manila_image_glance.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b994f8e9f0e6ba6eda6a836438248ba11accf5db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper\u0027"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027manila::image::glance\u0027 do"},{"line_number":4,"context_line":"  shared_examples \u0027manila::glance\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f560f44_8f4abb80","line":1,"updated":"2020-08-12 14:15:21.000000000","message":"This file should be renamed to manila_image_glance_spec.rb, otherwise it isn\u0027t recognized during unit tests execution","commit_id":"d4a87af89880f36b55131897ef513a18a0c531f2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2966df307d5bc67aebc173b50052f600d6f5adf6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper\u0027"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027manila::image::glance\u0027 do"},{"line_number":4,"context_line":"  shared_examples \u0027manila::glance\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f560f44_550a4425","line":1,"in_reply_to":"9f560f44_8f4abb80","updated":"2020-08-25 00:55:15.000000000","message":"+1 thanks, done","commit_id":"d4a87af89880f36b55131897ef513a18a0c531f2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b994f8e9f0e6ba6eda6a836438248ba11accf5db","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        is_expected.to contain_manila_config(\u0027glance/project_name\u0027).with_value(\u0027services\u0027)"},{"line_number":17,"context_line":"        is_expected.to contain_manila_config(\u0027glance/region_name\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":18,"context_line":"        is_expected.to contain_manila_config(\u0027glance/endpoint_type\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":19,"context_line":"        is_expected.to contain_manila_config(\u0027glance/password\u0027).with_value(\u0027glance\u0027)"},{"line_number":20,"context_line":"        is_expected.to contain_manila_config(\u0027glance/password\u0027)"},{"line_number":21,"context_line":"      end"},{"line_number":22,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f560f44_af497f8c","line":19,"range":{"start_line":19,"start_character":53,"end_line":19,"end_character":61},"updated":"2020-08-12 14:15:21.000000000","message":"I think this should be username","commit_id":"d4a87af89880f36b55131897ef513a18a0c531f2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2966df307d5bc67aebc173b50052f600d6f5adf6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        is_expected.to contain_manila_config(\u0027glance/project_name\u0027).with_value(\u0027services\u0027)"},{"line_number":17,"context_line":"        is_expected.to contain_manila_config(\u0027glance/region_name\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":18,"context_line":"        is_expected.to contain_manila_config(\u0027glance/endpoint_type\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":19,"context_line":"        is_expected.to contain_manila_config(\u0027glance/password\u0027).with_value(\u0027glance\u0027)"},{"line_number":20,"context_line":"        is_expected.to contain_manila_config(\u0027glance/password\u0027)"},{"line_number":21,"context_line":"      end"},{"line_number":22,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f560f44_b505a016","line":19,"range":{"start_line":19,"start_character":53,"end_line":19,"end_character":61},"in_reply_to":"9f560f44_af497f8c","updated":"2020-08-25 00:55:15.000000000","message":"Done","commit_id":"d4a87af89880f36b55131897ef513a18a0c531f2"}],"spec/classes/manila_image_glance_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ed5d1344d5f5350de572c7e07e0e81e5e6c7ff9e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        is_expected.to contain_manila_config(\u0027glance/region_name\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":18,"context_line":"        is_expected.to contain_manila_config(\u0027glance/endpoint_type\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":19,"context_line":"        is_expected.to contain_manila_config(\u0027glance/username\u0027).with_value(\u0027glance\u0027)"},{"line_number":20,"context_line":"        is_expected.to contain_manila_config(\u0027glance/password\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027).with_secret(true)"},{"line_number":21,"context_line":"      end"},{"line_number":22,"context_line":"    end"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9f560f44_31423b10","line":20,"range":{"start_line":20,"start_character":95,"end_line":20,"end_character":113},"updated":"2020-08-25 13:28:08.000000000","message":"Added this to assert that secret:true is always set.","commit_id":"562173ff21c19ce2d1977b542ab76dfe9e58e1a1"}]}