)]}'
{"manifests/backend/dellemc_vnx.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"93019b7e5f6fc7f0668a5c85d98241a7720ecad4","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    if $network_config_group !\u003d undef {"},{"line_number":149,"context_line":"      manila_config {"},{"line_number":150,"context_line":"        \"${share_backend_name}/network_config_group\": value \u003d\u003e $network_config_group;"},{"line_number":151,"context_line":"      }"},{"line_number":152,"context_line":"    }"},{"line_number":153,"context_line":"    if $admin_network_config_group !\u003d undef {"},{"line_number":154,"context_line":"      manila_config {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f560f44_7c6b8c84","line":151,"updated":"2020-08-31 13:40:18.000000000","message":"So this logic won\u0027t remove it if the value is undef. Is this desired?  Traditionally if the value is undef, the providers don\u0027t update the value and just leave in place. If the desire is to remove it from the config when not set, you need to use $::os_service_default","commit_id":"a33cf1088a1a6f9924312a40f79e06684a569dc9"}],"spec/defines/manila_backend_netapp_spec.rb":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"63312a7dad908fce4a65986ca10ac9b048c1159f","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    context \u0027with dhss\u003dtrue parameters\u0027 do"},{"line_number":9,"context_line":"      let :params do"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"          :driver_handles_share_servers        \u003d\u003e true,"},{"line_number":12,"context_line":"          :netapp_login                        \u003d\u003e \u0027netapp\u0027,"},{"line_number":13,"context_line":"          :netapp_password                     \u003d\u003e \u0027password\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f560f44_4378898e","line":10,"updated":"2020-08-28 12:14:28.000000000","message":"is this also needed here?\n:netapp_transport_type       \u003d\u003e \u0027http\u0027","commit_id":"a33cf1088a1a6f9924312a40f79e06684a569dc9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e905f5d44ad65ae1146ab089c3d7d08f211298a","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    context \u0027with dhss\u003dtrue parameters\u0027 do"},{"line_number":9,"context_line":"      let :params do"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"          :driver_handles_share_servers        \u003d\u003e true,"},{"line_number":12,"context_line":"          :netapp_login                        \u003d\u003e \u0027netapp\u0027,"},{"line_number":13,"context_line":"          :netapp_password                     \u003d\u003e \u0027password\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f560f44_49570328","line":10,"in_reply_to":"9f560f44_4378898e","updated":"2020-08-28 17:14:49.000000000","message":"Not necessary, I was just testing some overrides, if you don\u0027t override, you get the default, as asserted on line 36 here...","commit_id":"a33cf1088a1a6f9924312a40f79e06684a569dc9"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"63312a7dad908fce4a65986ca10ac9b048c1159f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"          :netapp_server_hostname              \u003d\u003e \u0027127.0.0.2\u0027,"},{"line_number":15,"context_line":"          :netapp_server_port                  \u003d\u003e \u0027443\u0027,"},{"line_number":16,"context_line":"          :netapp_vserver                      \u003d\u003e \u0027manilamsvm\u0027,"},{"line_number":17,"context_line":"          :netapp_root_volume_aggregate        \u003d\u003e \u0027aggr1\u0027,"},{"line_number":18,"context_line":"          :netapp_trace_flags                  \u003d\u003e \u0027method,api\u0027,"},{"line_number":19,"context_line":"          :network_config_group                \u003d\u003e \u0027netapp_network\u0027,"},{"line_number":20,"context_line":"          :admin_network_config_group          \u003d\u003e \u0027netapp_admin_network\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f560f44_63fcad0c","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":39},"updated":"2020-08-28 12:14:28.000000000","message":"nit: \u0027netapp_root_volume\u0027 just be be aligned with the following section.","commit_id":"a33cf1088a1a6f9924312a40f79e06684a569dc9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e905f5d44ad65ae1146ab089c3d7d08f211298a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"          :netapp_server_hostname              \u003d\u003e \u0027127.0.0.2\u0027,"},{"line_number":15,"context_line":"          :netapp_server_port                  \u003d\u003e \u0027443\u0027,"},{"line_number":16,"context_line":"          :netapp_vserver                      \u003d\u003e \u0027manilamsvm\u0027,"},{"line_number":17,"context_line":"          :netapp_root_volume_aggregate        \u003d\u003e \u0027aggr1\u0027,"},{"line_number":18,"context_line":"          :netapp_trace_flags                  \u003d\u003e \u0027method,api\u0027,"},{"line_number":19,"context_line":"          :network_config_group                \u003d\u003e \u0027netapp_network\u0027,"},{"line_number":20,"context_line":"          :admin_network_config_group          \u003d\u003e \u0027netapp_admin_network\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f560f44_892e3ba9","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":39},"in_reply_to":"9f560f44_63fcad0c","updated":"2020-08-28 17:14:49.000000000","message":"same as above, not overriding that to test the default on line 42..","commit_id":"a33cf1088a1a6f9924312a40f79e06684a569dc9"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"63312a7dad908fce4a65986ca10ac9b048c1159f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    context \u0027with dhss\u003dfalse parameters\u0027 do"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"      let :params do"},{"line_number":53,"context_line":"        {"},{"line_number":54,"context_line":"          :driver_handles_share_servers        \u003d\u003e false,"},{"line_number":55,"context_line":"          :netapp_login                        \u003d\u003e \u0027netapp\u0027,"},{"line_number":56,"context_line":"          :netapp_password                     \u003d\u003e \u0027password\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f560f44_8372a1ac","line":53,"updated":"2020-08-28 12:14:28.000000000","message":"is this also needed here?\n:netapp_transport_type       \u003d\u003e \u0027http\u0027","commit_id":"a33cf1088a1a6f9924312a40f79e06684a569dc9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e905f5d44ad65ae1146ab089c3d7d08f211298a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    context \u0027with dhss\u003dfalse parameters\u0027 do"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"      let :params do"},{"line_number":53,"context_line":"        {"},{"line_number":54,"context_line":"          :driver_handles_share_servers        \u003d\u003e false,"},{"line_number":55,"context_line":"          :netapp_login                        \u003d\u003e \u0027netapp\u0027,"},{"line_number":56,"context_line":"          :netapp_password                     \u003d\u003e \u0027password\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f560f44_e91ed772","line":53,"in_reply_to":"9f560f44_8372a1ac","updated":"2020-08-28 17:14:49.000000000","message":"testing overrides/defaults in the same test case - so ignoring some options deliberately :)","commit_id":"a33cf1088a1a6f9924312a40f79e06684a569dc9"}]}