)]}'
{"manifests/backend/lvm.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"60e6414832a7a593ea7f79e2a2c2f205516f5140","unresolved":true,"context_lines":[{"line_number":38,"context_line":"define manila::backend::lvm("},{"line_number":39,"context_line":"  $share_backend_name           \u003d $name,"},{"line_number":40,"context_line":"  $driver_handles_share_servers \u003d false,"},{"line_number":41,"context_line":"  $lvm_share_export_ip          \u003d undef,"},{"line_number":42,"context_line":"  $lvm_share_export_root        \u003d \u0027$state_path/mnt\u0027,"},{"line_number":43,"context_line":"  $lvm_share_mirrors            \u003d 0,"},{"line_number":44,"context_line":"  $lvm_share_volume_group       \u003d \u0027lvm-shares\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3c3c935e_d2111d1c","line":41,"range":{"start_line":41,"start_character":34,"end_line":41,"end_character":39},"updated":"2021-04-01 23:54:55.000000000","message":"I think we should make this parameter required.","commit_id":"eaaded5ea1917d01f75b5ce8a4021e7478631031"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"60e6414832a7a593ea7f79e2a2c2f205516f5140","unresolved":true,"context_lines":[{"line_number":39,"context_line":"  $share_backend_name           \u003d $name,"},{"line_number":40,"context_line":"  $driver_handles_share_servers \u003d false,"},{"line_number":41,"context_line":"  $lvm_share_export_ip          \u003d undef,"},{"line_number":42,"context_line":"  $lvm_share_export_root        \u003d \u0027$state_path/mnt\u0027,"},{"line_number":43,"context_line":"  $lvm_share_mirrors            \u003d 0,"},{"line_number":44,"context_line":"  $lvm_share_volume_group       \u003d \u0027lvm-shares\u0027,"},{"line_number":45,"context_line":"  $lvm_share_helpers            \u003d [\u0027CIFS\u003dmanila.share.drivers.helpers.CIFSHelperUserAccess\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7472e7f0_71bf1eef","line":42,"range":{"start_line":42,"start_character":35,"end_line":42,"end_character":51},"updated":"2021-04-01 23:54:55.000000000","message":"Please use $::os_service_default instead of redefining the same default. This is applicable for the rest of parameters.","commit_id":"eaaded5ea1917d01f75b5ce8a4021e7478631031"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"60e6414832a7a593ea7f79e2a2c2f205516f5140","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    \"${name}/lvm_share_export_root\":        value \u003d\u003e $lvm_share_export_root;"},{"line_number":58,"context_line":"    \"${name}/lvm_share_mirrors\":            value \u003d\u003e $lvm_share_mirrors;"},{"line_number":59,"context_line":"    \"${name}/lvm_share_volume_group\":       value \u003d\u003e $lvm_share_volume_group;"},{"line_number":60,"context_line":"    \"${name}/lvm_share_helpers\":            value \u003d\u003e $lvm_share_helpers;"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9dc9d0ae_c0aff1a4","line":60,"range":{"start_line":60,"start_character":54,"end_line":60,"end_character":71},"updated":"2021-04-01 23:54:55.000000000","message":"This is list opt thus I believe you should convert a list to a string.","commit_id":"eaaded5ea1917d01f75b5ce8a4021e7478631031"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cecc7a44d16f2fa38d6b938bf904031c9386c85e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# \u003d\u003d Class: manila::backend::lvm"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Configures Manila to use LVM as a share driver"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"e74573a0_186c060d","line":2,"range":{"start_line":2,"start_character":5,"end_line":2,"end_character":10},"updated":"2021-04-07 11:16:22.000000000","message":"This is not cleass. So Defines would be better.","commit_id":"528f909bc8696bac01ddcc346d024da4c6b30cbe"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cecc7a44d16f2fa38d6b938bf904031c9386c85e","unresolved":true,"context_lines":[{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":7,"context_line":"# [*share_backend_name*]"},{"line_number":8,"context_line":"#   Name of the backend in manila.conf that these settings will reside in"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*lvm_share_export_ip*]"},{"line_number":11,"context_line":"#  List of IPs to export shares belonging to the LVM storage driver."}],"source_content_type":"text/x-puppet","patch_set":7,"id":"af2f9c3d_349f4141","line":8,"updated":"2021-04-07 11:16:22.000000000","message":"(optional)\nand\nDefaults to: $name","commit_id":"528f909bc8696bac01ddcc346d024da4c6b30cbe"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cecc7a44d16f2fa38d6b938bf904031c9386c85e","unresolved":true,"context_lines":[{"line_number":8,"context_line":"#   Name of the backend in manila.conf that these settings will reside in"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*lvm_share_export_ip*]"},{"line_number":11,"context_line":"#  List of IPs to export shares belonging to the LVM storage driver."},{"line_number":12,"context_line":"#  lvm_share_export_ip \u003d \u003cNone\u003e"},{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"# [*driver_handles_share_servers*]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"72aa8985_5be05f04","line":11,"updated":"2021-04-07 11:16:22.000000000","message":"Please add (required)","commit_id":"528f909bc8696bac01ddcc346d024da4c6b30cbe"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cecc7a44d16f2fa38d6b938bf904031c9386c85e","unresolved":true,"context_lines":[{"line_number":48,"context_line":"  $share_driver \u003d \u0027manila.share.drivers.lvm.LVMShareDriver\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $lvm_share_export_ip \u003d\u003d undef {"},{"line_number":51,"context_line":"    fail(\u0027The cert_file parameter is required when use_ssl is set to true\u0027)"},{"line_number":52,"context_line":"  }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  manila_config {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"4a52415a_f9d08a9b","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":75},"updated":"2021-04-07 11:16:22.000000000","message":"This error is incorrect. Also, if this parameter is required then why don\u0027t you remove the default value ?","commit_id":"528f909bc8696bac01ddcc346d024da4c6b30cbe"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cecc7a44d16f2fa38d6b938bf904031c9386c85e","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    \"${name}/lvm_share_export_root\":        value \u003d\u003e $lvm_share_export_root;"},{"line_number":60,"context_line":"    \"${name}/lvm_share_mirrors\":            value \u003d\u003e $lvm_share_mirrors;"},{"line_number":61,"context_line":"    \"${name}/lvm_share_volume_group\":       value \u003d\u003e $lvm_share_volume_group;"},{"line_number":62,"context_line":"    \"${name}/lvm_share_helpers\":            value \u003d\u003e join($lvm_share_helpers, \u0027,\u0027);"},{"line_number":63,"context_line":"  }"},{"line_number":64,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"c4c186e8_7929f920","line":62,"range":{"start_line":62,"start_character":59,"end_line":62,"end_character":76},"updated":"2021-04-07 11:16:22.000000000","message":"Let\u0027s use any2array so that this parameter can accept a flat string.","commit_id":"528f909bc8696bac01ddcc346d024da4c6b30cbe"}],"spec/defines/manila_backend_lvm_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cecc7a44d16f2fa38d6b938bf904031c9386c85e","unresolved":true,"context_lines":[{"line_number":26,"context_line":"      is_expected.to contain_manila_config(\u0027mylvm/lvm_share_mirrors\u0027).with_value(\u00271\u0027)"},{"line_number":27,"context_line":"      is_expected.to contain_manila_config(\u0027mylvm/lvm_share_volume_group\u0027).with_value(\u0027lvm-shares\u0027)"},{"line_number":28,"context_line":"      is_expected.to contain_manila_config(\u0027mylvm/lvm_share_helpers\u0027).with_value("},{"line_number":29,"context_line":"        [\u0027CIFS\u003dmanila.share.drivers.helpers.CIFSHelperUserAccess\u0027,\u0027NFS\u003dmanila.share.drivers.helpers.NFSHelper\u0027])"},{"line_number":30,"context_line":"    end"},{"line_number":31,"context_line":"  end"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":7,"id":"916f0c32_e3810d49","line":29,"range":{"start_line":29,"start_character":7,"end_line":29,"end_character":111},"updated":"2021-04-07 11:16:22.000000000","message":"This test is incorrect.","commit_id":"528f909bc8696bac01ddcc346d024da4c6b30cbe"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cecc7a44d16f2fa38d6b938bf904031c9386c85e","unresolved":true,"context_lines":[{"line_number":35,"context_line":"  }).each do |os,facts|"},{"line_number":36,"context_line":"    context \"on #{os}\" do"},{"line_number":37,"context_line":"      let (:facts) do"},{"line_number":38,"context_line":"        facts.merge!(OSDefaults.get_facts())"},{"line_number":39,"context_line":"      end"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"      it_configures \u0027lvm share driver\u0027"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"0229c792_93e0646b","line":38,"updated":"2021-04-07 11:16:22.000000000","message":"It seems that this file is not properly invoked. Can you try adding\n {:osfamiliy \u003d\u003e \"#{os}\"}\nin get_facts ?","commit_id":"528f909bc8696bac01ddcc346d024da4c6b30cbe"}]}