)]}'
{"manifests/backend/flashblade.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b41886c30d4e14c8f6d7e609b4138981f477da46","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# Compatible for multiple backends"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*driver_handles_share_servers*]"},{"line_number":9,"context_line":"#  (required) Denotes whether the driver should handle the responsibility of"},{"line_number":10,"context_line":"#   managing share servers. This must be set to false if the driver is to"},{"line_number":11,"context_line":"#   operate without managing share servers."},{"line_number":12,"context_line":"#   FlashBlade driver requires this option to be as False."},{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"# [*flashblade_api*]"},{"line_number":15,"context_line":"#   (required) API token for admin-privileged user on system."},{"line_number":16,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"eea85913_f3746b70","line":13,"range":{"start_line":7,"start_character":1,"end_line":13,"end_character":1},"updated":"2021-05-27 14:02:04.000000000","message":"Do we have any use case where this parameter is set to True ?\nLooking at the parameter description, the parameter should be set to False always then it\u0027d make more sense to remove this parameter interface and hard code False in implementation. It\u0027s redundant to require users to set this False.","commit_id":"3592a4ad7608823346d25be1c4aa7c78141b6ad9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"af7e3d2b9bcb9c56367fae7e0b559b4674330719","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# Compatible for multiple backends"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*driver_handles_share_servers*]"},{"line_number":9,"context_line":"#  (required) Denotes whether the driver should handle the responsibility of"},{"line_number":10,"context_line":"#   managing share servers. This must be set to false if the driver is to"},{"line_number":11,"context_line":"#   operate without managing share servers."},{"line_number":12,"context_line":"#   FlashBlade driver requires this option to be as False."},{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"# [*flashblade_api*]"},{"line_number":15,"context_line":"#   (required) API token for admin-privileged user on system."},{"line_number":16,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3ccb2ae5_2ec1d687","line":13,"range":{"start_line":7,"start_character":1,"end_line":13,"end_character":1},"in_reply_to":"30c05914_d7e4e5ec","updated":"2021-05-28 05:42:12.000000000","message":"Thank you for pointing that out. IMO we should revisit the other drivers to deprecate/drop such useless and broken parameters. I\u0027ll work on that later.","commit_id":"3592a4ad7608823346d25be1c4aa7c78141b6ad9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"edfe04766a0bc2d75337a54b898bd1d357171084","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# Compatible for multiple backends"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*driver_handles_share_servers*]"},{"line_number":9,"context_line":"#  (required) Denotes whether the driver should handle the responsibility of"},{"line_number":10,"context_line":"#   managing share servers. This must be set to false if the driver is to"},{"line_number":11,"context_line":"#   operate without managing share servers."},{"line_number":12,"context_line":"#   FlashBlade driver requires this option to be as False."},{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"# [*flashblade_api*]"},{"line_number":15,"context_line":"#   (required) API token for admin-privileged user on system."},{"line_number":16,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"cd0cee39_51f834d7","line":13,"range":{"start_line":7,"start_character":1,"end_line":13,"end_character":1},"in_reply_to":"3ccb2ae5_2ec1d687","updated":"2021-06-07 14:20:22.000000000","message":"Ack","commit_id":"3592a4ad7608823346d25be1c4aa7c78141b6ad9"},{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"3271856ff42939f500bbc768771ce80865377f5d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# Compatible for multiple backends"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*driver_handles_share_servers*]"},{"line_number":9,"context_line":"#  (required) Denotes whether the driver should handle the responsibility of"},{"line_number":10,"context_line":"#   managing share servers. This must be set to false if the driver is to"},{"line_number":11,"context_line":"#   operate without managing share servers."},{"line_number":12,"context_line":"#   FlashBlade driver requires this option to be as False."},{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"# [*flashblade_api*]"},{"line_number":15,"context_line":"#   (required) API token for admin-privileged user on system."},{"line_number":16,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"30c05914_d7e4e5ec","line":13,"range":{"start_line":7,"start_character":1,"end_line":13,"end_character":1},"in_reply_to":"eea85913_f3746b70","updated":"2021-05-27 15:23:23.000000000","message":"I get what you are saying, but TBH I\u0027m just following what all the other 3rd party Manila drivers are doing here.\nThere is no support for this to be True, but every other vendors specifies this parameter and they do not support changing it either.","commit_id":"3592a4ad7608823346d25be1c4aa7c78141b6ad9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f6bf0cec5bf507ae484dd1165dd1fa118b2ff226","unresolved":true,"context_lines":[{"line_number":37,"context_line":"  $flashblade_api,"},{"line_number":38,"context_line":"  $flashblade_data_vip,"},{"line_number":39,"context_line":"  $flashblade_mgmt_vip,"},{"line_number":40,"context_line":"  $flashblade_eradicate        \u003d true,"},{"line_number":41,"context_line":"  $share_backend_name          \u003d $name,"},{"line_number":42,"context_line":"  $package_ensure              \u003d \u0027present\u0027,"},{"line_number":43,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"b8e73d34_667ede5a","line":40,"range":{"start_line":40,"start_character":23,"end_line":40,"end_character":30},"updated":"2021-06-07 14:31:41.000000000","message":"(nit) You can remove these spaces","commit_id":"35394ccd8f57a9174230236f09ccce78c0a021d9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"e2eca9445a355684d737c4ddf793f44d7ddda934","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  $flashblade_api,"},{"line_number":38,"context_line":"  $flashblade_data_vip,"},{"line_number":39,"context_line":"  $flashblade_mgmt_vip,"},{"line_number":40,"context_line":"  $flashblade_eradicate        \u003d true,"},{"line_number":41,"context_line":"  $share_backend_name          \u003d $name,"},{"line_number":42,"context_line":"  $package_ensure              \u003d \u0027present\u0027,"},{"line_number":43,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1d2d6dec_352bb90b","line":40,"range":{"start_line":40,"start_character":23,"end_line":40,"end_character":30},"in_reply_to":"b8e73d34_667ede5a","updated":"2021-06-07 14:57:36.000000000","message":"Done","commit_id":"35394ccd8f57a9174230236f09ccce78c0a021d9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f6bf0cec5bf507ae484dd1165dd1fa118b2ff226","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  $flashblade_share_driver \u003d \u0027manila.share.drivers.purestorage.flashblade.FlashBladeShareDriver\u0027"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  manila_config {"},{"line_number":52,"context_line":"    \"${share_backend_name}/share_driver\":                 value \u003d\u003e $flashblade_share_driver;"},{"line_number":53,"context_line":"    \"${share_backend_name}/flashblade_eradicate\":         value \u003d\u003e $flashblade_eradicate;"},{"line_number":54,"context_line":"    \"${share_backend_name}/flashblade_api\":               value \u003d\u003e $flashblade_api, secret \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"04887e74_8ce98020","line":51,"updated":"2021-06-07 14:31:41.000000000","message":"I think driver_handles_share_servers should be hard-coded to ensure the expected value(false) is used.","commit_id":"35394ccd8f57a9174230236f09ccce78c0a021d9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"e2eca9445a355684d737c4ddf793f44d7ddda934","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  $flashblade_share_driver \u003d \u0027manila.share.drivers.purestorage.flashblade.FlashBladeShareDriver\u0027"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  manila_config {"},{"line_number":52,"context_line":"    \"${share_backend_name}/share_driver\":                 value \u003d\u003e $flashblade_share_driver;"},{"line_number":53,"context_line":"    \"${share_backend_name}/flashblade_eradicate\":         value \u003d\u003e $flashblade_eradicate;"},{"line_number":54,"context_line":"    \"${share_backend_name}/flashblade_api\":               value \u003d\u003e $flashblade_api, secret \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"260ebc7a_a22592ef","line":51,"in_reply_to":"04887e74_8ce98020","updated":"2021-06-07 14:57:36.000000000","message":"Done","commit_id":"35394ccd8f57a9174230236f09ccce78c0a021d9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3d81a9f354f0d08d76a8e64ad04977d8c1448954","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    \"${share_backend_name}/share_backend_name\":           value \u003d\u003e $share_backend_name;"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  ensure_resource(\u0027package\u0027,\u0027nfs-utils\u0027,{"},{"line_number":61,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":62,"context_line":"    tag    \u003d\u003e \u0027manila-support-package\u0027,"},{"line_number":63,"context_line":"  })"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9429e797_8d5d9202","line":60,"range":{"start_line":60,"start_character":29,"end_line":60,"end_character":38},"updated":"2021-06-07 14:35:46.000000000","message":"I noticed that this package name is specific to centos and we should use nfs-common in Ubuntu/Debian. I\u0027ll fix this later because we need the same fix for the other backends....","commit_id":"35394ccd8f57a9174230236f09ccce78c0a021d9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"e2eca9445a355684d737c4ddf793f44d7ddda934","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \"${share_backend_name}/share_backend_name\":           value \u003d\u003e $share_backend_name;"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  ensure_resource(\u0027package\u0027,\u0027nfs-utils\u0027,{"},{"line_number":61,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":62,"context_line":"    tag    \u003d\u003e \u0027manila-support-package\u0027,"},{"line_number":63,"context_line":"  })"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"b9a0ed7e_eff74851","line":60,"range":{"start_line":60,"start_character":29,"end_line":60,"end_character":38},"in_reply_to":"9429e797_8d5d9202","updated":"2021-06-07 14:57:36.000000000","message":"I changed it to nfs-common - did you want that now, or do you need to do other changes for this to work?","commit_id":"35394ccd8f57a9174230236f09ccce78c0a021d9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"01e99092ffd0d4eb9523fcc921f6a0947a44235b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \"${share_backend_name}/share_backend_name\":           value \u003d\u003e $share_backend_name;"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  ensure_resource(\u0027package\u0027,\u0027nfs-utils\u0027,{"},{"line_number":61,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":62,"context_line":"    tag    \u003d\u003e \u0027manila-support-package\u0027,"},{"line_number":63,"context_line":"  })"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3861f39a_c2911aa3","line":60,"range":{"start_line":60,"start_character":29,"end_line":60,"end_character":38},"in_reply_to":"b9a0ed7e_eff74851","updated":"2021-06-08 00:40:47.000000000","message":"I\u0027ll submit the change separately so please keep nfs-utils.","commit_id":"35394ccd8f57a9174230236f09ccce78c0a021d9"}],"spec/defines/manila_backend_flashblade_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b41886c30d4e14c8f6d7e609b4138981f477da46","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  let(:title) {\u0027flashblade\u0027}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  let :params do"},{"line_number":8,"context_line":"    {"},{"line_number":9,"context_line":"      :flashblade_eradicate          \u003d\u003e true,"},{"line_number":10,"context_line":"      :driver_handles_share_servers  \u003d\u003e true,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"61e07e77_fbfb5ddb","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":13},"updated":"2021-05-27 14:02:04.000000000","message":"driver_handles_share_servers should be tested as well (unless you remove the parameter)","commit_id":"3592a4ad7608823346d25be1c4aa7c78141b6ad9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"edfe04766a0bc2d75337a54b898bd1d357171084","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  let(:title) {\u0027flashblade\u0027}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  let :params do"},{"line_number":8,"context_line":"    {"},{"line_number":9,"context_line":"      :flashblade_eradicate          \u003d\u003e true,"},{"line_number":10,"context_line":"      :driver_handles_share_servers  \u003d\u003e true,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"4e7fb337_5a2b5b61","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":13},"in_reply_to":"524fa822_d0007066","updated":"2021-06-07 14:20:22.000000000","message":"Ack","commit_id":"3592a4ad7608823346d25be1c4aa7c78141b6ad9"},{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"3271856ff42939f500bbc768771ce80865377f5d","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  let(:title) {\u0027flashblade\u0027}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  let :params do"},{"line_number":8,"context_line":"    {"},{"line_number":9,"context_line":"      :flashblade_eradicate          \u003d\u003e true,"},{"line_number":10,"context_line":"      :driver_handles_share_servers  \u003d\u003e true,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"7e944fd0_b463110c","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":13},"in_reply_to":"61e07e77_fbfb5ddb","updated":"2021-05-27 15:23:23.000000000","message":"As in other comment - I am following the standard template for every other driver and not being a puppet or ruby person I\u0027m not sure I would even know how to make the changes you are requesting","commit_id":"3592a4ad7608823346d25be1c4aa7c78141b6ad9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8f61aed89c3af31f77d4157ef3ee6b2ee3e6aaad","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  let(:title) {\u0027flashblade\u0027}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  let :params do"},{"line_number":8,"context_line":"    {"},{"line_number":9,"context_line":"      :flashblade_eradicate          \u003d\u003e true,"},{"line_number":10,"context_line":"      :driver_handles_share_servers  \u003d\u003e true,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"524fa822_d0007066","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":13},"in_reply_to":"7e944fd0_b463110c","updated":"2021-06-05 04:31:55.000000000","message":"Sorry but ignore my first comment. I somehow missed the parameter in L10.","commit_id":"3592a4ad7608823346d25be1c4aa7c78141b6ad9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b41886c30d4e14c8f6d7e609b4138981f477da46","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"  end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  shared_examples_for \u0027flashblade share driver\u0027 do"},{"line_number":18,"context_line":"    it \u0027configures flashblade share driver\u0027 do"},{"line_number":19,"context_line":"      is_expected.to contain_manila_config(\"flashblade/share_driver\").with_value("},{"line_number":20,"context_line":"\t      \u0027manila.share.drivers.purestorage.flashblade.FlashBladeShareDriver\u0027)"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"2b08d2e3_41bce02c","line":17,"range":{"start_line":17,"start_character":2,"end_line":17,"end_character":21},"updated":"2021-05-27 14:02:04.000000000","message":"I think you don\u0027t need an independent share_examples_for block here but you can put the following test cases directly under L33.","commit_id":"3592a4ad7608823346d25be1c4aa7c78141b6ad9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"edfe04766a0bc2d75337a54b898bd1d357171084","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"  end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  shared_examples_for \u0027flashblade share driver\u0027 do"},{"line_number":18,"context_line":"    it \u0027configures flashblade share driver\u0027 do"},{"line_number":19,"context_line":"      is_expected.to contain_manila_config(\"flashblade/share_driver\").with_value("},{"line_number":20,"context_line":"\t      \u0027manila.share.drivers.purestorage.flashblade.FlashBladeShareDriver\u0027)"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"e09a78cd_637890ab","line":17,"range":{"start_line":17,"start_character":2,"end_line":17,"end_character":21},"in_reply_to":"2b08d2e3_41bce02c","updated":"2021-06-07 14:20:22.000000000","message":"Ack","commit_id":"3592a4ad7608823346d25be1c4aa7c78141b6ad9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b41886c30d4e14c8f6d7e609b4138981f477da46","unresolved":true,"context_lines":[{"line_number":34,"context_line":"      it_configures \u0027flashblade share driver\u0027"},{"line_number":35,"context_line":"    end"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    context \u0027with share server config\u0027 do"},{"line_number":38,"context_line":"      before do"},{"line_number":39,"context_line":"        params.merge!({"},{"line_number":40,"context_line":"          :flashblade_api \u003d\u003e true,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ea4a53ce_d397023f","line":37,"range":{"start_line":37,"start_character":13,"end_line":37,"end_character":37},"updated":"2021-05-27 14:02:04.000000000","message":"This doesn\u0027t explain what is tested here.","commit_id":"3592a4ad7608823346d25be1c4aa7c78141b6ad9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"edfe04766a0bc2d75337a54b898bd1d357171084","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      it_configures \u0027flashblade share driver\u0027"},{"line_number":35,"context_line":"    end"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    context \u0027with share server config\u0027 do"},{"line_number":38,"context_line":"      before do"},{"line_number":39,"context_line":"        params.merge!({"},{"line_number":40,"context_line":"          :flashblade_api \u003d\u003e true,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"593292d3_2f37f147","line":37,"range":{"start_line":37,"start_character":13,"end_line":37,"end_character":37},"in_reply_to":"ea4a53ce_d397023f","updated":"2021-06-07 14:20:22.000000000","message":"Ack","commit_id":"3592a4ad7608823346d25be1c4aa7c78141b6ad9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f6bf0cec5bf507ae484dd1165dd1fa118b2ff226","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    {"},{"line_number":9,"context_line":"      :flashblade_api                \u003d\u003e \u0027admin\u0027,"},{"line_number":10,"context_line":"      :flashblade_mgmt_vip           \u003d\u003e \u002710.1.1.1\u0027,"},{"line_number":11,"context_line":"      :flashblade_data_vip           \u003d\u003e \u002710.1.1.2\u0027,"},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"  end"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":7,"id":"d9602330_11a66114","line":11,"range":{"start_line":11,"start_character":27,"end_line":11,"end_character":37},"updated":"2021-06-07 14:31:41.000000000","message":"(nit) you can remove these spaces","commit_id":"35394ccd8f57a9174230236f09ccce78c0a021d9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"e2eca9445a355684d737c4ddf793f44d7ddda934","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    {"},{"line_number":9,"context_line":"      :flashblade_api                \u003d\u003e \u0027admin\u0027,"},{"line_number":10,"context_line":"      :flashblade_mgmt_vip           \u003d\u003e \u002710.1.1.1\u0027,"},{"line_number":11,"context_line":"      :flashblade_data_vip           \u003d\u003e \u002710.1.1.2\u0027,"},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"  end"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":7,"id":"78fe5e0f_787268b2","line":11,"range":{"start_line":11,"start_character":27,"end_line":11,"end_character":37},"in_reply_to":"d9602330_11a66114","updated":"2021-06-07 14:57:36.000000000","message":"Done","commit_id":"35394ccd8f57a9174230236f09ccce78c0a021d9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f6bf0cec5bf507ae484dd1165dd1fa118b2ff226","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  let :default_params do"},{"line_number":16,"context_line":"    {"},{"line_number":17,"context_line":"     :flashblade_eradicate          \u003d\u003e true,"},{"line_number":18,"context_line":"    }"},{"line_number":19,"context_line":"  end"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":7,"id":"4b3ca6d7_757658c2","line":17,"range":{"start_line":17,"start_character":27,"end_line":17,"end_character":36},"updated":"2021-06-07 14:31:41.000000000","message":"(nit) you can remove these spaces","commit_id":"35394ccd8f57a9174230236f09ccce78c0a021d9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"e2eca9445a355684d737c4ddf793f44d7ddda934","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  let :default_params do"},{"line_number":16,"context_line":"    {"},{"line_number":17,"context_line":"     :flashblade_eradicate          \u003d\u003e true,"},{"line_number":18,"context_line":"    }"},{"line_number":19,"context_line":"  end"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":7,"id":"1e1f0a42_e8613d87","line":17,"range":{"start_line":17,"start_character":27,"end_line":17,"end_character":36},"in_reply_to":"4b3ca6d7_757658c2","updated":"2021-06-07 14:57:36.000000000","message":"Done","commit_id":"35394ccd8f57a9174230236f09ccce78c0a021d9"}]}