)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b21a6e521f4850f2c82944aaaa8dbf610b69b7e5","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Add new \"backend_availability_zone\" parameter to every share"},{"line_number":10,"context_line":"backend. The parameters are optional, and when set they override the"},{"line_number":11,"context_line":"DEFAULT/storage_availability_zone for the corresponding backend."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"(cherry picked from commit Ie7af8408fe8cec9349593fd9b4cb5bc7deb565cd)"},{"line_number":14,"context_line":"Change-Id: I62eb4815320c36a37be6f8b10d35f236417a103f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"399a0e3d_20a04228","line":12,"updated":"2021-10-28 12:07:13.000000000","message":"I tried the same backport in my local but git detected conflicts about some files. Please consider leaving that conflict information in commit message.","commit_id":"014810356d40f3fd76a2c6d979f54501ae37e6ae"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0781e94f627587188b937fea0881a33458159d8d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add new \"backend_availability_zone\" parameter to every share"},{"line_number":10,"context_line":"backend. The parameters are optional, and when set they override the"},{"line_number":11,"context_line":"DEFAULT/storage_availability_zone for the corresponding backend."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"(cherry picked from commit Ie7af8408fe8cec9349593fd9b4cb5bc7deb565cd)"},{"line_number":14,"context_line":"Change-Id: I62eb4815320c36a37be6f8b10d35f236417a103f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6e3d7172_a5eec0a3","line":12,"in_reply_to":"399a0e3d_20a04228","updated":"2021-10-28 15:38:53.000000000","message":"Done","commit_id":"014810356d40f3fd76a2c6d979f54501ae37e6ae"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b21a6e521f4850f2c82944aaaa8dbf610b69b7e5","unresolved":true,"context_lines":[{"line_number":10,"context_line":"backend. The parameters are optional, and when set they override the"},{"line_number":11,"context_line":"DEFAULT/storage_availability_zone for the corresponding backend."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"(cherry picked from commit Ie7af8408fe8cec9349593fd9b4cb5bc7deb565cd)"},{"line_number":14,"context_line":"Change-Id: I62eb4815320c36a37be6f8b10d35f236417a103f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"037e1714_5401d5db","line":13,"range":{"start_line":13,"start_character":27,"end_line":13,"end_character":68},"updated":"2021-10-28 12:07:13.000000000","message":"This should be commit hash instead of change id.\nAlso, please put this line AFTER Change-Id line.","commit_id":"014810356d40f3fd76a2c6d979f54501ae37e6ae"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0781e94f627587188b937fea0881a33458159d8d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"backend. The parameters are optional, and when set they override the"},{"line_number":11,"context_line":"DEFAULT/storage_availability_zone for the corresponding backend."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"(cherry picked from commit Ie7af8408fe8cec9349593fd9b4cb5bc7deb565cd)"},{"line_number":14,"context_line":"Change-Id: I62eb4815320c36a37be6f8b10d35f236417a103f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ea0fbb2c_48eae43d","line":13,"range":{"start_line":13,"start_character":27,"end_line":13,"end_character":68},"in_reply_to":"037e1714_5401d5db","updated":"2021-10-28 15:38:53.000000000","message":"Solving this issue. My local env is adding a new change-id automatically after a commit amend if it does not identify the change-id as the last item of the commit message","commit_id":"014810356d40f3fd76a2c6d979f54501ae37e6ae"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4c1011da9eb2ddd19a7edf52c4f6f5ff1e6b0ece","unresolved":true,"context_lines":[{"line_number":10,"context_line":"backend. The parameters are optional, and when set they override the"},{"line_number":11,"context_line":"DEFAULT/storage_availability_zone for the corresponding backend."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"(cherry picked from commit Ie7af8408fe8cec9349593fd9b4cb5bc7deb565cd)"},{"line_number":14,"context_line":"Change-Id: I62eb4815320c36a37be6f8b10d35f236417a103f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5295dd82_429438ff","line":13,"range":{"start_line":13,"start_character":27,"end_line":13,"end_character":68},"in_reply_to":"a7a0b6b8_66ca48ec","updated":"2021-10-28 18:56:29.000000000","message":"\u003e I guess you inserted a single line between Change-Id and (cherry picked ... ) line like the following example ?\n\nyep, that is the issue. Thanks!","commit_id":"014810356d40f3fd76a2c6d979f54501ae37e6ae"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f277cb2bde07520028292aa9573d6988f31aa535","unresolved":true,"context_lines":[{"line_number":10,"context_line":"backend. The parameters are optional, and when set they override the"},{"line_number":11,"context_line":"DEFAULT/storage_availability_zone for the corresponding backend."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"(cherry picked from commit Ie7af8408fe8cec9349593fd9b4cb5bc7deb565cd)"},{"line_number":14,"context_line":"Change-Id: I62eb4815320c36a37be6f8b10d35f236417a103f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a7a0b6b8_66ca48ec","line":13,"range":{"start_line":13,"start_character":27,"end_line":13,"end_character":68},"in_reply_to":"ea0fbb2c_48eae43d","updated":"2021-10-28 16:07:30.000000000","message":"I guess you inserted a single line between Change-Id and (cherry picked ... ) line like the following example ?\n\n```\nAdd ability\n\n...\n\nChange-Id: ....\n\n(cherry picked from commit a06...)\n```\n\nChange ID should be included in \"the last paragraph\" so you should not have any blank line below that.","commit_id":"014810356d40f3fd76a2c6d979f54501ae37e6ae"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f277cb2bde07520028292aa9573d6988f31aa535","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"(cherry picked from commit a0610b687eb4eefc5b9b6203d75fdaa2ad2b23b1)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I62eb4815320c36a37be6f8b10d35f236417a103f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"12e50707_fbb5411f","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":52},"updated":"2021-10-28 16:07:30.000000000","message":"I overlooked this in my initial review but we should NOT change Change-Id during backport and should use the same id. If you backport patch by\n $ git cherry-pick -x \u003cchange id\u003e\nthen it should not change anything but just add the cherry pick line, which you can find in https://review.opendev.org/c/openstack/puppet-manila/+/815862","commit_id":"54758e526f224f7429dd81db3c56651a6a80154c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4c1011da9eb2ddd19a7edf52c4f6f5ff1e6b0ece","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"(cherry picked from commit a0610b687eb4eefc5b9b6203d75fdaa2ad2b23b1)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I62eb4815320c36a37be6f8b10d35f236417a103f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"237e1071_d4102f7b","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":52},"in_reply_to":"12e50707_fbb5411f","updated":"2021-10-28 18:56:29.000000000","message":"Ack, thanks!","commit_id":"54758e526f224f7429dd81db3c56651a6a80154c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0781e94f627587188b937fea0881a33458159d8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"95cac1f2_2504d7f0","updated":"2021-10-28 15:38:53.000000000","message":"Thanks for the review, Takashi!\nStill need to solve the change id order issue though :)\nWill update that soon","commit_id":"54758e526f224f7429dd81db3c56651a6a80154c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"06b8171c94fd6d5a74c3f1c872fe9f04a9d0b5ba","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"763bfaf9_f8e0fddc","in_reply_to":"0e6afaf0_6ac8f51b","updated":"2021-10-29 04:45:20.000000000","message":"Yeah we should abandon this. If you properly cherry-pick the change and propose it, then gerrit just updates that path 815862 because it assumes two changes with the same commit id should be the same.","commit_id":"54758e526f224f7429dd81db3c56651a6a80154c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"47af62e69ed966377b7e4ab191a31e6cf4433a75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cebaf00d_9141c2a4","in_reply_to":"763bfaf9_f8e0fddc","updated":"2021-10-29 12:18:16.000000000","message":"Ack. Thank you very much, Takashi!","commit_id":"54758e526f224f7429dd81db3c56651a6a80154c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f277cb2bde07520028292aa9573d6988f31aa535","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b0ad1e40_3ead3174","in_reply_to":"95cac1f2_2504d7f0","updated":"2021-10-28 16:07:30.000000000","message":"I tried to fix this by my side, but it turned out change id is somehow edited during backport and gerrit creates a separate review because of different change ids.\nAs I mentioned in a different commit, we should keep change id during backport so the following review with the correct change id should be used instead.\n\nhttps://review.opendev.org/c/openstack/puppet-manila/+/815862","commit_id":"54758e526f224f7429dd81db3c56651a6a80154c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4c1011da9eb2ddd19a7edf52c4f6f5ff1e6b0ece","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0e6afaf0_6ac8f51b","in_reply_to":"b0ad1e40_3ead3174","updated":"2021-10-28 18:56:29.000000000","message":"\u003e As I mentioned in a different commit, we should keep change id during backport so the following review with the correct change id should be used instead.\nAck, thanks for explaining.\nAs we have the other change already corrected, wdyt about using that and abandoning this?","commit_id":"54758e526f224f7429dd81db3c56651a6a80154c"}],"manifests/backend/dellemc_isilon.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a833f0f2df945d68e87e2427179b83914eac1547","unresolved":true,"context_lines":[{"line_number":66,"context_line":"  $emc_nas_password,"},{"line_number":67,"context_line":"  $emc_nas_server,"},{"line_number":68,"context_line":"  $emc_share_backend,"},{"line_number":69,"context_line":"  $backend_availability_zone \u003d $::os_service_default,"},{"line_number":70,"context_line":"  $share_backend_name        \u003d $name,"},{"line_number":71,"context_line":"  $emc_nas_root_dir          \u003d undef,"},{"line_number":72,"context_line":"  $emc_nas_server_port       \u003d 8080,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"77e59575_709dc114","line":69,"range":{"start_line":69,"start_character":2,"end_line":69,"end_character":53},"updated":"2021-10-28 12:10:01.000000000","message":"This should be inserted after share_backend_name to make this consistent with the original change.","commit_id":"014810356d40f3fd76a2c6d979f54501ae37e6ae"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0781e94f627587188b937fea0881a33458159d8d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  $emc_nas_password,"},{"line_number":67,"context_line":"  $emc_nas_server,"},{"line_number":68,"context_line":"  $emc_share_backend,"},{"line_number":69,"context_line":"  $backend_availability_zone \u003d $::os_service_default,"},{"line_number":70,"context_line":"  $share_backend_name        \u003d $name,"},{"line_number":71,"context_line":"  $emc_nas_root_dir          \u003d undef,"},{"line_number":72,"context_line":"  $emc_nas_server_port       \u003d 8080,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"100f090d_83002cde","line":69,"range":{"start_line":69,"start_character":2,"end_line":69,"end_character":53},"in_reply_to":"77e59575_709dc114","updated":"2021-10-28 15:38:53.000000000","message":"Done","commit_id":"014810356d40f3fd76a2c6d979f54501ae37e6ae"}]}