)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9b9727cc19836b68162350705378a60138cc5fa3","unresolved":true,"context_lines":[{"line_number":10,"context_line":"backend. The parameters are optional, and when set they override the"},{"line_number":11,"context_line":"DEFAULT/storage_availability_zone for the corresponding backend."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Conflicts:"},{"line_number":14,"context_line":"\tmanifests/backend/dellemc_isilon.pp"},{"line_number":15,"context_line":"\tmanifests/backend/dellemc_vmax.pp"},{"line_number":16,"context_line":"\tmanifests/backend/dellemc_vnx.pp"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"804cf0e1_fadb48d0","line":13,"updated":"2021-10-28 16:13:59.000000000","message":"In projects like cinder, we require the list of conflicts to immediately follow the corresponding \"cherry picked from\" line, so my advice is to move the list so it follows L26 (with no intervening blank line).\n\nThe reason for doing it that way is it lets you correlate the list of conflicts with the associated cherry pick, and supports multiple conflict lists in situations where the patch is backported across multiple releases. For example, if this patch were a candidate for backporting to ussuri, you might need to resolve a different set of conflicts.","commit_id":"d1f4d26268f5bd4980d7eff4dae6ed3c61fd012b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bc43a2d11c019c3d97c590f83f6348eaa9eb1ded","unresolved":true,"context_lines":[{"line_number":10,"context_line":"backend. The parameters are optional, and when set they override the"},{"line_number":11,"context_line":"DEFAULT/storage_availability_zone for the corresponding backend."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Conflicts:"},{"line_number":14,"context_line":"\tmanifests/backend/dellemc_isilon.pp"},{"line_number":15,"context_line":"\tmanifests/backend/dellemc_vmax.pp"},{"line_number":16,"context_line":"\tmanifests/backend/dellemc_vnx.pp"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5c6686b0_f13fb2c9","line":13,"in_reply_to":"3483d855_7b1a2cae","updated":"2021-10-29 05:02:58.000000000","message":"Hmm... I went through the other repos but that usage is not yet very common (even in cinder) so I reverted back the change with additional notes assuming it\u0027s be better to stick on conventional practice for now to keep \"consistency\" here.\n\nOn the other hand I personally agree with that idea and I think it\u0027s very good improvement. Maybe we can raise that topic to openstack-discuss ml to hear whether the other projects also like the idean and they are interested in introducing that as part of commin basic guideline.","commit_id":"d1f4d26268f5bd4980d7eff4dae6ed3c61fd012b"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9dec77dbc1851f5061dd154fb938c3375465c2e8","unresolved":true,"context_lines":[{"line_number":10,"context_line":"backend. The parameters are optional, and when set they override the"},{"line_number":11,"context_line":"DEFAULT/storage_availability_zone for the corresponding backend."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Conflicts:"},{"line_number":14,"context_line":"\tmanifests/backend/dellemc_isilon.pp"},{"line_number":15,"context_line":"\tmanifests/backend/dellemc_vmax.pp"},{"line_number":16,"context_line":"\tmanifests/backend/dellemc_vnx.pp"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"09aa34cc_78b8e293","line":13,"in_reply_to":"5c6686b0_f13fb2c9","updated":"2021-10-29 15:42:37.000000000","message":"I guess maybe it\u0027s more of a downstream convention for my team. I\u0027m not optimistic about getting consensus in the wider community to adopt almost any kind of coding/comment style (everyone has an opinion), which is why I offered the idea as just a suggestion. Your latest patch set looks fine.","commit_id":"d1f4d26268f5bd4980d7eff4dae6ed3c61fd012b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3b724c793889aa2f01ef8845a2fafe2dd2ba32a2","unresolved":true,"context_lines":[{"line_number":10,"context_line":"backend. The parameters are optional, and when set they override the"},{"line_number":11,"context_line":"DEFAULT/storage_availability_zone for the corresponding backend."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Conflicts:"},{"line_number":14,"context_line":"\tmanifests/backend/dellemc_isilon.pp"},{"line_number":15,"context_line":"\tmanifests/backend/dellemc_vmax.pp"},{"line_number":16,"context_line":"\tmanifests/backend/dellemc_vnx.pp"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3483d855_7b1a2cae","line":13,"in_reply_to":"804cf0e1_fadb48d0","updated":"2021-10-29 04:49:49.000000000","message":"Ah I was not aware of that practice but that makes sense. I usually end up with adding a second conflicts note but adding it to the bottom sounds much simpler.\n\nI\u0027ll update the patch to follow that and let\u0027s see how the other reviewers respond to that.","commit_id":"d1f4d26268f5bd4980d7eff4dae6ed3c61fd012b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2bbe94c3cc2758f18a574f84f34792de4d391087","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f05f93b3_ee6e6ff8","updated":"2021-10-29 18:18:43.000000000","message":"Thanks, Takashi!","commit_id":"6d311078f7e0b575fe5226fd07dfeee56baebd8a"}]}