)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"91c77b3e1a8d748148af1aa564348e8c360ce805","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9da81d14_6e1354bd","updated":"2021-11-17 00:43:29.000000000","message":"I\u0027m wondering if we couldn\u0027t just rename the dellemc_vmax to dellemc_powermax a","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"faca41a5ec39e8aeb59fbd0b172bb6582566ad9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0c65ec0f_d08532e1","updated":"2021-11-16 23:26:39.000000000","message":"Please add unit tests following what we have in spec/defines/manila_backend_dellemc_vmax_spec.rb .\n\nAlso, a release note file should be added to document the change.","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4130af3c06248098c7dfbecc836bd27859e4aa6c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fe9f7580_2d2b2658","in_reply_to":"0c65ec0f_d08532e1","updated":"2021-11-16 23:27:36.000000000","message":"In addition, we should deperecate manila::backend::demmemc_vmax. If you are not familiar with the way then leave it and I\u0027ll cover that in a follow-up","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5e927f94d985c20d5e82e11d01c577ed39f372dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"53ba3c6f_f00949b9","in_reply_to":"9da81d14_6e1354bd","updated":"2021-11-17 01:14:22.000000000","message":"We should not just rename the class, because it breaks the existing interface. We should deprecate the existing one and add a new one to leave migration period.","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"91c77b3e1a8d748148af1aa564348e8c360ce805","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"62ea66cb_23125e3e","in_reply_to":"fe9f7580_2d2b2658","updated":"2021-11-17 00:43:29.000000000","message":"We should definitely deprecate it ... if it\u0027s documented somewhere, I can do that otherwise you can do it unless I have another commit I can base myself on.\n\nI added the same unit file as VMAX to PowerMax , created a release note ... let me know if there\u0027s other things you\u0027d improve.","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"94c34e79af728410b0d5148106112e850b9408d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"aa232e40_c2c7922c","updated":"2021-11-17 00:41:27.000000000","message":"Thanks for resolving issues you found, Takashi - please ignore my comments about them on PS#1. There are a couple of options missing that could be added as well; here\u0027s a sample manila.conf from one of our CI builds: https://zuul.opendev.org/t/openstack/build/c65c113ef6ba4174a11a73ae6a86b8ed/log/manila.conf.sample","commit_id":"1738daca38f4906192d80ff7fa3c15eca21b14e2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5e927f94d985c20d5e82e11d01c577ed39f372dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4b525947_8030f27c","updated":"2021-11-17 01:14:22.000000000","message":"It sees our updates conflicted. sorry about that.","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"fdb96e5cf3f3e9caca5ab1f7696b959c68c2d73d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"452a9d35_d9b95635","updated":"2021-11-19 02:16:17.000000000","message":"Are we sure we like that title/description ?  I did that as a WIP/PoC for myself but maybe we could improve that too.","commit_id":"2115a47221d49f443f3c28abc4d49f7c8ea3a667"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5438e2395d7194fa5313251e8ecf3c6464904077","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"23269e08_9e495fc8","updated":"2021-11-17 23:45:32.000000000","message":"Thank you both, LGTM!","commit_id":"2115a47221d49f443f3c28abc4d49f7c8ea3a667"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6c4d1accec25c139c4db8d4394425bacfb14c70a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"42dd21c2_8e9968da","in_reply_to":"452a9d35_d9b95635","updated":"2021-11-19 03:52:40.000000000","message":"It was not best but explains what is/should be changed. \n\nAnyway I updated the comment to explain the change and its context more clearly. Hope this looks good to everyone.","commit_id":"2115a47221d49f443f3c28abc4d49f7c8ea3a667"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8eb20d11228cb83d75f109c0194972e072f172b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"bb24f312_e273a12b","updated":"2021-11-22 20:01:20.000000000","message":"Thanks!","commit_id":"2e56767d7a9d8bd500bdbc094d4e22c2d5b71c12"}],"manifests/backend/dellemc_powermax.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"faca41a5ec39e8aeb59fbd0b172bb6582566ad9c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d define: manila::backend::dellemc_powermax"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Configures Manila to use the Dell EMC Isilon share driver"},{"line_number":4,"context_line":"# Compatible for multiple backends"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# \u003d\u003d\u003d Parameters"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"039b26c3_ae50c68b","line":3,"range":{"start_line":3,"start_character":40,"end_line":3,"end_character":46},"updated":"2021-11-16 23:26:39.000000000","message":"PowerMAX","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ef0a12561f140f0ef1932fa8c4c005850f33532c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d define: manila::backend::dellemc_powermax"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Configures Manila to use the Dell EMC Isilon share driver"},{"line_number":4,"context_line":"# Compatible for multiple backends"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# \u003d\u003d\u003d Parameters"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7833cac4_7be5a240","line":3,"range":{"start_line":3,"start_character":40,"end_line":3,"end_character":46},"in_reply_to":"039b26c3_ae50c68b","updated":"2021-11-16 23:28:11.000000000","message":"Seems tt should be \"PowerMax\" instead.","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"91c77b3e1a8d748148af1aa564348e8c360ce805","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d define: manila::backend::dellemc_powermax"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Configures Manila to use the Dell EMC Isilon share driver"},{"line_number":4,"context_line":"# Compatible for multiple backends"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# \u003d\u003d\u003d Parameters"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1c4da20f_cf16d898","line":3,"range":{"start_line":3,"start_character":40,"end_line":3,"end_character":46},"in_reply_to":"7833cac4_7be5a240","updated":"2021-11-17 00:43:29.000000000","message":"I copied the dellemc_vmax.pp file and it has that too.   Maybe another commit to fix that other file or should we throw everything in this one ?","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1c6014eeadcf63948cd23ed92754a750672d5597","unresolved":true,"context_lines":[{"line_number":8,"context_line":"# [*emc_nas_login*]"},{"line_number":9,"context_line":"#   (required) Administrative user account name used to access the storage"},{"line_number":10,"context_line":"#   system."},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# [*emc_nas_password*]"},{"line_number":13,"context_line":"#   (required) Password for the administrative user account specified in the"},{"line_number":14,"context_line":"#   emc_nas_login parameter."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"6d132abb_7d098dce","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":1},"updated":"2021-11-17 00:39:19.000000000","message":"Missing connection opt here: \n\n# Port number for the EMC server. (port value)\n# Minimum value: 0\n# Maximum value: 65535\n#emc_nas_server_port \u003d 8080","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"b65e557d69073ac836512036e7c629684087cd24","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# [*emc_nas_login*]"},{"line_number":9,"context_line":"#   (required) Administrative user account name used to access the storage"},{"line_number":10,"context_line":"#   system."},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# [*emc_nas_password*]"},{"line_number":13,"context_line":"#   (required) Password for the administrative user account specified in the"},{"line_number":14,"context_line":"#   emc_nas_login parameter."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"a7f14736_bf4fe19e","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":1},"in_reply_to":"6d132abb_7d098dce","updated":"2021-11-17 01:03:22.000000000","message":"Ack","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1c6014eeadcf63948cd23ed92754a750672d5597","unresolved":true,"context_lines":[{"line_number":16,"context_line":"# [*emc_nas_server*]"},{"line_number":17,"context_line":"#   (required) The hostname (or IP address) for the storage system."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*emc_share_backend*]"},{"line_number":20,"context_line":"#   (required) Share backend."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*share_backend_name*]"},{"line_number":23,"context_line":"#   (optional) Name of the backend in manila.conf that"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f98e8e2_4cd7dbca","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":29},"updated":"2021-11-17 00:39:19.000000000","message":"Not a required opt - we can set the default here to \"powermax\"; see Takashi\u0027s fix to the rest of the manifests here:\n\nhttps://review.opendev.org/c/openstack/puppet-manila/+/818180","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"b65e557d69073ac836512036e7c629684087cd24","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# [*emc_nas_server*]"},{"line_number":17,"context_line":"#   (required) The hostname (or IP address) for the storage system."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*emc_share_backend*]"},{"line_number":20,"context_line":"#   (required) Share backend."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*share_backend_name*]"},{"line_number":23,"context_line":"#   (optional) Name of the backend in manila.conf that"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"cfa07dda_95a89f1a","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":29},"in_reply_to":"3f98e8e2_4cd7dbca","updated":"2021-11-17 01:03:22.000000000","message":"Ack","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1c6014eeadcf63948cd23ed92754a750672d5597","unresolved":true,"context_lines":[{"line_number":22,"context_line":"# [*share_backend_name*]"},{"line_number":23,"context_line":"#   (optional) Name of the backend in manila.conf that"},{"line_number":24,"context_line":"#   these settings will reside in"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*backend_availability_zone*]"},{"line_number":27,"context_line":"#   (Optional) Availability zone for this share backend."},{"line_number":28,"context_line":"#   If not set, the storage_availability_zone option value"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9cc139ca_6d8259e8","line":25,"updated":"2021-11-17 00:39:19.000000000","message":"Missing opt:\n\n# The root directory where shares will be located. (string value)\n#emc_nas_root_dir \u003d \u003cNone\u003e","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"b65e557d69073ac836512036e7c629684087cd24","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# [*share_backend_name*]"},{"line_number":23,"context_line":"#   (optional) Name of the backend in manila.conf that"},{"line_number":24,"context_line":"#   these settings will reside in"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*backend_availability_zone*]"},{"line_number":27,"context_line":"#   (Optional) Availability zone for this share backend."},{"line_number":28,"context_line":"#   If not set, the storage_availability_zone option value"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"b7096277_ff3d4f63","line":25,"in_reply_to":"9cc139ca_6d8259e8","updated":"2021-11-17 01:03:22.000000000","message":"Ack","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1c6014eeadcf63948cd23ed92754a750672d5597","unresolved":true,"context_lines":[{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*driver_handles_share_servers*]"},{"line_number":66,"context_line":"#  (optional) Denotes whether the driver should handle the responsibility of"},{"line_number":67,"context_line":"#   managing share servers. This must be set to false if the driver is to"},{"line_number":68,"context_line":"#   operate without managing share servers."},{"line_number":69,"context_line":"#   VMAX driver requires this option to be as True."},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":"# \u003d\u003d\u003d Examples"},{"line_number":72,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"93581b9e_fe09069b","line":69,"range":{"start_line":65,"start_character":0,"end_line":69,"end_character":51},"updated":"2021-11-17 00:39:19.000000000","message":"Agree with the comment below; no need for this parameter - the driver only supports driver_handles_share_servers\u003dTrue","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"b65e557d69073ac836512036e7c629684087cd24","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*driver_handles_share_servers*]"},{"line_number":66,"context_line":"#  (optional) Denotes whether the driver should handle the responsibility of"},{"line_number":67,"context_line":"#   managing share servers. This must be set to false if the driver is to"},{"line_number":68,"context_line":"#   operate without managing share servers."},{"line_number":69,"context_line":"#   VMAX driver requires this option to be as True."},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":"# \u003d\u003d\u003d Examples"},{"line_number":72,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"4462ffe0_58cd20d9","line":69,"range":{"start_line":65,"start_character":0,"end_line":69,"end_character":51},"in_reply_to":"93581b9e_fe09069b","updated":"2021-11-17 01:03:22.000000000","message":"Ack but I feel this cleanup should be done in a different commit (imo).","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"faca41a5ec39e8aeb59fbd0b172bb6582566ad9c","unresolved":true,"context_lines":[{"line_number":91,"context_line":"  $emc_ssl_cert_path            \u003d $::os_service_default,"},{"line_number":92,"context_line":"  $emc_ssl_cert_verify          \u003d $::os_service_default,"},{"line_number":93,"context_line":"  $package_ensure               \u003d \u0027present\u0027,"},{"line_number":94,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":95,"context_line":"  $driver_handles_share_servers \u003d undef,"},{"line_number":96,"context_line":") {"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  include manila::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"4bf6444f_7baa7f63","line":95,"range":{"start_line":94,"start_character":0,"end_line":95,"end_character":40},"updated":"2021-11-16 23:26:39.000000000","message":"This parameter should be removed.","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"b65e557d69073ac836512036e7c629684087cd24","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  $emc_ssl_cert_path            \u003d $::os_service_default,"},{"line_number":92,"context_line":"  $emc_ssl_cert_verify          \u003d $::os_service_default,"},{"line_number":93,"context_line":"  $package_ensure               \u003d \u0027present\u0027,"},{"line_number":94,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":95,"context_line":"  $driver_handles_share_servers \u003d undef,"},{"line_number":96,"context_line":") {"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  include manila::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"b1bba47c_696e06ec","line":95,"range":{"start_line":94,"start_character":0,"end_line":95,"end_character":40},"in_reply_to":"4bf6444f_7baa7f63","updated":"2021-11-17 01:03:22.000000000","message":"Ack","commit_id":"c0c2369bddae6371b4e2e5b53da473055f768555"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5e927f94d985c20d5e82e11d01c577ed39f372dd","unresolved":true,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# [*emc_nas_server*]"},{"line_number":17,"context_line":"#   (required) The hostname (or IP address) for the storage system."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*share_backend_name*]"},{"line_number":20,"context_line":"#   (optional) Name of the backend in manila.conf that"},{"line_number":21,"context_line":"#   these settings will reside in"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"42079147_e4e1102e","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":1},"updated":"2021-11-17 01:14:22.000000000","message":"Description of emc_share_backend should not be removed as long as the parameter is kept.","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"14d5d1f10764389332c08aab085370be2d7b2010","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# [*emc_nas_server*]"},{"line_number":17,"context_line":"#   (required) The hostname (or IP address) for the storage system."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*share_backend_name*]"},{"line_number":20,"context_line":"#   (optional) Name of the backend in manila.conf that"},{"line_number":21,"context_line":"#   these settings will reside in"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"d96b89de_5ac2e418","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":1},"in_reply_to":"42079147_e4e1102e","updated":"2021-11-17 01:59:28.000000000","message":"Done","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5e927f94d985c20d5e82e11d01c577ed39f372dd","unresolved":true,"context_lines":[{"line_number":78,"context_line":"  $emc_nas_login,"},{"line_number":79,"context_line":"  $emc_nas_password,"},{"line_number":80,"context_line":"  $emc_nas_server,"},{"line_number":81,"context_line":"  $emc_share_backend            \u003d \u0027powermax\u0027,"},{"line_number":82,"context_line":"  $share_backend_name           \u003d $name,"},{"line_number":83,"context_line":"  $backend_availability_zone    \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $powermax_server_container    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"8d847993_09dd2ff2","line":81,"range":{"start_line":81,"start_character":29,"end_line":81,"end_character":32},"updated":"2021-11-17 01:14:22.000000000","message":"(nit) redundant spaces","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"14d5d1f10764389332c08aab085370be2d7b2010","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  $emc_nas_login,"},{"line_number":79,"context_line":"  $emc_nas_password,"},{"line_number":80,"context_line":"  $emc_nas_server,"},{"line_number":81,"context_line":"  $emc_share_backend            \u003d \u0027powermax\u0027,"},{"line_number":82,"context_line":"  $share_backend_name           \u003d $name,"},{"line_number":83,"context_line":"  $backend_availability_zone    \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $powermax_server_container    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"8e7f8636_4f994c2f","line":81,"range":{"start_line":81,"start_character":29,"end_line":81,"end_character":32},"in_reply_to":"8d847993_09dd2ff2","updated":"2021-11-17 01:59:28.000000000","message":"Done","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5e927f94d985c20d5e82e11d01c577ed39f372dd","unresolved":true,"context_lines":[{"line_number":99,"context_line":"  $powermax_share_driver \u003d \u0027manila.share.drivers.dell_emc.driver.EMCShareDriver\u0027"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  manila_config {"},{"line_number":102,"context_line":"    \"${share_backend_name}/share_driver\":                 value \u003d\u003e $powermax_share_driver;"},{"line_number":103,"context_line":"    \"${share_backend_name}/emc_nas_login\":                value \u003d\u003e $emc_nas_login;"},{"line_number":104,"context_line":"    \"${share_backend_name}/emc_nas_password\":             value \u003d\u003e $emc_nas_password, secret \u003d\u003e true;"},{"line_number":105,"context_line":"    \"${share_backend_name}/emc_nas_root_dir\":             value \u003d\u003e $emc_nas_root_dir;"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"a457a802_6dde65f0","line":102,"range":{"start_line":102,"start_character":55,"end_line":102,"end_character":58},"updated":"2021-11-17 01:14:22.000000000","message":"(nit) redundant spaces","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"14d5d1f10764389332c08aab085370be2d7b2010","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  $powermax_share_driver \u003d \u0027manila.share.drivers.dell_emc.driver.EMCShareDriver\u0027"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  manila_config {"},{"line_number":102,"context_line":"    \"${share_backend_name}/share_driver\":                 value \u003d\u003e $powermax_share_driver;"},{"line_number":103,"context_line":"    \"${share_backend_name}/emc_nas_login\":                value \u003d\u003e $emc_nas_login;"},{"line_number":104,"context_line":"    \"${share_backend_name}/emc_nas_password\":             value \u003d\u003e $emc_nas_password, secret \u003d\u003e true;"},{"line_number":105,"context_line":"    \"${share_backend_name}/emc_nas_root_dir\":             value \u003d\u003e $emc_nas_root_dir;"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"bc7fa29a_af4cf0b3","line":102,"range":{"start_line":102,"start_character":55,"end_line":102,"end_character":58},"in_reply_to":"a457a802_6dde65f0","updated":"2021-11-17 01:59:28.000000000","message":"Done","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5e927f94d985c20d5e82e11d01c577ed39f372dd","unresolved":true,"context_lines":[{"line_number":109,"context_line":"    \"${share_backend_name}/backend_availability_zone\":    value \u003d\u003e $backend_availability_zone;"},{"line_number":110,"context_line":"    \"${share_backend_name}/emc_share_backend\":            value \u003d\u003e $emc_share_backend;"},{"line_number":111,"context_line":"    \"${share_backend_name}/powermax_server_container\":    value \u003d\u003e $powermax_server_container;"},{"line_number":112,"context_line":"    \"${share_backend_name}/powermax_share_data_pools\":    value \u003d\u003e $powermax_share_data_pools;"},{"line_number":113,"context_line":"    \"${share_backend_name}/powermax_ethernet_ports\":      value \u003d\u003e $powermax_ethernet_ports;"},{"line_number":114,"context_line":"    \"${share_backend_name}/emc_nas_server_secure\":        value \u003d\u003e $emc_nas_server_secure;"},{"line_number":115,"context_line":"    \"${share_backend_name}/emc_ssl_cert_path\":            value \u003d\u003e $emc_ssl_cert_path;"},{"line_number":116,"context_line":"    \"${share_backend_name}/emc_ssl_cert_verify\":          value \u003d\u003e $emc_ssl_cert_verify;"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"a9b8c98e_72f1fdb5","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":92},"updated":"2021-11-17 01:14:22.000000000","message":"please update these lines following the change made in https://review.opendev.org/c/openstack/puppet-manila/+/818178/2/manifests/backend/dellemc_vmax.pp","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"14d5d1f10764389332c08aab085370be2d7b2010","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    \"${share_backend_name}/backend_availability_zone\":    value \u003d\u003e $backend_availability_zone;"},{"line_number":110,"context_line":"    \"${share_backend_name}/emc_share_backend\":            value \u003d\u003e $emc_share_backend;"},{"line_number":111,"context_line":"    \"${share_backend_name}/powermax_server_container\":    value \u003d\u003e $powermax_server_container;"},{"line_number":112,"context_line":"    \"${share_backend_name}/powermax_share_data_pools\":    value \u003d\u003e $powermax_share_data_pools;"},{"line_number":113,"context_line":"    \"${share_backend_name}/powermax_ethernet_ports\":      value \u003d\u003e $powermax_ethernet_ports;"},{"line_number":114,"context_line":"    \"${share_backend_name}/emc_nas_server_secure\":        value \u003d\u003e $emc_nas_server_secure;"},{"line_number":115,"context_line":"    \"${share_backend_name}/emc_ssl_cert_path\":            value \u003d\u003e $emc_ssl_cert_path;"},{"line_number":116,"context_line":"    \"${share_backend_name}/emc_ssl_cert_verify\":          value \u003d\u003e $emc_ssl_cert_verify;"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"a742164f_ce1e7916","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":92},"in_reply_to":"a9b8c98e_72f1fdb5","updated":"2021-11-17 01:59:28.000000000","message":"Done","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8a86d2e5730c66efb6f6a91f485b4c3669c54ae","unresolved":true,"context_lines":[{"line_number":88,"context_line":"  $powermax_share_data_pools \u003d $::os_service_default,"},{"line_number":89,"context_line":"  $powermax_ethernet_ports   \u003d $::os_service_default,"},{"line_number":90,"context_line":"  $emc_nas_server_secure     \u003d $::os_service_default,"},{"line_number":91,"context_line":"  $emc_nas_root_dir          \u003d $::os_service_default,"},{"line_number":92,"context_line":"  $emc_nas_server_port       \u003d $::os_service_default,"},{"line_number":93,"context_line":"  $emc_ssl_cert_path         \u003d $::os_service_default,"},{"line_number":94,"context_line":"  $emc_ssl_cert_verify       \u003d $::os_service_default,"},{"line_number":95,"context_line":"  $package_ensure            \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"ff14f4a1_b68c0481","line":92,"range":{"start_line":91,"start_character":0,"end_line":92,"end_character":53},"updated":"2021-11-17 02:28:02.000000000","message":"I rechecked current implementation in Manila but seems these parameters are used only by isilon driver.","commit_id":"48e045546df9cb67211290ea9523ea780f784f1c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4145e106e05bbe5cd90eea261694d5cfd3166811","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  $powermax_share_data_pools \u003d $::os_service_default,"},{"line_number":89,"context_line":"  $powermax_ethernet_ports   \u003d $::os_service_default,"},{"line_number":90,"context_line":"  $emc_nas_server_secure     \u003d $::os_service_default,"},{"line_number":91,"context_line":"  $emc_nas_root_dir          \u003d $::os_service_default,"},{"line_number":92,"context_line":"  $emc_nas_server_port       \u003d $::os_service_default,"},{"line_number":93,"context_line":"  $emc_ssl_cert_path         \u003d $::os_service_default,"},{"line_number":94,"context_line":"  $emc_ssl_cert_verify       \u003d $::os_service_default,"},{"line_number":95,"context_line":"  $package_ensure            \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"980ba216_37e72538","line":92,"range":{"start_line":91,"start_character":0,"end_line":92,"end_character":53},"in_reply_to":"ff14f4a1_b68c0481","updated":"2021-11-17 02:31:41.000000000","message":"Done","commit_id":"48e045546df9cb67211290ea9523ea780f784f1c"}],"releasenotes/notes/rebrand_vmax_to_powermax-5a76ce55590118aa.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5e927f94d985c20d5e82e11d01c577ed39f372dd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    VMAX is being rebranded to PowerMax in Manila and in order to achieve this,"},{"line_number":4,"context_line":"    puppet-manila must support the new naming properties names.  This is the"},{"line_number":5,"context_line":"    first fix required in various projects before being able to do so."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"20df8192_34ca0004","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"updated":"2021-11-17 01:14:22.000000000","message":"Please use features. Prelude is often used to describe release highlights.","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"14d5d1f10764389332c08aab085370be2d7b2010","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    VMAX is being rebranded to PowerMax in Manila and in order to achieve this,"},{"line_number":4,"context_line":"    puppet-manila must support the new naming properties names.  This is the"},{"line_number":5,"context_line":"    first fix required in various projects before being able to do so."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"157a9ff3_5db7cd47","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"in_reply_to":"20df8192_34ca0004","updated":"2021-11-17 01:59:28.000000000","message":"Done","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5e927f94d985c20d5e82e11d01c577ed39f372dd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    VMAX is being rebranded to PowerMax in Manila and in order to achieve this,"},{"line_number":4,"context_line":"    puppet-manila must support the new naming properties names.  This is the"},{"line_number":5,"context_line":"    first fix required in various projects before being able to do so."},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"70bb8928_ad7bf924","line":4,"range":{"start_line":4,"start_character":65,"end_line":4,"end_character":69},"updated":"2021-11-17 01:14:22.000000000","message":"Please do not explain the change but explain the feature. This is included in a release note document and there is nothing to find \"This\".","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"14d5d1f10764389332c08aab085370be2d7b2010","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    VMAX is being rebranded to PowerMax in Manila and in order to achieve this,"},{"line_number":4,"context_line":"    puppet-manila must support the new naming properties names.  This is the"},{"line_number":5,"context_line":"    first fix required in various projects before being able to do so."},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"2ed5defc_877fdc7e","line":4,"range":{"start_line":4,"start_character":65,"end_line":4,"end_character":69},"in_reply_to":"70bb8928_ad7bf924","updated":"2021-11-17 01:59:28.000000000","message":"Done","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5e927f94d985c20d5e82e11d01c577ed39f372dd","unresolved":true,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    VMAX is being rebranded to PowerMax in Manila and in order to achieve this,"},{"line_number":4,"context_line":"    puppet-manila must support the new naming properties names.  This is the"},{"line_number":5,"context_line":"    first fix required in various projects before being able to do so."},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    VMAX is being rebranded to PowerMax and will soon be deprecated in Manila"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"e4ae7d93_673156a3","line":5,"range":{"start_line":5,"start_character":26,"end_line":5,"end_character":70},"updated":"2021-11-17 01:14:22.000000000","message":"Also, I think it\u0027s better to avoid mentioning this considering scope of Puppet OpenStack project.","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"14d5d1f10764389332c08aab085370be2d7b2010","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    VMAX is being rebranded to PowerMax in Manila and in order to achieve this,"},{"line_number":4,"context_line":"    puppet-manila must support the new naming properties names.  This is the"},{"line_number":5,"context_line":"    first fix required in various projects before being able to do so."},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    VMAX is being rebranded to PowerMax and will soon be deprecated in Manila"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a9e87f20_692450eb","line":5,"range":{"start_line":5,"start_character":26,"end_line":5,"end_character":70},"in_reply_to":"e4ae7d93_673156a3","updated":"2021-11-17 01:59:28.000000000","message":"Done","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5e927f94d985c20d5e82e11d01c577ed39f372dd","unresolved":true,"context_lines":[{"line_number":3,"context_line":"    VMAX is being rebranded to PowerMax in Manila and in order to achieve this,"},{"line_number":4,"context_line":"    puppet-manila must support the new naming properties names.  This is the"},{"line_number":5,"context_line":"    first fix required in various projects before being able to do so."},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    VMAX is being rebranded to PowerMax and will soon be deprecated in Manila"},{"line_number":9,"context_line":"    itself."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bede427b_3d6c93d6","line":9,"range":{"start_line":6,"start_character":0,"end_line":9,"end_character":11},"updated":"2021-11-17 01:14:22.000000000","message":"If you intend to backport this then this should be done in a separate patch, because we can\u0027t backport deprecations.","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"14d5d1f10764389332c08aab085370be2d7b2010","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    VMAX is being rebranded to PowerMax in Manila and in order to achieve this,"},{"line_number":4,"context_line":"    puppet-manila must support the new naming properties names.  This is the"},{"line_number":5,"context_line":"    first fix required in various projects before being able to do so."},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    VMAX is being rebranded to PowerMax and will soon be deprecated in Manila"},{"line_number":9,"context_line":"    itself."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"e14616d5_2098534a","line":9,"range":{"start_line":6,"start_character":0,"end_line":9,"end_character":11},"in_reply_to":"aa6171a5_f7136c89","updated":"2021-11-17 01:59:28.000000000","message":"Done","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b9821110a02d8c3654ca052e0987a9ebd77616d5","unresolved":true,"context_lines":[{"line_number":3,"context_line":"    VMAX is being rebranded to PowerMax in Manila and in order to achieve this,"},{"line_number":4,"context_line":"    puppet-manila must support the new naming properties names.  This is the"},{"line_number":5,"context_line":"    first fix required in various projects before being able to do so."},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    VMAX is being rebranded to PowerMax and will soon be deprecated in Manila"},{"line_number":9,"context_line":"    itself."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"aa6171a5_f7136c89","line":9,"range":{"start_line":6,"start_character":0,"end_line":9,"end_character":11},"in_reply_to":"bede427b_3d6c93d6","updated":"2021-11-17 01:15:24.000000000","message":"I\u0027m expecting an independent change like https://review.opendev.org/c/openstack/puppet-manila/+/818182/","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"}],"spec/defines/manila_backend_dellemc_powermax_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5e927f94d985c20d5e82e11d01c577ed39f372dd","unresolved":true,"context_lines":[{"line_number":9,"context_line":"      :emc_nas_login     \u003d\u003e \u0027admin\u0027,"},{"line_number":10,"context_line":"      :emc_nas_password  \u003d\u003e \u0027password\u0027,"},{"line_number":11,"context_line":"      :emc_nas_server    \u003d\u003e \u0027127.0.0.2\u0027,"},{"line_number":12,"context_line":"      :emc_share_backend \u003d\u003e \u0027powermax\u0027,"},{"line_number":13,"context_line":"    }"},{"line_number":14,"context_line":"  end"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"1615122f_fd7f2e1f","line":12,"range":{"start_line":12,"start_character":6,"end_line":12,"end_character":39},"updated":"2021-11-17 01:14:22.000000000","message":"Please put this into :default_params","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"14d5d1f10764389332c08aab085370be2d7b2010","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      :emc_nas_login     \u003d\u003e \u0027admin\u0027,"},{"line_number":10,"context_line":"      :emc_nas_password  \u003d\u003e \u0027password\u0027,"},{"line_number":11,"context_line":"      :emc_nas_server    \u003d\u003e \u0027127.0.0.2\u0027,"},{"line_number":12,"context_line":"      :emc_share_backend \u003d\u003e \u0027powermax\u0027,"},{"line_number":13,"context_line":"    }"},{"line_number":14,"context_line":"  end"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"bd6439ec_acb54986","line":12,"range":{"start_line":12,"start_character":6,"end_line":12,"end_character":39},"in_reply_to":"1615122f_fd7f2e1f","updated":"2021-11-17 01:59:28.000000000","message":"Done","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5e927f94d985c20d5e82e11d01c577ed39f372dd","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  let :default_params do"},{"line_number":17,"context_line":"    {"},{"line_number":18,"context_line":"      :powermax_server_container     \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":19,"context_line":"      :powermax_share_data_pools     \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":20,"context_line":"      :powermax_ethernet_ports       \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":21,"context_line":"      :backend_availability_zone \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"1aa69fac_eb6d3901","line":18,"range":{"start_line":18,"start_character":33,"end_line":18,"end_character":37},"updated":"2021-11-17 01:14:22.000000000","message":"redundant spaces","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"14d5d1f10764389332c08aab085370be2d7b2010","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  let :default_params do"},{"line_number":17,"context_line":"    {"},{"line_number":18,"context_line":"      :powermax_server_container     \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":19,"context_line":"      :powermax_share_data_pools     \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":20,"context_line":"      :powermax_ethernet_ports       \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":21,"context_line":"      :backend_availability_zone \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"eb4fe99a_79d1e4d7","line":18,"range":{"start_line":18,"start_character":33,"end_line":18,"end_character":37},"in_reply_to":"1aa69fac_eb6d3901","updated":"2021-11-17 01:59:28.000000000","message":"Done","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5e927f94d985c20d5e82e11d01c577ed39f372dd","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    context \u0027with provided parameters\u0027 do"},{"line_number":54,"context_line":"      let :params do"},{"line_number":55,"context_line":"        required_params.merge!({"},{"line_number":56,"context_line":"          :powermax_server_container     \u003d\u003e \u0027container1\u0027,"},{"line_number":57,"context_line":"          :powermax_share_data_pools     \u003d\u003e \u0027*\u0027,"},{"line_number":58,"context_line":"          :powermax_ethernet_ports       \u003d\u003e \u0027eth1\u0027,"},{"line_number":59,"context_line":"          :backend_availability_zone \u003d\u003e \u0027my_zone\u0027,"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"43539115_3f417309","line":56,"range":{"start_line":56,"start_character":37,"end_line":56,"end_character":41},"updated":"2021-11-17 01:14:22.000000000","message":"redundant spaces.","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"14d5d1f10764389332c08aab085370be2d7b2010","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    context \u0027with provided parameters\u0027 do"},{"line_number":54,"context_line":"      let :params do"},{"line_number":55,"context_line":"        required_params.merge!({"},{"line_number":56,"context_line":"          :powermax_server_container     \u003d\u003e \u0027container1\u0027,"},{"line_number":57,"context_line":"          :powermax_share_data_pools     \u003d\u003e \u0027*\u0027,"},{"line_number":58,"context_line":"          :powermax_ethernet_ports       \u003d\u003e \u0027eth1\u0027,"},{"line_number":59,"context_line":"          :backend_availability_zone \u003d\u003e \u0027my_zone\u0027,"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"438e5a48_d8787165","line":56,"range":{"start_line":56,"start_character":37,"end_line":56,"end_character":41},"in_reply_to":"43539115_3f417309","updated":"2021-11-17 01:59:28.000000000","message":"Done","commit_id":"4b4ad1b86d57382cdc2c909392bde653afa48163"}]}