)]}'
{"manifests/backend/hitachi_hnas.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"83c760d77b0f615fe0e2615c77dff6bc5147403a","unresolved":true,"context_lines":[{"line_number":56,"context_line":"#  }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"define manila::backend::hitachi_hnas ("},{"line_number":59,"context_line":"  $hitachi_hnas_username,"},{"line_number":60,"context_line":"  $hitachi_hnas_password,"},{"line_number":61,"context_line":"  $hitachi_hnas_ip,"},{"line_number":62,"context_line":"  $hitachi_hnas_evs_id,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f9ec876_31807fc2","line":59,"range":{"start_line":59,"start_character":3,"end_line":59,"end_character":24},"updated":"2022-04-11 17:15:55.000000000","message":"This error has existed in the code since 2016. With this in mind, I suggest we use the opportunity fix the puppet parameter name as well (change it to $hitachi_hnas_user). I don\u0027t see any need to go through the usual fix/deprecate/remove sequence by creating additional patches when the current code is simply broken.","commit_id":"38150c84733cdfa6c0a7806bca759056d7051aed"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f9d3f5673a5918afd2446462d03416ef67122de4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"#  }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"define manila::backend::hitachi_hnas ("},{"line_number":59,"context_line":"  $hitachi_hnas_username,"},{"line_number":60,"context_line":"  $hitachi_hnas_password,"},{"line_number":61,"context_line":"  $hitachi_hnas_ip,"},{"line_number":62,"context_line":"  $hitachi_hnas_evs_id,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"2e06256a_c18ad6e5","line":59,"range":{"start_line":59,"start_character":3,"end_line":59,"end_character":24},"in_reply_to":"3f9ec876_31807fc2","updated":"2022-04-11 23:46:20.000000000","message":"I agree with you. Actually my original plan was to deprecate this parameter for renaming but that would be redundant considering the fact nobody has reported this bug since 2016. I\u0027ve updated the change to rename the parameter directly, so will wait for any feedback by the other cores.","commit_id":"38150c84733cdfa6c0a7806bca759056d7051aed"}]}