)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d5391bb0923752d4500b54766da97a187897bdfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f5dc9d6a_493e942c","updated":"2022-11-28 15:31:59.000000000","message":"Is there a reason why this patch and https://review.opendev.org/c/openstack/puppet-manila/+/865780 can\u0027t be combined? At least for me, splitting the work into separate patches actually made it more difficult to review.","commit_id":"248109ba3e0596b478ed50b004db29b1d628282b"}],"manifests/scheduler.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d5391bb0923752d4500b54766da97a187897bdfb","unresolved":true,"context_lines":[{"line_number":31,"context_line":"  include manila::params"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  if ! $scheduler_driver {"},{"line_number":34,"context_line":"    warning(\u0027Using a false value for scheduler_driver is deprecated.\u0027"},{"line_number":35,"context_line":"            + \u0027Use $::os_service_default instead.\u0027)"},{"line_number":36,"context_line":"    manila_config {"},{"line_number":37,"context_line":"      \u0027DEFAULT/scheduler_driver\u0027: value \u003d\u003e $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"14ad55ff_3ed62755","line":34,"updated":"2022-11-28 15:31:59.000000000","message":"I don\u0027t think it\u0027s necessary to reverse the logic. Couldn\u0027t you just add the warning above L38 in the original version?","commit_id":"248109ba3e0596b478ed50b004db29b1d628282b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0f71b8526d27d486d176b2f9219955dcfbcd77b0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  include manila::params"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  if ! $scheduler_driver {"},{"line_number":34,"context_line":"    warning(\u0027Using a false value for scheduler_driver is deprecated.\u0027"},{"line_number":35,"context_line":"            + \u0027Use $::os_service_default instead.\u0027)"},{"line_number":36,"context_line":"    manila_config {"},{"line_number":37,"context_line":"      \u0027DEFAULT/scheduler_driver\u0027: value \u003d\u003e $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"6bf2205c_95e70aa2","line":34,"in_reply_to":"14ad55ff_3ed62755","updated":"2022-11-28 15:41:16.000000000","message":"That\u0027s definitely true. Done.","commit_id":"248109ba3e0596b478ed50b004db29b1d628282b"}],"releasenotes/notes/scheduler_driver-os_service_default-5b7e2e78d93c6abe.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d5391bb0923752d4500b54766da97a187897bdfb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Using a false value for ``manila::scheduler::scheduler_driver``  has been"},{"line_number":5,"context_line":"    deprecated and the specified value will be directly rendered into"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c17a1ff9_e854f4c7","line":2,"updated":"2022-11-28 15:31:59.000000000","message":"I\u0027m not sure if readers will view this as a feature. It seems more of a deprecation or upgrade note. The general behavior doesn\u0027t change (the default puppet parameter yields the service\u0027s default value). The only impact is on deployments that specifically set manila::scheduler::scheduler_driver to False (which was previous the default value).","commit_id":"248109ba3e0596b478ed50b004db29b1d628282b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0f71b8526d27d486d176b2f9219955dcfbcd77b0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Using a false value for ``manila::scheduler::scheduler_driver``  has been"},{"line_number":5,"context_line":"    deprecated and the specified value will be directly rendered into"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1054a02d_389d9d91","line":2,"in_reply_to":"c17a1ff9_e854f4c7","updated":"2022-11-28 15:41:16.000000000","message":"I tried to leave the deprecations section but seems I left the wrong one ...","commit_id":"248109ba3e0596b478ed50b004db29b1d628282b"}]}