)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"01a0d66e32d97a32449611828fe0c08e01213fd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"604ac2a3_85600521","updated":"2023-10-06 16:49:51.000000000","message":"This patch looks fine, but then I noticed the next one in the relation chain adds a new manila::data::backup::nfs class. Would a manila::data::backup class be useful? Would it be a good place to host the new parameters added by this patch?","commit_id":"8478cc1ecb1ad18f6674586531aef7225706c6c0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1dc65cc5ec8ad7e5fe13c32f69e6eba7d3be311d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9904aa3f_6569733f","in_reply_to":"604ac2a3_85600521","updated":"2023-10-07 02:20:48.000000000","message":"That is a very good point and I think it makes more sense to squash these two. Let me update this change.","commit_id":"8478cc1ecb1ad18f6674586531aef7225706c6c0"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c9f28784656d7f145573fcce3f676155f11531a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9b83159b_5fcecb15","updated":"2023-10-09 14:45:26.000000000","message":"This isn\u0027t quite what I meant in my previous comment. Instead of adding parameters to the manila::data and manila::share classes, I\u0027m wondering if they could all be added to a new manila::backup class, with manila::backup::nfs being the initial supported driver.\n\nFull disclosure: I\u0027m not familiar with manila\u0027s backup facility, so my idea may not be viable.","commit_id":"2c6e685768ff23a92350c2cc999c3b7d48914464"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f402b1c48748047d01d4ddba270499924fbd304c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3f4e2223_6498836d","updated":"2023-10-11 04:48:26.000000000","message":"recheck adoption to rspec-puppet 4.0 was merged.","commit_id":"2c6e685768ff23a92350c2cc999c3b7d48914464"}]}