)]}'
{"manifests/data/backup/nfs.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b27c23ad3c6d2e0dfcb888fe0ae4e9221b7c00c5","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*backup_mount_template*]"},{"line_number":8,"context_line":"#   (Optional) The template for mounting NFS shares."},{"line_number":9,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027]"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*backup_unmount_template*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"46cbfc72_50ead0c8","line":8,"range":{"start_line":8,"start_character":5,"end_line":8,"end_character":13},"updated":"2023-10-06 16:54:30.000000000","message":"I don\u0027t know anything about manila\u0027s backup service, but I find it interesting that all of these new parameters are optional. I would think somewhere you\u0027d need to specify the NFS share where the backups are written, which couldn\u0027t have a default value.","commit_id":"596f52edac8b49bfb5834906392cdcc56ccb2b40"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0b6d4d2a8393fa500df5ccede2a1fac10811967d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*backup_mount_template*]"},{"line_number":8,"context_line":"#   (Optional) The template for mounting NFS shares."},{"line_number":9,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027]"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*backup_unmount_template*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3eecdc7f_72839b6b","line":8,"range":{"start_line":8,"start_character":5,"end_line":8,"end_character":13},"in_reply_to":"46cbfc72_50ead0c8","updated":"2023-10-07 02:30:32.000000000","message":"I left backup_mount_export optional so that users can use this class to purge nfs driver options but it might not be very useful while requiring it helps users notice missing required options.\n\nI\u0027ve made the export parameter required.","commit_id":"596f52edac8b49bfb5834906392cdcc56ccb2b40"}]}