)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"76aa308a83121b049adcf09dac964bce0db508e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"34305d1c_706aa20e","updated":"2025-09-10 19:42:28.000000000","message":"I don\u0027t have a problem with this, don\u0027t think there is any \"better way\" (?) – but we do have inconsistencies in auth_url across modules","commit_id":"d6d3697dee1dbffdd8bae9f6c2e37f89d0097779"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b24f5fb5cb815d743946fcc34224172e3303e43d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"33dfe715_a4bf01ef","updated":"2025-09-10 17:22:33.000000000","message":"I\u0027m not entirely certain what this achieves. The various auth_url settings already did use a common default value (the same hard-coded one) and this patch replaces the hard-coded value with the os_service_default fact. But, AFAIK there is no such service default value.\n\nOne alternative would to establish top level ::manila params for all of the auth fields that the nova, glance, neutron and cinder sub-classes could reference, but that is a larger effort that would impact upgrades.","commit_id":"d6d3697dee1dbffdd8bae9f6c2e37f89d0097779"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c6fdd3c2124427f1fae5876bbbeaffd762ea4052","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"95c5f436_e3d5edcb","in_reply_to":"17a250f1_7a11ac2d","updated":"2025-09-11 04:06:19.000000000","message":"Oh, now I see what you mean. This makes it consistent across various puppet modules, and I initially thought you meant within this module.","commit_id":"d6d3697dee1dbffdd8bae9f6c2e37f89d0097779"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"be118b9b1b7aba0c28f659f530d3e81f6da89529","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"17a250f1_7a11ac2d","in_reply_to":"33dfe715_a4bf01ef","updated":"2025-09-11 03:31:40.000000000","message":"This replaces os_service_default by the hard-coded value to use the consistent default auth_url across the modules. As we already set auth_type auth_url should be set along with that default.\n\nI agree that we can probably add something in openstacklib to define such defaults but that may need to cover not only auth_url but also a few others (which is probably equivalent to what we have in puppet-openstack-integreation) so I\u0027ll keep the scope minimum (at least this replace may be enough to resolve the inconsistency)","commit_id":"d6d3697dee1dbffdd8bae9f6c2e37f89d0097779"}]}