)]}'
{"manifests/init.pp":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"63cbbe5d1d84943c5c78bc1cb0d0e091ca22fdb7","unresolved":false,"context_lines":[{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"class mistral("},{"line_number":68,"context_line":"  $qpid_hostname     \u003d \u0027localhost\u0027,"},{"line_number":69,"context_line":"  $qpid_port         \u003d  5672,"},{"line_number":70,"context_line":"  $qpid_username     \u003d \u0027guest\u0027,"},{"line_number":71,"context_line":"  $qpid_password     \u003d \u0027guest\u0027,"},{"line_number":72,"context_line":"  $qpid_protocol     \u003d \u0027ssl\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a8ffd7b_f9c24233","line":69,"updated":"2015-12-03 12:23:41.000000000","message":"$::os_service_default sets it to whatever the default for the service is.  I don\u0027t think we should have the AMQP port numbers hard coded here.","commit_id":"304e5b6b02d5a112415be82b6eb86f6716da11e6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"fe60ebf07e3bf0d961735711a13fae9935c6cd61","unresolved":false,"context_lines":[{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"class mistral("},{"line_number":68,"context_line":"  $qpid_hostname     \u003d \u0027localhost\u0027,"},{"line_number":69,"context_line":"  $qpid_port         \u003d  5672,"},{"line_number":70,"context_line":"  $qpid_username     \u003d \u0027guest\u0027,"},{"line_number":71,"context_line":"  $qpid_password     \u003d \u0027guest\u0027,"},{"line_number":72,"context_line":"  $qpid_protocol     \u003d \u0027ssl\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba8a016a_52865eba","line":69,"updated":"2015-11-22 05:08:50.000000000","message":"This is the default for mistral? If it is why not use $::os_service_default?","commit_id":"304e5b6b02d5a112415be82b6eb86f6716da11e6"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"10db3b084d88f9d94e9bda8cc686f79d1f58c7e7","unresolved":false,"context_lines":[{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"class mistral("},{"line_number":68,"context_line":"  $qpid_hostname     \u003d \u0027localhost\u0027,"},{"line_number":69,"context_line":"  $qpid_port         \u003d  5672,"},{"line_number":70,"context_line":"  $qpid_username     \u003d \u0027guest\u0027,"},{"line_number":71,"context_line":"  $qpid_password     \u003d \u0027guest\u0027,"},{"line_number":72,"context_line":"  $qpid_protocol     \u003d \u0027ssl\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_56e75640","line":69,"in_reply_to":"9a8ffd7b_f9c24233","updated":"2015-12-03 20:56:23.000000000","message":"Sorry. You are both totally correct here. Will push up a patch to fix these things.","commit_id":"304e5b6b02d5a112415be82b6eb86f6716da11e6"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"bf3b94b793f7cbc0ab3001712c603eacc2f028c0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"class mistral("},{"line_number":68,"context_line":"  $qpid_hostname     \u003d \u0027localhost\u0027,"},{"line_number":69,"context_line":"  $qpid_port         \u003d  5672,"},{"line_number":70,"context_line":"  $qpid_username     \u003d \u0027guest\u0027,"},{"line_number":71,"context_line":"  $qpid_password     \u003d \u0027guest\u0027,"},{"line_number":72,"context_line":"  $qpid_protocol     \u003d \u0027ssl\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba8a016a_b3cf8cb2","line":69,"in_reply_to":"ba8a016a_52865eba","updated":"2015-11-22 12:44:55.000000000","message":"The default values for both rabbit_port and qpid_port in the mistral.conf file (upstream) are both 5692.\n\nI think $os_service_default would be for mistral, not rabbit. (os \u003d\u003d \"OpenStack\" service default) I think.","commit_id":"304e5b6b02d5a112415be82b6eb86f6716da11e6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bd92a799c8c173fc069cd617ff0e9a31e3a498f1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#  The name/ip of qpid. Default \u0027localhost\u0027"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#  [*qpid_port*]"},{"line_number":10,"context_line":"#  The port of qpid. Default \u00275672\u0027"},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"#  [*qpid_username*]"},{"line_number":13,"context_line":"#  User name for qpid. Default \u0027guest\u0027"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a740942_56c4363f","line":10,"updated":"2015-12-03 21:03:28.000000000","message":"$::os_service_default","commit_id":"515b3c272a801e65ba955ebeff11d31191b4da82"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bd92a799c8c173fc069cd617ff0e9a31e3a498f1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# password for rabbit. Default \u0027guest\u0027"},{"line_number":60,"context_line":"#"},{"line_number":61,"context_line":"# [*rabbit_port*]"},{"line_number":62,"context_line":"# The port of rabbit. Default \u00275672\u0027"},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*auth_protocol*]"},{"line_number":65,"context_line":"# Keystone protocol"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a740942_36bbaac6","line":62,"updated":"2015-12-03 21:03:28.000000000","message":"same here","commit_id":"515b3c272a801e65ba955ebeff11d31191b4da82"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"19829579dd1de0e087bfcce98e977abe760310b8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"class mistral("},{"line_number":68,"context_line":"  $qpid_hostname     \u003d \u0027localhost\u0027,"},{"line_number":69,"context_line":"  $qpid_port         \u003d  $::os_service_default,"},{"line_number":70,"context_line":"  $qpid_username     \u003d \u0027guest\u0027,"},{"line_number":71,"context_line":"  $qpid_password     \u003d \u0027guest\u0027,"},{"line_number":72,"context_line":"  $qpid_protocol     \u003d \u0027ssl\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a740942_527134a7","line":69,"updated":"2015-12-07 13:02:19.000000000","message":"qpid it isn\u0027t going to be droped?\nI don\u0027t think you need to change here.","commit_id":"5d50059b4e7650504b781b1ed25f2dc3f2a8b36b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4b9c7cca18e662e781482b0c77e83b8e0ae53bfe","unresolved":false,"context_lines":[{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"class mistral("},{"line_number":68,"context_line":"  $qpid_hostname     \u003d \u0027localhost\u0027,"},{"line_number":69,"context_line":"  $qpid_port         \u003d  $::os_service_default,"},{"line_number":70,"context_line":"  $qpid_username     \u003d \u0027guest\u0027,"},{"line_number":71,"context_line":"  $qpid_password     \u003d \u0027guest\u0027,"},{"line_number":72,"context_line":"  $qpid_protocol     \u003d \u0027ssl\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a740942_32c828a8","line":69,"in_reply_to":"7a740942_527134a7","updated":"2015-12-07 13:04:40.000000000","message":"yeah, Iury is right. See:\n\nhttps://review.openstack.org/253085","commit_id":"5d50059b4e7650504b781b1ed25f2dc3f2a8b36b"}]}