)]}'
{"manifests/engine.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"04a0e63d771e4d3b3568a5beb8ec117121eb7d03","unresolved":false,"context_lines":[{"line_number":46,"context_line":"#   Minimum value is 1."},{"line_number":47,"context_line":"#   Note that only final state execution will remove (SUCCESS/ERROR)."},{"line_number":48,"context_line":"#   Defaults to $::os_service_default."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class mistral::engine ("},{"line_number":51,"context_line":"  $package_ensure                \u003d present,"},{"line_number":52,"context_line":"  $manage_service                \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_eaa4bd4b","line":49,"updated":"2016-05-11 11:42:29.000000000","message":"empty line with #","commit_id":"8d7d40445f09acdd111c49a45d487601d5ebe251"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"04a0e63d771e4d3b3568a5beb8ec117121eb7d03","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $host                          \u003d $::os_service_default,"},{"line_number":55,"context_line":"  $topic                         \u003d $::os_service_default,"},{"line_number":56,"context_line":"  $version                       \u003d $::os_service_default,"},{"line_number":57,"context_line":"  $execution_field_size_limit_kb \u003d $::os_service_default,"},{"line_number":58,"context_line":") {"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  include ::mistral::params"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_2a1ec56f","line":57,"updated":"2016-05-11 11:42:29.000000000","message":"forgot to add a new parameters? :)","commit_id":"8d7d40445f09acdd111c49a45d487601d5ebe251"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"183c0300b2b4bc3a198069b3ed20985957537b20","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $host                          \u003d $::os_service_default,"},{"line_number":55,"context_line":"  $topic                         \u003d $::os_service_default,"},{"line_number":56,"context_line":"  $version                       \u003d $::os_service_default,"},{"line_number":57,"context_line":"  $execution_field_size_limit_kb \u003d $::os_service_default,"},{"line_number":58,"context_line":") {"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  include ::mistral::params"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab6814e_e85e1be8","line":57,"in_reply_to":"dab17558_2a1ec56f","updated":"2016-05-18 23:40:20.000000000","message":"yes, sorry I did this in a bit of a rush didn\u0027t I.","commit_id":"8d7d40445f09acdd111c49a45d487601d5ebe251"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6f3d1fcf7114cdeb42f5f62c6884d6573705bf0b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"#   (Optional) How often will the executions be evaluated"},{"line_number":38,"context_line":"#   (in minutes). For example for value 120 the interval"},{"line_number":39,"context_line":"#   will be 2 hours (every 2 hours)."},{"line_number":40,"context_line":"#   Defaults to $::os_service_default."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*older_than*]"},{"line_number":43,"context_line":"#   (Optional) Evaluate from which time remove executions in minutes."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_f4d1bece","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":37},"updated":"2016-05-19 10:44:05.000000000","message":"false or $::os_service_default?","commit_id":"3c3e04d498bd7d9584073801e5dee638ba00e688"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6f3d1fcf7114cdeb42f5f62c6884d6573705bf0b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"#   that finished a 60 minutes ago or more."},{"line_number":46,"context_line":"#   Minimum value is 1."},{"line_number":47,"context_line":"#   Note that only final state execution will remove (SUCCESS/ERROR)."},{"line_number":48,"context_line":"#   Defaults to $::os_service_default."},{"line_number":49,"context_line":"class mistral::engine ("},{"line_number":50,"context_line":"  $package_ensure                \u003d present,"},{"line_number":51,"context_line":"  $manage_service                \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_34dce6e3","line":48,"updated":"2016-05-19 10:44:05.000000000","message":"same","commit_id":"3c3e04d498bd7d9584073801e5dee638ba00e688"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6f3d1fcf7114cdeb42f5f62c6884d6573705bf0b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"#   Minimum value is 1."},{"line_number":47,"context_line":"#   Note that only final state execution will remove (SUCCESS/ERROR)."},{"line_number":48,"context_line":"#   Defaults to $::os_service_default."},{"line_number":49,"context_line":"class mistral::engine ("},{"line_number":50,"context_line":"  $package_ensure                \u003d present,"},{"line_number":51,"context_line":"  $manage_service                \u003d true,"},{"line_number":52,"context_line":"  $enabled                       \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_54e1aa99","line":49,"updated":"2016-05-19 10:44:05.000000000","message":"add please empty line with #","commit_id":"3c3e04d498bd7d9584073801e5dee638ba00e688"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c10ef2f70c384de1bc7c30f8c7784a4f8bb3b200","unresolved":false,"context_lines":[{"line_number":37,"context_line":"#   (Optional) How often will the executions be evaluated"},{"line_number":38,"context_line":"#   (in minutes). For example for value 120 the interval"},{"line_number":39,"context_line":"#   will be 2 hours (every 2 hours)."},{"line_number":40,"context_line":"#   Defaults to false."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*older_than*]"},{"line_number":43,"context_line":"#   (Optional) Evaluate from which time remove executions in minutes."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_01a71450","line":40,"updated":"2016-05-24 12:50:40.000000000","message":"why not using os_service_default like other params?","commit_id":"259a79225a9efc003f186882dddeebdc1b808b1b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c10ef2f70c384de1bc7c30f8c7784a4f8bb3b200","unresolved":false,"context_lines":[{"line_number":45,"context_line":"#   that finished a 60 minutes ago or more."},{"line_number":46,"context_line":"#   Minimum value is 1."},{"line_number":47,"context_line":"#   Note that only final state execution will remove (SUCCESS/ERROR)."},{"line_number":48,"context_line":"#   Defaults to false."},{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"class mistral::engine ("},{"line_number":51,"context_line":"  $package_ensure                \u003d present,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_61626018","line":48,"updated":"2016-05-24 12:50:40.000000000","message":"why not using os_service_default like other params?","commit_id":"259a79225a9efc003f186882dddeebdc1b808b1b"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"90f5a6dfa8a64241ce7a61b67caefdf519421c18","unresolved":false,"context_lines":[{"line_number":45,"context_line":"#   that finished a 60 minutes ago or more."},{"line_number":46,"context_line":"#   Minimum value is 1."},{"line_number":47,"context_line":"#   Note that only final state execution will remove (SUCCESS/ERROR)."},{"line_number":48,"context_line":"#   Defaults to false."},{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"class mistral::engine ("},{"line_number":51,"context_line":"  $package_ensure                \u003d present,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_b594228b","line":48,"in_reply_to":"bab6814e_61626018","updated":"2016-05-25 22:49:06.000000000","message":"Because we weren\u0027t before in executor.pp. I can change it I guess.","commit_id":"259a79225a9efc003f186882dddeebdc1b808b1b"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"2769f20f1603107011c09bc71cfb851b83b4c713","unresolved":false,"context_lines":[{"line_number":37,"context_line":"#   (Optional) How often will the executions be evaluated"},{"line_number":38,"context_line":"#   (in minutes). For example for value 120 the interval"},{"line_number":39,"context_line":"#   will be 2 hours (every 2 hours)."},{"line_number":40,"context_line":"#   Defaults to false."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*older_than*]"},{"line_number":43,"context_line":"#   (Optional) Evaluate from which time remove executions in minutes."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_59ff29aa","line":40,"updated":"2016-05-30 10:00:52.000000000","message":"should defaults to $::os_service_default","commit_id":"72d2644a42b8950bdceead1a6089c5268895fec9"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"2769f20f1603107011c09bc71cfb851b83b4c713","unresolved":false,"context_lines":[{"line_number":45,"context_line":"#   that finished a 60 minutes ago or more."},{"line_number":46,"context_line":"#   Minimum value is 1."},{"line_number":47,"context_line":"#   Note that only final state execution will remove (SUCCESS/ERROR)."},{"line_number":48,"context_line":"#   Defaults to false."},{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"class mistral::engine ("},{"line_number":51,"context_line":"  $package_ensure                \u003d present,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_b92c554b","line":48,"updated":"2016-05-30 10:00:52.000000000","message":"same here","commit_id":"72d2644a42b8950bdceead1a6089c5268895fec9"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"a61e9fbbb0d5a16f37528a1ad3a4c386814b78f1","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    \u0027engine/topic\u0027:                                    value \u003d\u003e $topic;"},{"line_number":90,"context_line":"    \u0027engine/version\u0027:                                  value \u003d\u003e $version;"},{"line_number":91,"context_line":"    \u0027engine/execution_field_size_limit_kb\u0027:            value \u003d\u003e $execution_field_size_limit_kb;"},{"line_number":92,"context_line":"    \u0027execution_expiration_policy/evaluation_interval\u0027: value \u003d\u003e $evaluation_interval;"},{"line_number":93,"context_line":"    \u0027execution_expiration_policy/older_than\u0027:          value \u003d\u003e $older_than;"},{"line_number":94,"context_line":"  }"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_02c306ee","line":92,"range":{"start_line":92,"start_character":64,"end_line":92,"end_character":85},"updated":"2016-06-01 05:16:18.000000000","message":"maybe you can pick option between mistral::engine::evaluation_interval and mistral::excutor::evaluation_interval to ensure backward compatibility.","commit_id":"9b995058ff2b0d1d3302cfc749b7818fa3b3baf7"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"a61e9fbbb0d5a16f37528a1ad3a4c386814b78f1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    \u0027engine/version\u0027:                                  value \u003d\u003e $version;"},{"line_number":91,"context_line":"    \u0027engine/execution_field_size_limit_kb\u0027:            value \u003d\u003e $execution_field_size_limit_kb;"},{"line_number":92,"context_line":"    \u0027execution_expiration_policy/evaluation_interval\u0027: value \u003d\u003e $evaluation_interval;"},{"line_number":93,"context_line":"    \u0027execution_expiration_policy/older_than\u0027:          value \u003d\u003e $older_than;"},{"line_number":94,"context_line":"  }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_a2795aca","line":93,"range":{"start_line":93,"start_character":64,"end_line":93,"end_character":75},"updated":"2016-06-01 05:16:18.000000000","message":"same","commit_id":"9b995058ff2b0d1d3302cfc749b7818fa3b3baf7"}],"manifests/executor.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"04a0e63d771e4d3b3568a5beb8ec117121eb7d03","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*older_than*]"},{"line_number":37,"context_line":"#   (Deprecated) This should now be set via mistral::engine::older_than."},{"line_number":38,"context_line":"#   Defaults to false."},{"line_number":39,"context_line":"class mistral::executor ("},{"line_number":40,"context_line":"  $package_ensure      \u003d present,"},{"line_number":41,"context_line":"  $manage_service      \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_0a81418f","line":38,"updated":"2016-05-11 11:42:29.000000000","message":"same","commit_id":"8d7d40445f09acdd111c49a45d487601d5ebe251"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6f3d1fcf7114cdeb42f5f62c6884d6573705bf0b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# [*older_than*]"},{"line_number":37,"context_line":"#   (Deprecated) This should now be set via mistral::engine::older_than."},{"line_number":38,"context_line":"#   Defaults to false."},{"line_number":39,"context_line":"class mistral::executor ("},{"line_number":40,"context_line":"  $package_ensure      \u003d present,"},{"line_number":41,"context_line":"  $manage_service      \u003d true,"},{"line_number":42,"context_line":"  $enabled             \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_f4e89e7e","line":39,"updated":"2016-05-19 10:44:05.000000000","message":"empty line with # :)","commit_id":"3c3e04d498bd7d9584073801e5dee638ba00e688"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7fb786a57970f4ca633a69996a6379063a3c3b14","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# [*evaluation_interval*]"},{"line_number":32,"context_line":"#   (Deprecated) This should now be set via"},{"line_number":33,"context_line":"#    mistral::engine::evaluation_interval."},{"line_number":34,"context_line":"#   Defaults to false."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*older_than*]"},{"line_number":37,"context_line":"#   (Deprecated) This should now be set via mistral::engine::older_than."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_e3766305","line":34,"updated":"2016-06-02 15:05:59.000000000","message":"false \u0026 undef will behave the same here.","commit_id":"9b995058ff2b0d1d3302cfc749b7818fa3b3baf7"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"a61e9fbbb0d5a16f37528a1ad3a4c386814b78f1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# [*evaluation_interval*]"},{"line_number":32,"context_line":"#   (Deprecated) This should now be set via"},{"line_number":33,"context_line":"#    mistral::engine::evaluation_interval."},{"line_number":34,"context_line":"#   Defaults to false."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*older_than*]"},{"line_number":37,"context_line":"#   (Deprecated) This should now be set via mistral::engine::older_than."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_c27c5eb7","line":34,"range":{"start_line":34,"start_character":16,"end_line":34,"end_character":21},"updated":"2016-06-01 05:16:18.000000000","message":"should be undef","commit_id":"9b995058ff2b0d1d3302cfc749b7818fa3b3baf7"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"a61e9fbbb0d5a16f37528a1ad3a4c386814b78f1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*older_than*]"},{"line_number":37,"context_line":"#   (Deprecated) This should now be set via mistral::engine::older_than."},{"line_number":38,"context_line":"#   Defaults to false."},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"class mistral::executor ("},{"line_number":41,"context_line":"  $package_ensure      \u003d present,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_a2603a02","line":38,"range":{"start_line":38,"start_character":16,"end_line":38,"end_character":21},"updated":"2016-06-01 05:16:18.000000000","message":"same","commit_id":"9b995058ff2b0d1d3302cfc749b7818fa3b3baf7"}]}
